coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: mb/google/brya: change loglevel prefix
by Paul Menzel (Code Review) 25 Mar '22

25 Mar '22

Attention is currently required from: John Su, Tim Wawrzynczak, Nick Vaccaro. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63099 ) Change subject: mb/google/brya: change loglevel prefix ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63099/comment/ca543d13_6294c249 PS1, Line 7: change loglevel prefix Please be more specific. Maybe: > Demote EC check message level from error to warning -- To view, visit https://review.coreboot.org/c/coreboot/+/63099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I83d3eec6dba7b8cd006b58b93a7c53842ad6ce0a Gerrit-Change-Number: 63099 Gerrit-PatchSet: 1 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Fri, 25 Mar 2022 07:27:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp: Enable UFS for ADL-N RVP
by Paul Menzel (Code Review) 25 Mar '22

25 Mar '22

Attention is currently required from: Rizwan Qureshi, Tim Wawrzynczak, Meera Ravindranath, Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62662 ) Change subject: mb/intel/adlrvp: Enable UFS for ADL-N RVP ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62662/comment/f84c8679_db30f7c6 PS1, Line 8: > Please elaborate. Thank you. Maybe also say in the commit message, what UFS is. -- To view, visit https://review.coreboot.org/c/coreboot/+/62662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If15bcaffc8fd3bbbe4b181820993ab2d882bbbe1 Gerrit-Change-Number: 62662 Gerrit-PatchSet: 3 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: Daniil Lunev <dlunev(a)chromium.org> Gerrit-CC: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Reka Norman <rekanorman(a)chromium.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 25 Mar 2022 07:25:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/cherry: Add MAX98390 support for DOJO
by Paul Menzel (Code Review) 25 Mar '22

25 Mar '22

Attention is currently required from: Rex-BC Chen, Trevor Wu, Yu-Ping Wu. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63083 ) Change subject: mb/google/cherry: Add MAX98390 support for DOJO ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/63083/comment/8b84dae7_7c4a6d45 PS3, Line 7: DOJO dojo? Also, maybe move it to the prefix. https://review.coreboot.org/c/coreboot/+/63083/comment/4e87b241_19a684e6 PS3, Line 10: "CHERRY_USE_MAX98390" to enable it. Elaborate a little? > … and hook it up over I2S? -- To view, visit https://review.coreboot.org/c/coreboot/+/63083 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b6bc5a5520292dd502b0389217f5062479b4490 Gerrit-Change-Number: 63083 Gerrit-PatchSet: 3 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Trevor Wu <trevor.wu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Trevor Wu <trevor.wu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 25 Mar 2022 07:24:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8195: Update audio and adsp power control
by Paul Menzel (Code Review) 25 Mar '22

25 Mar '22

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yu-Ping Wu. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63106 ) Change subject: soc/mediatek/mt8195: Update audio and adsp power control ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63106/comment/56cdf9af_058fee7e PS1, Line 9: Enable adsp power before audio power and update bus protection step Why? Please describe the problem and motivation. -- To view, visit https://review.coreboot.org/c/coreboot/+/63106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0bcf1ddeebf0d3df0a1d6b22273123be1aaf85a8 Gerrit-Change-Number: 63106 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Chun-Jie Chen <chun-jie.chen(a)mediatek.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 25 Mar 2022 07:22:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device: Set set_resources message for device_operations function
by Paul Menzel (Code Review) 25 Mar '22

25 Mar '22

Attention is currently required from: Terry Chen, Tim Wawrzynczak, Nick Vaccaro. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63108 ) Change subject: device: Set set_resources message for device_operations function ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Is this related to change-set Ie7e7923265c84999b97a075f0757e7a8d8963b2d? -- To view, visit https://review.coreboot.org/c/coreboot/+/63108 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2cd7413b2c8d1c8f5ac0f3b77747839ddacb241b Gerrit-Change-Number: 63108 Gerrit-PatchSet: 3 Gerrit-Owner: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Fri, 25 Mar 2022 07:21:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/intel/fit: Clear the FIT table when setting pointer
by Paul Menzel (Code Review) 25 Mar '22

25 Mar '22

Attention is currently required from: Arthur Heymans. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63036 ) Change subject: cpu/intel/fit: Clear the FIT table when setting pointer ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63036/comment/9afa652e_adcc62a8 PS1, Line 11: ifitool ifittool -- To view, visit https://review.coreboot.org/c/coreboot/+/63036 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia20a489dc90a4ae704e9ee6d532766899f83ffcc Gerrit-Change-Number: 63036 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 25 Mar 2022 07:19:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/intel/fit: Clear the FIT table when setting pointer
by Paul Menzel (Code Review) 25 Mar '22

25 Mar '22

Attention is currently required from: Arthur Heymans. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63036 ) Change subject: cpu/intel/fit: Clear the FIT table when setting pointer ...................................................................... Patch Set 1: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/63036/comment/4af74b68_fcb08972 PS1, Line 11: mean meantime https://review.coreboot.org/c/coreboot/+/63036/comment/c3f5243a_f75f6168 PS1, Line 11: microcode microcode update? https://review.coreboot.org/c/coreboot/+/63036/comment/5cd9bb38_ca53c9d7 PS1, Line 12: rebuild rebuilt https://review.coreboot.org/c/coreboot/+/63036/comment/c488be19_c527e748 PS1, Line 16: Tested how? -- To view, visit https://review.coreboot.org/c/coreboot/+/63036 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia20a489dc90a4ae704e9ee6d532766899f83ffcc Gerrit-Change-Number: 63036 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 25 Mar 2022 07:17:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device: Set set_resources message for device_operations function
by Terry Chen (Code Review) 24 Mar '22

24 Mar '22

Terry Chen has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/63108 ) Change subject: device: Set set_resources message for device_operations function ...................................................................... device: Set set_resources message for device_operations function While running power_Resume/control that shows the error "NONE missing set_resources". Set set_resources in device_operations pciexp_hotplug_dummy_ops function BUG=b:223936777 TEST=USE="project_primus" emerge-brya coreboot chromeos-bootimage test_that -b {BOARD_NAME} {device IP} f:.*power_Resume/control Signed-off-by: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Change-Id: I2cd7413b2c8d1c8f5ac0f3b77747839ddacb241b --- M src/device/pciexp_device.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/63108/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/63108 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2cd7413b2c8d1c8f5ac0f3b77747839ddacb241b Gerrit-Change-Number: 63108 Gerrit-PatchSet: 3 Gerrit-Owner: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: device: Set set_resources message for device_operations function
by Terry Chen (Code Review) 24 Mar '22

24 Mar '22

Terry Chen has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/63108 ) Change subject: device: Set set_resources message for device_operations function ...................................................................... device: Set set_resources message for device_operations function While running power_Resume/control that shows the error "NONE missing set_resources". Set set_resources in device_operations pciexp_hotplug_dummy_ops function BUG=b:223936777 TEST=USE="project_primus" emerge-brya coreboot chromeos-bootimage test_that -b {BOARD_NAME} {device IP} f:.*power_Resume/control Signed-off-by: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Change-Id: I2cd7413b2c8d1c8f5ac0f3b77747839ddacb241b --- M src/device/pciexp_device.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/63108/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63108 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2cd7413b2c8d1c8f5ac0f3b77747839ddacb241b Gerrit-Change-Number: 63108 Gerrit-PatchSet: 2 Gerrit-Owner: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: device: Demote missing set resources message from error to warnings
by Terry Chen (Code Review) 24 Mar '22

24 Mar '22

Terry Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63108 ) Change subject: device: Demote missing set resources message from error to warnings ...................................................................... device: Demote missing set resources message from error to warnings While running power_Resume/control that shows the error "NONE missing set_resources". The message does seem more like a warning, therefore switch to BIOS_WARN instead. BUG=b:223936777 TEST=USE="project_primus" emerge-brya coreboot chromeos-bootimage test_that -b {BOARD_NAME} {device IP} f:.*power_Resume/control Signed-off-by: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Change-Id: I2cd7413b2c8d1c8f5ac0f3b77747839ddacb241b --- M src/device/pciexp_device.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/63108/1 diff --git a/src/device/pciexp_device.c b/src/device/pciexp_device.c index c525301..3614340 100644 --- a/src/device/pciexp_device.c +++ b/src/device/pciexp_device.c @@ -585,6 +585,7 @@ static struct device_operations pciexp_hotplug_dummy_ops = { .read_resources = pciexp_hotplug_dummy_read_resources, + .set_resources = noop_set_resources, }; void pciexp_hotplug_scan_bridge(struct device *dev) -- To view, visit https://review.coreboot.org/c/coreboot/+/63108 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2cd7413b2c8d1c8f5ac0f3b77747839ddacb241b Gerrit-Change-Number: 63108 Gerrit-PatchSet: 1 Gerrit-Owner: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022