coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: mb/google/guybrush/var/dewatt: Update telemetry value
by Kenneth Chan (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Rob Barnes, Karthik Ramasubramanian. Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63136 ) Change subject: mb/google/guybrush/var/dewatt: Update telemetry value ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/63136 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4456ffddbf9963f1202a349abe52df2bbb726468 Gerrit-Change-Number: 63136 Gerrit-PatchSet: 4 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 28 Mar 2022 08:29:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush/var/dewatt: Update telemetry value
by Kenneth Chan (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Kenneth Chan, Rob Barnes. Hello build bot (Jenkins), Bhanu Prakash Maiya, Rob Barnes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63136 to look at the new patch set (#4). Change subject: mb/google/guybrush/var/dewatt: Update telemetry value ...................................................................... mb/google/guybrush/var/dewatt: Update telemetry value AMD SDLE testing had been done and apply the following telemetry settings for dewatt EVT: vdd scale: 91288 vdd offset: 279 soc scale: 29785 soc offset: 461 BUG=b:219626910 TEST=1. emerge-guybrush coreboot 2. pass AMD SDLE test Change-Id: I4456ffddbf9963f1202a349abe52df2bbb726468 Signed-off-by: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> --- M src/mainboard/google/guybrush/variants/dewatt/overridetree.cb 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/63136/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/63136 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4456ffddbf9963f1202a349abe52df2bbb726468 Gerrit-Change-Number: 63136 Gerrit-PatchSet: 4 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/guybrush/var/dewatt: Update telemetry value
by Kenneth Chan (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Kenneth Chan, Rob Barnes. Hello build bot (Jenkins), Bhanu Prakash Maiya, Rob Barnes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63136 to look at the new patch set (#3). Change subject: mb/google/guybrush/var/dewatt: Update telemetry value ...................................................................... mb/google/guybrush/var/dewatt: Update telemetry value AMD SDLE testing had been done and apply the following telemetry settings for dewatt: vdd scale: 91288 vdd offset: 279 soc scale: 29785 soc offset: 461 BUG=b:219626910 TEST=1. emerge-guybrush coreboot 2. pass AMD SDLE test Change-Id: I4456ffddbf9963f1202a349abe52df2bbb726468 Signed-off-by: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> --- M src/mainboard/google/guybrush/variants/dewatt/overridetree.cb 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/63136/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/63136 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4456ffddbf9963f1202a349abe52df2bbb726468 Gerrit-Change-Number: 63136 Gerrit-PatchSet: 3 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/guybrush/var/dewatt: update telemetry value
by Kenneth Chan (Code Review) 28 Mar '22

28 Mar '22

Kenneth Chan has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/63136 ) Change subject: mb/google/guybrush/var/dewatt: update telemetry value ...................................................................... mb/google/guybrush/var/dewatt: update telemetry value AMD SDLE testing had been done and apply the following telemetry settings for dewatt: vdd scale: 91288 vdd offset: 279 soc scale: 29785 soc offset: 461 BUG=b:219626910 TEST=1. emerge-guybrush coreboot 2. pass AMD SDLE test Change-Id: I4456ffddbf9963f1202a349abe52df2bbb726468 Signed-off-by: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> --- M src/mainboard/google/guybrush/variants/dewatt/overridetree.cb 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/63136/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63136 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4456ffddbf9963f1202a349abe52df2bbb726468 Gerrit-Change-Number: 63136 Gerrit-PatchSet: 2 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/guybrush/var/dewatt: update telemetry value
by Kenneth Chan (Code Review) 28 Mar '22

28 Mar '22

Kenneth Chan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63136 ) Change subject: mb/google/guybrush/var/dewatt: update telemetry value ...................................................................... mb/google/guybrush/var/dewatt: update telemetry value AMD SDLE testing had been done and apply the following telemetry settings for dewatt: vdd scale: 91288 vdd offset: 279 soc scale: 29785 soc offset: 461 BUG=b:219626910 TEST=1. emerge-guybrush coreboot 2. pass AMD SDLE test Change-Id: I4456ffddbf9963f1202a349abe52df2bbb726468 --- M src/mainboard/google/guybrush/variants/dewatt/overridetree.cb 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/63136/1 diff --git a/src/mainboard/google/guybrush/variants/dewatt/overridetree.cb b/src/mainboard/google/guybrush/variants/dewatt/overridetree.cb index 6cb8293..866aee5 100644 --- a/src/mainboard/google/guybrush/variants/dewatt/overridetree.cb +++ b/src/mainboard/google/guybrush/variants/dewatt/overridetree.cb @@ -22,10 +22,10 @@ register "thermctl_limit_degreeC" = "100" #Update values based on final stardust SDLE test report. - register "telemetry_vddcrvddfull_scale_current_mA" = "95359" #mA - register "telemetry_vddcrvddoffset" = "449" - register "telemetry_vddcrsocfull_scale_current_mA" = "31481" #mA - register "telemetry_vddcrsocoffset" = "193" + register "telemetry_vddcrvddfull_scale_current_mA" = "91288" #mA + register "telemetry_vddcrvddoffset" = "279" + register "telemetry_vddcrsocfull_scale_current_mA" = "29785" #mA + register "telemetry_vddcrsocoffset" = "461" #USB 2/3 phy config register "usb_phy" = "{ -- To view, visit https://review.coreboot.org/c/coreboot/+/63136 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4456ffddbf9963f1202a349abe52df2bbb726468 Gerrit-Change-Number: 63136 Gerrit-PatchSet: 1 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/guybrush/var/dewatt: add specific SPD hex for dewatt
by Chris Wang (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Chris Wang. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63132 to look at the new patch set (#4). Change subject: mb/google/guybrush/var/dewatt: add specific SPD hex for dewatt ...................................................................... mb/google/guybrush/var/dewatt: add specific SPD hex for dewatt Add the specific SPD hex file for the Samsung memory part with updating the part number into the SPD table. The ABL needs to identify the part by checking SPD data to do the proper tuning. BUG=b:224884904 TEST=Build, validate the SPD data has been applied. Signed-off-by: Chris.Wang <chris.wang(a)amd.corp-partner.google.com> Change-Id: Ia54726ce8c1bae46dcd4fed3df509ef184914e94 --- A src/mainboard/google/guybrush/variants/dewatt/memory/K4U6E3S4AB-MGCL.hex A src/mainboard/google/guybrush/variants/dewatt/memory/K4UBE3D4AB-MGCL.hex M src/mainboard/google/guybrush/variants/dewatt/memory/Makefile.inc 3 files changed, 66 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/63132/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/63132 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia54726ce8c1bae46dcd4fed3df509ef184914e94 Gerrit-Change-Number: 63132 Gerrit-PatchSet: 4 Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/guybrush/var/dewatt: add specific SPD hex for dewatt
by Chris Wang (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Chris Wang. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63132 to look at the new patch set (#3). Change subject: mb/google/guybrush/var/dewatt: add specific SPD hex for dewatt ...................................................................... mb/google/guybrush/var/dewatt: add specific SPD hex for dewatt Add the specific SPD hex file for the Samsung memory part with updating the part number into the SPD table. The ABL needs to identify the part by checking SPD data to do the proper tuning. BUG=b:224884904 TEST=Build, validate the SPD data has been applied. Signed-off-by: Chris.Wang <chris.wang(a)amd.corp-partner.google.com> Change-Id: Ia54726ce8c1bae46dcd4fed3df509ef184914e94 --- A src/mainboard/google/guybrush/variants/dewatt/memory/K4U6E3S4AB-MGCL.hex A src/mainboard/google/guybrush/variants/dewatt/memory/K4UBE3D4AB-MGCL.hex M src/mainboard/google/guybrush/variants/dewatt/memory/Makefile.inc 3 files changed, 67 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/63132/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/63132 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia54726ce8c1bae46dcd4fed3df509ef184914e94 Gerrit-Change-Number: 63132 Gerrit-PatchSet: 3 Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/mediatek/mt8186: Fix pmif setting for low power mode
by Rex-BC Chen (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63089 ) Change subject: soc/mediatek/mt8186: Fix pmif setting for low power mode ...................................................................... Patch Set 3: (1 comment) File src/soc/mediatek/mt8186/include/soc/pmif.h: https://review.coreboot.org/c/coreboot/+/63089/comment/640b3a60_5e19fff3 PS2, Line 14: spmi > yes Done -- To view, visit https://review.coreboot.org/c/coreboot/+/63089 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d02198f19f9cb052fba612c02404a6af1a10adb Gerrit-Change-Number: 63089 Gerrit-PatchSet: 3 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 28 Mar 2022 08:11:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

Change in blobs[master]: Revert "soc/mediatek/mt8186: Update SPM firmware to pcm_suspend_v0215...
by Rex-BC Chen (Code Review) 28 Mar '22

28 Mar '22

Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/63097 ) Change subject: Revert "soc/mediatek/mt8186: Update SPM firmware to pcm_suspend_v0215_v10" ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/blobs/+/63097/comment/9a34d86b_43412898 PS4, Line 12: original SPM firmware is used to prevent suspend fail. We disable : 26M clock to bypass pmic wrap when suspending. : We found the root cause of suspend fail and it's because the error : setting of pmif. (Fixed in CB:63089) : Therefore, we revert the original patch to enable 26M clock. > CB:62327 was created to fix a suspend failure issue, where we disable 26M clock to bypass pmic wrap […] Done -- To view, visit https://review.coreboot.org/c/blobs/+/63097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: I63923188b814f0b44690784b55bcec9aff9b3d23 Gerrit-Change-Number: 63097 Gerrit-PatchSet: 5 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 28 Mar 2022 08:10:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

Change in blobs[master]: Revert "soc/mediatek/mt8186: Update SPM firmware to pcm_suspend_v0215...
by Rex-BC Chen (Code Review) 28 Mar '22

28 Mar '22

Attention is currently required from: Rex-BC Chen. Hello Hung-Te Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/blobs/+/63097 to look at the new patch set (#5). Change subject: Revert "soc/mediatek/mt8186: Update SPM firmware to pcm_suspend_v0215_v10" ...................................................................... Revert "soc/mediatek/mt8186: Update SPM firmware to pcm_suspend_v0215_v10" This reverts commit d13ba18eb0daaa6d6cd708bb981ee0a562ac4789. Revert reason: CB:62327 was created to fix a suspend failure issue, where we disable 26M clock to bypass pmic wrap when suspending. However, it turns out that the root cause of the suspend issue is an incorrect pmif setting, which is fixed in CB:63089. Therefore, revert CB:62327 to enable 26M clock. BUG=b:215639203 TEST=test of suspend and resume pass. Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Change-Id: I63923188b814f0b44690784b55bcec9aff9b3d23 --- M soc/mediatek/mt8186/spm_firmware.bin M soc/mediatek/mt8186/spm_firmware.bin.md5 M soc/mediatek/mt8186/spm_release_notes.txt 3 files changed, 1 insertion(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/97/63097/5 -- To view, visit https://review.coreboot.org/c/blobs/+/63097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: I63923188b814f0b44690784b55bcec9aff9b3d23 Gerrit-Change-Number: 63097 Gerrit-PatchSet: 5 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022