Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63089 )
Change subject: soc/mediatek/mt8186: Fix pmif setting for low power mode
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63089/comment/272356a8_b2b3ee5b
PS2, Line 7: add pmif driver setting
> Fix pmif setting for low power mode
Done
https://review.coreboot.org/c/coreboot/+/63089/comment/e005eabe_61853166
PS2, Line 9: We encounter a issue of suspend fail, and the root cause is that
: the default pmif register setting is not correct for low power
: mode. Therefore, we add the correct setting of pmif low power.
> The current pmif register setting for low power mode is incorrect, which is causing suspend failure. […]
Done
File src/soc/mediatek/mt8186/include/soc/pmif.h:
https://review.coreboot.org/c/coreboot/+/63089/comment/cf9946c8_137df3b0
PS2, Line 8: _
> MT8186
Done
https://review.coreboot.org/c/coreboot/+/63089/comment/5c19cd76_eeccf063
PS2, Line 14: spmi
> Just to confirm, does "spmi" mean System Power Management Interface?
yes
--
To view, visit https://review.coreboot.org/c/coreboot/+/63089
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2d02198f19f9cb052fba612c02404a6af1a10adb
Gerrit-Change-Number: 63089
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Mon, 28 Mar 2022 08:08:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Rex-BC Chen.
Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63089
to look at the new patch set (#3).
Change subject: soc/mediatek/mt8186: Fix pmif setting for low power mode
......................................................................
soc/mediatek/mt8186: Fix pmif setting for low power mode
The current pmif register setting for low power mode is incorrect,
which is causing suspend failure. Therefore, add
pmif_spmi_set_lp_mode() to correct the setting.
This implementation is based on chapter 3.7 in MT8186 Functional
Specification.
BUG=b:215639203
TEST=test of suspend and resume pass.
Signed-off-by: Zhiyong Tao <zhiyong.tao(a)mediatek.com>
Change-Id: I2d02198f19f9cb052fba612c02404a6af1a10adb
---
M src/soc/mediatek/mt8186/Makefile.inc
M src/soc/mediatek/mt8186/include/soc/addressmap.h
A src/soc/mediatek/mt8186/include/soc/pmif.h
M src/soc/mediatek/mt8186/mt6366.c
A src/soc/mediatek/mt8186/pmif.c
5 files changed, 42 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/63089/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/63089
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2d02198f19f9cb052fba612c02404a6af1a10adb
Gerrit-Change-Number: 63089
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-MessageType: newpatchset
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59638 )
Change subject: drivers/intel/fsp2_0: Add support for FSP_NON_VOLATILE_STORAGE_HOB2
......................................................................
Patch Set 45:
(1 comment)
File src/drivers/intel/fsp2_0/include/fsp/util.h:
https://review.coreboot.org/c/coreboot/+/59638/comment/966b80b8_1575a367
PS44, Line 32: efi_physical_address
> can't say that i like this, but since it's in the fsp driver and not common coreboot code i won't object to this
Thanks Felix.
--
To view, visit https://review.coreboot.org/c/coreboot/+/59638
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27647e9ac1a4902256b3f1c34b60e1f0b787a06e
Gerrit-Change-Number: 59638
Gerrit-PatchSet: 45
Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-CC: Subrata Banik <subratabanik(a)google.com>
Gerrit-Comment-Date: Mon, 28 Mar 2022 08:00:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anil Kumar K <anil.kumar.k(a)intel.com>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: John Su, Tim Wawrzynczak, Derek Huang.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63116 )
Change subject: mb/google/brya/var/felwinter: Update GPP_E19 from NF to NC
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/63116
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06d02c5a8b6cf65d5643eaf30fb277c3321dac8b
Gerrit-Change-Number: 63116
Gerrit-PatchSet: 2
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derek.huang(a)intel.com>
Gerrit-Reviewer: Derek Huang <derek.huang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Derek Huang <derek.huang(a)intel.com>
Gerrit-Comment-Date: Mon, 28 Mar 2022 08:00:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Rex-BC Chen.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/63097 )
Change subject: Revert "soc/mediatek/mt8186: Update SPM firmware to pcm_suspend_v0215_v10"
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/blobs/+/63097/comment/ae06afbc_1e2b7963
PS4, Line 12: original SPM firmware is used to prevent suspend fail. We disable
: 26M clock to bypass pmic wrap when suspending.
: We found the root cause of suspend fail and it's because the error
: setting of pmif. (Fixed in CB:63089)
: Therefore, we revert the original patch to enable 26M clock.
CB:62327 was created to fix a suspend failure issue, where we disable 26M clock to bypass pmic wrap when suspending. However, it turns out that the root cause of the suspend issue is an incorrect pmif setting, which is fixed in CB:63089. Therefore, revert CB:62327 to enable 26M clock.
--
To view, visit https://review.coreboot.org/c/blobs/+/63097
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: I63923188b814f0b44690784b55bcec9aff9b3d23
Gerrit-Change-Number: 63097
Gerrit-PatchSet: 4
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Comment-Date: Mon, 28 Mar 2022 07:55:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: John Su, Tim Wawrzynczak, Eric Lai, Derek Huang.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63116 )
Change subject: mb/google/brya/var/felwinter: Update GPP_E19 from NF to NC
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/63116
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06d02c5a8b6cf65d5643eaf30fb277c3321dac8b
Gerrit-Change-Number: 63116
Gerrit-PatchSet: 2
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derek.huang(a)intel.com>
Gerrit-Reviewer: Derek Huang <derek.huang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Derek Huang <derek.huang(a)intel.com>
Gerrit-Comment-Date: Mon, 28 Mar 2022 07:53:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Rex-BC Chen.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63089 )
Change subject: soc/mediatek/mt8186: add pmif driver setting
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63089/comment/ee9b86b3_3fe22534
PS2, Line 7: add pmif driver setting
Fix pmif setting for low power mode
https://review.coreboot.org/c/coreboot/+/63089/comment/b8de4a3d_6722b71c
PS2, Line 9: We encounter a issue of suspend fail, and the root cause is that
: the default pmif register setting is not correct for low power
: mode. Therefore, we add the correct setting of pmif low power.
The current pmif register setting for low power mode is incorrect, which is causing suspend failure. Therefore, add pmif_spmi_set_lp_mode() to correct the setting.
File src/soc/mediatek/mt8186/include/soc/pmif.h:
https://review.coreboot.org/c/coreboot/+/63089/comment/88119278_76f78539
PS2, Line 8: _
MT8186
https://review.coreboot.org/c/coreboot/+/63089/comment/292bab34_b4a1e8a1
PS2, Line 14: spmi
Just to confirm, does "spmi" mean System Power Management Interface?
--
To view, visit https://review.coreboot.org/c/coreboot/+/63089
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2d02198f19f9cb052fba612c02404a6af1a10adb
Gerrit-Change-Number: 63089
Gerrit-PatchSet: 2
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Comment-Date: Mon, 28 Mar 2022 07:50:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Eric Lai, Derek Huang.
John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63116 )
Change subject: mb/google/brya/var/felwinter: Update GPP_E19 from NF to NC
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63116/comment/df19bbf4_d6a5d5cd
PS1, Line 7: mb/google/brya/var/felwinter: Reconfigure GPIO settings
> Update GPP_E19 from NF to NC
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/63116
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06d02c5a8b6cf65d5643eaf30fb277c3321dac8b
Gerrit-Change-Number: 63116
Gerrit-PatchSet: 2
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derek.huang(a)intel.com>
Gerrit-Reviewer: Derek Huang <derek.huang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subi.banik(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subi.banik(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Derek Huang <derek.huang(a)intel.com>
Gerrit-Comment-Date: Mon, 28 Mar 2022 07:44:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: John Su, Tim Wawrzynczak, Derek Huang.
Hello Frank Wu, build bot (Jenkins), Tim Wawrzynczak, Derek Huang, Derek Huang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63116
to look at the new patch set (#2).
Change subject: mb/google/brya/var/felwinter: Update GPP_E19 from NF to NC
......................................................................
mb/google/brya/var/felwinter: Update GPP_E19 from NF to NC
Configure GPIO according to updated schematics.
- GPP_E19 from NF to NC.
BUG=b:224107199
TEST=emerge-brya coreboot
Signed-off-by: John Su <john_su(a)compal.corp-partner.google.com>
Change-Id: I06d02c5a8b6cf65d5643eaf30fb277c3321dac8b
---
M src/mainboard/google/brya/variants/felwinter/gpio.c
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/63116/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/63116
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06d02c5a8b6cf65d5643eaf30fb277c3321dac8b
Gerrit-Change-Number: 63116
Gerrit-PatchSet: 2
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derek.huang(a)intel.com>
Gerrit-Reviewer: Derek Huang <derek.huang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Derek Huang <derek.huang(a)intel.com>
Gerrit-MessageType: newpatchset