Attention is currently required from: Subrata Banik, Angel Pons, Eric Lai, Felix Held.
Hello build bot (Jenkins), Angel Pons, Eric Lai, Michael Niewöhner, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63126
to look at the new patch set (#3).
Change subject: Documentation: gpio: Update table as per coreboot guidelines
......................................................................
Documentation: gpio: Update table as per …
[View More]coreboot guidelines
This patch fixes the table issue in markdown file introduced with commit
5338a16b (Documentation: gpio: Fix table).
BUG=b:211573253, b:211950520
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
Change-Id: Ic4f27f46a9d219098612d8b7747ae26116506fce
---
M Documentation/getting_started/gpio.md
1 file changed, 55 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/63126/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/63126
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4f27f46a9d219098612d8b7747ae26116506fce
Gerrit-Change-Number: 63126
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
[View Less]
Attention is currently required from: Subrata Banik, Angel Pons, Eric Lai, Felix Held.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63126 )
Change subject: Documentation: gpio: Update table as per coreboot guidelines
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> If you use ``` and ``` , it means code block. All formats won't work in the between. […]
https://doc.…
[View More]coreboot.org/getting_started/writing_documentation.html#markdow…
--
To view, visit https://review.coreboot.org/c/coreboot/+/63126
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4f27f46a9d219098612d8b7747ae26116506fce
Gerrit-Change-Number: 63126
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 28 Mar 2022 07:02:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
[View Less]
Attention is currently required from: Subrata Banik, Angel Pons, Felix Held.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63126 )
Change subject: Documentation: gpio: Update table as per coreboot guidelines
......................................................................
Patch Set 2:
(2 comments)
File Documentation/getting_started/gpio.md:
https://review.coreboot.org/c/coreboot/+/63126/comment/5c9010db_5bf60ad1
PS2, Line 179: |
oh …
[View More]well, not needed for empty lines, just for the three with text
https://review.coreboot.org/c/coreboot/+/63126/comment/4ffa23b9_45ddadee
PS2, Line 215: |
same
--
To view, visit https://review.coreboot.org/c/coreboot/+/63126
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4f27f46a9d219098612d8b7747ae26116506fce
Gerrit-Change-Number: 63126
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 28 Mar 2022 07:02:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
[View Less]
Attention is currently required from: John Su, Tim Wawrzynczak, Derek Huang.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63116 )
Change subject: mb/google/brya/var/felwinter: Reconfigure GPIO settings
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63116/comment/1ce291e5_8c3f9f57
PS1, Line 7: mb/google/brya/var/felwinter: Reconfigure GPIO …
[View More]settings
Update GPP_E19 from NF to NC
--
To view, visit https://review.coreboot.org/c/coreboot/+/63116
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06d02c5a8b6cf65d5643eaf30fb277c3321dac8b
Gerrit-Change-Number: 63116
Gerrit-PatchSet: 1
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derek.huang(a)intel.com>
Gerrit-Reviewer: Derek Huang <derek.huang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Derek Huang <derek.huang(a)intel.com>
Gerrit-Comment-Date: Mon, 28 Mar 2022 06:51:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
[View Less]
Attention is currently required from: Tim Wawrzynczak.
Hello build bot (Jenkins), Subrata Banik, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62987
to look at the new patch set (#7).
Change subject: soc/intel/alderlake: Log CSE RO write protection info for ADL
......................................................................
soc/intel/alderlake: Log CSE RO write protection info for ADL
The patch logs write protection …
[View More]information for Alder Lake platform.
As part of write protection information, coreboot logs status on CSE RO
write protection and range. Also, triggers assert if EOM is disabled,
and write protection for CSE RO is not enabled.
TEST=Verify the write protection details on Gimble.
Excerpt from Gimble coreboot log:
[DEBUG] ME: WP for RO is enabled : YES
[DEBUG] ME: RO write protection scope - Start=0x1000, End=0x15AFFF
Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Change-Id: I766d5358bb7dd495b4a9b22a2f1b41dc90f3d8d5
---
M src/soc/intel/alderlake/me.c
1 file changed, 24 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/62987/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/62987
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I766d5358bb7dd495b4a9b22a2f1b41dc90f3d8d5
Gerrit-Change-Number: 62987
Gerrit-PatchSet: 7
Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newpatchset
[View Less]
Attention is currently required from: John Su, Tim Wawrzynczak, Derek Huang.
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63116 )
Change subject: mb/google/brya/var/felwinter: Reconfigure GPIO settings
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/63116
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/…
[View More]settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06d02c5a8b6cf65d5643eaf30fb277c3321dac8b
Gerrit-Change-Number: 63116
Gerrit-PatchSet: 1
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derek.huang(a)intel.com>
Gerrit-Reviewer: Derek Huang <derek.huang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Derek Huang <derek.huang(a)intel.com>
Gerrit-Comment-Date: Mon, 28 Mar 2022 06:26:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
[View Less]
Attention is currently required from: Tim Wawrzynczak, Arthur Heymans.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63008 )
Change subject: soc/intel/alderlake: Use coreboot native event handler for FSP-M/S
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Ping!
Can someone review this CL again.
--
To view, visit https://review.coreboot.org/c/coreboot/+/63008
To unsubscribe, …
[View More]or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I665def977faaae45f6f834d75e8456859093ba49
Gerrit-Change-Number: 63008
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Mon, 28 Mar 2022 05:58:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
[View Less]
Attention is currently required from: Tim Wawrzynczak, Arthur Heymans, Eric Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63009 )
Change subject: soc/intel/alderlake: Enable FSP_USES_CB_DEBUG_EVENT_HANDLER Kconfig
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
> > if this won't increase boot time, it's fine.
>
> Writing console to memory when caching is …
[View More]properly set up should have a negligible boot time impact.
I have verified and confirmed that no boot time penalty.
--
To view, visit https://review.coreboot.org/c/coreboot/+/63009
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4a0530a282657e379a00c3e7d0ed8148dd5e9196
Gerrit-Change-Number: 63009
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 28 Mar 2022 05:58:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
[View Less]