coreboot-gerrit February 2022

coreboot-gerrit@coreboot.org

1 participants
7066 discussions

Change in coreboot[master]: mb/google/brya: Add custom PLD fields to devicetree for brya variants
by EricR Lai (Code Review) 09 Feb '22

09 Feb '22

Attention is currently required from: Tim Wawrzynczak, Won Chung, Benson Leung, Prashant Malani. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61571 ) Change subject: mb/google/brya: Add custom PLD fields to devicetree for brya variants ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61571 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If610e6b3c849d982345ed1b8607ffd2af105dc51 Gerrit-Change-Number: 61571 Gerrit-PatchSet: 6 Gerrit-Owner: Won Chung <wonchung(a)google.com> Gerrit-Reviewer: Benson Leung <bleung(a)chromium.org> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Prashant Malani <pmalani(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Won Chung <wonchung(a)google.com> Gerrit-Attention: Benson Leung <bleung(a)chromium.org> Gerrit-Attention: Prashant Malani <pmalani(a)chromium.org> Gerrit-Comment-Date: Wed, 09 Feb 2022 04:43:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Adjust CSE RO and Data partition in the CSE region
by Tracy Wu (Code Review) 09 Feb '22

09 Feb '22

Tracy Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61728 ) Change subject: mb/google/brya: Adjust CSE RO and Data partition in the CSE region ...................................................................... mb/google/brya: Adjust CSE RO and Data partition in the CSE region This reverts commit 19a4247a06 ("mb/google/brya: Adjust CSE RO and Data partition in the CSE region"). There is an issue for Kano when update from 14474 to 14498 by using futility tool. For temporarily WA, need to switch back to use cse_serger stitch method and revert these changes of partition size. BUG=b:218376385 TEST=use flashrom to downgrade to 14474 then use futility to update to this generated coreboot. Signed-off-by: Tracy Wu <tracy.wu(a)intel.corp-partner.google.com> Change-Id: Ia8bdf6b28d952f6d983b84e39da96e159027a822 --- M src/mainboard/google/brya/chromeos.fmd 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/61728/1 diff --git a/src/mainboard/google/brya/chromeos.fmd b/src/mainboard/google/brya/chromeos.fmd index e445383..72c6429 100644 --- a/src/mainboard/google/brya/chromeos.fmd +++ b/src/mainboard/google/brya/chromeos.fmd @@ -3,8 +3,8 @@ SI_DESC 4K SI_ME { CSE_LAYOUT 8K - CSE_RO 1640K - CSE_DATA 420K + CSE_RO 1588K + CSE_DATA 512K # 64-KiB aligned to optimize RW erases during CSE update. CSE_RW 3008K } -- To view, visit https://review.coreboot.org/c/coreboot/+/61728 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8bdf6b28d952f6d983b84e39da96e159027a822 Gerrit-Change-Number: 61728 Gerrit-PatchSet: 1 Gerrit-Owner: Tracy Wu <tracy.wu(a)intel.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: console: Add missing va_end() in wrap_interactive_printf()
by Raul Rangel (Code Review) 09 Feb '22

09 Feb '22

Attention is currently required from: Julius Werner. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61724 ) Change subject: console: Add missing va_end() in wrap_interactive_printf() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I845a784d90f65610fd1e0d751ea13e9af5b970fd Gerrit-Change-Number: 61724 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 09 Feb 2022 04:14:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: console/post: Lower post code loglevel to BIOS_INFO
by Raul Rangel (Code Review) 09 Feb '22

09 Feb '22

Attention is currently required from: Julius Werner, Ron Minnich. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61692 ) Change subject: console/post: Lower post code loglevel to BIOS_INFO ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85c8768232ae0cbf65669a7ee6abd538a3b2d5e1 Gerrit-Change-Number: 61692 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Wed, 09 Feb 2022 04:14:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common: Re-use Alder Lake-M device IDs for Alder Lake-N
by Usha P (Code Review) 09 Feb '22

09 Feb '22

Attention is currently required from: Bora Guvendik, Selma Bensaid, Tim Wawrzynczak, Rizwan Qureshi, Krishna P Bhat D, Patrick Rudolph. Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61162 ) Change subject: soc/intel/common: Re-use Alder Lake-M device IDs for Alder Lake-N ...................................................................... Patch Set 3: (1 comment) File src/include/device/pci_ids.h: https://review.coreboot.org/c/coreboot/+/61162/comment/49b3e39b_0725f97e PS3, Line 3400: #define PCI_DEVICE_ID_INTEL_ADP_M_N_PCIE_RP1 0x54b8 : #define PCI_DEVICE_ID_INTEL_ADP_M_N_PCIE_RP2 0x54b9 : #define PCI_DEVICE_ID_INTEL_ADP_M_N_PCIE_RP3 0x54ba : #define PCI_DEVICE_ID_INTEL_ADP_M_N_PCIE_RP4 0x54bb : #define PCI_DEVICE_ID_INTEL_ADP_M_PCIE_RP5 0x54bc : #define PCI_DEVICE_ID_INTEL_ADP_M_PCIE_RP6 0x54bd : #define PCI_DEVICE_ID_INTEL_ADP_M_N_PCIE_RP7 0x54be : #define PCI_DEVICE_ID_INTEL_ADP_M_PCIE_RP8 0x54bf : #define PCI_DEVICE_ID_INTEL_ADP_M_N_PCIE_RP9 0x54b0 : #define PCI_DEVICE_ID_INTEL_ADP_M_N_PCIE_RP10 0x54b1 > Hm, for ADL-N, though, wouldn't these be called […] No. According to EDS Doc #645548, ADL-N has root port's 1,2,3,4,7,9,10,11 and 12. -- To view, visit https://review.coreboot.org/c/coreboot/+/61162 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6042017c6189cbc3ca9dce0e50acfb68ea4003f1 Gerrit-Change-Number: 61162 Gerrit-PatchSet: 3 Gerrit-Owner: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 09 Feb 2022 04:07:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/variants/brask: Enable Bluetooth offload support
by Zhuohao Lee (Code Review) 09 Feb '22

09 Feb '22

Attention is currently required from: Mac Chiang. Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61404 ) Change subject: mb/google/brya/variants/brask: Enable Bluetooth offload support ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/brya/variants/brask/overridetree.cb: https://review.coreboot.org/c/coreboot/+/61404/comment/f5287104_1bb12f68 PS3, Line 2: 1 3 Could you change the FW_CONFIG starting from 0. ie. 0 2 ? -- To view, visit https://review.coreboot.org/c/coreboot/+/61404 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id5da8c5c471be176bc0fe1eda4da7faf8ed2e8d2 Gerrit-Change-Number: 61404 Gerrit-PatchSet: 3 Gerrit-Owner: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Comment-Date: Wed, 09 Feb 2022 03:54:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Update fsp submodule to upstream master
by Martin Roth - Personal (Code Review) 09 Feb '22

09 Feb '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60820 to look at the new patch set (#2). Change subject: Update fsp submodule to upstream master ...................................................................... Update fsp submodule to upstream master Updating from commit id 10eae55: 2021-08-24 21:11:18 +0800 - (Elkhart Lake MR1 FSP) to commit id f4bbf5a: 2022-01-29 00:32:47 +0800 - (Apollo Lake MR10 FSP) This brings in 20 new commits: f4bbf5a Apollo Lake MR10 FSP aab8be0 Apollo Lake MR10 FSP 45b935f Apollo Lake MR10 FSP 755e782 Signed-off-by: Wong <swee.heng.wong(a)intel.com> da956c1 Whitley FSP 2.2.0.3A 7e3d894 Whitley FSP 2.2.0.3A 04ad3cd Tiger Lake - UP3 IoT FSP MR4 ccf7f35 Elkhart Lake MR2 FSP 4aa1275 Elkhart Lake MR2 FSP 8aa6a9a Cedar Island FSP 2.2.0.3A 2e2e740 Whitley FSP 2.2.0.3A 91a6117 Tiger Lake - UP3 IoT FSP MR3 2863499 Delete FspUpd.h df41c58 Delete FsptUpd.h 0d420eb Delete FspsUpd.h 53cc56a Delete FspmUpd.h ad51318 Tiger Lake - UP3 IoT FSP MR3 63273a4 Delete Fsp.fd ce61eb3 Tiger Lake - UP3 IoT FSP MR3 f7f77a2 Delete Fsp.bsf Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I6128b9703498dd36be73c19cbbfe349c206c6cf3 --- M 3rdparty/fsp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/60820/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60820 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6128b9703498dd36be73c19cbbfe349c206c6cf3 Gerrit-Change-Number: 60820 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth - Personal <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Update intel-sec-tools submodule to upstream master
by Martin Roth - Personal (Code Review) 09 Feb '22

09 Feb '22

Martin Roth - Personal has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/60822 ) Change subject: Update intel-sec-tools submodule to upstream master ...................................................................... Update intel-sec-tools submodule to upstream master Updating from commit id 0031ac7: 2021-06-22 14:22:03 +0200 - (Merge pull request #245 from 9elements/meparser) to commit id 2db573f: 2022-02-04 16:55:15 +0000 - (Merge pull request #320 from 9elements/feature/replay_pcr1) This brings in 137 new commits. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I65c69d716a829ea38145d5e075089d1bdf151593 --- M 3rdparty/intel-sec-tools 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/60822/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65c69d716a829ea38145d5e075089d1bdf151593 Gerrit-Change-Number: 60822 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth - Personal <martinroth(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Update opensbi submodule to upstream master
by Martin Roth - Personal (Code Review) 09 Feb '22

09 Feb '22

Martin Roth - Personal has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/60823 ) Change subject: Update opensbi submodule to upstream master ...................................................................... Update opensbi submodule to upstream master Updating from commit id 215421c: 2019-11-15 17:42:55 +0530 - (lib: Remove date and time from init message) to commit id ce4c018: 2022-02-04 11:16:29 +0530 - (lib: utils/serial: Round UART8250 baud rate divisor to nearest integer) This brings in 589 new commits. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I2e7d7f465407a3a8dd4e431db82bc755fd41b017 --- M 3rdparty/opensbi 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/60823/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60823 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2e7d7f465407a3a8dd4e431db82bc755fd41b017 Gerrit-Change-Number: 60823 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth - Personal <martinroth(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Update qc_blobs submodule to upstream master
by Martin Roth - Personal (Code Review) 09 Feb '22

09 Feb '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60825 to look at the new patch set (#2). Change subject: Update qc_blobs submodule to upstream master ...................................................................... Update qc_blobs submodule to upstream master Updating from commit id 98db386: 2021-08-03 11:57:30 -0700 - (herobrine: Add gsi_fw_blobs and Release Notes) to commit id 9ab0f0b: 2022-01-18 19:01:30 +0530 - (sc7280: Update AOP firmware to version 379) This brings in 13 new commits: 9ab0f0b sc7280: Update AOP firmware to version 379 826cb9c sc7180/boot : Update qclib blobs binaries and release notes ddf67d1 sc7280/ boot and shrm blobs updated 8592f11 sc7280: Update AOP firmware to version 364 aef8a0a sc7280/ boot and shrm blobs updated c72bc4e sc7280/cpucp: Update cpucp blobs binaries and release notes version from 054 to 060 33e57fe sc7280/boot,/shrm : Update qclib blobs binaries and release notes version 13 511851b sc7180/boot : Update qclib blobs binaries and release notes version 30 f91d0ef herobrine: qc_sec blob update 8c50f78 sc7180/boot : Update qclib blobs binaries and release notes 8523ef4 sc7180/qtiseclib: Update version from 26 to 44 5b77a37 sc7280/qtiseclib: Update version from 33 to 44 4815cc2 sc7280: Update AOP firmware to version 360 Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I510141916900507fd29a0e9315a3f8d954bc0cab --- M 3rdparty/qc_blobs 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/60825/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I510141916900507fd29a0e9315a3f8d954bc0cab Gerrit-Change-Number: 60825 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth - Personal <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2022