coreboot-gerrit February 2022

coreboot-gerrit@coreboot.org

1 participants
7066 discussions

Change in coreboot[master]: Update blobs submodule to upstream master
by Martin Roth - Personal (Code Review) 09 Feb '22

09 Feb '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60819 to look at the new patch set (#2). Change subject: Update blobs submodule to upstream master ...................................................................... Update blobs submodule to upstream master Updating from commit id b8e3eaf: 2021-07-15 08:09:11 +0000 - (mainboard/starlabs: Add files for Star Labs laptops) to commit id 5dfc5da: 2022-01-24 16:48:56 +0800 - (soc/mediatek/mt8186: Add dram.elf version 0.1.0 for DRAM calibration) This brings in 9 new commits: 5dfc5da soc/mediatek/mt8186: Add dram.elf version 0.1.0 for DRAM calibration 6355817 soc/mediatek/mt8186: List `sspm.bin` in README 54ca015 soc/mediatek/mt8186: Add SSPM firmware 27eb91b soc/mediatek/mt8186: Add SPM firmware a2f02b4 soc/mediatek/mt8186: Add MT8186 basic files f836ff3 soc/mediatek/mt8195: Update MCUPM firmware from v1.01.00 to v1.02.00 bb02df0 soc/mediatek/mt8195: Add dpm.pm and dpm.dm version 1.0 7f00baa soc/mediatek/mt8195: Add dram.elf for full calibration flow 19e1e69 soc/mediatek/mt8195: Update MCUPM firmware from v1.00.00 to v1.01.00 Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Ieff9a5d9ba5ad9abcb9eb3e8117995235ffab1e9 --- M 3rdparty/blobs 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/60819/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60819 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieff9a5d9ba5ad9abcb9eb3e8117995235ffab1e9 Gerrit-Change-Number: 60819 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth - Personal <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/var/brask: Enable ASPM of RTL8125
by Rory Liu (Code Review) 09 Feb '22

09 Feb '22

Attention is currently required from: Tim Wawrzynczak, Zhuohao Lee. Rory Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61268 ) Change subject: mb/google/brya/var/brask: Enable ASPM of RTL8125 ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/61268 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9a56df1d68696f409f9ee681d37de6759a588d80 Gerrit-Change-Number: 61268 Gerrit-PatchSet: 4 Gerrit-Owner: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Comment-Date: Wed, 09 Feb 2022 03:43:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Update stm submodule to upstream master
by Martin Roth - Personal (Code Review) 09 Feb '22

09 Feb '22

Martin Roth - Personal has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/60826 ) Change subject: Update stm submodule to upstream master ...................................................................... Abandoned Eugene says that this shouldn't be merged. -- To view, visit https://review.coreboot.org/c/coreboot/+/60826 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c7d6f1867d79882de6f172b38eb77b40a5aff7d Gerrit-Change-Number: 60826 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth - Personal <martinroth(a)google.com> Gerrit-Reviewer: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: mb/google/brya/variants/brask: Enable Bluetooth offload support
by Mac Chiang (Code Review) 09 Feb '22

09 Feb '22

Attention is currently required from: Zhuohao Lee. Mac Chiang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61404 ) Change subject: mb/google/brya/variants/brask: Enable Bluetooth offload support ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/61404/comment/ec987647_39775682 PS2, Line 13: t > nit: remove this extra letter Done -- To view, visit https://review.coreboot.org/c/coreboot/+/61404 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id5da8c5c471be176bc0fe1eda4da7faf8ed2e8d2 Gerrit-Change-Number: 61404 Gerrit-PatchSet: 3 Gerrit-Owner: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Comment-Date: Wed, 09 Feb 2022 03:30:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/variants/brask: Enable Bluetooth offload support
by Mac Chiang (Code Review) 09 Feb '22

09 Feb '22

Attention is currently required from: Mac Chiang, Zhuohao Lee. Hello build bot (Jenkins), Tim Wawrzynczak, Zhuohao Lee, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/61404 to look at the new patch set (#3). Change subject: mb/google/brya/variants/brask: Enable Bluetooth offload support ...................................................................... mb/google/brya/variants/brask: Enable Bluetooth offload support Add fw_config NAU88L25B_I2S field, I2S2 configuration and enabling CnviBtAudioOffload UPD bit. BUG=none TEST=emerge-brask coreboot Signed-off-by: Mac Chiang <mac.chiang(a)intel.com> Change-Id: Id5da8c5c471be176bc0fe1eda4da7faf8ed2e8d2 --- M src/mainboard/google/brya/variants/brask/Makefile.inc A src/mainboard/google/brya/variants/brask/fw_config.c M src/mainboard/google/brya/variants/brask/overridetree.cb A src/mainboard/google/brya/variants/brask/variant.c 4 files changed, 64 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/61404/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/61404 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id5da8c5c471be176bc0fe1eda4da7faf8ed2e8d2 Gerrit-Change-Number: 61404 Gerrit-PatchSet: 3 Gerrit-Owner: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/common/cse: Add `finalize` operation for CSE
by Sridhar Siricilla (Code Review) 09 Feb '22

09 Feb '22

Attention is currently required from: Arthur Heymans, Felix Singer, Subrata Banik, Tim Wawrzynczak, Angel Pons, Lean Sheng Tan, Werner Zeh, Patrick Rudolph, EricR Lai. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60405 ) Change subject: soc/intel/common/cse: Add `finalize` operation for CSE ...................................................................... Patch Set 25: (1 comment) File src/soc/intel/common/block/cse/cse.c: https://review.coreboot.org/c/coreboot/+/60405/comment/29563125_6435994c PS24, Line 1195: static void cse_final(struct device *dev) : { : if (CONFIG(SKIP_FSP_NOTIFY_PHASE_READY_TO_BOOT)) { : cse_send_end_of_post(); : : cse_control_global_reset_lock(); : : if (CONFIG(DISABLE_HECI1_AT_PRE_BOOT)) { : cse_set_to_d0i3(); : heci1_disable(); : } : } : : if (CONFIG(SKIP_FSP_NOTIFY_PHASE_END_OF_FIRMWARE)) : heci_set_to_d0i3(); : } > > CB_INTEL_SOC_RUN_OPS_BEFORE_PAYLOAD_LAUNCH?? seriously?! A Kconfig option that says coreboot runs […] >Even thats the case with FSP-NotifyPhase API call as well today, Please check the log below: NotifyPhaseApi() - Begin [Phase: 00000040] FSP Ready To Boot ... ...... NotifyPhaseApi() - End [Status: 0x00000000] PROGRESS CODE: V0000487F I0 PROGRESS CODE: V00002800 I0 NotifyPhaseApi() - Begin [Phase: 000000F0] FSP End of Firmware ... ...... NotifyPhaseApi() - End [Status: 0x00000000] Because coreboot chose to give call those FSP Notify APIs sequentially. But, the flow can be changed later with existing desing. But, can your new flow allows such flexibility? -- To view, visit https://review.coreboot.org/c/coreboot/+/60405 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70bde33f77026e8be165ff082defe3cab6686ec7 Gerrit-Change-Number: 60405 Gerrit-PatchSet: 25 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Wed, 09 Feb 2022 03:25:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Update arm-trusted-firmware submodule to upstream master
by Martin Roth - Personal (Code Review) 09 Feb '22

09 Feb '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60818 to look at the new patch set (#2). Change subject: Update arm-trusted-firmware submodule to upstream master ...................................................................... Update arm-trusted-firmware submodule to upstream master Updating from commit id 73193689c: 2021-12-06 16:47:33 +0100 - (Merge changes I7c9f8490,Ia92c6d19 into integration) to commit id e0a6a512b: 2022-02-03 22:59:34 +0100 - (Merge changes from topic "msm8916" into integration) This brings in 324 new commits. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I44bca36f4b05e08fe7d7de0966131be84c0a7d2b --- M 3rdparty/arm-trusted-firmware 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/60818/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60818 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I44bca36f4b05e08fe7d7de0966131be84c0a7d2b Gerrit-Change-Number: 60818 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth - Personal <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede/var/pirika: Add Wifi SAR for pasara
by Frank Chu (Code Review) 09 Feb '22

09 Feb '22

Attention is currently required from: Karthik Ramasubramanian. Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61705 ) Change subject: mb/google/dedede/var/pirika: Add Wifi SAR for pasara ...................................................................... Patch Set 3: (2 comments) File src/mainboard/google/dedede/variants/pirika/Makefile.inc: https://review.coreboot.org/c/coreboot/+/61705/comment/de59815c_6bc7ebd0 PS1, Line 3: $(CONFIG_FW_CONFIG) > ramstage-y since variant.c is not looking anything in FW_CONFIG. Done File src/mainboard/google/dedede/variants/pirika/variant.c: https://review.coreboot.org/c/coreboot/+/61705/comment/ccf5adab_6fc455ce PS1, Line 4: #include <fw_config.h> > Is it required? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/61705 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida475307c8448c5c2758c289da7708484bcb89e3 Gerrit-Change-Number: 61705 Gerrit-PatchSet: 3 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 09 Feb 2022 03:20:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: spd/lp5: Generate initial SPDs for Sabrina SoC
by Tim Wawrzynczak (Code Review) 09 Feb '22

09 Feb '22

Attention is currently required from: Reka Norman, Tim Wawrzynczak, Karthik Ramasubramanian. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61543 ) Change subject: spd/lp5: Generate initial SPDs for Sabrina SoC ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61543 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibb43f26b36460290341c5ffcad1ef5a2ff1647c8 Gerrit-Change-Number: 61543 Gerrit-PatchSet: 3 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 09 Feb 2022 03:19:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/net/r8168: Add ASPM control mechanism
by Tim Wawrzynczak (Code Review) 09 Feb '22

09 Feb '22

Attention is currently required from: Rory Liu, Paul Menzel, Zhuohao Lee, Alan Huang. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61267 ) Change subject: drivers/net/r8168: Add ASPM control mechanism ...................................................................... Patch Set 4: Code-Review+2 (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/61267/comment/11867212_2a9c72c3 PS1, Line 13: > We're not sure if it's necessary for other devices, so we make it optional. […] I think may also depend on board design. File src/drivers/net/chip.h: https://review.coreboot.org/c/coreboot/+/61267/comment/06568f9f_b08a44f1 PS2, Line 35: /* Allow kernel driver to enable ASPM L1.2. */ : bool enable_aspm; > So coreboot already has a Kconfig option to enable ASPM on PCIe links (PCIEXP_ASPM, see https://revi […] Done File src/drivers/net/r8168.c: https://review.coreboot.org/c/coreboot/+/61267/comment/587cf6b6_237f2ca1 PS3, Line 40: ASPM_L1_2 0xe059000f > nit: […] Ack https://review.coreboot.org/c/coreboot/+/61267/comment/af4d600d_30e149eb PS3, Line 359: /* Enable ASPM_L1.2 */ : if (CONFIG(PCIEXP_ASPM)) : enable_aspm_l1_2(io_base); > I see, thank you for the explanation. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/61267 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I944dbf04d3ca19df4de224540bee538bff4d1f12 Gerrit-Change-Number: 61267 Gerrit-PatchSet: 4 Gerrit-Owner: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 09 Feb 2022 03:18:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2022