Rex-BC Chen has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/58639 )
Change subject: DO-NOT-SUBMIT: MT8186 Corsola review ToT
......................................................................
Abandoned
most part of mt8186 coreboot patches are merged.
I think we can abandon this ToT.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58639
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53f304822c426417bb58037daa536bfb8dda1db3
Gerrit-Change-Number: 58639
Gerrit-PatchSet: 121
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: abandon
Attention is currently required from: Mac Chiang.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61404 )
Change subject: mb/google/brya/variants/brask: Enable Bluetooth offload support
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File src/mainboard/google/brya/variants/brask/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/61404/comment/8292b1b6_1fff130d
PS3, Line 2: 1 3
> Thanks Zhuohao! I modified it.
Thanks Mac!
--
To view, visit https://review.coreboot.org/c/coreboot/+/61404
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5da8c5c471be176bc0fe1eda4da7faf8ed2e8d2
Gerrit-Change-Number: 61404
Gerrit-PatchSet: 4
Gerrit-Owner: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Huang <alan-huang(a)quanta.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-Comment-Date: Wed, 09 Feb 2022 05:58:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Mac Chiang <mac.chiang(a)intel.com>
Comment-In-Reply-To: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Zhuohao Lee.
Mac Chiang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61404 )
Change subject: mb/google/brya/variants/brask: Enable Bluetooth offload support
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brya/variants/brask/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/61404/comment/6b8aac9e_b09b7d16
PS3, Line 2: 1 3
> Could you change the FW_CONFIG starting from 0. ie. […]
Thanks Zhuohao! I modified it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/61404
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5da8c5c471be176bc0fe1eda4da7faf8ed2e8d2
Gerrit-Change-Number: 61404
Gerrit-PatchSet: 4
Gerrit-Owner: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Huang <alan-huang(a)quanta.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Comment-Date: Wed, 09 Feb 2022 05:49:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Mac Chiang.
Hello build bot (Jenkins), Tim Wawrzynczak, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61404
to look at the new patch set (#4).
Change subject: mb/google/brya/variants/brask: Enable Bluetooth offload support
......................................................................
mb/google/brya/variants/brask: Enable Bluetooth offload support
Add fw_config NAU88L25B_I2S field, I2S2 configuration and
enabling CnviBtAudioOffload UPD bit.
BUG=none
TEST=temerge-brask coreboot
Signed-off-by: Mac Chiang <mac.chiang(a)intel.com>
Change-Id: Id5da8c5c471be176bc0fe1eda4da7faf8ed2e8d2
---
M src/mainboard/google/brya/variants/brask/Makefile.inc
A src/mainboard/google/brya/variants/brask/fw_config.c
M src/mainboard/google/brya/variants/brask/overridetree.cb
A src/mainboard/google/brya/variants/brask/variant.c
4 files changed, 64 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/61404/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/61404
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5da8c5c471be176bc0fe1eda4da7faf8ed2e8d2
Gerrit-Change-Number: 61404
Gerrit-PatchSet: 4
Gerrit-Owner: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Huang <alan-huang(a)quanta.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61446 )
Change subject: soc/mediatek/mt8186: Fix issue of clearing watchdog status
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
@hung-te,
Could we merge these patches?
Thanks!
--
To view, visit https://review.coreboot.org/c/coreboot/+/61446
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8c5dbaab2ac43d3867037bc4160aa5af2d79284f
Gerrit-Change-Number: 61446
Gerrit-PatchSet: 2
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Comment-Date: Wed, 09 Feb 2022 05:23:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment