Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/60338 )
Change subject: soc/mediatek/mt8186: Add SPM firmware
......................................................................
Patch Set 1:
(1 comment)
File soc/mediatek/mt8186/spm_firmware.bin:
PS1:
> I think it's not a good idea to change this. […]
Then can you ask them to change how they create the version string?
--
To view, visit https://review.coreboot.org/c/blobs/+/60338
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: I5a35f1c10886d31da9ba6dfec5ee2b3cf0664563
Gerrit-Change-Number: 60338
Gerrit-PatchSet: 1
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 10 Feb 2022 13:08:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: comment
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61776 )
Change subject: Revert "cpu/x86/lapic: Unconditionally use CPUID leaf 0xb if available"
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61776/comment/904d8efb_4a53f978
PS1, Line 16: valid APIC ID.
> Advanced Micro Devices CPUID Specification […]
!cpu_is_amd() wouldn't be the right check there, since cezanne does support x2apic and cpuid_ext(0xb, 0).edx returns a valid apic id on cezanne, so that's not generally wrong for all amd cpus. the problem is only present on picasso and possibly earlier amd cpus that don't support x2apic.
would adding a function to check the presence of the x2apic feature via bit 21 in EAX of CPUID leaf 1 be a good alternative?
--
To view, visit https://review.coreboot.org/c/coreboot/+/61776
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If1e3c55ce2d048b14c08e06bb79810179a87993d
Gerrit-Change-Number: 61776
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-Comment-Date: Thu, 10 Feb 2022 12:59:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-MessageType: comment
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61438 )
Change subject: mb/google/dedede/var/magolor: Add custom Wifi SAR for magneto
......................................................................
mb/google/dedede/var/magolor: Add custom Wifi SAR for magneto
Add wifi sar for magneto.
Due to fw-config cannot distinguish between magolor and magneto.
Using sku_id to decide to load magneto custom wifi sar.
BUG=b:208261420
TEST= emerge-dedede coreboot
Signed-off-by: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Change-Id: I77f141372ba8e7b8f5849b00e115ad8bb1e7ca00
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61438
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Shou-Chieh Hsu <shouchieh(a)google.com>
Reviewed-by: Henry Sun <henrysun(a)google.com>
Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com>
Reviewed-by: David Wu <david_wu(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/magolor/variant.c
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
David Wu: Looks good to me, approved
Karthik Ramasubramanian: Looks good to me, approved
Henry Sun: Looks good to me, but someone else must approve
Shou-Chieh Hsu: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/dedede/variants/magolor/variant.c b/src/mainboard/google/dedede/variants/magolor/variant.c
index 39a197a..33c428c 100644
--- a/src/mainboard/google/dedede/variants/magolor/variant.c
+++ b/src/mainboard/google/dedede/variants/magolor/variant.c
@@ -14,6 +14,8 @@
MAGISTER_SKU_END = 0xcffff,
MAGMA_SKU_START = 0xd0000,
MAGMA_SKU_END = 0xdffff,
+ MAGNETO_SKU_START = 0x110000,
+ MAGNETO_SKU_END = 0x11ffff,
};
const char *get_wifi_sar_cbfs_filename(void)
@@ -26,6 +28,8 @@
return "wifi_sar-magister.hex";
if (sku_id >= MAGMA_SKU_START && sku_id <= MAGMA_SKU_END)
return "wifi_sar-magma.hex";
+ if (sku_id >= MAGNETO_SKU_START && sku_id <= MAGNETO_SKU_END)
+ return "wifi_sar-magneto.hex";
return WIFI_SAR_CBFS_DEFAULT_FILENAME;
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/61438
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I77f141372ba8e7b8f5849b00e115ad8bb1e7ca00
Gerrit-Change-Number: 61438
Gerrit-PatchSet: 3
Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-MessageType: merged