coreboot-gerrit February 2022

coreboot-gerrit@coreboot.org

1 participants
7066 discussions

Change in coreboot[master]: mb/google/brya/var/brask: Enable ASPM of RTL8125
by Rory Liu (Code Review) 11 Feb '22

11 Feb '22

Attention is currently required from: Rory Liu, Zhuohao Lee, Alan Huang. Hello build bot (Jenkins), Tim Wawrzynczak, Paul Menzel, Zhuohao Lee, Alan Huang, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/61268 to look at the new patch set (#6). Change subject: mb/google/brya/var/brask: Enable ASPM of RTL8125 ...................................................................... mb/google/brya/var/brask: Enable ASPM of RTL8125 Brask cannot pass powerd_dbus_suspend test because the NIC does not enter ASPM L1.2. Here we add "enable_aspm_l1_2" in devicetree for RTL8125 to enable ASPM L1.2. BUG=b:204309459 BRANCH=None TEST=emerge and test with command powerd_dbus_suspend Signed-off-by: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Change-Id: I9a56df1d68696f409f9ee681d37de6759a588d80 --- M src/mainboard/google/brya/variants/brask/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/61268/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/61268 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9a56df1d68696f409f9ee681d37de6759a588d80 Gerrit-Change-Number: 61268 Gerrit-PatchSet: 6 Gerrit-Owner: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rory Liu <rory.liu(a)quanta.corp-partner.google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Alan Huang <alan-huang(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in blobs[master]: soc/mediatek/mt8186: Add SPM firmware
by Rex-BC Chen (Code Review) 11 Feb '22

11 Feb '22

Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/60338 ) Change subject: soc/mediatek/mt8186: Add SPM firmware ...................................................................... Patch Set 1: (1 comment) File soc/mediatek/mt8186/spm_firmware.bin: PS1: > Then can you ask them to change how they create the version string? We have checked the issue:215639203, and we may changed the spm blob. Maybe we can see this issue after fixing 215639203. -- To view, visit https://review.coreboot.org/c/blobs/+/60338 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: I5a35f1c10886d31da9ba6dfec5ee2b3cf0664563 Gerrit-Change-Number: 60338 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 11 Feb 2022 01:54:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/smmstore/store.c: Add static assertion based on fmap
by Matt DeVillier (Code Review) 11 Feb '22

11 Feb '22

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61562 ) Change subject: drivers/smmstore/store.c: Add static assertion based on fmap ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Building with `make -j$(nproc)` results in compilation failing: src/drivers/smmstore/store.c:5:10: fatal error: fmap_config.h: No such file or directory 5 | #include <fmap_config.h> Building with just `make` (or make -j1) succeeds. -- To view, visit https://review.coreboot.org/c/coreboot/+/61562 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b5b511142d93d5799565a8936e9a087117044b3 Gerrit-Change-Number: 61562 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: MrChromebox <mrchromebox(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 11 Feb 2022 01:24:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86/acpi: Add code for KEY_MENU
by Boris Mittelberg (Code Review) 11 Feb '22

11 Feb '22

Boris Mittelberg has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61835 ) Change subject: arch/x86/acpi: Add code for KEY_MENU ...................................................................... arch/x86/acpi: Add code for KEY_MENU Brya chromebooks need support for MENU aka hamburger key. BUG=b:215038215 BRANCH=none TEST=none Signed-off-by: Boris Mittelberg <bmbm(a)google.com> Change-Id: I07873dd9385c743a6512408688ec44a5e97219f9 --- M src/acpi/acpigen_ps2_keybd.c M src/ec/google/chromeec/ec_acpi.c M src/include/acpi/acpigen_ps2_keybd.h 3 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/61835/1 diff --git a/src/acpi/acpigen_ps2_keybd.c b/src/acpi/acpigen_ps2_keybd.c index c65790d..0880a32 100644 --- a/src/acpi/acpigen_ps2_keybd.c +++ b/src/acpi/acpigen_ps2_keybd.c @@ -56,6 +56,7 @@ KEY_PRIVACY_SCREEN_TOGGLE), [PS2_KEY_MICMUTE] = KEYMAP(0x9b, KEY_MICMUTE), /* e01b */ [PS2_KEY_KBD_BKLIGHT_TOGGLE] = KEYMAP(0x9e, KEY_KBDILLUMTOGGLE), /* e01e */ + [PS2_KEY_MENU] = KEYMAP(0xaf, KEY_CONTROLPANEL), /* e02f */ }; /* Keymap for numeric keypad keys */ diff --git a/src/ec/google/chromeec/ec_acpi.c b/src/ec/google/chromeec/ec_acpi.c index 0598364..c6301e1 100644 --- a/src/ec/google/chromeec/ec_acpi.c +++ b/src/ec/google/chromeec/ec_acpi.c @@ -186,6 +186,7 @@ [TK_PREV_TRACK] = PS2_KEY_PREV_TRACK, [TK_KBD_BKLIGHT_TOGGLE] = PS2_KEY_KBD_BKLIGHT_TOGGLE, [TK_MICMUTE] = PS2_KEY_MICMUTE, + [TK_MENU] = PS2_KEY_MENU, }; static void fill_ssdt_ps2_keyboard(const struct device *dev) diff --git a/src/include/acpi/acpigen_ps2_keybd.h b/src/include/acpi/acpigen_ps2_keybd.h index e32ca2a..7dd8282 100644 --- a/src/include/acpi/acpigen_ps2_keybd.h +++ b/src/include/acpi/acpigen_ps2_keybd.h @@ -26,6 +26,7 @@ PS2_KEY_PREV_TRACK, PS2_KEY_KBD_BKLIGHT_TOGGLE, PS2_KEY_MICMUTE, + PS2_KEY_MENU, }; #define PS2_MIN_TOP_ROW_KEYS 10 -- To view, visit https://review.coreboot.org/c/coreboot/+/61835 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I07873dd9385c743a6512408688ec44a5e97219f9 Gerrit-Change-Number: 61835 Gerrit-PatchSet: 1 Gerrit-Owner: Boris Mittelberg <bmbm(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/mediatek: Fix printing SPM version
by Yu-Ping Wu (Code Review) 11 Feb '22

11 Feb '22

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61800 ) Change subject: soc/mediatek: Fix printing SPM version ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/61800/comment/86c305b0_fee0f535 PS1, Line 16: none > Do we need to cherry-pick this change to asurada or cherry branches? For mt8192 there's \0 at the end. For mt8195 there isn't, but I don't remember seeing this problem on cherry. That said, I think we should still fix the firmware branches. -- To view, visit https://review.coreboot.org/c/coreboot/+/61800 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icfeb686539dc20cf5b78de77c27bdbb137b5d624 Gerrit-Change-Number: 61800 Gerrit-PatchSet: 2 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 11 Feb 2022 00:23:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek: Fix printing SPM version
by Yu-Ping Wu (Code Review) 11 Feb '22

11 Feb '22

Attention is currently required from: Yu-Ping Wu. Hello Hung-Te Lin, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/61800 to look at the new patch set (#2). Change subject: soc/mediatek: Fix printing SPM version ...................................................................... soc/mediatek: Fix printing SPM version Currently the SPM version string is stored at the end of the blob, possibly without a trailing '\0'. Therefore, we should be careful not to print characters beyond the blob size. BUG=b:211944565 TEST=emerge-corsola coreboot TEST=SPM version looked good in AP console BRANCH=asurada,cherry Change-Id: Icfeb686539dc20cf5b78de77c27bdbb137b5d624 Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M src/soc/mediatek/common/spm.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/61800/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61800 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icfeb686539dc20cf5b78de77c27bdbb137b5d624 Gerrit-Change-Number: 61800 Gerrit-PatchSet: 2 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/chromeos/crosfirmware: format with shfmt
by Paul Menzel (Code Review) 11 Feb '22

11 Feb '22

Attention is currently required from: Matt DeVillier. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61617 ) Change subject: util/chromeos/crosfirmware: format with shfmt ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/61617 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46ce84668bfb4ea3df179317e2848b6bb75d8d5c Gerrit-Change-Number: 61617 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Thu, 10 Feb 2022 23:26:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [RFC] cpu/x86/lapic: Always have LAPIC enabled
by Paul Menzel (Code Review) 11 Feb '22

11 Feb '22

Attention is currently required from: Kyösti Mälkki. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61794 ) Change subject: [RFC] cpu/x86/lapic: Always have LAPIC enabled ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/61794 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id564a3007ea7a3d9fb81005a05399a18c4cf7289 Gerrit-Change-Number: 61794 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Thu, 10 Feb 2022 23:24:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/lapic: Fix SMP=n case with LEGACY_SMP_INIT
by Paul Menzel (Code Review) 11 Feb '22

11 Feb '22

Attention is currently required from: Keith Hui, Branden Waldner, Kyösti Mälkki. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61793 ) Change subject: cpu/x86/lapic: Fix SMP=n case with LEGACY_SMP_INIT ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/61793 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If51e5d65153a02ac7af191e7897c04bd4e298006 Gerrit-Change-Number: 61793 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Branden Waldner <scruffy99(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Attention: Branden Waldner <scruffy99(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Thu, 10 Feb 2022 23:23:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/nivviks: Initialise overridetree
by Kangheui Won (Code Review) 11 Feb '22

11 Feb '22

Attention is currently required from: Reka Norman, Rizwan Qureshi, Tim Wawrzynczak, Krishna P Bhat D, Usha P. Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61605 ) Change subject: mb/google/brya/var/nivviks: Initialise overridetree ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61605 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id3ecd184415a20a3a52da8bb5e60fe2ce0495b44 Gerrit-Change-Number: 61605 Gerrit-PatchSet: 5 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Comment-Date: Thu, 10 Feb 2022 23:15:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2022