Attention is currently required from: Keith Hui, Branden Waldner, Angel Pons, Patrick Rudolph.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55314 )
Change subject: sb,soc/intel: Use register_new_ioapic_gsi0()
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8:
> Sorry I am late to the game, but what is the purpose of this patch train?
Remove incorrect and/or stale setting of IOAPIC IDs and ultimately simplify some of the ACPI creation.
--
To view, visit https://review.coreboot.org/c/coreboot/+/55314
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b0e4021595fb160ae3bf798468f4505b460266f
Gerrit-Change-Number: 55314
Gerrit-PatchSet: 8
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Branden Waldner <scruffy99(a)gmail.com>
Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Keith Hui <buurin(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Keith Hui <buurin(a)gmail.com>
Gerrit-Attention: Branden Waldner <scruffy99(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Keith Hui <buurin(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 10 Feb 2022 21:28:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Keith Hui <buurin(a)gmail.com>
Gerrit-MessageType: comment
Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61562 )
Change subject: drivers/smmstore/store.c: Add static assertion based on fmap
......................................................................
drivers/smmstore/store.c: Add static assertion based on fmap
Instead of having runtime failures that are hard to debug because SMM
debugging is disabled by default assert some properties of fmap at
buildtime.
Change-Id: I5b5b511142d93d5799565a8936e9a087117044b3
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61562
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Martin Roth <martinroth(a)google.com>
Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/drivers/smmstore/store.c
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
Martin Roth: Looks good to me, approved
Matt DeVillier: Looks good to me, but someone else must approve
diff --git a/src/drivers/smmstore/store.c b/src/drivers/smmstore/store.c
index 24e8a88..6ba3f53 100644
--- a/src/drivers/smmstore/store.c
+++ b/src/drivers/smmstore/store.c
@@ -2,6 +2,7 @@
#include <boot_device.h>
#include <fmap.h>
+#include <fmap_config.h>
#include <commonlib/helpers.h>
#include <commonlib/region.h>
#include <console/console.h>
@@ -10,6 +11,13 @@
#define SMMSTORE_REGION "SMMSTORE"
+
+_Static_assert(IS_ALIGNED(FMAP_SECTION_SMMSTORE_START, SMM_BLOCK_SIZE),
+ "SMMSTORE FMAP region not aligned to 64K");
+
+_Static_assert(SMM_BLOCK_SIZE <= FMAP_SECTION_SMMSTORE_SIZE,
+ "SMMSTORE FMAP region must be at least 64K");
+
/*
* The region format is still not finalized, but so far it looks like this:
* (
--
To view, visit https://review.coreboot.org/c/coreboot/+/61562
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5b5b511142d93d5799565a8936e9a087117044b3
Gerrit-Change-Number: 61562
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: MrChromebox <mrchromebox(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: merged
Attention is currently required from: Arthur Heymans, Matt DeVillier, MrChromebox.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61562 )
Change subject: drivers/smmstore/store.c: Add static assertion based on fmap
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61562
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5b5b511142d93d5799565a8936e9a087117044b3
Gerrit-Change-Number: 61562
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: MrChromebox <mrchromebox(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: MrChromebox <mrchromebox(a)gmail.com>
Gerrit-Comment-Date: Thu, 10 Feb 2022 21:25:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61684 )
Change subject: mb/google/reef/coral/mainboard.c: Drop break after return inside switch
......................................................................
mb/google/reef/coral/mainboard.c: Drop break after return inside switch
Drop unnecessary switch break after return, to alleviate linter warnings.
Change-Id: I7cc49caaeafb490cb62b75ec5c3ca4822573464b
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61684
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
---
M src/mainboard/google/reef/variants/coral/mainboard.c
1 file changed, 0 insertions(+), 8 deletions(-)
Approvals:
build bot (Jenkins): Verified
Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/google/reef/variants/coral/mainboard.c b/src/mainboard/google/reef/variants/coral/mainboard.c
index ec7041d..1e7ebba 100644
--- a/src/mainboard/google/reef/variants/coral/mainboard.c
+++ b/src/mainboard/google/reef/variants/coral/mainboard.c
@@ -132,28 +132,22 @@
case SKU_0_ASTRONAUT:
case SKU_1_ASTRONAUT:
return "vbt-astronaut.bin";
- break;
case SKU_2_SANTA:
case SKU_3_SANTA:
return "vbt-santa.bin";
- break;
case SKU_13_EPAULETTE:
case SKU_14_EPAULETTE:
case SKU_15_EPAULETTE:
case SKU_16_EPAULETTE:
return "vbt-epaulette.bin";
- break;
case SKU_28_RABBID_RUGGED:
return "vbt-rabbid_rugged.bin";
- break;
case SKU_30_BABYTIGER:
case SKU_33_BABYTIGER:
return "vbt-babytiger.bin";
- break;
case SKU_52_BABYMEGA:
case SKU_53_BABYMEGA:
return "vbt-babymega.bin";
- break;
case SKU_160_NASHER:
case SKU_161_NASHER:
case SKU_162_NASHER:
@@ -162,10 +156,8 @@
case SKU_165_NASHER360:
case SKU_166_NASHER360:
return "vbt-nasher.bin";
- break;
default:
return "vbt.bin";
- break;
}
}
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
--
To view, visit https://review.coreboot.org/c/coreboot/+/61684
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7cc49caaeafb490cb62b75ec5c3ca4822573464b
Gerrit-Change-Number: 61684
Gerrit-PatchSet: 5
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Paul Menzel, Tim Wawrzynczak.
Tim Wawrzynczak has uploaded a new patch set (#3) to the change originally created by Tracy Wu. ( https://review.coreboot.org/c/coreboot/+/61728 )
Change subject: mb/google/brya: Adjust FMD file for some boards
......................................................................
mb/google/brya: Adjust FMD file for some boards
When brya boards that use ChromeOS autoupdate update their firmware,
devices with SOC_INTEL_CSE_SUB_PART_UPDATE will end up attempting to
replace IOM and NPHY BPDT firmware in the CSE region. However, because
of the way the autoupdate works, the CSE RO will not be updated during
autoupdate. This means that these boards now have different stitching
schemes between CSE RO and RW and this causes the sub-partition update
to fail and the boot hangs. To remedy the situation for these boards,
a separate FMD files is provided so they can continue to use the
cse_serger tool for stitching. The only boards affected were kano and
brask, so they are updated here.
BUG=b:218376385
TEST=use flashrom to downgrade to 14474 then use futility to update to
image with this patch and system boots.
Signed-off-by: Tracy Wu <tracy.wu(a)intel.corp-partner.google.com>
Change-Id: Ia8bdf6b28d952f6d983b84e39da96e159027a822
---
M src/mainboard/google/brya/Kconfig
A src/mainboard/google/brya/chromeos-serger.fmd
2 files changed, 64 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/61728/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/61728
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8bdf6b28d952f6d983b84e39da96e159027a822
Gerrit-Change-Number: 61728
Gerrit-PatchSet: 3
Gerrit-Owner: Tracy Wu <tracy.wu(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Matt DeVillier.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61683 )
Change subject: mb/google/reef/coral: Sync mainboard.c with Chromium fork
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61683
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf2a53a351138aff310385f4026197d74ab6848b
Gerrit-Change-Number: 61683
Gerrit-PatchSet: 4
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Thu, 10 Feb 2022 21:21:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment