coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: mb/prodrive/atlas: Add DP++ support
by build bot (Jenkins) (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Christian Walter, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70154 ) Change subject: mb/prodrive/atlas: Add DP++ support ...................................................................... Patch Set 1: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164918): https://review.coreboot.org/c/coreboot/+/70154/comment/3661677e_cfdd685d PS1, Line 8: 'suppport' may be misspelled - perhaps 'support'? -- To view, visit https://review.coreboot.org/c/coreboot/+/70154 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7aa34297a10bf16b9043140bff91fd3a8c4009d4 Gerrit-Change-Number: 70154 Gerrit-PatchSet: 1 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 30 Nov 2022 10:01:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/prodrive/atlas: Add DP++ support
by Lean Sheng Tan (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Christian Walter, Angel Pons. Lean Sheng Tan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70154 ) Change subject: mb/prodrive/atlas: Add DP++ support ...................................................................... mb/prodrive/atlas: Add DP++ support Update VBT configurations for DP++ and DP dongles suppport. Signed-off-by: Lean Sheng Tan <sheng.tan(a)9elements.com> Change-Id: I7aa34297a10bf16b9043140bff91fd3a8c4009d4 --- M src/mainboard/prodrive/atlas/data.vbt 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/70154/1 diff --git a/src/mainboard/prodrive/atlas/data.vbt b/src/mainboard/prodrive/atlas/data.vbt index d1e0dc9..9c4aa8a 100644 --- a/src/mainboard/prodrive/atlas/data.vbt +++ b/src/mainboard/prodrive/atlas/data.vbt Binary files differ -- To view, visit https://review.coreboot.org/c/coreboot/+/70154 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7aa34297a10bf16b9043140bff91fd3a8c4009d4 Gerrit-Change-Number: 70154 Gerrit-PatchSet: 1 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: 3rdparty/fsp: Update submodule pointer to latest master
by Lean Sheng Tan (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Arthur Heymans, Lean Sheng Tan. Hello Angel Pons, Arthur Heymans, Marvin Drees, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70153 to look at the new patch set (#2). Change subject: 3rdparty/fsp: Update submodule pointer to latest master ...................................................................... 3rdparty/fsp: Update submodule pointer to latest master Here are the FSP updates with latest master: - IoT EHL MR5 - IoT ADL-P MR2 - IoT ADL-S MR3 - IoT ADL-PS PV - IoT TGL MR7 Signed-off-by: Lean Sheng Tan <sheng.tan(a)9elements.com> Change-Id: If4a76fe25c7b7a2c34e5bb284418c01c77b22abb --- M 3rdparty/fsp 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/70153/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4a76fe25c7b7a2c34e5bb284418c01c77b22abb Gerrit-Change-Number: 70153 Gerrit-PatchSet: 2 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: 3rdparty/fsp: Update submodule pointer to latest master
by Angel Pons (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Arthur Heymans, Lean Sheng Tan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70153 ) Change subject: 3rdparty/fsp: Update submodule pointer to latest master ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/70153/comment/3367163d_d0fde6d3 PS1, Line 7: 3rdparty/fsp: Update submodule pointer to latest master What horrors does the updated submodule bring? It would be great if you could mention what's new with this submodule update, or at the very least the reason why you'd like to update the submodule. -- To view, visit https://review.coreboot.org/c/coreboot/+/70153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4a76fe25c7b7a2c34e5bb284418c01c77b22abb Gerrit-Change-Number: 70153 Gerrit-PatchSet: 1 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Wed, 30 Nov 2022 09:54:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: 3rdparty/fsp: Update submodule pointer to latest master
by Marvin Drees (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Angel Pons, Arthur Heymans, Lean Sheng Tan. Marvin Drees has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70153 ) Change subject: 3rdparty/fsp: Update submodule pointer to latest master ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/70153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4a76fe25c7b7a2c34e5bb284418c01c77b22abb Gerrit-Change-Number: 70153 Gerrit-PatchSet: 1 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Wed, 30 Nov 2022 09:49:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: sb/intel/i82801gx: Use bloolean for p_cnt_throttling_supported
by Arthur Heymans (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Evgeny Zinoviev, Alexander Couzens, Elyes Haouas. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70113 ) Change subject: sb/intel/i82801gx: Use bloolean for p_cnt_throttling_supported ...................................................................... Patch Set 4: Code-Review-2 (1 comment) Patchset: PS4: Why are you removing and therefore changing the value of all those devicetree settings? -- To view, visit https://review.coreboot.org/c/coreboot/+/70113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ae96caf2d0700ca46d59c082b64b75fc1962a47 Gerrit-Change-Number: 70113 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 30 Nov 2022 09:49:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: sb/intel: Use boolean for c4onc3_enable
by Arthur Heymans (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Stefan Ott, Evgeny Zinoviev, Alexander Couzens, Elyes Haouas. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70112 ) Change subject: sb/intel: Use boolean for c4onc3_enable ...................................................................... Patch Set 2: Code-Review-2 (2 comments) Patchset: PS2: Some devicetrees have it set to 0 others to 1 and both are just removed? What is this patch trying to achieve? File src/southbridge/intel/i82801gx/chip.h: https://review.coreboot.org/c/coreboot/+/70112/comment/6653058d_e78d8223 PS2, Line 66: c4onc3_enable:true; This just a weird way of writing "bool c4onc3_enable:1;" ? -- To view, visit https://review.coreboot.org/c/coreboot/+/70112 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4a5ea5f71579610721c91e8a7412da615c0d150 Gerrit-Change-Number: 70112 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 30 Nov 2022 09:48:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: 3rdparty/fsp: Update submodule pointer to latest master
by Lean Sheng Tan (Code Review) 30 Nov '22

30 Nov '22

Lean Sheng Tan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70153 ) Change subject: 3rdparty/fsp: Update submodule pointer to latest master ...................................................................... 3rdparty/fsp: Update submodule pointer to latest master Signed-off-by: Lean Sheng Tan <sheng.tan(a)9elements.com> Change-Id: If4a76fe25c7b7a2c34e5bb284418c01c77b22abb --- M 3rdparty/fsp 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/70153/1 diff --git a/3rdparty/fsp b/3rdparty/fsp index 12160fe..2047412 160000 --- a/3rdparty/fsp +++ b/3rdparty/fsp @@ -1 +1 @@ -Subproject commit 12160fe64bc1caaba3c2d6be44da0cd8787a2561 +Subproject commit 204741228d90f74e9926343083b8059cd16740b7 -- To view, visit https://review.coreboot.org/c/coreboot/+/70153 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4a76fe25c7b7a2c34e5bb284418c01c77b22abb Gerrit-Change-Number: 70153 Gerrit-PatchSet: 1 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: drivers/generic/nau8315: Allow custom _HID from config
by David Lin (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Alan Lee, John Hsu. David Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69965 ) Change subject: drivers/generic/nau8315: Allow custom _HID from config ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/69965 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6f02e495eeb06290947edc9e44fa25a4ce18956 Gerrit-Change-Number: 69965 Gerrit-PatchSet: 1 Gerrit-Owner: David Lin <CTLIN0(a)nuvoton.com> Gerrit-Reviewer: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Hsu <KCHSU0(a)nuvoton.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: CT Lin <ctlin0(a)nuvoton.corp-partner.google.com> Gerrit-CC: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com> Gerrit-Attention: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-Attention: John Hsu <KCHSU0(a)nuvoton.com> Gerrit-Comment-Date: Wed, 30 Nov 2022 09:39:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Add timestamp for cse_fw_sync The patch add tim...
by Dinesh Gehlot (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Hello Tarun Tuli, Subrata Banik, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70172 to look at the new patch set (#4). Change subject: soc/intel/meteorlake: Add timestamp for cse_fw_sync The patch add timestamp around cse_fw_sync(). ...................................................................... soc/intel/meteorlake: Add timestamp for cse_fw_sync The patch add timestamp around cse_fw_sync(). BUG=none TEST=Verified on rex, cbmem -t: 948:starting CSE firmware sync 1,340,551 (50,657) 949:finished CSE firmware sync 1,379,348 (38,797) Port of commit 7c6dd796f26f (“soc/intel/alderlake: Add timestamp for cse_fw_sync”) Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> Change-Id: I6cfbf84018e312fbf9482f0fba05b444603cd4b9 --- M src/soc/intel/meteorlake/romstage/romstage.c 1 file changed, 25 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/70172/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/70172 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6cfbf84018e312fbf9482f0fba05b444603cd4b9 Gerrit-Change-Number: 70172 Gerrit-PatchSet: 4 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022