coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: mb/google/brya/var/anahera: Adjust I2C5 timing for touchpad
by Chen Wisley (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Wisley Chen. Hello Wisley Chen, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/70171 to review the following change. Change subject: mb/google/brya/var/anahera: Adjust I2C5 timing for touchpad ...................................................................... mb/google/brya/var/anahera: Adjust I2C5 timing for touchpad Adjust scl_lcnt, scl_hcnt, sda_hold value for I2C5 to meet touchpad SPEC. BUG=b:260540852 BRANCH=firmware-brya-14505.B TEST=build, checked TP function work normally, and measure the timing meet SPEC Change-Id: I9036a604a90558911c4f8a492db9f1f0f28bf404 Signed-off-by: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/anahera/overridetree.cb 1 file changed, 22 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/70171/1 diff --git a/src/mainboard/google/brya/variants/anahera/overridetree.cb b/src/mainboard/google/brya/variants/anahera/overridetree.cb index df7f632..1773e0e 100644 --- a/src/mainboard/google/brya/variants/anahera/overridetree.cb +++ b/src/mainboard/google/brya/variants/anahera/overridetree.cb @@ -66,7 +66,12 @@ .speed = I2C_SPEED_FAST, .rise_time_ns = 650, .fall_time_ns = 400, - .data_hold_time_ns = 50, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 170, + .scl_hcnt = 70, + .sda_hold = 40, + } }, }" register "tcc_offset" = "3" # TCC of 97C -- To view, visit https://review.coreboot.org/c/coreboot/+/70171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9036a604a90558911c4f8a492db9f1f0f28bf404 Gerrit-Change-Number: 70171 Gerrit-PatchSet: 1 Gerrit-Owner: Chen Wisley <wisley.chen%quantatw.com(a)gtempaccount.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: util/ectool/Makefile: improve cross-compilation support
by Michał Kotyla (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Nico Huber, Martin L Roth, Paul Menzel. Michał Kotyla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70102 ) Change subject: util/ectool/Makefile: improve cross-compilation support ...................................................................... Patch Set 2: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/70102/comment/fa190ec9_151faf0b PS1, Line 7: util/ectool/Makefile : > Please remove the space before the colon. Removed https://review.coreboot.org/c/coreboot/+/70102/comment/86d1d34c_9ee622d1 PS1, Line 11: buildsystem like Yocto > Please add a dot/period at the end of sentences. Done Patchset: PS2: Commit messages updated File util/ectool/Makefile: https://review.coreboot.org/c/coreboot/+/70102/comment/942691ae_48d4615a PS1, Line 3: CC ?= gcc > Do you have more information regarding this. […] More description added to the commit message -- To view, visit https://review.coreboot.org/c/coreboot/+/70102 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If5c88bde0ae00f0211a250906cbdedfe4f59c67b Gerrit-Change-Number: 70102 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Kotyla Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: maciej.gabryelski(a)3mdeb.com Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 30 Nov 2022 08:44:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/meteorlake: Refactor `pmc_lockdown_cfg` function
by Kapil Porwal (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Tarun Tuli, Eran Mitrani, Kapil Porwal, Nick Vaccaro. Hello build bot (Jenkins), Tarun Tuli, Eran Mitrani, Subrata Banik, Nick Vaccaro, Eric Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70132 to look at the new patch set (#6). Change subject: soc/intel/meteorlake: Refactor `pmc_lockdown_cfg` function ...................................................................... soc/intel/meteorlake: Refactor `pmc_lockdown_cfg` function This patch refactors the `pmc_lockdown_cfg()` to remove the helper functions and uses the `setbits32` function to enforce bit locking as applicable. This patch also locks PMC features like: 1. Debug mode configuration and host read access to PMC XRAM. 2. PMC soft strap message interface. 3. PMC static function. and then calls into the PMC IPC function that informs about PCI enumeration. Port of - 1. commit 2eec87a553ec ("soc/intel/alderlake: Refactor `pmc_lockdown_cfg` function") 2. commit bae4a0b5a1e4 ("soc/intel/alderlake: Implement PMC feature lock") 3. commit c2570dc99800 ("soc/intel/alderlake: Implement PMC soft strap interface lock") 4. commit f021952c4067 ("soc/intel/alderlake: Implement PMC static function lock") 5. commit 457891415380 ("soc/intel/alderlake: Call into PMC IPC to inform PCI enumeration done") BUG=none TEST=Boot to OS on google/rex. Register values in OS - # busybox devmem 0xfe0018d4 32 #bit31 0x80000000 # busybox devmem 0xfe001024 32 #bit21,18,17,4 0x00362610 # busybox devmem 0xfe001818 32 #bit27,22 0x2B4F0004 # busybox devmem 0xfe00104c 32 #bit0 0x00000001 Signed-off-by: Kapil Porwal <kapilporwal(a)google.com> Change-Id: I3622748d8fecef69c60bb3fe9bfe68fc126764b7 --- M src/soc/intel/meteorlake/include/soc/pmc.h M src/soc/intel/meteorlake/lockdown.c 2 files changed, 69 insertions(+), 40 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/70132/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/70132 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3622748d8fecef69c60bb3fe9bfe68fc126764b7 Gerrit-Change-Number: 70132 Gerrit-PatchSet: 6 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: sb/intel: Use boolean for docking_supported
by Eric Lai (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Stefan Ott, Evgeny Zinoviev, Alexander Couzens, Elyes Haouas. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70111 ) Change subject: sb/intel: Use boolean for docking_supported ...................................................................... Patch Set 4: -Code-Review (5 comments) Patchset: PS4: Sorry, I see the problem. My fault, default true is better. Previous patch you didn't set default true in bd82x6x. So both true can remove the most line. File src/mainboard/getac/p470/devicetree.cb: https://review.coreboot.org/c/coreboot/+/70111/comment/6d92ca40_3efbdec6 PS4, Line 48: 1 true File src/mainboard/lenovo/t60/devicetree.cb: https://review.coreboot.org/c/coreboot/+/70111/comment/1abc5977_697886dc PS4, Line 66: 1 true File src/mainboard/lenovo/x60/devicetree.cb: https://review.coreboot.org/c/coreboot/+/70111/comment/9c1838de_c4a53b36 PS4, Line 60: 1 true File src/mainboard/roda/rk886ex/devicetree.cb: https://review.coreboot.org/c/coreboot/+/70111/comment/408ccb6c_d61c4e94 PS4, Line 43: 1 true -- To view, visit https://review.coreboot.org/c/coreboot/+/70111 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1df5a0bd914c11993ce291939f68848bcce0c638 Gerrit-Change-Number: 70111 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 30 Nov 2022 08:40:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/ifdtool/Makefile: improve cross-compilation support
by Michał Kotyla (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Stefan Reinauer. Hello build bot (Jenkins), Maciej Pijanowski, Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70105 to look at the new patch set (#2). Change subject: util/ifdtool/Makefile: improve cross-compilation support ...................................................................... util/ifdtool/Makefile: improve cross-compilation support INSTALL and PREFIX variables will not be overwritten. Also, mkidir was replaced by a tool from the INSTALL variable to be compatible with other cross-compilation buildsystems (like Yocto). Overwriting variables generates problems when we use different buildsystem like Yocto where tool names are stored in environment variables. This change may make building util tool easier - the user of different buildsystem will not have to remember to pass correct tool names during running the make command. Also, this change does not affect the rest of users - if the variable was not set before, then it will be configured as before. Signed-off-by: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Change-Id: Ia8dd67d18392e1e11d9160b187ef1a874d69ff5d --- M util/ifdtool/Makefile 1 file changed, 27 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/70105/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70105 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia8dd67d18392e1e11d9160b187ef1a874d69ff5d Gerrit-Change-Number: 70105 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Kotyla Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: util/inteltool/Makefile: improve cross-compilation support
by Michał Kotyla (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Stefan Reinauer. Hello build bot (Jenkins), maciej.gabryelski(a)3mdeb.com, Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70104 to look at the new patch set (#2). Change subject: util/inteltool/Makefile: improve cross-compilation support ...................................................................... util/inteltool/Makefile: improve cross-compilation support Use tool from INSTALL variable to create directory instead of mkdir to be compatible with other cross-compilation buildsystems (like Yocto). Signed-off-by: Maciej Gabryelski <maciej.gabryelski(a)3mdeb.com> Change-Id: I0b0949d07baae1ae1d7b22ac3d0b8913f81d89c1 --- M util/inteltool/Makefile 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/70104/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70104 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0b0949d07baae1ae1d7b22ac3d0b8913f81d89c1 Gerrit-Change-Number: 70104 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Kotyla Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: maciej.gabryelski(a)3mdeb.com Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: util/superiotool/Makefile: improve cross-compilation support
by Michał Kotyla (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Felix Held. Hello build bot (Jenkins), maciej.gabryelski(a)3mdeb.com, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70103 to look at the new patch set (#2). Change subject: util/superiotool/Makefile: improve cross-compilation support ...................................................................... util/superiotool/Makefile: improve cross-compilation support Use tool from INSTALL variable to create directory instead of mkdir to be compatible with other cross-compilation buildsystems (like Yocto). Signed-off-by: Maciej Gabryelski <maciej.gabryelski(a)3mdeb.com> Change-Id: I9d455f3d1a6d86c88b8e22da825fe14f9630e971 --- M util/superiotool/Makefile 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/70103/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d455f3d1a6d86c88b8e22da825fe14f9630e971 Gerrit-Change-Number: 70103 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Kotyla Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: maciej.gabryelski(a)3mdeb.com Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: util/ectool/Makefile: improve cross-compilation support
by Michał Kotyla (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Nico Huber, Martin L Roth, Michał Kotyla. Hello build bot (Jenkins), Nico Huber, maciej.gabryelski(a)3mdeb.com, Martin L Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70102 to look at the new patch set (#2). Change subject: util/ectool/Makefile: improve cross-compilation support ...................................................................... util/ectool/Makefile: improve cross-compilation support Build variables like CC, INSTALL, PREFIX, and LDFLAGS should not be overwritten by the Makefile. This generates problems when we use different buildsystem like Yocto where tool names are stored in environment variables. This change may make building util tool easier - the user of different buildsystem will not have to remember to pass correct tool names during running the make command. Also, this change does not affect the rest of users - if the variable was not set before, then it will be configured as before. Signed-off-by: Maciej Gabryelski <maciej.gabryelski(a)3mdeb.com> Change-Id: If5c88bde0ae00f0211a250906cbdedfe4f59c67b --- M util/ectool/Makefile 1 file changed, 25 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/70102/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70102 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If5c88bde0ae00f0211a250906cbdedfe4f59c67b Gerrit-Change-Number: 70102 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Kotyla Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: maciej.gabryelski(a)3mdeb.com Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Michał Kotyla Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: sb/intel: Use boolean for docking_supported
by Eric Lai (Code Review) 30 Nov '22

30 Nov '22

1 0

[S] Change in coreboot[master]: sb/intel: Use boolean for c4onc3_enable
by Elyes Haouas (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Stefan Ott, Evgeny Zinoviev, Alexander Couzens. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70112 ) Change subject: sb/intel: Use boolean for c4onc3_enable ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: > oh I missed that. […] recently add as per you suggestion 😊 PS2: Thx -- To view, visit https://review.coreboot.org/c/coreboot/+/70112 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4a5ea5f71579610721c91e8a7412da615c0d150 Gerrit-Change-Number: 70112 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 30 Nov 2022 08:25:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022