Attention is currently required from: Martin L Roth, MichaĆ Kotyla, Paul Menzel.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70102 )
Change subject: util/ectool/Makefile: improve cross-compilation support
......................................................................
Patch Set 2:
(2 comments)
File util/ectool/Makefile:
https://review.coreboot.org/c/coreboot/+/70102/comment/422559c4_28cc2e42
PS1, Line 3: CC ?= gcc
> More description added to the commit message
It's common practice to honor the environment variables. IIRC, GNU even
recommends to reserve all-caps variables for user-overridable things.
File util/ectool/Makefile:
https://review.coreboot.org/c/coreboot/+/70102/comment/c9a23e76_49101502
PS2, Line 12: LDFLAGS ?= -lioperm
This doesn't seem like good practice. `ioperm` is needed. Why should the
environment know that `ectool` needs it?
It's probably better to use separate variables for the environment, defaults
and necessary flags. The CFLAGS above for instance just provide a default,
but nothing that is required, nothing `ectool` specific. The `-l` flags,
however, seem necessary.
--
To view, visit https://review.coreboot.org/c/coreboot/+/70102
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If5c88bde0ae00f0211a250906cbdedfe4f59c67b
Gerrit-Change-Number: 70102
Gerrit-PatchSet: 2
Gerrit-Owner: MichaĆ Kotyla
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: maciej.gabryelski(a)3mdeb.com
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: MichaĆ Kotyla
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 30 Nov 2022 10:16:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: MichaĆ Kotyla
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Wonkyu Kim, Ravishankar Sarawadi, Rizwan Qureshi, Angel Pons, Krishna P Bhat D, Tim Wawrzynczak, Tarun Tuli, Jamie Ryu, Harsha B R, Kapil Porwal, Nick Vaccaro, Ronak Kanabar, Raj Astekar.
Harsha B R has uploaded a new patch set (#15) to the change originally created by Jamie Ryu. ( https://review.coreboot.org/c/coreboot/+/66102 )
Change subject: mb/intel/mtlrvp: Add MTL-P RVP board ids
......................................................................
mb/intel/mtlrvp: Add MTL-P RVP board ids
This adds MTL-P board id definition. Change include,
1. Add new board_id.c
2. Add new board_id.h
3. Add board_id config in variants.h
4. Makefile changes
BUG=b:224325352
TEST=Able to build with the patch and boot the mtlrvp platform with the
subsequent patches in the train
Signed-off-by: Jamie Ryu <jamie.m.ryu(a)intel.com>
Change-Id: I90b0543d5db208f696d2c2c2dc3d2581514a845b
Signed-off-by: Harsha B R <harsha.b.r(a)intel.com>
---
M src/mainboard/intel/mtlrvp/Makefile.inc
A src/mainboard/intel/mtlrvp/board_id.c
A src/mainboard/intel/mtlrvp/board_id.h
A src/mainboard/intel/mtlrvp/variants/baseboard/include/baseboard/variants.h
4 files changed, 92 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/66102/15
--
To view, visit https://review.coreboot.org/c/coreboot/+/66102
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90b0543d5db208f696d2c2c2dc3d2581514a845b
Gerrit-Change-Number: 66102
Gerrit-PatchSet: 15
Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Harsha B R <harsha.b.r(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Reviewer: Usha P <usha.p(a)intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Attention: Harsha B R <harsha.b.r(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com>
Gerrit-MessageType: newpatchset
Frank Chu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70174 )
Change subject: mb/google/brya/var/marasov: Adjust the bit fields in the FW_CONFIG
......................................................................
mb/google/brya/var/marasov: Adjust the bit fields in the FW_CONFIG
Adjust the bit fields in the FW_CONFIG for Proto Phase.
BUG=b:254404046
BRANCH=firmware-brya-14505.B
TEST=FW_NAME=marasov emerge-brya coreboot
Signed-off-by: Frank Chu <Frank_Chu(a)pegatron.corp-partner.google.com>
Change-Id: Ia71269918092655c11c2b37a26ec19123f759650
---
M src/mainboard/google/brya/variants/marasov/overridetree.cb
1 file changed, 21 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/70174/1
diff --git a/src/mainboard/google/brya/variants/marasov/overridetree.cb b/src/mainboard/google/brya/variants/marasov/overridetree.cb
index 70787c6..7ceafe6 100644
--- a/src/mainboard/google/brya/variants/marasov/overridetree.cb
+++ b/src/mainboard/google/brya/variants/marasov/overridetree.cb
@@ -1,16 +1,16 @@
fw_config
- field KB_BL 7 7
+ field KB_BL 0 0
option KB_BL_ABSENT 0
option KB_BL_PRESENT 1
end
- field AUDIO 8 10
+ field AUDIO 1 3
option AUDIO_UNKNOWN 0
option ALC1019_ALC5682I_VD_I2S 1
option ALC1019_ALC5682I_VS_I2S 2
end
- field THERMAL 18 18
- option THERMAL_6W 0
- option THERMAL_15W 1
+ field UFC 4 4
+ option UFC_USB 0
+ option UFC_MIPI 1
end
field STORAGE 30 31
option STORAGE_UNKNOWN 0
--
To view, visit https://review.coreboot.org/c/coreboot/+/70174
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia71269918092655c11c2b37a26ec19123f759650
Gerrit-Change-Number: 70174
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-MessageType: newchange
Attention is currently required from: Christian Walter, Angel Pons, Maximilian Brune, David Milosevic.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70154 )
Change subject: mb/prodrive/atlas: Add DP++ support
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/70154/comment/8ba2ad07_eae362e1
PS1, Line 8:
> > 'suppport' may be misspelled - perhaps 'support'? [âŠ]
Done
https://review.coreboot.org/c/coreboot/+/70154/comment/9f213d7c_70ed4085
PS1, Line 9: Update VBT configurations for DP++ and DP dongles suppport.
> Is this tested?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/70154
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7aa34297a10bf16b9043140bff91fd3a8c4009d4
Gerrit-Change-Number: 70154
Gerrit-PatchSet: 2
Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Comment-Date: Wed, 30 Nov 2022 10:12:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Maximilian Brune, Lean Sheng Tan, David Milosevic.
Hello Christian Walter, Angel Pons, Maximilian Brune, David Milosevic,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/70154
to look at the new patch set (#2).
Change subject: mb/prodrive/atlas: Add DP++ support
......................................................................
mb/prodrive/atlas: Add DP++ support
Update VBT configurations for DP++ and DP dongles support.
Tested working on customer's side.
Signed-off-by: Lean Sheng Tan <sheng.tan(a)9elements.com>
Change-Id: I7aa34297a10bf16b9043140bff91fd3a8c4009d4
---
M src/mainboard/prodrive/atlas/data.vbt
1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/70154/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/70154
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7aa34297a10bf16b9043140bff91fd3a8c4009d4
Gerrit-Change-Number: 70154
Gerrit-PatchSet: 2
Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Christian Walter, Maximilian Brune, Lean Sheng Tan, David Milosevic.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70154 )
Change subject: mb/prodrive/atlas: Add DP++ support
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/70154/comment/6d0e374f_663d7c66
PS1, Line 8:
> 'suppport' may be misspelled - perhaps 'support'?
Please fix.
https://review.coreboot.org/c/coreboot/+/70154/comment/b1b421aa_5f24d98e
PS1, Line 9: Update VBT configurations for DP++ and DP dongles suppport.
Is this tested?
--
To view, visit https://review.coreboot.org/c/coreboot/+/70154
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7aa34297a10bf16b9043140bff91fd3a8c4009d4
Gerrit-Change-Number: 70154
Gerrit-PatchSet: 1
Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Comment-Date: Wed, 30 Nov 2022 10:10:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Arthur Heymans.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70153 )
Change subject: 3rdparty/fsp: Update submodule pointer to latest master
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/70153/comment/a951b94c_5ec98b49
PS1, Line 7: 3rdparty/fsp: Update submodule pointer to latest master
> What horrors does the updated submodule bring? It would be great if you could mention what's new wit [âŠ]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/70153
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4a76fe25c7b7a2c34e5bb284418c01c77b22abb
Gerrit-Change-Number: 70153
Gerrit-PatchSet: 2
Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Wed, 30 Nov 2022 10:04:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment