coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: soc/intel/common/block/uart: Show ACPI UART in OS
by Patrick Rudolph (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Angel Pons. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70155 ) Change subject: soc/intel/common/block/uart: Show ACPI UART in OS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/70155 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I01bdccff1b11e1862970c924fd5fc7718a2d6ce9 Gerrit-Change-Number: 70155 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 30 Nov 2022 11:02:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/ectool/Makefile: improve cross-compilation support
by Maciej Pijanowski (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Nico Huber, Martin L Roth, Michał Kotyla, Paul Menzel. Maciej Pijanowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70102 ) Change subject: util/ectool/Makefile: improve cross-compilation support ...................................................................... Patch Set 2: (2 comments) File util/ectool/Makefile: https://review.coreboot.org/c/coreboot/+/70102/comment/7cd90d53_6dbe8f15 PS1, Line 3: CC ?= gcc > It's common practice to honor the environment variables. IIRC, GNU even […] It is typical for cross-compilation environments to expose these via environment variables. See e.g. https://danyspin97.org/blog/makefiles-best-practices/ (Compiler section) File util/ectool/Makefile: https://review.coreboot.org/c/coreboot/+/70102/comment/7458e7c7_a2944d76 PS2, Line 12: LDFLAGS ?= -lioperm > This doesn't seem like good practice. `ioperm` is needed. Why should the […] See for example here: https://sourceforge.net/p/dos2unix/dos2unix/ci/master/tree/dos2unix/Makefil… for a nice example of having LDFLAGS_USER allowing to inject additional flags from environment, keeping the required default libraries in the Makefile. We should also allow for providing the value of OS_ARCH from environment. Using host tools to determine the target environment is not a good idea. The same file also can be used as an example here: https://sourceforge.net/p/dos2unix/dos2unix/ci/master/tree/dos2unix/Makefil… -- To view, visit https://review.coreboot.org/c/coreboot/+/70102 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If5c88bde0ae00f0211a250906cbdedfe4f59c67b Gerrit-Change-Number: 70102 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Kotyla Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: maciej.gabryelski(a)3mdeb.com Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Michał Kotyla Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 30 Nov 2022 10:59:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Michał Kotyla Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/gaelin: Configure audio in devicetree
by Raymond Chung (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Tarun Tuli, Derek Huang, Paul Menzel, Zhuohao Lee. Raymond Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69964 ) Change subject: mb/google/brya/var/gaelin: Configure audio in devicetree ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/brya/variants/gaelin/overridetree.cb: https://review.coreboot.org/c/coreboot/+/69964/comment/1f4365d5_8294b6d3 PS3, Line 239: device ref hda on > does it necessary to turn hda on? I think it's for sound wire device, ALC1015 uses i2s only? Yes, it requires hda to be turned on. Otherwise ALC1015 cannot work normally. -- To view, visit https://review.coreboot.org/c/coreboot/+/69964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc8cacce6cb4b3e55fc7332bb9eb9ac20848fc5b Gerrit-Change-Number: 69964 Gerrit-PatchSet: 3 Gerrit-Owner: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Bruce Chiang <brucechiang(a)msi.corp-partner.google.com> Gerrit-CC: Eason Chang <easonchang(a)msi.corp-partner.google.com> Gerrit-CC: Eddy Lu <eddylu(a)ami.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Comment-Date: Wed, 30 Nov 2022 10:51:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Derek Huang <derekhuang(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common/block/uart: Show ACPI UART in OS
by Lean Sheng Tan (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Angel Pons. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70155 ) Change subject: soc/intel/common/block/uart: Show ACPI UART in OS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70155 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I01bdccff1b11e1862970c924fd5fc7718a2d6ce9 Gerrit-Change-Number: 70155 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 30 Nov 2022 10:36:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/prodrive/atlas: Add DP++ support
by Angel Pons (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Christian Walter, Maximilian Brune, Lean Sheng Tan, David Milosevic. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70154 ) Change subject: mb/prodrive/atlas: Add DP++ support ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70154 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7aa34297a10bf16b9043140bff91fd3a8c4009d4 Gerrit-Change-Number: 70154 Gerrit-PatchSet: 2 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Comment-Date: Wed, 30 Nov 2022 10:32:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common/block/uart: Show ACPI UART in OS
by Arthur Heymans (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Angel Pons. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70155 ) Change subject: soc/intel/common/block/uart: Show ACPI UART in OS ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: acpi_device_status() does not set the SHOW_IN_UI bit when a device is 'hidden'. Hidden in the coreboot context only means that the silicon messed up the PCI spec. I think it makes sense to change acpi_device_status(). -- To view, visit https://review.coreboot.org/c/coreboot/+/70155 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I01bdccff1b11e1862970c924fd5fc7718a2d6ce9 Gerrit-Change-Number: 70155 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 30 Nov 2022 10:31:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/intel/mtlrvp: Add MTL-P RVP board ids
by Harsha B R (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Wonkyu Kim, Ravishankar Sarawadi, Rizwan Qureshi, Angel Pons, Krishna P Bhat D, Tim Wawrzynczak, Tarun Tuli, Jamie Ryu, Subrata Banik, Kapil Porwal, Nick Vaccaro, Ronak Kanabar, Raj Astekar. Harsha B R has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66102 ) Change subject: mb/intel/mtlrvp: Add MTL-P RVP board ids ...................................................................... Patch Set 15: (1 comment) File src/mainboard/intel/mtlrvp/board_id.c: https://review.coreboot.org/c/coreboot/+/66102/comment/100ef408_b3d43f90 PS4, Line 10: > yes, thats correct. Since the requested code changes will be addressed later (as part of cros_bug), please do help in resolving this comment to progress the CL. -- To view, visit https://review.coreboot.org/c/coreboot/+/66102 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I90b0543d5db208f696d2c2c2dc3d2581514a845b Gerrit-Change-Number: 66102 Gerrit-PatchSet: 15 Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Comment-Date: Wed, 30 Nov 2022 10:27:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Harsha B R <harsha.b.r(a)intel.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common/block/uart: Show ACPI UART in OS
by Angel Pons (Code Review) 30 Nov '22

30 Nov '22

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70155 ) Change subject: soc/intel/common/block/uart: Show ACPI UART in OS ...................................................................... soc/intel/common/block/uart: Show ACPI UART in OS Do not hide UARTs in ACPI mode from the OS, as this prevents using them on at least Windows. Currently, the driver is only used on the Prodrive Hermes mainboard. Change-Id: I01bdccff1b11e1862970c924fd5fc7718a2d6ce9 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/soc/intel/common/block/uart/uart.c 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/70155/1 diff --git a/src/soc/intel/common/block/uart/uart.c b/src/soc/intel/common/block/uart/uart.c index b881c58..0ca3361 100644 --- a/src/soc/intel/common/block/uart/uart.c +++ b/src/soc/intel/common/block/uart/uart.c @@ -253,7 +253,9 @@ acpi_device_write_uid(dev); acpigen_write_name_string("_DDN", "LPSS ACPI UART"); - acpigen_write_STA(acpi_device_status(dev)); + + /* Do not hide the UART device from the OS */ + acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_ON); /* Resources */ acpigen_write_name("_CRS"); -- To view, visit https://review.coreboot.org/c/coreboot/+/70155 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I01bdccff1b11e1862970c924fd5fc7718a2d6ce9 Gerrit-Change-Number: 70155 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: drivers/generic/nau8315: Allow custom _HID from config
by Mac Chiang (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Alan Lee, John Hsu, David Lin. Mac Chiang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69965 ) Change subject: drivers/generic/nau8315: Allow custom _HID from config ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/69965 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6f02e495eeb06290947edc9e44fa25a4ce18956 Gerrit-Change-Number: 69965 Gerrit-PatchSet: 1 Gerrit-Owner: David Lin <CTLIN0(a)nuvoton.com> Gerrit-Reviewer: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Hsu <KCHSU0(a)nuvoton.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: CT Lin <ctlin0(a)nuvoton.corp-partner.google.com> Gerrit-Attention: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-Attention: John Hsu <KCHSU0(a)nuvoton.com> Gerrit-Attention: David Lin <CTLIN0(a)nuvoton.com> Gerrit-Comment-Date: Wed, 30 Nov 2022 10:24:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/prodrive/atlas: Add DP++ support
by Lean Sheng Tan (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Christian Walter, Angel Pons, Maximilian Brune, David Milosevic. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70154 ) Change subject: mb/prodrive/atlas: Add DP++ support ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/70154/comment/35036680_81311955 PS1, Line 9: Update VBT configurations for DP++ and DP dongles suppport. > Done Yes it is tested on customer's side. added the texts. -- To view, visit https://review.coreboot.org/c/coreboot/+/70154 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7aa34297a10bf16b9043140bff91fd3a8c4009d4 Gerrit-Change-Number: 70154 Gerrit-PatchSet: 2 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Comment-Date: Wed, 30 Nov 2022 10:23:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022