Attention is currently required from: Subrata Banik, Nick Vaccaro.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69639 )
Change subject: mb/google/brya/acpi: Update NVPCF_FUNC_UPDATE_DYNAMIC_PARAMS
......................................................................
Patch Set 9: -Code-Review
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69639
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69b80f4af2ecef6cf91034fc15fb6e8715eeca4f
Gerrit-Change-Number: 69639
Gerrit-PatchSet: 9
Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Wed, 30 Nov 2022 13:01:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Alexander Couzens, Evgeny Zinoviev.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69502 )
Change subject: mb/*: Replace SNB PCI devices with references from chipset.cb
......................................................................
Patch Set 7: Verified+1
(8 comments)
File src/mainboard/apple/macbookair4_2/devicetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164941):
https://review.coreboot.org/c/coreboot/+/69502/comment/c7d86d6b_80db5b0f
PS7, Line 43: device ref hda on # High Definition Audio Audio controller
Possible repeated word: 'Audio'
File src/mainboard/asrock/b75pro3-m/devicetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164941):
https://review.coreboot.org/c/coreboot/+/69502/comment/69842064_ab26b464
PS7, Line 60: device ref hda on # High Definition Audio Audio controller
Possible repeated word: 'Audio'
File src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164941):
https://review.coreboot.org/c/coreboot/+/69502/comment/3d1c3dc0_da4935b5
PS7, Line 33: device ref hda on end # High Definition Audio Audio controller
Possible repeated word: 'Audio'
File src/mainboard/hp/z220_series/devicetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164941):
https://review.coreboot.org/c/coreboot/+/69502/comment/5b044d72_9fefb3c8
PS7, Line 37: device ref hda on end # High Definition Audio Audio controller
Possible repeated word: 'Audio'
File src/mainboard/lenovo/l520/devicetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164941):
https://review.coreboot.org/c/coreboot/+/69502/comment/1a4e7ad4_211e9707
PS7, Line 44: device ref hda on end # High Definition Audio Audio controller
Possible repeated word: 'Audio'
File src/mainboard/lenovo/s230u/devicetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164941):
https://review.coreboot.org/c/coreboot/+/69502/comment/1716a895_0afb24e5
PS7, Line 48: device ref hda on end # High Definition Audio Audio controller
Possible repeated word: 'Audio'
File src/mainboard/lenovo/t430/devicetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164941):
https://review.coreboot.org/c/coreboot/+/69502/comment/c82e91a6_e894c92c
PS7, Line 46: device ref hda on end # High Definition Audio Audio controller
Possible repeated word: 'Audio'
File src/mainboard/lenovo/x131e/devicetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164941):
https://review.coreboot.org/c/coreboot/+/69502/comment/1553078b_5c8faa7c
PS7, Line 58: device ref hda on end # High Definition Audio Audio controller
Possible repeated word: 'Audio'
--
To view, visit https://review.coreboot.org/c/coreboot/+/69502
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74c34a97ea4340fb11a0db422a48e1418221627e
Gerrit-Change-Number: 69502
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Comment-Date: Wed, 30 Nov 2022 12:28:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Maciej Pijanowski, Martin L Roth, Michał Kotyla.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70102 )
Change subject: util/ectool/Makefile: improve cross-compilation support
......................................................................
Patch Set 2:
(1 comment)
File util/ectool/Makefile:
https://review.coreboot.org/c/coreboot/+/70102/comment/69c481b1_f15ca8a0
PS1, Line 3: CC ?= gcc
> It is typical for cross-compilation environments to expose these via environment variables. See e.g. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/70102
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If5c88bde0ae00f0211a250906cbdedfe4f59c67b
Gerrit-Change-Number: 70102
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Kotyla <michal.kotyla(a)3mdeb.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: maciej.gabryelski(a)3mdeb.com
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Michał Kotyla <michal.kotyla(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 30 Nov 2022 12:24:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Comment-In-Reply-To: Michał Kotyla <michal.kotyla(a)3mdeb.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Martin L Roth, Michał Kotyla.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70102 )
Change subject: util/ectool/Makefile: improve cross-compilation support
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/70102/comment/0e860288_f129c7b0
PS1, Line 7: util/ectool/Makefile :
> Removed
Done
https://review.coreboot.org/c/coreboot/+/70102/comment/7dac4092_4eb63e45
PS1, Line 11: buildsystem like Yocto
> Done
Done
Patchset:
PS2:
Thank you for the updates. You can mark comments as resolved yourself, once you addressed them.
--
To view, visit https://review.coreboot.org/c/coreboot/+/70102
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If5c88bde0ae00f0211a250906cbdedfe4f59c67b
Gerrit-Change-Number: 70102
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Kotyla <michal.kotyla(a)3mdeb.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: maciej.gabryelski(a)3mdeb.com
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Michał Kotyla <michal.kotyla(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 30 Nov 2022 12:24:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Kotyla <michal.kotyla(a)3mdeb.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Tristan Corrick, Angel Pons, Alexander Couzens, Evgeny Zinoviev, Patrick Rudolph.
Arthur Heymans has uploaded a new patch set (#20) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/59316 )
Change subject: cpu/intel/model_206ax: Remove fake lapic device
......................................................................
cpu/intel/model_206ax: Remove fake lapic device
Instead of using a fake lapic device hook up the cpu cluster to chip
cpu/intel/model_206ax.
The lapic device is also not needed as the mp init will allocate it for
the BSP at runtime.
Change-Id: Id3b1c4ca027e2905535e137691c3e3e60417dbf3
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/cpu/intel/model_206ax/acpi.c
M src/cpu/intel/model_206ax/chip.h
M src/cpu/intel/model_206ax/model_206ax_init.c
M src/mainboard/dell/snb_ivb_workstations/variants/baseboard/devicetree.cb
M src/mainboard/google/stout/devicetree.cb
M src/mainboard/intel/emeraldlake2/devicetree.cb
M src/mainboard/kontron/ktqm77/devicetree.cb
M src/mainboard/roda/rv11/variants/rv11/devicetree.cb
M src/mainboard/roda/rv11/variants/rw11/devicetree.cb
M src/mainboard/samsung/stumpy/devicetree.cb
M src/northbridge/intel/sandybridge/chipset.cb
M src/northbridge/intel/sandybridge/northbridge.c
12 files changed, 56 insertions(+), 90 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/59316/20
--
To view, visit https://review.coreboot.org/c/coreboot/+/59316
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id3b1c4ca027e2905535e137691c3e3e60417dbf3
Gerrit-Change-Number: 59316
Gerrit-PatchSet: 20
Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Tristan Corrick <tristan(a)corrick.kiwi>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Shelley Chen, Taniya Das, Venkat Thogaru, Julius Werner, Sudheer Amrabadi.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68384 )
Change subject: soc/qualcomm/sc7280: Add API to differentialize PRO and NON_PRO SKUs
......................................................................
Patch Set 15:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68384/comment/9bcf7c45_f44663e7
PS15, Line 7: differentialize
differentiate
--
To view, visit https://review.coreboot.org/c/coreboot/+/68384
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9f23696384a6c1a89000292eafebd8a16c273ca
Gerrit-Change-Number: 68384
Gerrit-PatchSet: 15
Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Taniya Das <quic_tdas(a)quicinc.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Taniya Das <tdas(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Taniya Das <quic_tdas(a)quicinc.com>
Gerrit-Attention: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Taniya Das <tdas(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-Comment-Date: Wed, 30 Nov 2022 12:20:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70155 )
Change subject: soc/intel/common/block/uart: Show ACPI UART in OS
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/70155
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I01bdccff1b11e1862970c924fd5fc7718a2d6ce9
Gerrit-Change-Number: 70155
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Wed, 30 Nov 2022 11:52:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Arthur Heymans, Elyes Haouas.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69700 )
Change subject: crossgcc: Upgrade LLVM from 15.0.0 to 15.0.6
......................................................................
Patch Set 10:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69700/comment/5310ce2f_d8b2b8b3
PS7, Line 8:
> Ack
Please add the comment back.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69700
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e6c23c6552eded92e706bc21bb162a66767572e
Gerrit-Change-Number: 69700
Gerrit-PatchSet: 10
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Wed, 30 Nov 2022 11:52:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Arthur Heymans, Elyes Haouas.
Hello Felix Singer, build bot (Jenkins), Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69700
to look at the new patch set (#10).
Change subject: crossgcc: Upgrade LLVM from 15.0.0 to 15.0.6
......................................................................
crossgcc: Upgrade LLVM from 15.0.0 to 15.0.6
Change-Id: I9e6c23c6552eded92e706bc21bb162a66767572e
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M util/crossgcc/buildgcc
D util/crossgcc/sum/clang-15.0.0.src.tar.xz.cksum
A util/crossgcc/sum/clang-15.0.6.src.tar.xz.cksum
D util/crossgcc/sum/clang-tools-extra-15.0.0.src.tar.xz.cksum
A util/crossgcc/sum/clang-tools-extra-15.0.6.src.tar.xz.cksum
D util/crossgcc/sum/cmake-15.0.0.src.tar.xz.cksum
A util/crossgcc/sum/cmake-15.0.6.src.tar.xz.cksum
D util/crossgcc/sum/compiler-rt-15.0.0.src.tar.xz.cksum
A util/crossgcc/sum/compiler-rt-15.0.6.src.tar.xz.cksum
D util/crossgcc/sum/llvm-15.0.0.src.tar.xz.cksum
A util/crossgcc/sum/llvm-15.0.6.src.tar.xz.cksum
11 files changed, 16 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/69700/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/69700
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e6c23c6552eded92e706bc21bb162a66767572e
Gerrit-Change-Number: 69700
Gerrit-PatchSet: 10
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: newpatchset