coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: mb/google/brya/acpi: Update NVPCF_FUNC_UPDATE_DYNAMIC_PARAMS
by Nick Vaccaro (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Tarun Tuli, Paul Menzel. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69639 ) Change subject: mb/google/brya/acpi: Update NVPCF_FUNC_UPDATE_DYNAMIC_PARAMS ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69639 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I69b80f4af2ecef6cf91034fc15fb6e8715eeca4f Gerrit-Change-Number: 69639 Gerrit-PatchSet: 12 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 30 Nov 2022 17:32:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/acpi: Update NVPCF_FUNC_UPDATE_DYNAMIC_PARAMS
by Subrata Banik (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Tarun Tuli, Paul Menzel, Nick Vaccaro. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69639 ) Change subject: mb/google/brya/acpi: Update NVPCF_FUNC_UPDATE_DYNAMIC_PARAMS ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69639 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I69b80f4af2ecef6cf91034fc15fb6e8715eeca4f Gerrit-Change-Number: 69639 Gerrit-PatchSet: 12 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Wed, 30 Nov 2022 17:28:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/acpi: Update NVPCF_FUNC_UPDATE_DYNAMIC_PARAMS
by Tarun Tuli (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Subrata Banik, Paul Menzel, Nick Vaccaro. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69639 ) Change subject: mb/google/brya/acpi: Update NVPCF_FUNC_UPDATE_DYNAMIC_PARAMS ...................................................................... Patch Set 12: (2 comments) File src/mainboard/google/brya/acpi/nvpcf.asl: https://review.coreboot.org/c/coreboot/+/69639/comment/ae7e563c_59f50cae PS10, Line 53: x1D > 0x1d Done https://review.coreboot.org/c/coreboot/+/69639/comment/c97a8a4d_8bdcd453 PS10, Line 58: C > 0xc8 Done -- To view, visit https://review.coreboot.org/c/coreboot/+/69639 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I69b80f4af2ecef6cf91034fc15fb6e8715eeca4f Gerrit-Change-Number: 69639 Gerrit-PatchSet: 12 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Wed, 30 Nov 2022 17:25:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: [WIP] Make UartSub driver bind to LPSS UART
by Angel Pons (Code Review) 30 Nov '22

30 Nov '22

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70156 ) Change subject: [WIP] Make UartSub driver bind to LPSS UART ...................................................................... [WIP] Make UartSub driver bind to LPSS UART Crude but seems to be working for UART 2 using "fitlet2" UartSub driver. Change-Id: I197ff2df2e4506994daa1ae72026b17ff662a9ab Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/soc/intel/common/block/uart/uart.c 1 file changed, 24 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/70156/1 diff --git a/src/soc/intel/common/block/uart/uart.c b/src/soc/intel/common/block/uart/uart.c index 0ca3361..56a5d27 100644 --- a/src/soc/intel/common/block/uart/uart.c +++ b/src/soc/intel/common/block/uart/uart.c @@ -201,7 +201,7 @@ } } -static void uart_acpi_write_irq(const struct device *dev) +static inline void uart_acpi_write_irq(const struct device *dev) { if (CONFIG(SOC_INTEL_COMMON_BLOCK_IRQ)) { const int irq = get_pci_devfn_irq(dev->path.pci.devfn); @@ -220,7 +220,7 @@ static void uart_fill_ssdt(const struct device *dev) { const char *scope = acpi_device_scope(dev); - const char *hid = acpi_device_hid(dev); + const char *hid = "INT3511"; // acpi_device_hid(dev); struct resource *res; /* In ACPI mode the device is "invisible" */ @@ -251,8 +251,8 @@ else if (strcmp(hid, "INT34BA") == 0) acpigen_write_name_string("_CID", "INT344A"); - acpi_device_write_uid(dev); - acpigen_write_name_string("_DDN", "LPSS ACPI UART"); + //acpi_device_write_uid(dev); + //acpigen_write_name_string("_DDN", "LPSS ACPI UART"); /* Do not hide the UART device from the OS */ acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_ON); @@ -261,8 +261,14 @@ acpigen_write_name("_CRS"); acpigen_write_resourcetemplate_header(); - uart_acpi_write_irq(dev); - acpigen_write_mem32fixed(1, res->base, res->size); + struct acpi_uart uart = ACPI_UART_RAW_DEVICE(115200, 32); + uart.lines_in_use = 0xfc; + uart.shared = true; + uart.resource = scope; + + acpi_device_write_uart(&uart); + //uart_acpi_write_irq(dev); + //acpigen_write_mem32fixed(1, res->base, res->size); acpigen_write_resourcetemplate_footer(); -- To view, visit https://review.coreboot.org/c/coreboot/+/70156 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I197ff2df2e4506994daa1ae72026b17ff662a9ab Gerrit-Change-Number: 70156 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/herobrine: Only retrieve sku_id from EC once
by Doug Anderson (Code Review) 30 Nov '22

30 Nov '22

Attention is currently required from: Shelley Chen, Julius Werner. Doug Anderson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70162 ) Change subject: mb/google/herobrine: Only retrieve sku_id from EC once ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70162 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia787968100baf58a41ccce0cf95ed3ec9ce1758a Gerrit-Change-Number: 70162 Gerrit-PatchSet: 3 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Doug Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-CC: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-CC: mturney mturney <mturney(a)codeaurora.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 30 Nov 2022 16:57:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/system76: Rename gaze16 to tgl-h
by Martin L Roth (Code Review) 30 Nov '22

30 Nov '22

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/67990 ) Change subject: mb/system76: Rename gaze16 to tgl-h ...................................................................... mb/system76: Rename gaze16 to tgl-h Change-Id: Icbf9348447b9e7acc0caa8082cf5dd00853da37a Signed-off-by: Tim Crawford <tcrawford(a)system76.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/67990 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Jeremy Soller <jeremy(a)system76.com> --- R src/mainboard/system76/tgl-h/Kconfig R src/mainboard/system76/tgl-h/Kconfig.name R src/mainboard/system76/tgl-h/Makefile.inc R src/mainboard/system76/tgl-h/acpi/mainboard.asl R src/mainboard/system76/tgl-h/acpi/sleep.asl R src/mainboard/system76/tgl-h/board_info.txt R src/mainboard/system76/tgl-h/bootblock.c R src/mainboard/system76/tgl-h/cmos.default R src/mainboard/system76/tgl-h/cmos.layout R src/mainboard/system76/tgl-h/devicetree.cb R src/mainboard/system76/tgl-h/dsdt.asl R src/mainboard/system76/tgl-h/include/variant/gpio.h R src/mainboard/system76/tgl-h/include/variant/romstage.h R src/mainboard/system76/tgl-h/ramstage.c R src/mainboard/system76/tgl-h/romstage.c A src/mainboard/system76/tgl-h/variants/gaze16-3050/board_info.txt R src/mainboard/system76/tgl-h/variants/gaze16-3050/data.vbt R src/mainboard/system76/tgl-h/variants/gaze16-3050/gpio.c R src/mainboard/system76/tgl-h/variants/gaze16-3050/gpio_early.c R src/mainboard/system76/tgl-h/variants/gaze16-3050/hda_verb.c R src/mainboard/system76/tgl-h/variants/gaze16-3050/overridetree.cb R src/mainboard/system76/tgl-h/variants/gaze16-3050/ramstage.c R src/mainboard/system76/tgl-h/variants/gaze16-3050/romstage.c A src/mainboard/system76/tgl-h/variants/gaze16-3060/board_info.txt R src/mainboard/system76/tgl-h/variants/gaze16-3060/data.vbt R src/mainboard/system76/tgl-h/variants/gaze16-3060/gpio.c R src/mainboard/system76/tgl-h/variants/gaze16-3060/gpio_early.c R src/mainboard/system76/tgl-h/variants/gaze16-3060/hda_verb.c R src/mainboard/system76/tgl-h/variants/gaze16-3060/overridetree.cb R src/mainboard/system76/tgl-h/variants/gaze16-3060/ramstage.c R src/mainboard/system76/tgl-h/variants/gaze16-3060/romstage.c 31 files changed, 18 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Jeremy Soller: Looks good to me, approved diff --git a/src/mainboard/system76/gaze16/Kconfig b/src/mainboard/system76/tgl-h/Kconfig similarity index 98% rename from src/mainboard/system76/gaze16/Kconfig rename to src/mainboard/system76/tgl-h/Kconfig index 7d60138..cceb1ed 100644 --- a/src/mainboard/system76/gaze16/Kconfig +++ b/src/mainboard/system76/tgl-h/Kconfig @@ -26,7 +26,7 @@ select TPM_RDRESP_NEED_DELAY config MAINBOARD_DIR - default "system76/gaze16" + default "system76/tgl-h" config MAINBOARD_PART_NUMBER default "gaze16-3050" if BOARD_SYSTEM76_GAZE16_3050 diff --git a/src/mainboard/system76/gaze16/Kconfig.name b/src/mainboard/system76/tgl-h/Kconfig.name similarity index 100% rename from src/mainboard/system76/gaze16/Kconfig.name rename to src/mainboard/system76/tgl-h/Kconfig.name diff --git a/src/mainboard/system76/gaze16/Makefile.inc b/src/mainboard/system76/tgl-h/Makefile.inc similarity index 100% rename from src/mainboard/system76/gaze16/Makefile.inc rename to src/mainboard/system76/tgl-h/Makefile.inc diff --git a/src/mainboard/system76/gaze16/acpi/mainboard.asl b/src/mainboard/system76/tgl-h/acpi/mainboard.asl similarity index 100% rename from src/mainboard/system76/gaze16/acpi/mainboard.asl rename to src/mainboard/system76/tgl-h/acpi/mainboard.asl diff --git a/src/mainboard/system76/gaze16/acpi/sleep.asl b/src/mainboard/system76/tgl-h/acpi/sleep.asl similarity index 100% rename from src/mainboard/system76/gaze16/acpi/sleep.asl rename to src/mainboard/system76/tgl-h/acpi/sleep.asl diff --git a/src/mainboard/system76/gaze16/board_info.txt b/src/mainboard/system76/tgl-h/board_info.txt similarity index 74% rename from src/mainboard/system76/gaze16/board_info.txt rename to src/mainboard/system76/tgl-h/board_info.txt index 8b3be68..badfb66 100644 --- a/src/mainboard/system76/gaze16/board_info.txt +++ b/src/mainboard/system76/tgl-h/board_info.txt @@ -1,7 +1,5 @@ Vendor name: System76 -Board name: gaze16 Category: laptop -Release year: 2021 ROM package: SOIC-8 ROM protocol: SPI ROM socketed: n diff --git a/src/mainboard/system76/gaze16/bootblock.c b/src/mainboard/system76/tgl-h/bootblock.c similarity index 100% rename from src/mainboard/system76/gaze16/bootblock.c rename to src/mainboard/system76/tgl-h/bootblock.c diff --git a/src/mainboard/system76/gaze16/cmos.default b/src/mainboard/system76/tgl-h/cmos.default similarity index 100% rename from src/mainboard/system76/gaze16/cmos.default rename to src/mainboard/system76/tgl-h/cmos.default diff --git a/src/mainboard/system76/gaze16/cmos.layout b/src/mainboard/system76/tgl-h/cmos.layout similarity index 100% rename from src/mainboard/system76/gaze16/cmos.layout rename to src/mainboard/system76/tgl-h/cmos.layout diff --git a/src/mainboard/system76/gaze16/devicetree.cb b/src/mainboard/system76/tgl-h/devicetree.cb similarity index 100% rename from src/mainboard/system76/gaze16/devicetree.cb rename to src/mainboard/system76/tgl-h/devicetree.cb diff --git a/src/mainboard/system76/gaze16/dsdt.asl b/src/mainboard/system76/tgl-h/dsdt.asl similarity index 100% rename from src/mainboard/system76/gaze16/dsdt.asl rename to src/mainboard/system76/tgl-h/dsdt.asl diff --git a/src/mainboard/system76/gaze16/include/variant/gpio.h b/src/mainboard/system76/tgl-h/include/variant/gpio.h similarity index 100% rename from src/mainboard/system76/gaze16/include/variant/gpio.h rename to src/mainboard/system76/tgl-h/include/variant/gpio.h diff --git a/src/mainboard/system76/gaze16/include/variant/romstage.h b/src/mainboard/system76/tgl-h/include/variant/romstage.h similarity index 100% rename from src/mainboard/system76/gaze16/include/variant/romstage.h rename to src/mainboard/system76/tgl-h/include/variant/romstage.h diff --git a/src/mainboard/system76/gaze16/ramstage.c b/src/mainboard/system76/tgl-h/ramstage.c similarity index 100% rename from src/mainboard/system76/gaze16/ramstage.c rename to src/mainboard/system76/tgl-h/ramstage.c diff --git a/src/mainboard/system76/gaze16/romstage.c b/src/mainboard/system76/tgl-h/romstage.c similarity index 100% rename from src/mainboard/system76/gaze16/romstage.c rename to src/mainboard/system76/tgl-h/romstage.c diff --git a/src/mainboard/system76/tgl-h/variants/gaze16-3050/board_info.txt b/src/mainboard/system76/tgl-h/variants/gaze16-3050/board_info.txt new file mode 100644 index 0000000..6555d4d --- /dev/null +++ b/src/mainboard/system76/tgl-h/variants/gaze16-3050/board_info.txt @@ -0,0 +1,2 @@ +Board name: gaze16 +Release year: 2021 diff --git a/src/mainboard/system76/gaze16/variants/gaze16-3050/data.vbt b/src/mainboard/system76/tgl-h/variants/gaze16-3050/data.vbt similarity index 100% rename from src/mainboard/system76/gaze16/variants/gaze16-3050/data.vbt rename to src/mainboard/system76/tgl-h/variants/gaze16-3050/data.vbt Binary files differ diff --git a/src/mainboard/system76/gaze16/variants/gaze16-3050/gpio.c b/src/mainboard/system76/tgl-h/variants/gaze16-3050/gpio.c similarity index 100% rename from src/mainboard/system76/gaze16/variants/gaze16-3050/gpio.c rename to src/mainboard/system76/tgl-h/variants/gaze16-3050/gpio.c diff --git a/src/mainboard/system76/gaze16/variants/gaze16-3050/gpio_early.c b/src/mainboard/system76/tgl-h/variants/gaze16-3050/gpio_early.c similarity index 100% rename from src/mainboard/system76/gaze16/variants/gaze16-3050/gpio_early.c rename to src/mainboard/system76/tgl-h/variants/gaze16-3050/gpio_early.c diff --git a/src/mainboard/system76/gaze16/variants/gaze16-3050/hda_verb.c b/src/mainboard/system76/tgl-h/variants/gaze16-3050/hda_verb.c similarity index 100% rename from src/mainboard/system76/gaze16/variants/gaze16-3050/hda_verb.c rename to src/mainboard/system76/tgl-h/variants/gaze16-3050/hda_verb.c diff --git a/src/mainboard/system76/gaze16/variants/gaze16-3050/overridetree.cb b/src/mainboard/system76/tgl-h/variants/gaze16-3050/overridetree.cb similarity index 100% rename from src/mainboard/system76/gaze16/variants/gaze16-3050/overridetree.cb rename to src/mainboard/system76/tgl-h/variants/gaze16-3050/overridetree.cb diff --git a/src/mainboard/system76/gaze16/variants/gaze16-3050/ramstage.c b/src/mainboard/system76/tgl-h/variants/gaze16-3050/ramstage.c similarity index 100% rename from src/mainboard/system76/gaze16/variants/gaze16-3050/ramstage.c rename to src/mainboard/system76/tgl-h/variants/gaze16-3050/ramstage.c diff --git a/src/mainboard/system76/gaze16/variants/gaze16-3050/romstage.c b/src/mainboard/system76/tgl-h/variants/gaze16-3050/romstage.c similarity index 100% rename from src/mainboard/system76/gaze16/variants/gaze16-3050/romstage.c rename to src/mainboard/system76/tgl-h/variants/gaze16-3050/romstage.c diff --git a/src/mainboard/system76/tgl-h/variants/gaze16-3060/board_info.txt b/src/mainboard/system76/tgl-h/variants/gaze16-3060/board_info.txt new file mode 100644 index 0000000..6555d4d --- /dev/null +++ b/src/mainboard/system76/tgl-h/variants/gaze16-3060/board_info.txt @@ -0,0 +1,2 @@ +Board name: gaze16 +Release year: 2021 diff --git a/src/mainboard/system76/gaze16/variants/gaze16-3060/data.vbt b/src/mainboard/system76/tgl-h/variants/gaze16-3060/data.vbt similarity index 100% rename from src/mainboard/system76/gaze16/variants/gaze16-3060/data.vbt rename to src/mainboard/system76/tgl-h/variants/gaze16-3060/data.vbt Binary files differ diff --git a/src/mainboard/system76/gaze16/variants/gaze16-3060/gpio.c b/src/mainboard/system76/tgl-h/variants/gaze16-3060/gpio.c similarity index 100% rename from src/mainboard/system76/gaze16/variants/gaze16-3060/gpio.c rename to src/mainboard/system76/tgl-h/variants/gaze16-3060/gpio.c diff --git a/src/mainboard/system76/gaze16/variants/gaze16-3060/gpio_early.c b/src/mainboard/system76/tgl-h/variants/gaze16-3060/gpio_early.c similarity index 100% rename from src/mainboard/system76/gaze16/variants/gaze16-3060/gpio_early.c rename to src/mainboard/system76/tgl-h/variants/gaze16-3060/gpio_early.c diff --git a/src/mainboard/system76/gaze16/variants/gaze16-3060/hda_verb.c b/src/mainboard/system76/tgl-h/variants/gaze16-3060/hda_verb.c similarity index 100% rename from src/mainboard/system76/gaze16/variants/gaze16-3060/hda_verb.c rename to src/mainboard/system76/tgl-h/variants/gaze16-3060/hda_verb.c diff --git a/src/mainboard/system76/gaze16/variants/gaze16-3060/overridetree.cb b/src/mainboard/system76/tgl-h/variants/gaze16-3060/overridetree.cb similarity index 100% rename from src/mainboard/system76/gaze16/variants/gaze16-3060/overridetree.cb rename to src/mainboard/system76/tgl-h/variants/gaze16-3060/overridetree.cb diff --git a/src/mainboard/system76/gaze16/variants/gaze16-3060/ramstage.c b/src/mainboard/system76/tgl-h/variants/gaze16-3060/ramstage.c similarity index 100% rename from src/mainboard/system76/gaze16/variants/gaze16-3060/ramstage.c rename to src/mainboard/system76/tgl-h/variants/gaze16-3060/ramstage.c diff --git a/src/mainboard/system76/gaze16/variants/gaze16-3060/romstage.c b/src/mainboard/system76/tgl-h/variants/gaze16-3060/romstage.c similarity index 100% rename from src/mainboard/system76/gaze16/variants/gaze16-3060/romstage.c rename to src/mainboard/system76/tgl-h/variants/gaze16-3060/romstage.c -- To view, visit https://review.coreboot.org/c/coreboot/+/67990 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icbf9348447b9e7acc0caa8082cf5dd00853da37a Gerrit-Change-Number: 67990 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: arch/x86: Buildtest clang targets with VBOOT_STARTS_BEFORE_BOOTBLOCK
by Martin L Roth (Code Review) 30 Nov '22

30 Nov '22

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69746 ) ( 5 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: arch/x86: Buildtest clang targets with VBOOT_STARTS_BEFORE_BOOTBLOCK ...................................................................... arch/x86: Buildtest clang targets with VBOOT_STARTS_BEFORE_BOOTBLOCK TESTED: google/vilboz boots with clang build. Change-Id: Ie115c27b4cb0b8f83d7647bdd27ffcbac9376399 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69746 Reviewed-by: Martin L Roth <gaumless(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/arch/x86/Kconfig 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index ef08f56..f7b9250 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -33,7 +33,7 @@ select ARCH_VERSTAGE_X86_32 if !VBOOT_STARTS_BEFORE_BOOTBLOCK select ARCH_ROMSTAGE_X86_32 select ARCH_RAMSTAGE_X86_32 - select ARCH_SUPPORTS_CLANG if !VBOOT_STARTS_BEFORE_BOOTBLOCK + select ARCH_SUPPORTS_CLANG # stage selectors for x64 -- To view, visit https://review.coreboot.org/c/coreboot/+/69746 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie115c27b4cb0b8f83d7647bdd27ffcbac9376399 Gerrit-Change-Number: 69746 Gerrit-PatchSet: 11 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: arch/arm/armv7: Disable generating neon FPU code
by Martin L Roth (Code Review) 30 Nov '22

30 Nov '22

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69745 ) ( 5 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: arch/arm/armv7: Disable generating neon FPU code ...................................................................... arch/arm/armv7: Disable generating neon FPU code By default clang generates code with neon instructions. These are not supported on all arm targets so default to fpu=none. Change-Id: I48fc505107d131466be39f466151df62b2d2bd0b Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69745 Reviewed-by: Martin L Roth <gaumless(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/arch/arm/armv7/Makefile.inc 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved diff --git a/src/arch/arm/armv7/Makefile.inc b/src/arch/arm/armv7/Makefile.inc index d9f78e5..53261ee 100644 --- a/src/arch/arm/armv7/Makefile.inc +++ b/src/arch/arm/armv7/Makefile.inc @@ -9,6 +9,7 @@ ifeq ($(CONFIG_COMPILER_GCC),y) armv7_asm_flags += -Wa,-mno-warn-deprecated else # CLANG +armv7_flags += -mfpu=none bootblock-ld-ccopts += -target arm-eabi verstage-ld-ccopts += -target arm-eabi romstage-ld-ccopts += -target arm-eabi -- To view, visit https://review.coreboot.org/c/coreboot/+/69745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I48fc505107d131466be39f466151df62b2d2bd0b Gerrit-Change-Number: 69745 Gerrit-PatchSet: 11 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: arch/arm/eabi_compat.c: Add eabi_clrX and eabi_memcyX
by Martin L Roth (Code Review) 30 Nov '22

30 Nov '22

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69743 ) Change subject: arch/arm/eabi_compat.c: Add eabi_clrX and eabi_memcyX ...................................................................... arch/arm/eabi_compat.c: Add eabi_clrX and eabi_memcyX Clang generated code uses this for zero initialized variables. Change-Id: I460a0096918141c1cf8826bdf1853a3aa3aecff8 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69743 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin L Roth <gaumless(a)gmail.com> --- M src/arch/arm/eabi_compat.c 1 file changed, 38 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved diff --git a/src/arch/arm/eabi_compat.c b/src/arch/arm/eabi_compat.c index 2a110d5..849fc65 100644 --- a/src/arch/arm/eabi_compat.c +++ b/src/arch/arm/eabi_compat.c @@ -23,6 +23,14 @@ { } +/* Support the alias for the __aeabi_memcpy which may + assume memory alignment. */ +void __aeabi_memcpy4(void *dest, const void *src, size_t n) + __attribute((alias("__aeabi_memcpy"))); + +void __aeabi_memcpy8(void *dest, const void *src, size_t n) + __attribute((alias("__aeabi_memcpy"))); + void __aeabi_memcpy(void *dest, const void *src, size_t n); void __aeabi_memcpy(void *dest, const void *src, size_t n) { @@ -34,3 +42,18 @@ { (void)memset(dest, c, n); } + +/* Support the alias for the __aeabi_memclr which may + assume memory alignment. */ +void __aeabi_memclr4(void *dest, size_t n) + __attribute((alias("__aeabi_memclr"))); + +void __aeabi_memclr8(void *dest, size_t n) + __attribute((alias("__aeabi_memclr"))); + +/* Support the routine __aeabi_memclr. */ +void __aeabi_memclr(void *dest, size_t n); +void __aeabi_memclr(void *dest, size_t n) +{ + __aeabi_memset(dest, n, 0); +} -- To view, visit https://review.coreboot.org/c/coreboot/+/69743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I460a0096918141c1cf8826bdf1853a3aa3aecff8 Gerrit-Change-Number: 69743 Gerrit-PatchSet: 11 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: arm/armv7/Makefile.inc: Fix processing ld files with clang
by Martin L Roth (Code Review) 30 Nov '22

30 Nov '22

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69744 ) ( 5 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: arm/armv7/Makefile.inc: Fix processing ld files with clang ...................................................................... arm/armv7/Makefile.inc: Fix processing ld files with clang When processing linker scripts clang needs to be set for the proper target or it gets confused by other options. Change-Id: I040aa14a06c728269ca1026e0002392e5ac8fef8 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69744 Reviewed-by: Martin L Roth <gaumless(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/arch/arm/armv7/Makefile.inc 1 file changed, 22 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved diff --git a/src/arch/arm/armv7/Makefile.inc b/src/arch/arm/armv7/Makefile.inc index 5675a26..d9f78e5 100644 --- a/src/arch/arm/armv7/Makefile.inc +++ b/src/arch/arm/armv7/Makefile.inc @@ -8,6 +8,12 @@ armv7_asm_flags = -Wa,-mthumb -Wa,-mimplicit-it=always ifeq ($(CONFIG_COMPILER_GCC),y) armv7_asm_flags += -Wa,-mno-warn-deprecated +else # CLANG +bootblock-ld-ccopts += -target arm-eabi +verstage-ld-ccopts += -target arm-eabi +romstage-ld-ccopts += -target arm-eabi +ramstage-ld-ccopts += -target arm-eabi +rmodule_arm-ld-ccopts += -target arm-eabi endif armv7-r_asm_flags = $(armv7-r_flags) $(armv7_asm_flags) -- To view, visit https://review.coreboot.org/c/coreboot/+/69744 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I040aa14a06c728269ca1026e0002392e5ac8fef8 Gerrit-Change-Number: 69744 Gerrit-PatchSet: 11 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022