Attention is currently required from: Arthur Heymans.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69115
to look at the new patch set (#5).
Change subject: {cpu/nb}/amd/family14: Remove platform
......................................................................
{cpu/nb}/amd/family14: Remove platform
This platform use the LEGACY_SMP_INIT which is to be deprecated after
release 4.18.
Change-Id: Ieaac0a32e71d208b66fd2c4e26f5349abc921d4f
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/cpu/amd/agesa/Kconfig
M src/cpu/amd/agesa/Makefile.inc
D src/cpu/amd/agesa/family14/Kconfig
D src/cpu/amd/agesa/family14/Makefile.inc
D src/cpu/amd/agesa/family14/acpi/cpu.asl
D src/cpu/amd/agesa/family14/chip_name.c
D src/cpu/amd/agesa/family14/fixme.c
D src/cpu/amd/agesa/family14/model_14_init.c
M src/northbridge/amd/agesa/Makefile.inc
D src/northbridge/amd/agesa/family14/Kconfig
D src/northbridge/amd/agesa/family14/Makefile.inc
D src/northbridge/amd/agesa/family14/acpi/northbridge.asl
D src/northbridge/amd/agesa/family14/acpi_tables.c
D src/northbridge/amd/agesa/family14/chip.h
D src/northbridge/amd/agesa/family14/dimmSpd.c
D src/northbridge/amd/agesa/family14/northbridge.c
D src/northbridge/amd/agesa/family14/pci_devs.h
D src/northbridge/amd/agesa/family14/state_machine.c
18 files changed, 13 insertions(+), 1,519 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/69115/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/69115
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieaac0a32e71d208b66fd2c4e26f5349abc921d4f
Gerrit-Change-Number: 69115
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Kyösti Mälkki, Felix Held.
Hello build bot (Jenkins), Kyösti Mälkki, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69114
to look at the new patch set (#4).
Change subject: mb/aopen/dxplplusu: Remove board
......................................................................
mb/aopen/dxplplusu: Remove board
This board use the LEGACY_SMP_INIT which is to be deprecated after
release 4.18.
Change-Id: Idf37ade31ddb55697df1a65062c092a0a485e175
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/arch/x86/smbios.c
M src/cpu/intel/Kconfig
M src/cpu/intel/Makefile.inc
D src/cpu/intel/socket_mPGA604/Kconfig
D src/cpu/intel/socket_mPGA604/Makefile.inc
M src/cpu/x86/Kconfig
M src/cpu/x86/smm/smmrelocate.S
D src/mainboard/aopen/Kconfig
D src/mainboard/aopen/Kconfig.name
D src/mainboard/aopen/dxplplusu/Kconfig
D src/mainboard/aopen/dxplplusu/Kconfig.name
D src/mainboard/aopen/dxplplusu/Makefile.inc
D src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl
D src/mainboard/aopen/dxplplusu/acpi/e7505_sec.asl
D src/mainboard/aopen/dxplplusu/acpi/i82801db.asl
D src/mainboard/aopen/dxplplusu/acpi/p64h2.asl
D src/mainboard/aopen/dxplplusu/acpi/power.asl
D src/mainboard/aopen/dxplplusu/acpi/scsi.asl
D src/mainboard/aopen/dxplplusu/acpi/superio.asl
D src/mainboard/aopen/dxplplusu/acpi_tables.c
D src/mainboard/aopen/dxplplusu/board_info.txt
D src/mainboard/aopen/dxplplusu/bootblock.c
D src/mainboard/aopen/dxplplusu/devicetree.cb
D src/mainboard/aopen/dxplplusu/dsdt.asl
D src/northbridge/intel/e7505/Kconfig
D src/northbridge/intel/e7505/Makefile.inc
D src/northbridge/intel/e7505/e7505.h
D src/northbridge/intel/e7505/memmap.c
D src/northbridge/intel/e7505/northbridge.c
D src/northbridge/intel/e7505/raminit.c
D src/northbridge/intel/e7505/raminit.h
D src/northbridge/intel/e7505/romstage.c
M src/southbridge/intel/common/smbus.c
D src/southbridge/intel/i82801dx/Kconfig
D src/southbridge/intel/i82801dx/Makefile.inc
D src/southbridge/intel/i82801dx/ac97.c
D src/southbridge/intel/i82801dx/bootblock.c
D src/southbridge/intel/i82801dx/chip.h
D src/southbridge/intel/i82801dx/early_smbus.c
D src/southbridge/intel/i82801dx/fadt.c
D src/southbridge/intel/i82801dx/i82801dx.c
D src/southbridge/intel/i82801dx/i82801dx.h
D src/southbridge/intel/i82801dx/ide.c
D src/southbridge/intel/i82801dx/lpc.c
D src/southbridge/intel/i82801dx/pci.c
D src/southbridge/intel/i82801dx/smi.c
D src/southbridge/intel/i82801dx/smihandler.c
D src/southbridge/intel/i82801dx/usb.c
D src/southbridge/intel/i82801dx/usb2.c
D src/southbridge/intel/i82870/82870.h
D src/southbridge/intel/i82870/Kconfig
D src/southbridge/intel/i82870/Makefile.inc
D src/southbridge/intel/i82870/ioapic.c
D src/southbridge/intel/i82870/pcibridge.c
M src/superio/smsc/Makefile.inc
D src/superio/smsc/lpc47m10x/Kconfig
D src/superio/smsc/lpc47m10x/Makefile.inc
D src/superio/smsc/lpc47m10x/early_serial.c
D src/superio/smsc/lpc47m10x/lpc47m10x.h
D src/superio/smsc/lpc47m10x/superio.c
60 files changed, 16 insertions(+), 5,263 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/69114/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/69114
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf37ade31ddb55697df1a65062c092a0a485e175
Gerrit-Change-Number: 69114
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin.
Liju-Clr Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69139 )
Change subject: Revert "soc/mediatek/mt8188: Allow CPUfreq hardware to access MCUPM registers"
......................................................................
Revert "soc/mediatek/mt8188: Allow CPUfreq hardware to access MCUPM registers"
This reverts commit a8172c329fe309f3b5b409c1a59a227186400dd4.
In this patch, we allow MCUPM to access secure registers and set the
domain to DOMAIN_2.
Additional attribute settings are also required when a hardware is
set to a specific domain. Otherwise, there would be violation between
hardware. Since MT8188 is in bring-up stage, we simply enable access
register permission for the DOMAIN_0 by default. So remove the wrong
setting for MCUPM, SCP and SSPM.
We will complete DEVAPC setting when the settings are confirmed.
Change-Id: I5d9809f6e84b8d10bc2e6f2ea5a442e676ad3bf9
---
M src/soc/mediatek/mt8188/devapc.c
M src/soc/mediatek/mt8188/include/soc/devapc.h
2 files changed, 22 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/69139/1
diff --git a/src/soc/mediatek/mt8188/devapc.c b/src/soc/mediatek/mt8188/devapc.c
index 260b9ff..1fe3cf8 100644
--- a/src/soc/mediatek/mt8188/devapc.c
+++ b/src/soc/mediatek/mt8188/devapc.c
@@ -1550,12 +1550,6 @@
static void infra_init(uintptr_t base)
{
- /* Side band */
- SET32_BITFIELDS(getreg(base, MAS_SEC_0), MCUPM_SEC, SECURE_TRANS);
-
- /* Master domain */
- SET32_BITFIELDS(getreg(base, MAS_DOM_0), SCP_SSPM_DOM, DOMAIN_2, MCUPM_DOM, DOMAIN_2);
-
/* Default APC setting */
set_infra_ao_apc(base);
}
diff --git a/src/soc/mediatek/mt8188/include/soc/devapc.h b/src/soc/mediatek/mt8188/include/soc/devapc.h
index d742c22..e0b0f00 100644
--- a/src/soc/mediatek/mt8188/include/soc/devapc.h
+++ b/src/soc/mediatek/mt8188/include/soc/devapc.h
@@ -17,10 +17,6 @@
AO_APC_CON = 0x00F00,
};
-DEFINE_BIT(MCUPM_SEC, 1)
-DEFINE_BITFIELD(MCUPM_DOM, 11, 8)
-DEFINE_BITFIELD(SCP_SSPM_DOM, 19, 16)
-
/******************************************************************************
* STRUCTURE DEFINITION
******************************************************************************/
--
To view, visit https://review.coreboot.org/c/coreboot/+/69139
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d9809f6e84b8d10bc2e6f2ea5a442e676ad3bf9
Gerrit-Change-Number: 69139
Gerrit-PatchSet: 1
Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-MessageType: newchange
Attention is currently required from: Liju-Clr Chen, Rex-BC Chen, Yu-Ping Wu, Yidi Lin.
Hello Hung-Te Lin, build bot (Jenkins), Rex-BC Chen, Yu-Ping Wu, Yidi Lin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69089
to look at the new patch set (#5).
Change subject: soc/mediatek/mt8188: Disable input-gating for big-core SRAM
......................................................................
soc/mediatek/mt8188: Disable input-gating for big-core SRAM
The input-gating is an experimental feature (but unfortunately default
enabled) and would lead to crash on MT8188, so we have to disable it
in the firmware stage.
BUG=b:233720142
TEST=CPUfreq in kernel test pass.
Change-Id: Ifd68fe9362587955cdb8598c4cc5c2d0eefe53ca
Signed-off-by: Liju-Clr Chen <liju-clr.chen(a)mediatek.com>
---
M src/soc/mediatek/mt8188/Makefile.inc
A src/soc/mediatek/mt8188/cpu_inputgating.c
A src/soc/mediatek/mt8188/include/soc/cpu_inputgating.h
M src/soc/mediatek/mt8188/soc.c
4 files changed, 45 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/69089/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/69089
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd68fe9362587955cdb8598c4cc5c2d0eefe53ca
Gerrit-Change-Number: 69089
Gerrit-PatchSet: 5
Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Liju-Clr Chen, Paul Menzel, Rex-BC Chen.
Hello Hung-Te Lin, build bot (Jenkins), Rex-BC Chen, Yidi Lin, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69088
to look at the new patch set (#5).
Change subject: soc/mediatek/mt8188: Fix AP hang when enabling cpufreq-hw driver
......................................................................
soc/mediatek/mt8188: Fix AP hang when enabling cpufreq-hw driver
When enabling cpufreq-hw driver, MCUPM will conduct power tasks and
access some registers of the other hardware. There are some registers
configured as secure read/write due to the hardware design. So we
enable sideband to allow MCUPM to access the secure registers.
BUG=b:236331463
TEST=It works well after boot to login shell.
Change-Id: I67b08c38a31a7eae1bc59543a5148a78b61456d6
Signed-off-by: Liju-Clr Chen <liju-clr.chen(a)mediatek.com>
---
M src/soc/mediatek/mt8188/devapc.c
M src/soc/mediatek/mt8188/include/soc/devapc.h
2 files changed, 24 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/69088/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/69088
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67b08c38a31a7eae1bc59543a5148a78b61456d6
Gerrit-Change-Number: 69088
Gerrit-PatchSet: 5
Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69119
to look at the new patch set (#11).
Change subject: nb/amd/agesa: Remove leftover code
......................................................................
nb/amd/agesa: Remove leftover code
This code is now unused by any platform.
Change-Id: I5464daa8cfb8231e2b19447c343fc80ab1d68ce8
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
D src/northbridge/amd/agesa/Kconfig
D src/northbridge/amd/agesa/Makefile.inc
2 files changed, 12 insertions(+), 43 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/69119/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/69119
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5464daa8cfb8231e2b19447c343fc80ab1d68ce8
Gerrit-Change-Number: 69119
Gerrit-PatchSet: 11
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68789 )
Change subject: soc/intel/common: provide display hook in PEP for ECs
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68789/comment/9a62a40d_15e2960f
PS3, Line 7: S0ix
> Should be display from the comment?
indeed, thanks!
--
To view, visit https://review.coreboot.org/c/coreboot/+/68789
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icbfd294cdd238e63eb947c227a9cf73daca702ef
Gerrit-Change-Number: 68789
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 02 Nov 2022 09:10:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Angel Pons, Arthur Heymans.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68791 )
Change subject: ec/clevo/it5570e: add driver for EC used on various Clevo laptops
......................................................................
Patch Set 6:
(2 comments)
File src/ec/clevo/it5570e/commands.c:
https://review.coreboot.org/c/coreboot/+/68791/comment/77c573af_2358fc2e
PS4, Line 41: while (recv_ec_data() != '$');
> > check the previous push. […]
Looks like CB:69077 is fine :O Personally, I still prefer the variant without `do {}`. I'll prepare a RFC change for the linter. Let's see what others think :-)
File src/ec/clevo/it5570e/commands.c:
https://review.coreboot.org/c/coreboot/+/68791/comment/cf35d195_3a9d098e
PS6, Line 120: printk(BIOS_ERR, "EC: invalid flexicharger settings: start/stop > 100%%\n");
> Should the parameters be sanitized?
ouch, the plan was to just return bc I'm not a fan of trying to guess what the user intended. will fix
--
To view, visit https://review.coreboot.org/c/coreboot/+/68791
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8c0bee9002ad9edcd10c83b775fc723744caaa0
Gerrit-Change-Number: 68791
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Wed, 02 Nov 2022 09:08:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Kyösti Mälkki, Felix Held.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69114 )
Change subject: mb/aopen/dxplplusu: Remove board
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
source "src/cpu/intel/socket_mPGA604/Kconfig" is leftover here:
nano +23 src/cpu/intel/Kconfig
--
To view, visit https://review.coreboot.org/c/coreboot/+/69114
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf37ade31ddb55697df1a65062c092a0a485e175
Gerrit-Change-Number: 69114
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 02 Nov 2022 08:59:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Kyle Lin.
Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69052 )
Change subject: mb/google/brya: Create marasov variant
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> I only can + code review, thanks
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/69052
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe2dc442480f6a73877b40625e228cdb2038aa4d
Gerrit-Change-Number: 69052
Gerrit-PatchSet: 3
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kyle Lin <kylelinck(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Kyle Lin <kylelinck(a)google.com>
Gerrit-Comment-Date: Wed, 02 Nov 2022 08:49:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyle Lin <kylelinck(a)google.com>
Comment-In-Reply-To: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-MessageType: comment