Attention is currently required from: Michał Żygowski, Christian Walter, Julius Werner, Krystian Hebel, Yu-Ping Wu.
Hello Michał Żygowski, Christian Walter, Julius Werner, Krystian Hebel, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69160
to look at the new patch set (#2).
Change subject: security/tpm: resolve conflicts in TSS implementations
......................................................................
security/tpm: resolve conflicts in TSS implementations
No functional changes. Just code updates to don't have any compiler or
linker errors if TSS 1.2 and TSS 2.0 were both compiled in.
Change-Id: Ia0ea5a917c46ada9fc3274f17240e12bca98db6a
Ticket: https://ticket.coreboot.org/issues/433
Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
---
M src/drivers/crb/tis.c
M src/security/tpm/Makefile.inc
M src/security/tpm/tspi/tspi.c
M src/security/tpm/tss.h
M src/security/tpm/tss/tcg-1.2/tss.c
A src/security/tpm/tss/tcg-1.2/tss.h
M src/security/tpm/tss/tcg-2.0/tss.c
A src/security/tpm/tss/tcg-2.0/tss.h
M src/security/tpm/tss/tcg-2.0/tss_marshaling.c
A src/security/tpm/tss/tss.c
M src/security/tpm/tss/vendor/cr50/cr50.c
M src/security/vboot/secdata_tpm.c
12 files changed, 458 insertions(+), 213 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/69160/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69160
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia0ea5a917c46ada9fc3274f17240e12bca98db6a
Gerrit-Change-Number: 69160
Gerrit-PatchSet: 2
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Kacper Stojek, Paul Menzel.
Hello build bot (Jenkins), Michał Żygowski, Stefan Reinauer,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68474
to look at the new patch set (#8).
Change subject: util/inteltool: Add support for Elkhart lake
......................................................................
util/inteltool: Add support for Elkhart lake
Document: 614109, 601458
Tested on: Protectli vault_ehl (VP2420)
Signed-off-by: Kacper Stojek <kacper.stojek(a)3mdeb.com>
Change-Id: I54948741082ca1072642046f64539a4c15ddb578
---
M util/inteltool/gpio.c
M util/inteltool/gpio_groups.c
A util/inteltool/gpio_names/elkhartlake.h
M util/inteltool/inteltool.c
M util/inteltool/inteltool.h
M util/inteltool/pcr.c
6 files changed, 608 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/68474/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/68474
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54948741082ca1072642046f64539a4c15ddb578
Gerrit-Change-Number: 68474
Gerrit-PatchSet: 8
Gerrit-Owner: Kacper Stojek
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kacper Stojek
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Angel Pons, Arthur Heymans.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68791 )
Change subject: ec/clevo/it5570e: add driver for EC used on various Clevo laptops
......................................................................
Patch Set 8:
(1 comment)
File src/ec/clevo/it5570e/ssdt.c:
https://review.coreboot.org/c/coreboot/+/68791/comment/7959a79a_352acf48
PS4, Line 66: acpigen_emit_ext_op(FIELD_OP);
: acpigen_write_len_f();
: acpigen_emit_simple_namestring(opreg.name);
: acpigen_emit_byte(flags);
:
: for (int fan = 1; fan <= fan_cnt; fan++) {
: /* temps */
: for (int i = 1; i <= IT5570E_FAN_CURVE_LEN; i++) {
: snprintf(fieldname, 5, "F%dT%d", fan, i);
: acpigen_write_field_name(fieldname, 8);
: }
:
: /* duties */
: for (int i = 1; i <= IT5570E_FAN_CURVE_LEN; i++) {
: snprintf(fieldname, 5, "F%dD%d", fan, i);
: acpigen_write_field_name(fieldname, 8);
: }
:
: /* ramps */
: for (int i = 1; i < IT5570E_FAN_CURVE_LEN; i++) {
: snprintf(fieldname, 5, "F%dR%d", fan, i);
: acpigen_write_field_name(fieldname, 16);
: }
: }
:
: acpigen_pop_len();
> Sounds like a good idea. However, I'd like to postpone that to a different change. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/68791
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8c0bee9002ad9edcd10c83b775fc723744caaa0
Gerrit-Change-Number: 68791
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Wed, 02 Nov 2022 17:02:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Angel Pons.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68790 )
Change subject: device/mmio: add clr/setbitsXp macros
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68790/comment/4e56aaf6_98d1e563
PS2, Line 9: pendant
> pendant is also a synonym for `counterpart`
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/68790
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5b10ccab97c3a372051050b28ada854baec91d18
Gerrit-Change-Number: 68790
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Wed, 02 Nov 2022 17:01:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Lance Zhao, Michał Żygowski, Michał Kopeć, Tim Wawrzynczak, Angel Pons, Arthur Heymans.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68787 )
Change subject: acpigen: export acpigen_write_field_name
......................................................................
Patch Set 4:
(1 comment)
File src/include/acpi/acpigen.h:
https://review.coreboot.org/c/coreboot/+/68787/comment/a89c75bb_482b6502
PS2, Line 523: void acpigen_write_field_name(const char *name, uint32_t size);
> I wrote a suggestion on the patch using this to avoid duplicating most of acpigen_write_field. […]
see https://review.coreboot.org/c/coreboot/+/68791/4..8/src/ec/clevo/it5570e/ss…
--
To view, visit https://review.coreboot.org/c/coreboot/+/68787
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If89f9569c33949995d3b45a5f871ff2cb84a6610
Gerrit-Change-Number: 68787
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Wed, 02 Nov 2022 17:00:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Ofer Fried, Ren Kuo, Tim Wawrzynczak, Nick Vaccaro.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68917 )
Change subject: mb/google/brya/variants/volmar: Add firmware config field for FP_MCU
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68917
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I867771904811459697056662d5e29c545a1a9474
Gerrit-Change-Number: 68917
Gerrit-PatchSet: 3
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Ofer Fried <oferfried(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paz Zcharya <pazz(a)google.com>
Gerrit-Attention: Ofer Fried <oferfried(a)google.com>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Wed, 02 Nov 2022 16:55:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Angel Pons, Arthur Heymans.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68791 )
Change subject: ec/clevo/it5570e: add driver for EC used on various Clevo laptops
......................................................................
Patch Set 8:
(3 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162172):
https://review.coreboot.org/c/coreboot/+/68791/comment/a1ef317a_341089c7
PS8, Line 56: Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com>
Non-standard signature: Co-authored-by:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162172):
https://review.coreboot.org/c/coreboot/+/68791/comment/e1895868_6bcc8570
PS8, Line 57: Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Non-standard signature: Co-authored-by:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162172):
https://review.coreboot.org/c/coreboot/+/68791/comment/da378527_373791be
PS8, Line 58: Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de>
Non-standard signature: Co-authored-by:
--
To view, visit https://review.coreboot.org/c/coreboot/+/68791
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8c0bee9002ad9edcd10c83b775fc723744caaa0
Gerrit-Change-Number: 68791
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Wed, 02 Nov 2022 16:53:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Angel Pons, Arthur Heymans.
Hello Felix Singer, build bot (Jenkins), Michał Żygowski, Tim Wawrzynczak, Michał Kopeć,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68791
to look at the new patch set (#8).
Change subject: ec/clevo/it5570e: add driver for EC used on various Clevo laptops
......................................................................
ec/clevo/it5570e: add driver for EC used on various Clevo laptops
This adds a driver for the ITE IT5570E EC in combination with Clevo
vendor EC firmware. The interface is mostly identical on various laptop
models. Thus, we have implemented one common driver to support them all.
The following features were implemented:
- Basics like battery, ac, etc.
- Suspend/hibernate support: S0ix, S3*, S4/S5
- Save/restore of keyboard backlight level during S0ix without the need
for Clevo vendor software (ControlCenter)
- Flexicharger
- Fn keys (backlight, volume, airplane etc.)
- Various configuration options via Kconfig / CMOS options
* Note: S3 support works at least on L140CU (Cometlake), but it's not
enabled for this board because S0ix is used.
Not implemented, yet:
- Type-C UCSI: the EC firmware seems to be buggy (with vendor fw, too)
- dGPU support is WIP
An example of how this driver can be hooked up by a board can be seen in
in change CB:59850, where support for the L140MU is added.
Known issues:
- Touchpad toggle:
The touchpad toggle (Fn-F1) has two modes, Ctrl-Alt-F9 mode and
keycodes 0xf7/0xf8 mode. Ctrl-Alt-F9 is the native touchpad toggle
shortcut on Windows. On Linux this would switch to virtual console 9,
if enabled. Thus, one should use the keycodes mode and add udev
rules as specified in [1]. If VT9 is disabled, Ctrl-Alt-F9 mode could
be used to set up a keyboard shortcut command toggling the touchpad.
- Multi-fan systems
The Clevo NV41MZ (w/o dGPU) has two fans that should be in-sync.
However, the second fan does not spin. This needs further
investigation.
[1] https://docs.dasharo.com/variants/clevo_nv41/post_install/
Testing the various functionalities of this EC driver was done in the
changes hooking up this driver for the boards.
Change-Id: Ic8c0bee9002ad9edcd10c83b775fc723744caaa0
Co-authored-by: Michał Kopeć <michal.kopec(a)3mdeb.com>
Co-authored-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Co-authored-by: Michael Niewöhner <foss(a)mniewoehner.de>
Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de>
---
A src/ec/clevo/it5570e/Kconfig
A src/ec/clevo/it5570e/Makefile.inc
A src/ec/clevo/it5570e/acpi/ac.asl
A src/ec/clevo/it5570e/acpi/battery.asl
A src/ec/clevo/it5570e/acpi/buttons.asl
A src/ec/clevo/it5570e/acpi/common.asl
A src/ec/clevo/it5570e/acpi/ec.asl
A src/ec/clevo/it5570e/acpi/ec_queries.asl
A src/ec/clevo/it5570e/acpi/ec_ram.asl
A src/ec/clevo/it5570e/acpi/hid.asl
A src/ec/clevo/it5570e/acpi/lid.asl
A src/ec/clevo/it5570e/chip.h
A src/ec/clevo/it5570e/commands.c
A src/ec/clevo/it5570e/commands.h
A src/ec/clevo/it5570e/early_init.c
A src/ec/clevo/it5570e/early_init.h
A src/ec/clevo/it5570e/ec.c
A src/ec/clevo/it5570e/ec.h
A src/ec/clevo/it5570e/i2ec.c
A src/ec/clevo/it5570e/i2ec.h
A src/ec/clevo/it5570e/smbios.c
A src/ec/clevo/it5570e/smihandler.c
A src/ec/clevo/it5570e/smm.h
A src/ec/clevo/it5570e/ssdt.c
24 files changed, 2,066 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/68791/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/68791
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8c0bee9002ad9edcd10c83b775fc723744caaa0
Gerrit-Change-Number: 68791
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Kacper Stojek, Paul Menzel.
Hello build bot (Jenkins), Michał Żygowski, Stefan Reinauer,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68474
to look at the new patch set (#7).
Change subject: util/inteltool: Add support for Elkhart lake
......................................................................
util/inteltool: Add support for Elkhart lake
Document: 614109, 601458
Tested on: Protectli vault_ehl (VP2420)
Signed-off-by: Kacper Stojek <kacper.stojek(a)3mdeb.com>
Change-Id: I54948741082ca1072642046f64539a4c15ddb578
---
M util/inteltool/gpio.c
M util/inteltool/gpio_groups.c
A util/inteltool/gpio_names/elkhartlake.h
M util/inteltool/inteltool.c
M util/inteltool/inteltool.h
M util/inteltool/pcr.c
6 files changed, 608 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/68474/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/68474
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54948741082ca1072642046f64539a4c15ddb578
Gerrit-Change-Number: 68474
Gerrit-PatchSet: 7
Gerrit-Owner: Kacper Stojek
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kacper Stojek
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset