coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: soc/intel/common: provide display hook in PEP for ECs
by Michael Niewöhner (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Eric Lai. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68789 ) Change subject: soc/intel/common: provide display hook in PEP for ECs ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/68789/comment/bb661aab_ed446aea PS3, Line 7: S0ix > indeed, thanks! ouch, overwritten by push... fixed again -- To view, visit https://review.coreboot.org/c/coreboot/+/68789 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icbfd294cdd238e63eb947c227a9cf73daca702ef Gerrit-Change-Number: 68789 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 02 Nov 2022 17:43:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common: provide display hook in PEP for ECs
by Michael Niewöhner (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Eric Lai. Hello Felix Singer, build bot (Jenkins), Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Angel Pons, Eric Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68789 to look at the new patch set (#6). Change subject: soc/intel/common: provide display hook in PEP for ECs ...................................................................... soc/intel/common: provide display hook in PEP for ECs Provide PEP display notification hook for ECs. Change-Id: Icbfd294cdd238e63eb947c227a9cf73daca702ef Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/soc/intel/common/block/acpi/pep.c 1 file changed, 25 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/68789/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/68789 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icbfd294cdd238e63eb947c227a9cf73daca702ef Gerrit-Change-Number: 68789 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: drivers/ocp/ewl: Add EWL driver for EWL type 3 error handling
by Jonathan Zhang (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Johnny Lin, Shelly Chang. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69145 ) Change subject: drivers/ocp/ewl: Add EWL driver for EWL type 3 error handling ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69145 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd5b521bafd457505db4147c5d3fe41364a09045 Gerrit-Change-Number: 69145 Gerrit-PatchSet: 1 Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Comment-Date: Wed, 02 Nov 2022 17:31:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: payloads/grub: Fix entry point
by Paul Menzel (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Nico Huber, Martin L Roth, Stefan Reinauer, Arthur Heymans, Michael Niewöhner, Hackware. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64235 ) Change subject: payloads/grub: Fix entry point ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS2: > ``` […] I can’t remember why I commented this. It’s the build failure I got with GCC 12. So please ignore. -- To view, visit https://review.coreboot.org/c/coreboot/+/64235 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4a12f45d30b781870faa38575e8b2c10e0a42e8 Gerrit-Change-Number: 64235 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hackware <human(a)hackware.cl> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Hackware <human(a)hackware.cl> Gerrit-Comment-Date: Wed, 02 Nov 2022 17:29:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/xeon_sp: Add weak mainboard_ewl_check for EWL check after FSP-M
by Jonathan Zhang (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Johnny Lin, Christian Walter, Arthur Heymans, Tim Chu. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69143 ) Change subject: soc/xeon_sp: Add weak mainboard_ewl_check for EWL check after FSP-M ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69143 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f542e71d20307397c398fd757d9408438f681ed Gerrit-Change-Number: 69143 Gerrit-PatchSet: 1 Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Wed, 02 Nov 2022 17:26:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: checkpatch: add Co-authored-by to signature list
by build bot (Jenkins) (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Martin L Roth. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69166 ) Change subject: checkpatch: add Co-authored-by to signature list ...................................................................... Patch Set 1: (15 comments) File util/lint/checkpatch.pl: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162190): https://review.coreboot.org/c/coreboot/+/69166/comment/3bddd389_40d0841b PS1, Line 618: Reviewed-by:| Do not use whitespace before Reviewed-by: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162190): https://review.coreboot.org/c/coreboot/+/69166/comment/5a954cab_f1f45473 PS1, Line 618: Reviewed-by:| Use a single space after Reviewed-by: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162190): https://review.coreboot.org/c/coreboot/+/69166/comment/0d7b95c1_9594965c PS1, Line 618: Reviewed-by:| Unrecognized email address: '|' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162190): https://review.coreboot.org/c/coreboot/+/69166/comment/4a8984ca_2645a91a PS1, Line 619: Reported-by:| Do not use whitespace before Reported-by: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162190): https://review.coreboot.org/c/coreboot/+/69166/comment/208b19ba_91cb48c7 PS1, Line 619: Reported-by:| Use a single space after Reported-by: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162190): https://review.coreboot.org/c/coreboot/+/69166/comment/974619ae_9219499c PS1, Line 619: Reported-by:| Unrecognized email address: '|' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162190): https://review.coreboot.org/c/coreboot/+/69166/comment/d75e8c78_4b7e3337 PS1, Line 620: Suggested-by:| Do not use whitespace before Suggested-by: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162190): https://review.coreboot.org/c/coreboot/+/69166/comment/b9f3081f_ca803805 PS1, Line 620: Suggested-by:| Use a single space after Suggested-by: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162190): https://review.coreboot.org/c/coreboot/+/69166/comment/7b9e6253_9dc926c8 PS1, Line 620: Suggested-by:| Unrecognized email address: '|' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162190): https://review.coreboot.org/c/coreboot/+/69166/comment/5f7fd610_7a9d6030 PS1, Line 622: To:| Do not use whitespace before To: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162190): https://review.coreboot.org/c/coreboot/+/69166/comment/46f1489c_892b8a6e PS1, Line 622: To:| Use a single space after To: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162190): https://review.coreboot.org/c/coreboot/+/69166/comment/ce956ef8_cb4dd3c8 PS1, Line 622: To:| Unrecognized email address: '|' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162190): https://review.coreboot.org/c/coreboot/+/69166/comment/17dc4df4_50c269d4 PS1, Line 623: Cc: Do not use whitespace before Cc: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162190): https://review.coreboot.org/c/coreboot/+/69166/comment/5f68d581_a106bb48 PS1, Line 623: Cc: Use a single space after Cc: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162190): https://review.coreboot.org/c/coreboot/+/69166/comment/1cb1da8d_6dd749e7 PS1, Line 623: Cc: Unrecognized email address: '' -- To view, visit https://review.coreboot.org/c/coreboot/+/69166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7f66824febe3be756c64ebf44c94bc653a66f1e1 Gerrit-Change-Number: 69166 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Wed, 02 Nov 2022 17:20:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: checkpatch: add Co-authored-by to signature list
by Michael Niewöhner (Code Review) 02 Nov '22

02 Nov '22

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69166 ) Change subject: checkpatch: add Co-authored-by to signature list ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/69166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7f66824febe3be756c64ebf44c94bc653a66f1e1 Gerrit-Change-Number: 69166 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Wed, 02 Nov 2022 17:20:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: inc/dev: Add some PCIe DPC/AER definitions
by Jonathan Zhang (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Johnny Lin, Paul Menzel, Jingle Hsu, Shuming Chu (Shuming). Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69106 ) Change subject: inc/dev: Add some PCIe DPC/AER definitions ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/69106/comment/78200a9b_9fe02949 PS2, Line 7: inc/dev: Add some PCIe DPC/AER definitions I would prefer not to short it "include/device/pci_def.h:" -- To view, visit https://review.coreboot.org/c/coreboot/+/69106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifb6722c326ef69ef1bf3b1c2c1d5bc0cb29d7c12 Gerrit-Change-Number: 69106 Gerrit-PatchSet: 2 Gerrit-Owner: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Comment-Date: Wed, 02 Nov 2022 17:17:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: util/inteltool: Add support for Elkhart lake
by Kacper Stojek (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Michał Żygowski, Paul Menzel. Kacper Stojek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68474 ) Change subject: util/inteltool: Add support for Elkhart lake ...................................................................... Patch Set 8: (10 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/68474/comment/ac4698dd_69042625 PS1, Line 10: > It is not there. […] I've done it here in the gerrit editor, so maybe I really did not push this change. Now it is here though. File util/inteltool/gpio_names/elkhartlake.h: https://review.coreboot.org/c/coreboot/+/68474/comment/167e7087_1c976490 PS6, Line 447: "VGPIO_0", "n/a", : "VGPIO_4", "n/a", : "VGPIO_5", "n/a", : "VGPIO_6", "n/a", : "VGPIO_7", "n/a", : "VGPIO_8", "n/a", : "VGPIO_9", "n/a", : "VGPIO_10", "n/a", : "VGPIO_11", "n/a", : "VGPIO_12", "n/a", : "VGPIO_13", "n/a", : "VGPIO_18", "n/a", : "VGPIO_19", "n/a", : "VGPIO_20", "n/a", : "VGPIO_21", "n/a", : "VGPIO_22", "n/a", : "VGPIO_23", "n/a", : "VGPIO_24", "n/a", : "VGPIO_25", "n/a", : "VGPIO_30", "n/a", : "VGPIO_31", "n/a", : "VGPIO_32", "n/a", : "VGPIO_33", "n/a", : "VGPIO_34", "n/a", : "VGPIO_35", "n/a", : "VGPIO_36", "n/a", : "VGPIO_37", "n/a", : "VGPIO_39", "n/a", > I guess VGPIOs have only 1 native function which is VGPIOx, so I would suggest to change it to: […] Done https://review.coreboot.org/c/coreboot/+/68474/comment/2302c6d8_bd38cf18 PS6, Line 486: "VGPIO_USB_0", "n/a", : "VGPIO_USB_1", "n/a", : "VGPIO_USB_2", "n/a", : "VGPIO_USB_3", "n/a", > "VGPIO_USB_0", "VGPIO_USB_0", […] Done https://review.coreboot.org/c/coreboot/+/68474/comment/d62eed63_9680c7c7 PS6, Line 501: &elkhartlake_pch_group_t, : &elkhartlake_pch_group_g, > Bad indent Done https://review.coreboot.org/c/coreboot/+/68474/comment/9f0f3853_7946c524 PS6, Line 528: &elkhartlake_pch_group_gpd, > Bad indent Done https://review.coreboot.org/c/coreboot/+/68474/comment/d465aeae_ad575495 PS6, Line 539: &elkhartlake_pch_group_s, : &elkhartlake_pch_group_a, : &elkhartlake_pch_group_vgpio_usb, > Bad indent Done https://review.coreboot.org/c/coreboot/+/68474/comment/13658ff6_1ce37538 PS6, Line 552: &elkhartlake_pch_group_c, : &elkhartlake_pch_group_f, : &elkhartlake_pch_group_e, > Bad indent Done https://review.coreboot.org/c/coreboot/+/68474/comment/764b5b11_40f6de4b PS6, Line 565: &elkhartlake_pch_group_r, > Bad indent Done File util/inteltool/gpio_names/elkhartlake.h: https://review.coreboot.org/c/coreboot/+/68474/comment/a08f3959_2c4759ad PS1, Line 150: "GP_DSW07","n/a", > Let's make it RSVD Done File util/inteltool/inteltool.h: https://review.coreboot.org/c/coreboot/+/68474/comment/ca62531f_36ed672f PS6, Line 300: #define PCI_DEVICE_ID_INTEL_EHL 0x4b00 > One TAB more? It seems not to be aligned properly with above defines […] For now I've just added the tab and left it at that. -- To view, visit https://review.coreboot.org/c/coreboot/+/68474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54948741082ca1072642046f64539a4c15ddb578 Gerrit-Change-Number: 68474 Gerrit-PatchSet: 8 Gerrit-Owner: Kacper Stojek Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 02 Nov 2022 17:15:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Kacper Stojek Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/guybrush: Store XHCI BARs
by Robert Zieba (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Jason Nien, Martin Roth, Karthik Ramasubramanian. Hello build bot (Jenkins), Jason Nien, Martin Roth, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68326 to look at the new patch set (#5). Change subject: mb/google/guybrush: Store XHCI BARs ...................................................................... mb/google/guybrush: Store XHCI BARs This commit implements `smm_mainboard_pci_bar_store_init` to store the BARs for XHCI devices. These stored BARs are later used by the elog code to log XHCI wake events. Example elog contents: ``` 250 | 2022-10-11 16:04:49 | S0ix Enter 251 | 2022-10-11 16:04:53 | S0ix Exit 252 | 2022-10-11 16:04:53 | Wake Source | GPE # | 31 253 | 2022-10-11 16:04:53 | Wake Source | PME - XHCI (USB 2.0 port) | 1 254 | 2022-10-11 16:05:24 | S0ix Enter 255 | 2022-10-11 16:05:27 | S0ix Exit 256 | 2022-10-11 16:05:27 | Wake Source | GPE # | 31 257 | 2022-10-11 16:05:27 | Wake Source | PME - XHCI (USB 2.0 port) | 257 ``` BRANCH=guybrush BUG=b:186792595 TEST=Ran on nipperkin, verified that XHCI wake events show up in elog Change-Id: I1d0911df9e3102791bf7b5723ac38e2ba82a9db6 Signed-off-by: Robert Zieba <robertzieba(a)google.com> --- M src/mainboard/google/guybrush/mainboard.c 1 file changed, 47 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/68326/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/68326 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1d0911df9e3102791bf7b5723ac38e2ba82a9db6 Gerrit-Change-Number: 68326 Gerrit-PatchSet: 5 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022