coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: mb/google/brya/variants/volmar: Add firmware config field for FP_MCU
by Tarun Tuli (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Ofer Fried, Ren Kuo, Tim Wawrzynczak, Nick Vaccaro. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68917 ) Change subject: mb/google/brya/variants/volmar: Add firmware config field for FP_MCU ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68917 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I867771904811459697056662d5e29c545a1a9474 Gerrit-Change-Number: 68917 Gerrit-PatchSet: 3 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ofer Fried <oferfried(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paz Zcharya <pazz(a)google.com> Gerrit-Attention: Ofer Fried <oferfried(a)google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Wed, 02 Nov 2022 16:55:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: ec/clevo/it5570e: add driver for EC used on various Clevo laptops
by build bot (Jenkins) (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Angel Pons, Arthur Heymans. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68791 ) Change subject: ec/clevo/it5570e: add driver for EC used on various Clevo laptops ...................................................................... Patch Set 8: (3 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162172): https://review.coreboot.org/c/coreboot/+/68791/comment/a1ef317a_341089c7 PS8, Line 56: Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> Non-standard signature: Co-authored-by: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162172): https://review.coreboot.org/c/coreboot/+/68791/comment/e1895868_6bcc8570 PS8, Line 57: Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Non-standard signature: Co-authored-by: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162172): https://review.coreboot.org/c/coreboot/+/68791/comment/da378527_373791be PS8, Line 58: Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> Non-standard signature: Co-authored-by: -- To view, visit https://review.coreboot.org/c/coreboot/+/68791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8c0bee9002ad9edcd10c83b775fc723744caaa0 Gerrit-Change-Number: 68791 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 02 Nov 2022 16:53:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: ec/clevo/it5570e: add driver for EC used on various Clevo laptops
by Michael Niewöhner (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Angel Pons, Arthur Heymans. Hello Felix Singer, build bot (Jenkins), Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68791 to look at the new patch set (#8). Change subject: ec/clevo/it5570e: add driver for EC used on various Clevo laptops ...................................................................... ec/clevo/it5570e: add driver for EC used on various Clevo laptops This adds a driver for the ITE IT5570E EC in combination with Clevo vendor EC firmware. The interface is mostly identical on various laptop models. Thus, we have implemented one common driver to support them all. The following features were implemented: - Basics like battery, ac, etc. - Suspend/hibernate support: S0ix, S3*, S4/S5 - Save/restore of keyboard backlight level during S0ix without the need for Clevo vendor software (ControlCenter) - Flexicharger - Fn keys (backlight, volume, airplane etc.) - Various configuration options via Kconfig / CMOS options * Note: S3 support works at least on L140CU (Cometlake), but it's not enabled for this board because S0ix is used. Not implemented, yet: - Type-C UCSI: the EC firmware seems to be buggy (with vendor fw, too) - dGPU support is WIP An example of how this driver can be hooked up by a board can be seen in in change CB:59850, where support for the L140MU is added. Known issues: - Touchpad toggle: The touchpad toggle (Fn-F1) has two modes, Ctrl-Alt-F9 mode and keycodes 0xf7/0xf8 mode. Ctrl-Alt-F9 is the native touchpad toggle shortcut on Windows. On Linux this would switch to virtual console 9, if enabled. Thus, one should use the keycodes mode and add udev rules as specified in [1]. If VT9 is disabled, Ctrl-Alt-F9 mode could be used to set up a keyboard shortcut command toggling the touchpad. - Multi-fan systems The Clevo NV41MZ (w/o dGPU) has two fans that should be in-sync. However, the second fan does not spin. This needs further investigation. [1] https://docs.dasharo.com/variants/clevo_nv41/post_install/ Testing the various functionalities of this EC driver was done in the changes hooking up this driver for the boards. Change-Id: Ic8c0bee9002ad9edcd10c83b775fc723744caaa0 Co-authored-by: Michał Kopeć <michal.kopec(a)3mdeb.com> Co-authored-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Co-authored-by: Michael Niewöhner <foss(a)mniewoehner.de> Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- A src/ec/clevo/it5570e/Kconfig A src/ec/clevo/it5570e/Makefile.inc A src/ec/clevo/it5570e/acpi/ac.asl A src/ec/clevo/it5570e/acpi/battery.asl A src/ec/clevo/it5570e/acpi/buttons.asl A src/ec/clevo/it5570e/acpi/common.asl A src/ec/clevo/it5570e/acpi/ec.asl A src/ec/clevo/it5570e/acpi/ec_queries.asl A src/ec/clevo/it5570e/acpi/ec_ram.asl A src/ec/clevo/it5570e/acpi/hid.asl A src/ec/clevo/it5570e/acpi/lid.asl A src/ec/clevo/it5570e/chip.h A src/ec/clevo/it5570e/commands.c A src/ec/clevo/it5570e/commands.h A src/ec/clevo/it5570e/early_init.c A src/ec/clevo/it5570e/early_init.h A src/ec/clevo/it5570e/ec.c A src/ec/clevo/it5570e/ec.h A src/ec/clevo/it5570e/i2ec.c A src/ec/clevo/it5570e/i2ec.h A src/ec/clevo/it5570e/smbios.c A src/ec/clevo/it5570e/smihandler.c A src/ec/clevo/it5570e/smm.h A src/ec/clevo/it5570e/ssdt.c 24 files changed, 2,066 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/68791/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/68791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8c0bee9002ad9edcd10c83b775fc723744caaa0 Gerrit-Change-Number: 68791 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: util/inteltool: Add support for Elkhart lake
by Kacper Stojek (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Kacper Stojek, Paul Menzel. Hello build bot (Jenkins), Michał Żygowski, Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68474 to look at the new patch set (#7). Change subject: util/inteltool: Add support for Elkhart lake ...................................................................... util/inteltool: Add support for Elkhart lake Document: 614109, 601458 Tested on: Protectli vault_ehl (VP2420) Signed-off-by: Kacper Stojek <kacper.stojek(a)3mdeb.com> Change-Id: I54948741082ca1072642046f64539a4c15ddb578 --- M util/inteltool/gpio.c M util/inteltool/gpio_groups.c A util/inteltool/gpio_names/elkhartlake.h M util/inteltool/inteltool.c M util/inteltool/inteltool.h M util/inteltool/pcr.c 6 files changed, 608 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/68474/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/68474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54948741082ca1072642046f64539a4c15ddb578 Gerrit-Change-Number: 68474 Gerrit-PatchSet: 7 Gerrit-Owner: Kacper Stojek Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kacper Stojek Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

[XL] Change in coreboot[master]: ec/clevo/it5570e: add driver for EC used on various Clevo laptops
by build bot (Jenkins) (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Angel Pons, Arthur Heymans. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68791 ) Change subject: ec/clevo/it5570e: add driver for EC used on various Clevo laptops ...................................................................... Patch Set 7: (5 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162165): https://review.coreboot.org/c/coreboot/+/68791/comment/298ee7be_ba7181cb PS7, Line 56: Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> Non-standard signature: Co-authored-by: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162165): https://review.coreboot.org/c/coreboot/+/68791/comment/7066736d_5d603831 PS7, Line 57: Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Non-standard signature: Co-authored-by: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162165): https://review.coreboot.org/c/coreboot/+/68791/comment/ff08cd9d_1a617ea2 PS7, Line 58: Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> Non-standard signature: Co-authored-by: File src/ec/clevo/it5570e/ec.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162165): https://review.coreboot.org/c/coreboot/+/68791/comment/2317c7dd_97ea1184 PS7, Line 119: if (dev->path.type == DEVICE_PATH_GENERIC && dev->path.generic.id == 0) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162165): https://review.coreboot.org/c/coreboot/+/68791/comment/86e52cf5_d6b3775e PS7, Line 122: else { else should follow close brace '}' -- To view, visit https://review.coreboot.org/c/coreboot/+/68791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8c0bee9002ad9edcd10c83b775fc723744caaa0 Gerrit-Change-Number: 68791 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 02 Nov 2022 16:50:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: ec/clevo/it5570e: add driver for EC used on various Clevo laptops
by Michael Niewöhner (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Angel Pons, Arthur Heymans. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68791 ) Change subject: ec/clevo/it5570e: add driver for EC used on various Clevo laptops ...................................................................... Patch Set 7: (9 comments) File src/ec/clevo/it5570e/commands.c: https://review.coreboot.org/c/coreboot/+/68791/comment/e3df0c50_b3f10846 PS4, Line 41: while (recv_ec_data() != '$'); > Looks like CB:69077 is fine :O Personally, I still prefer the variant without `do {}`. […] well, at least I tried... the linter checks regarding if/do/while are pretty complex, so I went your way ;) https://review.coreboot.org/c/coreboot/+/68791/comment/a457d3df_22949adf PS4, Line 119: else if (start > 100 || stop > 100) { > Hmmm, let's find a loophole in the coding style. How about: […] Done https://review.coreboot.org/c/coreboot/+/68791/comment/d3c099d0_3fbaea4b PS4, Line 122: else if (start >= stop) { > See above Done File src/ec/clevo/it5570e/commands.c: https://review.coreboot.org/c/coreboot/+/68791/comment/0eaffcf6_b2731e92 PS6, Line 120: printk(BIOS_ERR, "EC: invalid flexicharger settings: start/stop > 100%%\n"); > ouch, the plan was to just return bc I'm not a fan of trying to guess what the user intended. […] Done File src/ec/clevo/it5570e/ec.c: https://review.coreboot.org/c/coreboot/+/68791/comment/02a640fe_2c3086fd PS4, Line 63: version = ec_read_fw_version(); > uhm, the data is read during runtime, done as discussed; was just a misunderstanding on my side https://review.coreboot.org/c/coreboot/+/68791/comment/401ea0a4_a1852f23 PS4, Line 94: power_unit = 1 << (msr_read(MSR_PKG_POWER_SKU_UNIT) & 0xf); > I don't think so. This is being read at runtime. […] done as discussed https://review.coreboot.org/c/coreboot/+/68791/comment/8abee0c7_8c3109ac PS4, Line 124: if (dev->path.type == DEVICE_PATH_GENERIC && dev->path.generic.id == 0) { > > braces {} are not necessary for any arm of this statement […] Done File src/ec/clevo/it5570e/ssdt.c: https://review.coreboot.org/c/coreboot/+/68791/comment/f835d8c6_437dc2d6 PS4, Line 45: (float) > Test: […] -> done without fp https://review.coreboot.org/c/coreboot/+/68791/comment/06e0a1df_139970c0 PS4, Line 140: for (int i = 0; i < fan_cnt; i++) { > not necessary but also not forbidden. […] heh, I just realized that it's already mixed -> done -- To view, visit https://review.coreboot.org/c/coreboot/+/68791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8c0bee9002ad9edcd10c83b775fc723744caaa0 Gerrit-Change-Number: 68791 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 02 Nov 2022 16:49:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: ec/clevo/it5570e: add driver for EC used on various Clevo laptops
by Michael Niewöhner (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Angel Pons, Arthur Heymans. Hello Felix Singer, build bot (Jenkins), Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68791 to look at the new patch set (#7). Change subject: ec/clevo/it5570e: add driver for EC used on various Clevo laptops ...................................................................... ec/clevo/it5570e: add driver for EC used on various Clevo laptops This adds a driver for the ITE IT5570E EC in combination with Clevo vendor EC firmware. The interface is mostly identical on various laptop models. Thus, we have implemented one common driver to support them all. The following features were implemented: - Basics like battery, ac, etc. - Suspend/hibernate support: S0ix, S3*, S4/S5 - Save/restore of keyboard backlight level during S0ix without the need for Clevo vendor software (ControlCenter) - Flexicharger - Fn keys (backlight, volume, airplane etc.) - Various configuration options via Kconfig / CMOS options * Note: S3 support works at least on L140CU (Cometlake), but it's not enabled for this board because S0ix is used. Not implemented, yet: - Type-C UCSI: the EC firmware seems to be buggy (with vendor fw, too) - dGPU support is WIP An example of how this driver can be hooked up by a board can be seen in in change CB:59850, where support for the L140MU is added. Known issues: - Touchpad toggle: The touchpad toggle (Fn-F1) has two modes, Ctrl-Alt-F9 mode and keycodes 0xf7/0xf8 mode. Ctrl-Alt-F9 is the native touchpad toggle shortcut on Windows. On Linux this would switch to virtual console 9, if enabled. Thus, one should use the keycodes mode and add udev rules as specified in [1]. If VT9 is disabled, Ctrl-Alt-F9 mode could be used to set up a keyboard shortcut command toggling the touchpad. - Multi-fan systems The Clevo NV41MZ (w/o dGPU) has two fans that should be in-sync. However, the second fan does not spin. This needs further investigation. [1] https://docs.dasharo.com/variants/clevo_nv41/post_install/ Testing the various functionalities of this EC driver was done in the changes hooking up this driver for the boards. Change-Id: Ic8c0bee9002ad9edcd10c83b775fc723744caaa0 Co-authored-by: Michał Kopeć <michal.kopec(a)3mdeb.com> Co-authored-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Co-authored-by: Michael Niewöhner <foss(a)mniewoehner.de> Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- A src/ec/clevo/it5570e/Kconfig A src/ec/clevo/it5570e/Makefile.inc A src/ec/clevo/it5570e/acpi/ac.asl A src/ec/clevo/it5570e/acpi/battery.asl A src/ec/clevo/it5570e/acpi/buttons.asl A src/ec/clevo/it5570e/acpi/common.asl A src/ec/clevo/it5570e/acpi/ec.asl A src/ec/clevo/it5570e/acpi/ec_queries.asl A src/ec/clevo/it5570e/acpi/ec_ram.asl A src/ec/clevo/it5570e/acpi/hid.asl A src/ec/clevo/it5570e/acpi/lid.asl A src/ec/clevo/it5570e/chip.h A src/ec/clevo/it5570e/commands.c A src/ec/clevo/it5570e/commands.h A src/ec/clevo/it5570e/early_init.c A src/ec/clevo/it5570e/early_init.h A src/ec/clevo/it5570e/ec.c A src/ec/clevo/it5570e/ec.h A src/ec/clevo/it5570e/i2ec.c A src/ec/clevo/it5570e/i2ec.h A src/ec/clevo/it5570e/smbios.c A src/ec/clevo/it5570e/smihandler.c A src/ec/clevo/it5570e/smm.h A src/ec/clevo/it5570e/ssdt.c 24 files changed, 2,068 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/68791/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/68791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8c0bee9002ad9edcd10c83b775fc723744caaa0 Gerrit-Change-Number: 68791 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/common: provide S0ix hooks in PEP for ECs
by Michael Niewöhner (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć. Hello Felix Singer, build bot (Jenkins), Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Angel Pons, Eric Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68789 to look at the new patch set (#5). Change subject: soc/intel/common: provide S0ix hooks in PEP for ECs ...................................................................... soc/intel/common: provide S0ix hooks in PEP for ECs Provide PEP display notification hooks for ECs. Change-Id: Icbfd294cdd238e63eb947c227a9cf73daca702ef Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/soc/intel/common/block/acpi/pep.c 1 file changed, 25 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/68789/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/68789 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icbfd294cdd238e63eb947c227a9cf73daca702ef Gerrit-Change-Number: 68789 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/qualcomm/sc7280: Move AOP load and reset handle to Romstage
by Shelley Chen (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Venkat Thogaru, Sudheer Amrabadi. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67673 ) Change subject: soc/qualcomm/sc7280: Move AOP load and reset handle to Romstage ...................................................................... Patch Set 18: (1 comment) Patchset: PS18: Hi Sudheer, just wondering if you figured out what sections in the memlayout are hardcoded to the address (which one was causing the exception before)? -- To view, visit https://review.coreboot.org/c/coreboot/+/67673 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iabc8ee8f6e7b14d237b0aeaae42da8077f9dafc4 Gerrit-Change-Number: 67673 Gerrit-PatchSet: 18 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: T.Michael Turney <tmiketurney(a)gmail.com> Gerrit-Attention: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Comment-Date: Wed, 02 Nov 2022 16:43:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: commonlib: Fix AMD MP2 BUFFER id
by Paul Menzel (Code Review) 02 Nov '22

02 Nov '22

Attention is currently required from: Martin L Roth, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69165 ) Change subject: commonlib: Fix AMD MP2 BUFFER id ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/69165 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae6213ac99bc5c64fd5dcd681c7922eafa011fc0 Gerrit-Change-Number: 69165 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 02 Nov 2022 16:36:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022