coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: cpu/x86/mp_init.c: Set a bogus initial lapic_id
by Felix Held (Code Review) 03 Nov '22

03 Nov '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69108 ) Change subject: cpu/x86/mp_init.c: Set a bogus initial lapic_id ...................................................................... cpu/x86/mp_init.c: Set a bogus initial lapic_id This makes it easier to catch errors later if the ap_init code fails to properly set things up. Change-Id: I938faf042bfa4fe1fc39e78ab740c9b210bc105c Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69108 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Jonathan Zhang <jonzhang(a)fb.com> --- M src/cpu/x86/mp_init.c 1 file changed, 22 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, but someone else must approve Jonathan Zhang: Looks good to me, approved diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c index e3b294f..8cd785e 100644 --- a/src/cpu/x86/mp_init.c +++ b/src/cpu/x86/mp_init.c @@ -375,9 +375,11 @@ /* Build the CPU device path */ cpu_path.type = DEVICE_PATH_APIC; - /* Assuming linear APIC space allocation. AP will set its own - APIC id in the ap_init() path above. */ - cpu_path.apic.apic_id = info->cpu->path.apic.apic_id + i; + /* + * Set a bogus apic_id. + * AP will set its own APIC id in the ap_init() path above. + */ + cpu_path.apic.apic_id = UINT32_MAX; /* Allocate the new CPU device structure */ new = alloc_find_dev(cpu_bus, &cpu_path); -- To view, visit https://review.coreboot.org/c/coreboot/+/69108 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I938faf042bfa4fe1fc39e78ab740c9b210bc105c Gerrit-Change-Number: 69108 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: treewide: Add 'IWYU pragma: export' comment
by 9elements QA (Code Review) 03 Nov '22

03 Nov '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68332 ) Change subject: treewide: Add 'IWYU pragma: export' comment ...................................................................... Patch Set 16: Automatic boot test returned (PASS/FAIL/TOTAL): 15 / 1 / 16 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/133294 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/133293 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/133292 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/133291 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/133290 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/133289 FAIL: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/133288 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/133287 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload TianoCore : https://lava.9esec.io/r/133286 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/133285 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/133284 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/133283 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/133282 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/133281 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/133280 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/133279 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/68332 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I482c645f6b5f955e532ad94def1b2f74f15ca908 Gerrit-Change-Number: 68332 Gerrit-PatchSet: 16 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 03 Nov 2022 21:05:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Documentation/drivers: Update section on touchscreen runtime detection
by Matt DeVillier (Code Review) 03 Nov '22

03 Nov '22

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69175 ) Change subject: Documentation/drivers: Update section on touchscreen runtime detection ...................................................................... Documentation/drivers: Update section on touchscreen runtime detection Update section now that google/skyrim implements power sequencing and touchscreen runtime detection. Change-Id: Ida63bebf18575d6856edfc65965ff82a4072df87 Signed-off-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> --- M Documentation/drivers/dt_entries.md 1 file changed, 16 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/69175/1 diff --git a/Documentation/drivers/dt_entries.md b/Documentation/drivers/dt_entries.md index 7726b45..ee67747 100644 --- a/Documentation/drivers/dt_entries.md +++ b/Documentation/drivers/dt_entries.md @@ -162,9 +162,9 @@ Touchscreens can use this feature as well, but special care is needed to implement the proper power sequencing for the device to be detected. Generally, this means driving the enable GPIO high and holding the reset GPIO low in early -GPIO init (bootblock/romstage), then releasing reset in ramstage. While no -boards in the tree currently implement this, it has been used in downstream -forks without issue for some time now. +GPIO init (bootblock/romstage), then releasing reset in ramstage. The first +mainboard in the tree to implement this is google/skyrim. It has been used in +downstream forks without issue for some time now on several other boards. ### wake -- To view, visit https://review.coreboot.org/c/coreboot/+/69175 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida63bebf18575d6856edfc65965ff82a4072df87 Gerrit-Change-Number: 69175 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: {device,drivers}: Include <cpu/cpu.h> instead of <arch/cpu.h>
by 9elements QA (Code Review) 03 Nov '22

03 Nov '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69038 ) Change subject: {device,drivers}: Include <cpu/cpu.h> instead of <arch/cpu.h> ...................................................................... Patch Set 5: Automatic boot test returned (PASS/FAIL/TOTAL): 15 / 1 / 16 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/133260 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/133259 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/133258 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/133257 FAIL: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/133256 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/133255 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/133254 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/133253 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload TianoCore : https://lava.9esec.io/r/133252 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/133251 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/133250 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/133249 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/133248 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/133247 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/133246 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/133245 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/69038 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1727bf56b4090d040aab413006dec7aca0587d44 Gerrit-Change-Number: 69038 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Thu, 03 Nov 2022 20:17:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: 3rdparty/blobs: Advance submodule pointer
by Sean Rhodes (Code Review) 03 Nov '22

03 Nov '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68587 to look at the new patch set (#6). Change subject: 3rdparty/blobs: Advance submodule pointer ...................................................................... 3rdparty/blobs: Advance submodule pointer This contains the following commits: * 835724d: mainboard/starlabs/starbook: Update the EC binaries for StarLabs * ecbe941: soc/mediatek: Update capitalization of coreboot * 0e4444e: soc/mediatek/mt8188: Update MCUPM firmware from v1.01.02 to v1.01.03 * 88570f6: mainboard/starlabs/starbook/adl: Update the EC binary to 1.01 by Sean Rhodes * f8e84db@ mainboard/starlabs/cezanne/starbook: Add EC binary 1.02 by Sean Rhodes Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I7afd43102718f211fe8d4fd69061dcdce5bfc323 --- M 3rdparty/blobs 1 file changed, 22 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/68587/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/68587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7afd43102718f211fe8d4fd69061dcdce5bfc323 Gerrit-Change-Number: 68587 Gerrit-PatchSet: 6 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in blobs[master]: mainboard/starlabs/cezanne/starbook: Add EC binary 1.02
by Felix Held (Code Review) 03 Nov '22

03 Nov '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/blobs/+/68952 ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mainboard/starlabs/cezanne/starbook: Add EC binary 1.02 ...................................................................... mainboard/starlabs/cezanne/starbook: Add EC binary 1.02 1.02 Modified the F10 scan code for better compatibility Modified the F12 scan code for better compatibility Initialised the Keyboard Backlight from the EC to avoid problems when switching branch 1.01 Fix the backlight helper to remember the last state Modified the scan code of the sysreq key 1.00 Initial release EC firmware for the StarBook Mk VI Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I557fd5cd3b987fb4d9a1fb0eaa0e442d94c848fe --- A mainboard/starlabs/cezanne/starbook/README.md A mainboard/starlabs/cezanne/starbook/ec.bin 2 files changed, 40 insertions(+), 0 deletions(-) Approvals: Matt DeVillier: Looks good to me, approved Angel Pons: Verified; Looks good to me, approved diff --git a/mainboard/starlabs/cezanne/starbook/README.md b/mainboard/starlabs/cezanne/starbook/README.md new file mode 100644 index 0000000..77ee61d --- /dev/null +++ b/mainboard/starlabs/cezanne/starbook/README.md @@ -0,0 +1,18 @@ +This is the firmware binary for the ITE embedded controller used in the StarBook Mk VI. The embedded controller +controls all the low level function in the laptop like switches, keyboard and power. + +It is licensed under the [MIT License](../../MIT.md), and as such, the source code is not available. + +## **StarBook**[MkVI-AMD](https://github.com/StarLabsLtd/firmware/tree/master/StarBook/MkVI-AMD) +#### ITE128: [1.02](https://github.com/StarLabsLtd/firmware/raw/master/StarBook/MkVI-AMD/… (2022-10-28) +> Modified the F10 scan code for better compatibility +> Modified the F12 scan code for better compatibility +> Initialised the Keyboard Backlight from the EC to avoid problems when switching branch + +#### ITE128: [1.01](https://github.com/StarLabsLtd/firmware/raw/master/StarBook/MkVI-AMD/… (2022-10-28) +> Fix the backlight helper to remember the last state +> Modified the scan code of the sysreq key + +#### ITE128: [1.00](https://github.com/StarLabsLtd/firmware/raw/master/StarBook/MkVI-AMD/… (2022-10-28) +> Initial release EC firmware for the StarBook Mk VI + diff --git a/mainboard/starlabs/cezanne/starbook/ec.bin b/mainboard/starlabs/cezanne/starbook/ec.bin new file mode 100644 index 0000000..d380892 --- /dev/null +++ b/mainboard/starlabs/cezanne/starbook/ec.bin Binary files differ -- To view, visit https://review.coreboot.org/c/blobs/+/68952 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: I557fd5cd3b987fb4d9a1fb0eaa0e442d94c848fe Gerrit-Change-Number: 68952 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: merged

1 0

[S] Change in blobs[master]: mainboard/starlabs/starbook/adl: Update the EC binary to 1.01
by Felix Held (Code Review) 03 Nov '22

03 Nov '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/blobs/+/68586 ) Change subject: mainboard/starlabs/starbook/adl: Update the EC binary to 1.01 ...................................................................... mainboard/starlabs/starbook/adl: Update the EC binary to 1.01 [ADL] 1.01: Enable hybrid power - when the battery has more than 15% power, support chargers that don't output the required 40W. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: If2c6311af7744b6bd708c2084ce18fcfe13b8f5d --- M mainboard/starlabs/starbook/adl/README.md M mainboard/starlabs/starbook/adl/ec.bin 2 files changed, 20 insertions(+), 1 deletion(-) Approvals: Felix Held: Verified; Looks good to me, approved diff --git a/mainboard/starlabs/starbook/adl/README.md b/mainboard/starlabs/starbook/adl/README.md index 89063ae..9025604 100644 --- a/mainboard/starlabs/starbook/adl/README.md +++ b/mainboard/starlabs/starbook/adl/README.md @@ -3,5 +3,10 @@ It is licensed under the [MIT License](../../MIT.md), and as such, the source code is not available. -#### ITE128: [1.00](https://github.com/StarLabsLtd/firmware/raw/master/StarBook/MkVI/ITE1… (2021-10-08) +#### ITE128: [1.01](https://github.com/StarLabsLtd/firmware/raw/master/StarBook/MkVI-Inte… (2022-10-28) +> Enabled hybrid power; when using a charger that doesn't supply enough power, +> the battery will also power the laptop. This will only happen if the battery +> is charged to 15% or more. + +#### ITE128: [1.00](https://github.com/StarLabsLtd/firmware/raw/master/StarBook/MkV/ITE12… (2021-10-08) > Initial release firmware for the StarBook Mk VI diff --git a/mainboard/starlabs/starbook/adl/ec.bin b/mainboard/starlabs/starbook/adl/ec.bin index f4b7ab5..87475b3 100644 --- a/mainboard/starlabs/starbook/adl/ec.bin +++ b/mainboard/starlabs/starbook/adl/ec.bin Binary files differ -- To view, visit https://review.coreboot.org/c/blobs/+/68586 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: If2c6311af7744b6bd708c2084ce18fcfe13b8f5d Gerrit-Change-Number: 68586 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: merged

1 0

[S] Change in blobs[master]: mainboard/starlabs/starbook/adl: Update the EC binary to 1.01
by Felix Held (Code Review) 03 Nov '22

03 Nov '22

Attention is currently required from: Sean Rhodes, Arthur Heymans. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/68586 ) Change subject: mainboard/starlabs/starbook/adl: Update the EC binary to 1.01 ...................................................................... Patch Set 3: Verified+1 Code-Review+2 -- To view, visit https://review.coreboot.org/c/blobs/+/68586 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: If2c6311af7744b6bd708c2084ce18fcfe13b8f5d Gerrit-Change-Number: 68586 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 03 Nov 2022 20:12:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in blobs[master]: mainboard/starlabs/starbook/adl: Update the EC binary to 1.01
by Sean Rhodes (Code Review) 03 Nov '22

03 Nov '22

Attention is currently required from: Sean Rhodes, Arthur Heymans. Hello Matt DeVillier, Angel Pons, Arthur Heymans, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/blobs/+/68586 to look at the new patch set (#3). Change subject: mainboard/starlabs/starbook/adl: Update the EC binary to 1.01 ...................................................................... mainboard/starlabs/starbook/adl: Update the EC binary to 1.01 [ADL] 1.01: Enable hybrid power - when the battery has more than 15% power, support chargers that don't output the required 40W. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: If2c6311af7744b6bd708c2084ce18fcfe13b8f5d --- M mainboard/starlabs/starbook/adl/README.md M mainboard/starlabs/starbook/adl/ec.bin 2 files changed, 20 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/86/68586/3 -- To view, visit https://review.coreboot.org/c/blobs/+/68586 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: If2c6311af7744b6bd708c2084ce18fcfe13b8f5d Gerrit-Change-Number: 68586 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/amd/glinda/data_fabric: Add register bitslice struct
by Fred Reitberger (Code Review) 03 Nov '22

03 Nov '22

Fred Reitberger has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69072 ) Change subject: soc/amd/glinda/data_fabric: Add register bitslice struct ...................................................................... soc/amd/glinda/data_fabric: Add register bitslice struct Add structs to define the data_fabric register bitfields, updated per glinda ppr #57254, rev 1.51 Update IOMS0_FABRIC_ID and DF_MMIO_NP per referenced ppr. Signed-off-by: Fred Reitberger <reitbergerfred(a)gmail.com> Change-Id: I509eaf5910d8d65ce0956200d7c00451ff9ce864 Reviewed-on: https://review.coreboot.org/c/coreboot/+/69072 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> --- M src/soc/amd/glinda/include/soc/data_fabric.h 1 file changed, 46 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved diff --git a/src/soc/amd/glinda/include/soc/data_fabric.h b/src/soc/amd/glinda/include/soc/data_fabric.h index 0bb9561..32cbd20 100644 --- a/src/soc/amd/glinda/include/soc/data_fabric.h +++ b/src/soc/amd/glinda/include/soc/data_fabric.h @@ -8,10 +8,36 @@ #include <types.h> /* SoC-specific bits in D18F0_MMIO_CTRL0 */ -#define DF_MMIO_NP BIT(16) +#define DF_MMIO_NP BIT(3) -#define IOMS0_FABRIC_ID 9 +#define IOMS0_FABRIC_ID 15 #define NUM_NB_MMIO_REGS 8 +union df_mmio_control { + struct { + uint32_t re : 1; /* [ 0.. 0] */ + uint32_t we : 1; /* [ 1.. 1] */ + uint32_t : 1; /* [ 2.. 2] */ + uint32_t np : 1; /* [ 3.. 3] */ + uint32_t : 12; /* [15.. 4] */ + uint32_t fabric_id : 6; /* [21..16] */ + uint32_t : 10; /* [31..22] */ + }; + uint32_t raw; +}; + +union df_ficaa { + struct { + uint32_t cfg_inst_acc_en : 1; /* [ 0.. 0] */ + uint32_t reg_num : 10; /* [10.. 1] */ + uint32_t func_num : 3; /* [13..11] */ + uint32_t b64_en : 1; /* [14..14] */ + uint32_t : 1; /* [15..15] */ + uint32_t inst_id : 8; /* [23..16] */ + uint32_t : 8; /* [31..24] */ + }; + uint32_t raw; +}; + #endif /* AMD_GLINDA_DATA_FABRIC_H */ -- To view, visit https://review.coreboot.org/c/coreboot/+/69072 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I509eaf5910d8d65ce0956200d7c00451ff9ce864 Gerrit-Change-Number: 69072 Gerrit-PatchSet: 3 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022