Attention is currently required from: Felix Singer, Raul Rangel, Martin L Roth, Stefan Reinauer.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63799 )
Change subject: util/scripts: Add script to show platforms, CPU, type, and date added
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/63799
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f7265d95df31f3a74aa2aa164f6a094c1139750
Gerrit-Change-Number: 63799
Gerrit-PatchSet: 4
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Fri, 04 Nov 2022 14:41:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: V Sowmya, Shahina Shaik, Haribalaraman Ramasubramanian, Paul Menzel, Sridhar Siricilla, Julius Werner, Balaji Manigandan, Yu-Ping Wu.
Shahina Shaik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69221 )
Change subject: security/vboot: Fix different size operands in bitwise operation
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69221/comment/eb99eef2_6e2e4107
PS1, Line 7: UPSTREAM:
> Please remove.
removed the string "UPSTREAM"
https://review.coreboot.org/c/coreboot/+/69221/comment/07551dc1_83cd2e44
PS1, Line 10:
> What error do you get?
We got the issue of "Operands in a bitwise operation have different size" in Klocwork report with severity of "Review(4)".
--
To view, visit https://review.coreboot.org/c/coreboot/+/69221
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifecd5de843bd0229c0cab758d4a641889b4bffd6
Gerrit-Change-Number: 69221
Gerrit-PatchSet: 2
Gerrit-Owner: Shahina Shaik <shahina.shaik(a)intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Shahina Shaik <shahina.shaik(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Attention: Shahina Shaik <shahina.shaik(a)intel.com>
Gerrit-Attention: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Fri, 04 Nov 2022 14:30:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Jeremy Soller, Paul Menzel.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66918 )
Change subject: mb/system76: Reset Realtek codec before configuring
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/66918/comment/9ef36ba5_5d28c3b9
PS2, Line 8:
> Only oryp5 had a problem (CB:65733). […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/66918
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64c1fd23f708f77a81fad0bc889f42d4df3f6e61
Gerrit-Change-Number: 66918
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Fri, 04 Nov 2022 14:20:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Crawford <tcrawford(a)system76.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Jeremy Soller, Paul Menzel.
Hello build bot (Jenkins), Jeremy Soller,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/66918
to look at the new patch set (#3).
Change subject: mb/system76: Reset Realtek codec before configuring
......................................................................
mb/system76: Reset Realtek codec before configuring
Perform a codec reset before configuring to avoid potential issues like
oryp5 had. Inspecting proprietary firmware for multiple boards shows
that this is always done as well.
Change-Id: I64c1fd23f708f77a81fad0bc889f42d4df3f6e61
Signed-off-by: Tim Crawford <tcrawford(a)system76.com>
---
M src/mainboard/system76/addw1/variants/addw1/hda_verb.c
M src/mainboard/system76/addw1/variants/addw2/hda_verb.c
M src/mainboard/system76/bonw14/hda_verb.c
M src/mainboard/system76/cml-u/variants/darp6/hda_verb.c
M src/mainboard/system76/cml-u/variants/galp4/hda_verb.c
M src/mainboard/system76/gaze15/variants/gaze14/hda_verb.c
M src/mainboard/system76/gaze15/variants/gaze15/hda_verb.c
M src/mainboard/system76/gaze16/variants/gaze16-3050/hda_verb.c
M src/mainboard/system76/gaze16/variants/gaze16-3060/hda_verb.c
M src/mainboard/system76/kbl-u/variants/galp2/hda_verb.c
M src/mainboard/system76/kbl-u/variants/galp3-b/hda_verb.c
M src/mainboard/system76/kbl-u/variants/galp3/hda_verb.c
M src/mainboard/system76/lemp9/hda_verb.c
M src/mainboard/system76/oryp5/hda_verb.c
M src/mainboard/system76/oryp6/variants/oryp6/hda_verb.c
M src/mainboard/system76/oryp6/variants/oryp7/hda_verb.c
M src/mainboard/system76/oryp8/hda_verb.c
M src/mainboard/system76/tgl-u/variants/darp7/hda_verb.c
M src/mainboard/system76/tgl-u/variants/galp5/hda_verb.c
M src/mainboard/system76/tgl-u/variants/lemp10/hda_verb.c
M src/mainboard/system76/whl-u/variants/darp5/hda_verb.c
M src/mainboard/system76/whl-u/variants/galp3-c/hda_verb.c
22 files changed, 57 insertions(+), 22 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/66918/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/66918
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64c1fd23f708f77a81fad0bc889f42d4df3f6e61
Gerrit-Change-Number: 66918
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Kyösti Mälkki.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68893 )
Change subject: [WIP]cpu/mp_init: Detect the number of CPUs are runtime
......................................................................
Patch Set 10:
(2 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162429):
https://review.coreboot.org/c/coreboot/+/68893/comment/8e8f0fb4_ee7ec0c0
PS10, Line 8:
Possible repeated word: 'are'
File src/cpu/x86/mp_init.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162429):
https://review.coreboot.org/c/coreboot/+/68893/comment/e0b78b00_9351d1ab
PS10, Line 493: if (!cpu->enabled) {
braces {} are not necessary for any arm of this statement
--
To view, visit https://review.coreboot.org/c/coreboot/+/68893
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iafe9d3d4838dad46cd0c7b6d30b905cbd258f17f
Gerrit-Change-Number: 68893
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Comment-Date: Fri, 04 Nov 2022 14:15:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Lance Zhao, Arthur Heymans, Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Tim Wawrzynczak, Christian Walter, Angel Pons, Shuming Chu (Shuming), TangYiwei.
Hello Lance Zhao, build bot (Jenkins), Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Tim Wawrzynczak, Christian Walter, TangYiwei,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68912
to look at the new patch set (#11).
Change subject: soc/intel/xeon_sp: Don't sort struct device cpus for numa
......................................................................
soc/intel/xeon_sp: Don't sort struct device cpus for numa
Currently the xeon_sp code reassigns struct devices apic_id so that srat
entries can be added in a certain order.
This is not a good idea as it breaks thread local storage which contains
a pointer to it's struct device cpu.
This moves the sorting of the lapic_ids to the srat table generation
and adds the numa node id in each core init entry (now it is done in
parallel too as a bonus).
Change-Id: I372bcea1932d28e9bf712cc712f19a76fe3199b1
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/soc/intel/xeon_sp/cpx/cpu.c
M src/soc/intel/xeon_sp/include/soc/util.h
M src/soc/intel/xeon_sp/nb_acpi.c
M src/soc/intel/xeon_sp/skx/cpu.c
M src/soc/intel/xeon_sp/util.c
5 files changed, 59 insertions(+), 120 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/68912/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/68912
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I372bcea1932d28e9bf712cc712f19a76fe3199b1
Gerrit-Change-Number: 68912
Gerrit-PatchSet: 11
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-CC: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Attention: TangYiwei
Gerrit-MessageType: newpatchset
Attention is currently required from: Lance Zhao, Tim Wawrzynczak.
Hello Lance Zhao, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69225
to look at the new patch set (#5).
Change subject: acpi/acpi.c: Follow spec more closely for MADT
......................................................................
acpi/acpi.c: Follow spec more closely for MADT
Secondary threads need to be added after the primary threads.
Change-Id: I3a98560760b662a7ba7efb46f5f7882fb0f7bb1f
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/acpi/acpi.c
1 file changed, 41 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/69225/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/69225
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a98560760b662a7ba7efb46f5f7882fb0f7bb1f
Gerrit-Change-Number: 69225
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Kyösti Mälkki.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68893 )
Change subject: [WIP]cpu/mp_init: Detect the number of CPUs are runtime
......................................................................
Patch Set 9:
(2 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162426):
https://review.coreboot.org/c/coreboot/+/68893/comment/2bf6298c_e3801124
PS9, Line 8:
Possible repeated word: 'are'
File src/cpu/x86/mp_init.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162426):
https://review.coreboot.org/c/coreboot/+/68893/comment/9346276e_6037d0c4
PS9, Line 493: if (!cpu->enabled) {
braces {} are not necessary for any arm of this statement
--
To view, visit https://review.coreboot.org/c/coreboot/+/68893
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iafe9d3d4838dad46cd0c7b6d30b905cbd258f17f
Gerrit-Change-Number: 68893
Gerrit-PatchSet: 9
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Comment-Date: Fri, 04 Nov 2022 14:14:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment