Attention is currently required from: Marc Jones, Johnny Lin, Angel Pons.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69144 )
Change subject: soc/intel/xeon_sp/cpx: Add get_ewl_hob() utility function
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> hmm, but how did the Jenkins build on patch set 2 succeed?
should i push a revert of this and the next patch to unbreak the tree or is there some other patch sitting in review that will make this work that i should look into instead?
--
To view, visit https://review.coreboot.org/c/coreboot/+/69144
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8f949e9c881099c3723fca056e2c4732ca8b64cf
Gerrit-Change-Number: 69144
Gerrit-PatchSet: 3
Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Fri, 04 Nov 2022 17:59:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Crawford <tcrawford(a)system76.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Marc Jones, Johnny Lin, Angel Pons.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69144 )
Change subject: soc/intel/xeon_sp/cpx: Add get_ewl_hob() utility function
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> src/soc/intel/xeon_sp/cpx/include/soc/soc_util.h:8:10: fatal error: hob_enhancedwarningloglib. […]
hmm, but how did the Jenkins build on patch set 2 succeed?
--
To view, visit https://review.coreboot.org/c/coreboot/+/69144
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8f949e9c881099c3723fca056e2c4732ca8b64cf
Gerrit-Change-Number: 69144
Gerrit-PatchSet: 3
Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Fri, 04 Nov 2022 17:49:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Crawford <tcrawford(a)system76.com>
Gerrit-MessageType: comment
Attention is currently required from: Justin van Son, Christian Walter, Maximilian Brune, Lean Sheng Tan, David Milosevic.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68222 )
Change subject: mb/prodrive/atlas: Disable C-States & cTDP
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> This change is not needed anymore, disabling C states seems to have the opposite effect of what is d […]
Interesting. Marking as unresolved for emphasis.
Wild thought for the PCIe issue: maybe things like OBFF (Optimized Buffer Flush/Fill) *could* help.
--
To view, visit https://review.coreboot.org/c/coreboot/+/68222
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf1c15ac258c78025420966bf592795b66101d17
Gerrit-Change-Number: 68222
Gerrit-PatchSet: 2
Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-Attention: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Comment-Date: Fri, 04 Nov 2022 17:48:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-MessageType: comment
Attention is currently required from: Taniya Das, Venkat Thogaru, Paul Menzel, Julius Werner, Sudheer Amrabadi.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68384 )
Change subject: soc/qualcomm/sc7280: Add API to differentialize PRO and NON_PRO SKUs
......................................................................
Patch Set 11:
(1 comment)
File src/soc/qualcomm/sc7280/socinfo.c:
https://review.coreboot.org/c/coreboot/+/68384/comment/d9508b2b_ca817b58
PS4, Line 12: static struct chipinfo chipinfolut[] = {
> So which one is it, future purpose or readability? […]
Qualcomm, do you have an update on this?
--
To view, visit https://review.coreboot.org/c/coreboot/+/68384
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9f23696384a6c1a89000292eafebd8a16c273ca
Gerrit-Change-Number: 68384
Gerrit-PatchSet: 11
Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Taniya Das <quic_tdas(a)quicinc.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Taniya Das <tdas(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Taniya Das <quic_tdas(a)quicinc.com>
Gerrit-Attention: Venkat Thogaru <thogaru(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Taniya Das <tdas(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-Comment-Date: Fri, 04 Nov 2022 17:44:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Comment-In-Reply-To: Taniya Das <tdas(a)qualcomm.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Jeremy Soller, Angel Pons.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65384 )
Change subject: mb/system76/adl-p: Add Lemur Pro 11 as a variant
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/65384
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic930df1ebacc8c7ef14dbb6c67a97eddb918b365
Gerrit-Change-Number: 65384
Gerrit-PatchSet: 18
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Fri, 04 Nov 2022 17:38:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67991 )
Change subject: mb/system76/tgl-h: Convert oryp8 to a variant
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/67991
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ied55add6d7549f165d8b97032d7f21ede0ce2dde
Gerrit-Change-Number: 67991
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 04 Nov 2022 17:16:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jeremy Soller.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61301 )
Change subject: mb/system76: Add custom backlight levels for Intel GMA
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/61301
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibea37f19acca0d718211fc41706019a92a240c70
Gerrit-Change-Number: 61301
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Comment-Date: Fri, 04 Nov 2022 17:15:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Maximilian Brune, Lean Sheng Tan, David Milosevic.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68222 )
Change subject: mb/prodrive/atlas: Disable C-States & cTDP
......................................................................
Patch Set 2: -Code-Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/68222
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf1c15ac258c78025420966bf592795b66101d17
Gerrit-Change-Number: 68222
Gerrit-PatchSet: 2
Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Comment-Date: Fri, 04 Nov 2022 16:38:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment