coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[M] Change in coreboot[master]: Revert "drivers/ocp/ewl: Add EWL driver for EWL type 3 error handling"
by Matt DeVillier (Code Review) 04 Nov '22

04 Nov '22

Attention is currently required from: Felix Held. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69228 ) Change subject: Revert "drivers/ocp/ewl: Add EWL driver for EWL type 3 error handling" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69228 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idb2fa27e75eede1648ddbf82c8bfbeeb2e9220a6 Gerrit-Change-Number: 69228 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 04 Nov 2022 18:22:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Revert "soc/intel/xeon_sp/cpx: Add get_ewl_hob() utility function"
by Angel Pons (Code Review) 04 Nov '22

04 Nov '22

Attention is currently required from: Johnny Lin, Christian Walter, Felix Held, Tim Chu. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69229 ) Change subject: Revert "soc/intel/xeon_sp/cpx: Add get_ewl_hob() utility function" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If56609dd2d91a70fe7e99ce86e0341f2b3fee3d3 Gerrit-Change-Number: 69229 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 04 Nov 2022 18:22:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Revert "drivers/ocp/ewl: Add EWL driver for EWL type 3 error handling"
by Angel Pons (Code Review) 04 Nov '22

04 Nov '22

Attention is currently required from: Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69228 ) Change subject: Revert "drivers/ocp/ewl: Add EWL driver for EWL type 3 error handling" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69228 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idb2fa27e75eede1648ddbf82c8bfbeeb2e9220a6 Gerrit-Change-Number: 69228 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 04 Nov 2022 18:22:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Revert "soc/intel/xeon_sp/cpx: Add get_ewl_hob() utility function"
by Jonathan Zhang (Code Review) 04 Nov '22

04 Nov '22

Attention is currently required from: Johnny Lin, Christian Walter, Felix Held, Tim Chu. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69229 ) Change subject: Revert "soc/intel/xeon_sp/cpx: Add get_ewl_hob() utility function" ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: We did get general approval for the header file, but need to turn around probably till Monday, so in the interim, let's revert this patch to unbreak the tree. -- To view, visit https://review.coreboot.org/c/coreboot/+/69229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If56609dd2d91a70fe7e99ce86e0341f2b3fee3d3 Gerrit-Change-Number: 69229 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 04 Nov 2022 18:21:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Revert "soc/intel/xeon_sp/cpx: Add get_ewl_hob() utility function"
by Arthur Heymans (Code Review) 04 Nov '22

04 Nov '22

Attention is currently required from: Jonathan Zhang, Johnny Lin, Christian Walter, Felix Held, Tim Chu. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69229 ) Change subject: Revert "soc/intel/xeon_sp/cpx: Add get_ewl_hob() utility function" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If56609dd2d91a70fe7e99ce86e0341f2b3fee3d3 Gerrit-Change-Number: 69229 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 04 Nov 2022 18:21:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Revert "drivers/ocp/ewl: Add EWL driver for EWL type 3 error handling"
by Arthur Heymans (Code Review) 04 Nov '22

04 Nov '22

Attention is currently required from: Felix Held. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69228 ) Change subject: Revert "drivers/ocp/ewl: Add EWL driver for EWL type 3 error handling" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69228 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idb2fa27e75eede1648ddbf82c8bfbeeb2e9220a6 Gerrit-Change-Number: 69228 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 04 Nov 2022 18:21:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Revert "soc/intel/xeon_sp/cpx: Add get_ewl_hob() utility function"
by Tim Crawford (Code Review) 04 Nov '22

04 Nov '22

Attention is currently required from: Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Felix Held, Tim Chu. Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69229 ) Change subject: Revert "soc/intel/xeon_sp/cpx: Add get_ewl_hob() utility function" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If56609dd2d91a70fe7e99ce86e0341f2b3fee3d3 Gerrit-Change-Number: 69229 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 04 Nov 2022 18:21:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Revert "drivers/ocp/ewl: Add EWL driver for EWL type 3 error handling"
by Tim Crawford (Code Review) 04 Nov '22

04 Nov '22

Attention is currently required from: Felix Held. Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69228 ) Change subject: Revert "drivers/ocp/ewl: Add EWL driver for EWL type 3 error handling" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69228 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idb2fa27e75eede1648ddbf82c8bfbeeb2e9220a6 Gerrit-Change-Number: 69228 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 04 Nov 2022 18:20:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Revert "soc/intel/xeon_sp/cpx: Add get_ewl_hob() utility function"
by Felix Held (Code Review) 04 Nov '22

04 Nov '22

Attention is currently required from: Jonathan Zhang, Johnny Lin, Christian Walter, Arthur Heymans, Tim Chu. Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69229 ) Change subject: Revert "soc/intel/xeon_sp/cpx: Add get_ewl_hob() utility function" ...................................................................... Revert "soc/intel/xeon_sp/cpx: Add get_ewl_hob() utility function" This reverts commit 3bc9fbb496c7e1ae346c8d7e98d2bcabbbbe8673. The patch that added hob_enhancedwarningloglib.h was marked as private after the Jenkins run, so I didn't see and submit it before submitting the patch that gets reverted by this commit. Temporary revert this patch to fix the coreboot tree until the issue with the missing patch is sorted out. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: If56609dd2d91a70fe7e99ce86e0341f2b3fee3d3 --- M src/soc/intel/xeon_sp/cpx/Makefile.inc M src/soc/intel/xeon_sp/cpx/include/soc/soc_util.h M src/soc/intel/xeon_sp/cpx/soc_util.c 3 files changed, 19 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/69229/1 diff --git a/src/soc/intel/xeon_sp/cpx/Makefile.inc b/src/soc/intel/xeon_sp/cpx/Makefile.inc index 7e18b92..0cd267b 100644 --- a/src/soc/intel/xeon_sp/cpx/Makefile.inc +++ b/src/soc/intel/xeon_sp/cpx/Makefile.inc @@ -5,7 +5,7 @@ subdirs-y += ../../../../cpu/intel/turbo subdirs-y += ../../../../cpu/intel/microcode -romstage-y += romstage.c ddr.c soc_util.c +romstage-y += romstage.c ddr.c romstage-$(CONFIG_DISPLAY_UPD_DATA) += upd_display.c romstage-$(CONFIG_DISPLAY_HOBS) += hob_display.c diff --git a/src/soc/intel/xeon_sp/cpx/include/soc/soc_util.h b/src/soc/intel/xeon_sp/cpx/include/soc/soc_util.h index c4e2a7d..5ce3928 100644 --- a/src/soc/intel/xeon_sp/cpx/include/soc/soc_util.h +++ b/src/soc/intel/xeon_sp/cpx/include/soc/soc_util.h @@ -5,13 +5,11 @@ #include <hob_iiouds.h> #include <hob_memmap.h> -#include <hob_enhancedwarningloglib.h> const struct SystemMemoryMapHob *get_system_memory_map(void); uint32_t get_socket_stack_busno(uint32_t socket, uint32_t stack); int soc_get_stack_for_port(int port); -const EWL_PRIVATE_DATA *get_ewl_hob(void); #endif /* _SOC_UTIL_H_ */ diff --git a/src/soc/intel/xeon_sp/cpx/soc_util.c b/src/soc/intel/xeon_sp/cpx/soc_util.c index 2a8b6c9..cd1e06d 100644 --- a/src/soc/intel/xeon_sp/cpx/soc_util.c +++ b/src/soc/intel/xeon_sp/cpx/soc_util.c @@ -9,20 +9,6 @@ #include <soc/soc_util.h> #include <soc/util.h> -const EWL_PRIVATE_DATA *get_ewl_hob(void) -{ - size_t hob_size; - static const EWL_PRIVATE_DATA *hob; - const uint8_t ewl_id_hob_guid[16] = FSP_HOB_EWLID_GUID; - - if (hob != NULL) - return hob; - - hob = fsp_find_extension_hob_by_guid(ewl_id_hob_guid, &hob_size); - assert(hob != NULL && hob_size != 0); - return hob; -} - const struct SystemMemoryMapHob *get_system_memory_map(void) { size_t hob_size; -- To view, visit https://review.coreboot.org/c/coreboot/+/69229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If56609dd2d91a70fe7e99ce86e0341f2b3fee3d3 Gerrit-Change-Number: 69229 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: Revert "drivers/ocp/ewl: Add EWL driver for EWL type 3 error handling"
by Felix Held (Code Review) 04 Nov '22

04 Nov '22

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69228 ) Change subject: Revert "drivers/ocp/ewl: Add EWL driver for EWL type 3 error handling" ...................................................................... Revert "drivers/ocp/ewl: Add EWL driver for EWL type 3 error handling" This reverts commit 059902882ce56502124375c9395ebe8b49640710. A dependency of the previous patch that added the get_ewl_hob function used by this patch was missing, so this patch needs to be temporary reverted to revert the patch that breaks the build due to the missing dependency. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Idb2fa27e75eede1648ddbf82c8bfbeeb2e9220a6 --- D src/drivers/ocp/ewl/Kconfig D src/drivers/ocp/ewl/Makefile.inc D src/drivers/ocp/ewl/ewl.c D src/drivers/ocp/ewl/ocp_ewl.h 4 files changed, 17 insertions(+), 74 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/69228/1 diff --git a/src/drivers/ocp/ewl/Kconfig b/src/drivers/ocp/ewl/Kconfig deleted file mode 100644 index 3c3b82d..0000000 --- a/src/drivers/ocp/ewl/Kconfig +++ /dev/null @@ -1,5 +0,0 @@ -config OCP_EWL - bool - default n - help - It implements checking FSP Enhanced Warning Log Hob. diff --git a/src/drivers/ocp/ewl/Makefile.inc b/src/drivers/ocp/ewl/Makefile.inc deleted file mode 100644 index 43112e9..0000000 --- a/src/drivers/ocp/ewl/Makefile.inc +++ /dev/null @@ -1 +0,0 @@ -romstage-$(CONFIG_OCP_EWL) += ewl.c diff --git a/src/drivers/ocp/ewl/ewl.c b/src/drivers/ocp/ewl/ewl.c deleted file mode 100644 index d70a23f..0000000 --- a/src/drivers/ocp/ewl/ewl.c +++ /dev/null @@ -1,58 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <soc/soc_util.h> -#include <lib.h> -#include "ocp_ewl.h" - -static void process_ewl_type3(EWL_ENTRY_HEADER *header, EWL_ENTRY_MEMORY_LOCATION memory_location) -{ - /* Treat warning as type 3, collect basic information and print to serial log */ - EWL_ENTRY_TYPE3 *basic_warning; - basic_warning = (EWL_ENTRY_TYPE3 *)header; - printk(BIOS_ERR, "Major Warning Code = 0x%02x, Minor Warning Code = 0x%02x,\n", - basic_warning->Context.MajorWarningCode, - basic_warning->Context.MinorWarningCode); - printk(BIOS_ERR, "Major Checkpoint: 0x%02x\n", basic_warning->Context.MajorCheckpoint); - printk(BIOS_ERR, "Minor Checkpoint: 0x%02x\n", basic_warning->Context.MinorCheckpoint); - - if (memory_location.Socket != 0xff) - printk(BIOS_ERR, "Socket %d\n", memory_location.Socket); - if (memory_location.Channel != 0xff) - printk(BIOS_ERR, "Channel %d\n", memory_location.Channel); - if (memory_location.Dimm != 0xff) - printk(BIOS_ERR, "Dimm %d\n", memory_location.Dimm); - if (memory_location.Rank != 0xff) - printk(BIOS_ERR, "Rank %d\n", memory_location.Rank); -} - -void get_ewl(void) -{ - const EWL_PRIVATE_DATA *hob = get_ewl_hob(); - int offset = 0; - bool type3_flag = 0; - EWL_ENTRY_HEADER *warning_header; - printk(BIOS_DEBUG, "Number of EWL entries %d\n", hob->numEntries); - while (offset < hob->status.Header.FreeOffset) { - warning_header = (EWL_ENTRY_HEADER *) &(hob->status.Buffer[offset]); - if (warning_header->Type == EwlType3) { - printk(BIOS_ERR, "EWL type: %d\n", warning_header->Type); - if (warning_header->Size != sizeof(EWL_ENTRY_TYPE3)) { - printk(BIOS_ERR, "EWL type3 size mismatch!\n"); - return; - } - EWL_ENTRY_TYPE3 *type3; - type3 = (EWL_ENTRY_TYPE3 *)warning_header; - process_ewl_type3(warning_header, type3->MemoryLocation); - type3_flag = 1; - } else { - printk(BIOS_DEBUG, "EWL type: %d size:%d severity level:%d\n", - warning_header->Type, - warning_header->Size, - warning_header->Severity); - hexdump(&(hob->status.Buffer[offset]), warning_header->Size); - } - offset += warning_header->Size; - } - if (type3_flag) - die("Memory Training Error!\n"); -} diff --git a/src/drivers/ocp/ewl/ocp_ewl.h b/src/drivers/ocp/ewl/ocp_ewl.h deleted file mode 100644 index 38d5286d..0000000 --- a/src/drivers/ocp/ewl/ocp_ewl.h +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#ifndef __OCP_EWL_H -#define __OCP_EWL_H - -#include <soc/soc_util.h> - -void get_ewl(void); - -#endif -- To view, visit https://review.coreboot.org/c/coreboot/+/69228 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idb2fa27e75eede1648ddbf82c8bfbeeb2e9220a6 Gerrit-Change-Number: 69228 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022