coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[M] Change in coreboot[master]: mp_service_ppi: Use struct device to fill in buffer
by Arthur Heymans (Code Review) 04 Nov '22

04 Nov '22

Attention is currently required from: Andrey Petrov. Hello Andrey Petrov, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69223 to look at the new patch set (#2). Change subject: mp_service_ppi: Use struct device to fill in buffer ...................................................................... mp_service_ppi: Use struct device to fill in buffer Now the CPU topology is filled in struct device during mp_init. Change-Id: I7322b43f5b95dda5fbe81e7427f5269c9d6f8755 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c M src/soc/intel/common/block/cpu/cpulib.c M src/soc/intel/common/block/include/intelblocks/cpulib.h 3 files changed, 20 insertions(+), 65 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/69223/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69223 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7322b43f5b95dda5fbe81e7427f5269c9d6f8755 Gerrit-Change-Number: 69223 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: cpu: Add SPDX license headers to Makefiles
by Angel Pons (Code Review) 04 Nov '22

04 Nov '22

Attention is currently required from: Martin L Roth, Jakub Czapiga. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68979 ) Change subject: cpu: Add SPDX license headers to Makefiles ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/cpu/amd/Makefile.inc: https://review.coreboot.org/c/coreboot/+/68979/comment/879bef70_a8339e09 PS1, Line 1: ## SPDX-License-Identifier: GPL-2.0-only > nit: I think these files could use one empty line after SPDX comment to make them more eye-appealing +1 -- To view, visit https://review.coreboot.org/c/coreboot/+/68979 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3033f2a9eebc75220f7666325857b3ddd60c8f75 Gerrit-Change-Number: 68979 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Comment-Date: Fri, 04 Nov 2022 13:45:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: payloads: Make PAYLOAD_NONE a bool outside of the choice
by Felix Held (Code Review) 04 Nov '22

04 Nov '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68595 ) Change subject: payloads: Make PAYLOAD_NONE a bool outside of the choice ...................................................................... payloads: Make PAYLOAD_NONE a bool outside of the choice Instead of having the config option PAYLOADS_NONE inside the choice of payloads, make that a separate choice that enables the payload menu. If the no_payload option is selected, this hides the other options and keeps them out of the saved config file and config.h Signed-off-by: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Change-Id: I932c65630261a5b39809abf4dfbda5bf932c6684 Reviewed-on: https://review.coreboot.org/c/coreboot/+/68595 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Sean Rhodes <sean(a)starlabs.systems> --- M payloads/Kconfig 1 file changed, 30 insertions(+), 10 deletions(-) Approvals: build bot (Jenkins): Verified Sean Rhodes: Looks good to me, approved diff --git a/payloads/Kconfig b/payloads/Kconfig index 2e627d7..2a2773a 100644 --- a/payloads/Kconfig +++ b/payloads/Kconfig @@ -1,15 +1,8 @@ menu "Payload" -config NO_DEFAULT_PAYLOAD - bool - -choice - prompt "Add a payload" - default PAYLOAD_NONE if NO_DEFAULT_PAYLOAD || !ARCH_X86 - default PAYLOAD_SEABIOS if ARCH_X86 - config PAYLOAD_NONE - bool "None" + bool "Don't add a payload" + default y if !ARCH_X86 help Select this option if you want to create an "empty" coreboot ROM image for a certain mainboard, i.e. a coreboot ROM image @@ -18,6 +11,11 @@ For such an image to be useful, you have to use 'cbfstool' to add a payload to the ROM image later. +if !PAYLOAD_NONE +choice + prompt "Payload to add" + default PAYLOAD_SEABIOS if ARCH_X86 + config PAYLOAD_ELF bool "An ELF executable payload" help @@ -58,7 +56,7 @@ prompt "Payload compression algorithm" default COMPRESSED_PAYLOAD_LZMA default COMPRESSED_PAYLOAD_NONE if PAYLOAD_LINUX || PAYLOAD_LINUXBOOT || PAYLOAD_FIT - depends on !PAYLOAD_NONE && !PAYLOAD_LINUX && !PAYLOAD_LINUXBOOT && !PAYLOAD_FIT + depends on !PAYLOAD_LINUX && !PAYLOAD_LINUXBOOT && !PAYLOAD_FIT help Choose the compression algorithm for the chosen payloads. You can choose between None, LZMA, or LZ4. @@ -178,4 +176,7 @@ source "payloads/external/*/Kconfig.secondary" endmenu # "Secondary Payloads" + +endif # !PAYLOAD_NONE + endmenu -- To view, visit https://review.coreboot.org/c/coreboot/+/68595 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I932c65630261a5b39809abf4dfbda5bf932c6684 Gerrit-Change-Number: 68595 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: Docs: Add SPDX headers to Makefiles
by Angel Pons (Code Review) 04 Nov '22

04 Nov '22

Attention is currently required from: Felix Singer, Martin L Roth. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68957 ) Change subject: Docs: Add SPDX headers to Makefiles ...................................................................... Patch Set 2: Code-Review+2 (2 comments) File Documentation/Makefile: https://review.coreboot.org/c/coreboot/+/68957/comment/f1b750ef_949725d1 PS2, Line 1: ## SPDX-License-Identifier: GPL-2.0-only nit: Using one # would be consistent with the existing comments. File Documentation/Makefile.sphinx: https://review.coreboot.org/c/coreboot/+/68957/comment/73498b69_d7892728 PS2, Line 1: ## SPDX-License-Identifier: GPL-2.0-only Ditto -- To view, visit https://review.coreboot.org/c/coreboot/+/68957 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id229fb22d20c489db3dd7a59f29e7ac10174fd85 Gerrit-Change-Number: 68957 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Fri, 04 Nov 2022 13:45:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mainboard: Add SPDX license headers to Makefiles
by Angel Pons (Code Review) 04 Nov '22

04 Nov '22

Attention is currently required from: Felix Singer, Jason Nien, Jeremy Soller, Martin Roth, Tim Crawford, Nico Huber, Tarun Tuli, Martin L Roth, Damien Zammit, Subrata Banik, Maxim Polyakov, Kapil Porwal, Alexander Couzens, Werner Zeh, Evgeny Zinoviev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68982 ) Change subject: mainboard: Add SPDX license headers to Makefiles ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68982 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic451e68b1ad9ccdf34484dd98bd7fca7e177ef22 Gerrit-Change-Number: 68982 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Damien Zammit Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Comment-Date: Fri, 04 Nov 2022 13:43:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: cpu: Include <cpu/cpu.h> instead of <arch/cpu.h>
by Felix Held (Code Review) 04 Nov '22

04 Nov '22

Attention is currently required from: Elyes Haouas. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69037 ) Change subject: cpu: Include <cpu/cpu.h> instead of <arch/cpu.h> ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/cpu/intel/common/hyperthreading.c: https://review.coreboot.org/c/coreboot/+/69037/comment/fd6ebc20_c6d03e19 PS2, Line 4: #include <cpu/cpu.h> not sure if you want to reorder this one too to have it in alphabetic order -- To view, visit https://review.coreboot.org/c/coreboot/+/69037 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia4a3807e45777e2a596878fe09e3c80b1fd2704d Gerrit-Change-Number: 69037 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 04 Nov 2022 13:43:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mainboard: Add SPDX license headers to Makefiles
by Angel Pons (Code Review) 04 Nov '22

04 Nov '22

Attention is currently required from: Felix Singer, Jason Nien, Jeremy Soller, Martin Roth, Tim Crawford, Nico Huber, Tarun Tuli, Martin L Roth, Damien Zammit, Subrata Banik, Maxim Polyakov, Kapil Porwal, Alexander Couzens, Werner Zeh, Evgeny Zinoviev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68982 ) Change subject: mainboard: Add SPDX license headers to Makefiles ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/68982 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic451e68b1ad9ccdf34484dd98bd7fca7e177ef22 Gerrit-Change-Number: 68982 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Damien Zammit Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Comment-Date: Fri, 04 Nov 2022 13:41:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: common/acpi/dptc: Implement DTTS Proposal
by Paul Menzel (Code Review) 04 Nov '22

04 Nov '22

Attention is currently required from: Raul Rangel, Jason Nien, EricKY Cheng, Matt DeVillier, Martin Roth, Tim Van Patten, Eric Peers, Jason Glenesk, Caveh Jalali, Tim Wawrzynczak, Fred Reitberger, Karthikeyan Ramasubramanian, Boris Mittelberg, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68471 ) Change subject: common/acpi/dptc: Implement DTTS Proposal ...................................................................... Patch Set 30: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/68471/comment/421dc49c_8aa31a32 PS30, Line 9: DTTS indicated Dynamic Thermal Table Switching. : The proposal would like to develop the schematic : for switching 6 thermal table by lid status, : machine body mode and temperature. : After entering the OS, the thermal table would be table A. : If the “Motion” or “Lid-status changement” is detected. : The thermal table would switch to laptop mode or lid-close : mode. Once the higher environment temperatures are detected, : the thermal table would switch to the corresponding power : throttle table(B, D or F). Based on these table switching : mechanisms, no matter how the end-user uses Chromebook, : they could enjoy more humanized thermal designs. Please reflow for 72 characters per line, and add a blank line between paragraphs. https://review.coreboot.org/c/coreboot/+/68471/comment/314f318a_ecc45747 PS30, Line 39: Table table https://review.coreboot.org/c/coreboot/+/68471/comment/4366f625_742066d3 PS30, Line 39: 5. Assume Table A is current table. When the temperature Maybe start a new paragraph, saying it’s an example. https://review.coreboot.org/c/coreboot/+/68471/comment/72ecd019_76daab1d PS30, Line 40: reach reaches -- To view, visit https://review.coreboot.org/c/coreboot/+/68471 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I866e5e497e2936984e713029b5f0b6d54cbc9622 Gerrit-Change-Number: 68471 Gerrit-PatchSet: 30 Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: LeilaCY Lin <leilacy_lin(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 04 Nov 2022 13:40:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/i2c/sx9324: Add support for Linux's SX9324 driver
by Tarun Tuli (Code Review) 04 Nov '22

04 Nov '22

Attention is currently required from: Victor Ding, Jason Nien, Martin Roth. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69192 ) Change subject: drivers/i2c/sx9324: Add support for Linux's SX9324 driver ...................................................................... Patch Set 6: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/69192/comment/cf5821ef_a5032d54 PS6, Line 26: TEST=Dump ACPI SSDT then verify _DSD entries related to the legacy nit: do you mind including what board(s)/platform(s) you verified the SSDT on -- To view, visit https://review.coreboot.org/c/coreboot/+/69192 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I42cd6841c3a270c242ed2e739db245e858eadb3b Gerrit-Change-Number: 69192 Gerrit-PatchSet: 6 Gerrit-Owner: Victor Ding <victording(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Victor Ding <victording(a)google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Fri, 04 Nov 2022 13:38:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: src/soc/amd/mendocino: Enable override of MAINBOARD_BLOBS_DIR
by Fred Reitberger (Code Review) 04 Nov '22

04 Nov '22

Attention is currently required from: Raul Rangel, Matt DeVillier, Nikolai Vyssotski, Felix Held. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68801 ) Change subject: src/soc/amd/mendocino: Enable override of MAINBOARD_BLOBS_DIR ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68801 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I028042b947887d1182642ad4482dd1bba7ad8e23 Gerrit-Change-Number: 68801 Gerrit-PatchSet: 3 Gerrit-Owner: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 04 Nov 2022 13:36:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022