coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: configs: Add 64bit buildtest for prodrive/hermes
by Angel Pons (Code Review) 04 Nov '22

04 Nov '22

Attention is currently required from: Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69236 ) Change subject: configs: Add 64bit buildtest for prodrive/hermes ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File configs/config.prodrive_hermes_x86_64: PS1: File might need to be named `config.prodrive_hermes.x86_64` -- To view, visit https://review.coreboot.org/c/coreboot/+/69236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic62a33f8d8c3fdaa8182e797b2bf6fbed6b55731 Gerrit-Change-Number: 69236 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 04 Nov 2022 19:52:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: configs: Add 64bit buildtest for prodrive/hermes
by Arthur Heymans (Code Review) 04 Nov '22

04 Nov '22

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69236 ) Change subject: configs: Add 64bit buildtest for prodrive/hermes ...................................................................... configs: Add 64bit buildtest for prodrive/hermes This configuration also boots on real hardware. Change-Id: Ic62a33f8d8c3fdaa8182e797b2bf6fbed6b55731 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- A configs/config.prodrive_hermes_x86_64 1 file changed, 29 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/69236/1 diff --git a/configs/config.prodrive_hermes_x86_64 b/configs/config.prodrive_hermes_x86_64 new file mode 100644 index 0000000..506f494 --- /dev/null +++ b/configs/config.prodrive_hermes_x86_64 @@ -0,0 +1,17 @@ +# Settings used by Prodrive to build coreboot for the Hermes but with x86_64 enabled +CONFIG_VENDOR_PRODRIVE=y +CONFIG_BOARD_PRODRIVE_HERMES=y +CONFIG_MAINBOARD_SMBIOS_MANUFACTURER="Prodrive Technologies B.V." +CONFIG_POST_IO=y +CONFIG_USE_LEGACY_8254_TIMER=y +CONFIG_HERMES_USES_SPS_FIRMWARE=y +CONFIG_GENERIC_LINEAR_FRAMEBUFFER=y +CONFIG_SMMSTORE=y +CONFIG_SMMSTORE_V2=y +CONFIG_DEFAULT_CONSOLE_LOGLEVEL_3=y +CONFIG_POST_DEVICE_LPC=y +CONFIG_MAINBOARD_SERIAL_NUMBER="N/A" +CONFIG_PCIEXP_SUPPORT_RESIZABLE_BARS=y +CONFIG_PCIEXP_DEFAULT_MAX_RESIZABLE_BAR_BITS=36 +CONFIG_RUN_FSP_GOP=y +CONFIG_USE_EXP_X86_64_SUPPORT=y -- To view, visit https://review.coreboot.org/c/coreboot/+/69236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic62a33f8d8c3fdaa8182e797b2bf6fbed6b55731 Gerrit-Change-Number: 69236 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: Set x86_64 as supported architecture for clang
by Arthur Heymans (Code Review) 04 Nov '22

04 Nov '22

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69235 ) Change subject: Set x86_64 as supported architecture for clang ...................................................................... Set x86_64 as supported architecture for clang This boots on both qemu and real hardware now. Change-Id: Ibd320059cff575847bbf1844b5bb100312f77916 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/arch/x86/Kconfig 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/69235/1 diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index b60f600..f7f87d6 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -64,6 +64,7 @@ select ARCH_VERSTAGE_X86_64 select ARCH_ROMSTAGE_X86_64 select ARCH_RAMSTAGE_X86_64 + select ARCH_SUPPORTS_CLANG config ARCH_ALL_STAGES_X86 bool -- To view, visit https://review.coreboot.org/c/coreboot/+/69235 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd320059cff575847bbf1844b5bb100312f77916 Gerrit-Change-Number: 69235 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: soc/intel/common/xhci: Fix building for 64bit
by Arthur Heymans (Code Review) 04 Nov '22

04 Nov '22

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69234 ) Change subject: soc/intel/common/xhci: Fix building for 64bit ...................................................................... soc/intel/common/xhci: Fix building for 64bit Tested with clang on prodrive/hermes: Boots to payload Change-Id: I66392bcb4ed94c97dde43342dd29dab15d1dd9ea Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/intel/common/block/xhci/xhci.c 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/69234/1 diff --git a/src/soc/intel/common/block/xhci/xhci.c b/src/soc/intel/common/block/xhci/xhci.c index 4a40834..a12f875 100644 --- a/src/soc/intel/common/block/xhci/xhci.c +++ b/src/soc/intel/common/block/xhci/xhci.c @@ -27,7 +27,7 @@ if (mem_base == 0 || mem_base == 0xffffffff) return 0; - return (uint8_t *)(mem_base & ~PCI_BASE_ADDRESS_MEM_ATTR_MASK); + return (uint8_t *)(uintptr_t)(mem_base & ~PCI_BASE_ADDRESS_MEM_ATTR_MASK); } void xhci_host_reset(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/69234 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I66392bcb4ed94c97dde43342dd29dab15d1dd9ea Gerrit-Change-Number: 69234 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: include/cper.h: Add CPER Memory Error Section definitions
by Jonathan Zhang (Code Review) 04 Nov '22

04 Nov '22

Attention is currently required from: Johnny Lin, Angel Pons, Shuming Chu (Shuming). Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69198 ) Change subject: include/cper.h: Add CPER Memory Error Section definitions ...................................................................... Patch Set 2: (1 comment) File src/include/cper.h: https://review.coreboot.org/c/coreboot/+/69198/comment/a131ad5d_290eaa3c PS2, Line 508: /* UEFI Spec, Appendix N.2.5 Memory Error Types */ Let's add the spec version, table number, such as "IA32/X64 Processor Error Section (Table 255)"; also put it in the right sequence instead of end of the header file. -- To view, visit https://review.coreboot.org/c/coreboot/+/69198 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0a165350a16a4cbe4033a3e7c43fa23a5b27c44b Gerrit-Change-Number: 69198 Gerrit-PatchSet: 2 Gerrit-Owner: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Comment-Date: Fri, 04 Nov 2022 19:44:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/sifive/ux00ddr.h: Remove set but unused variables
by build bot (Jenkins) (Code Review) 04 Nov '22

04 Nov '22

Attention is currently required from: Arthur Heymans, Philipp Hug, ron minnich, Elyes Haouas. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63074 ) Change subject: soc/sifive/ux00ddr.h: Remove set but unused variables ...................................................................... Patch Set 14: (4 comments) File src/soc/sifive/fu540/ux00ddr.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162465): https://review.coreboot.org/c/coreboot/+/63074/comment/64508e29_6a1c22ce PS14, Line 179: /* char slicelsc = '0'; */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162465): https://review.coreboot.org/c/coreboot/+/63074/comment/81e32688_c5b526b5 PS14, Line 180: /* char slicemsc = '0'; */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162465): https://review.coreboot.org/c/coreboot/+/63074/comment/72e82a13_9009a428 PS14, Line 181: /* slicelsc += (dq % 10); */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162465): https://review.coreboot.org/c/coreboot/+/63074/comment/003028cb_eaa3a6fc PS14, Line 182: /* slicemsc += (dq / 10); */ code indent should use tabs where possible -- To view, visit https://review.coreboot.org/c/coreboot/+/63074 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I442a42e297f2968dd2c824a93a9a1e2bc74ea2f4 Gerrit-Change-Number: 63074 Gerrit-PatchSet: 14 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 04 Nov 2022 19:39:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/xeon_sp: Remove unused 'soc_chip.h' file
by Jonathan Zhang (Code Review) 04 Nov '22

04 Nov '22

Attention is currently required from: Johnny Lin, Christian Walter, Arthur Heymans, Elyes Haouas, Tim Chu. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69207 ) Change subject: soc/intel/xeon_sp: Remove unused 'soc_chip.h' file ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/xeon_sp/include/soc/soc_chip.h: https://review.coreboot.org/c/coreboot/+/69207/comment/989a0ca6_fe8b3ab0 PS1, Line 6: ../chip.h > src/soc/intel/xeon_sp/cpx/chip.h or […] Depends on which soc (cpx or skx) is defined in the .config, the appropriate chip.h is picked. -- To view, visit https://review.coreboot.org/c/coreboot/+/69207 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb968972bf55f4792ae71255aac4b87e36e395b7 Gerrit-Change-Number: 69207 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 04 Nov 2022 19:38:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: ec/starlabs/merlin: Add EC related files for Cezanne laptops
by Angel Pons (Code Review) 04 Nov '22

04 Nov '22

Attention is currently required from: Sean Rhodes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68333 ) Change subject: ec/starlabs/merlin: Add EC related files for Cezanne laptops ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68333 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I87806b830b3d58a6ce3b89f45b5a07f4502a87f3 Gerrit-Change-Number: 68333 Gerrit-PatchSet: 7 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Fri, 04 Nov 2022 19:38:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: ec/starlabs/merlin: Rename the Cezanne EC code
by Angel Pons (Code Review) 04 Nov '22

04 Nov '22

Attention is currently required from: Sean Rhodes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68319 ) Change subject: ec/starlabs/merlin: Rename the Cezanne EC code ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File src/ec/starlabs/merlin/variants/cezanne-desktop/ecdefs.h: https://review.coreboot.org/c/coreboot/+/68319/comment/0046f2b8_3fd2546d PS5, Line 10: _EC_STARLABS_CEZANNE_EC_DEFS_H Maybe rename the guards? -- To view, visit https://review.coreboot.org/c/coreboot/+/68319 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25f812cb1c6cefca1ebbe3bee5d20cf521dd60af Gerrit-Change-Number: 68319 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Fri, 04 Nov 2022 19:33:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: cpu/x86/topology: Add code to fill in topology on struct path
by Jonathan Zhang (Code Review) 04 Nov '22

04 Nov '22

Attention is currently required from: Shuming Chu (Shuming), Arthur Heymans, TangYiwei. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69222 ) Change subject: cpu/x86/topology: Add code to fill in topology on struct path ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/cpu/x86/topology.c: https://review.coreboot.org/c/coreboot/+/69222/comment/648d8568_46678071 PS1, Line 33: if (cpuid_max_func >= CPUID_EXTENDED_CPU_TOPOLOGY) Should we print the failure and die() from the caller if CB_ERR is returned? File src/include/cpu/x86/topology.h: https://review.coreboot.org/c/coreboot/+/69222/comment/2bd74c00_32e4b512 PS1, Line 5: It would be good to add a comment here to explain what this function does. -- To view, visit https://review.coreboot.org/c/coreboot/+/69222 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2210eb9b663dd90941a64132aa7154440dc7e5a9 Gerrit-Change-Number: 69222 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Reviewer: TangYiwei Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: TangYiwei Gerrit-Comment-Date: Fri, 04 Nov 2022 19:32:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022