coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: soc/intel/common: Remove the option to send EOP early
by Sean Rhodes (Code Review) 07 Nov '22

07 Nov '22

Attention is currently required from: SRIDHAR SIRICILLA, Subrata Banik, Tim Wawrzynczak, Angel Pons. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67760 ) Change subject: soc/intel/common: Remove the option to send EOP early ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > NM, I had early EOP mixed in my brain with the async EOP stuff, which was downstream only then rever […] @subrata Any feedback on this? Or could we merge PS:1 as to avoid problems in master? -- To view, visit https://review.coreboot.org/c/coreboot/+/67760 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1cdb97474ba0f37bf61f22d72cd3cc840f817652 Gerrit-Change-Number: 67760 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: SRIDHAR SIRICILLA Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: SRIDHAR SIRICILLA Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Comment-Date: Mon, 07 Nov 2022 22:31:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Tim Wawrzynczak <inforichland(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb: Add HP Memphis-S (IPM87-MP)
by Ravi Mistry (Code Review) 07 Nov '22

07 Nov '22

Attention is currently required from: Ravi Mistry. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69320 to look at the new patch set (#4). Change subject: mb: Add HP Memphis-S (IPM87-MP) ...................................................................... mb: Add HP Memphis-S (IPM87-MP) This is a µATX mainboard with a A1150 socket and two DDR3 DIMM slots. Specs: - HP Memphis-S (IPM87-MP) - Intel H87 - Macronix MX25L6473E (8MB) - Fintek F71808A - Realtek RTL8111 compatible Gigabit Tested with EDK2 payload to boot Fedora Linux 36. Working: - PCIE slots (including MINI_CARD1) - USB 2.0, 3.0 - Both DIMM slots - SATA (except mSATA) - Ethernet - VGA, DVI (libgfxinit and VBT) - S0/S3/S5 - Audio - Hardware monitor Untested: - mSATA - HOOD_SENSE - MINI_LED header - EHCI debug port, LPC debug - CMOS Change-Id: If3162fa4c60374877d9e67e9e1f6121743f03b21 Signed-off-by: Ravi Mistry <rvstry(a)protonmail.com> --- A src/mainboard/hp/memphis-s/Kconfig A src/mainboard/hp/memphis-s/Kconfig.name A src/mainboard/hp/memphis-s/Makefile.inc A src/mainboard/hp/memphis-s/acpi/ec.asl A src/mainboard/hp/memphis-s/acpi/platform.asl A src/mainboard/hp/memphis-s/acpi/superio.asl A src/mainboard/hp/memphis-s/board_info.txt A src/mainboard/hp/memphis-s/bootblock.c A src/mainboard/hp/memphis-s/cmos.default A src/mainboard/hp/memphis-s/cmos.layout A src/mainboard/hp/memphis-s/data.vbt A src/mainboard/hp/memphis-s/devicetree.cb A src/mainboard/hp/memphis-s/dsdt.asl A src/mainboard/hp/memphis-s/gma-mainboard.ads A src/mainboard/hp/memphis-s/gpio.c A src/mainboard/hp/memphis-s/hda_verb.c A src/mainboard/hp/memphis-s/romstage.c 17 files changed, 655 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/69320/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/69320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If3162fa4c60374877d9e67e9e1f6121743f03b21 Gerrit-Change-Number: 69320 Gerrit-PatchSet: 4 Gerrit-Owner: Ravi Mistry Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ravi Mistry Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: mb: Add HP Memphis-S (IPM87-MP)
by build bot (Jenkins) (Code Review) 07 Nov '22

07 Nov '22

Attention is currently required from: Ravi Mistry. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69320 ) Change subject: mb: Add HP Memphis-S (IPM87-MP) ...................................................................... Patch Set 3: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162839): https://review.coreboot.org/c/coreboot/+/69320/comment/1fe9dc49_f23e1392 PS3, Line 11: Specs: Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/69320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If3162fa4c60374877d9e67e9e1f6121743f03b21 Gerrit-Change-Number: 69320 Gerrit-PatchSet: 3 Gerrit-Owner: Ravi Mistry Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ravi Mistry Gerrit-Comment-Date: Mon, 07 Nov 2022 22:19:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: cpu/amd/agesa: Remove leftover code
by 9elements QA (Code Review) 07 Nov '22

07 Nov '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69118 ) Change subject: cpu/amd/agesa: Remove leftover code ...................................................................... Patch Set 12: Automatic boot test returned (PASS/FAIL/TOTAL): 15 / 1 / 16 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/134263 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/134262 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/134261 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/134260 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/134259 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/134258 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/134257 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/134256 FAIL: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload TianoCore : https://lava.9esec.io/r/134255 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/134254 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/134253 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/134252 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/134251 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/134250 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/134249 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/134248 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/69118 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0c082bbdb09457e3876962fa75725add11cb67c Gerrit-Change-Number: 69118 Gerrit-PatchSet: 12 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Mon, 07 Nov 2022 22:19:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb: Add HP Memphis-S (IPM87-MP)
by Ravi Mistry (Code Review) 07 Nov '22

07 Nov '22

Attention is currently required from: Ravi Mistry. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69320 to look at the new patch set (#3). Change subject: mb: Add HP Memphis-S (IPM87-MP) ...................................................................... mb: Add HP Memphis-S (IPM87-MP) This is a µATX mainboard with an LGA1150 socket and two DDR3 DIMM slots. Specs: - HP Memphis-S (IPM87-MP) - Intel H87 - Macronix MX25L6473E (8MB) - Fintek F71808A - Realtek RTL8111 compatible Gigabit Tested with EDK2 payload to boot Fedora Linux 36. Working: - PCIE slots (including MINI_CARD1) - USB 2.0, 3.0 - Both DIMM slots - SATA (except mSATA) - Ethernet - VGA, DVI (libgfxinit and VBT) - S0/S3/S5 - Audio - Hardware monitor Untested: - mSATA - HOOD_SENSE - MINI_LED header - EHCI debug port, LPC debug - CMOS Change-Id: If3162fa4c60374877d9e67e9e1f6121743f03b21 Signed-off-by: Ravi Mistry <rvstry(a)protonmail.com> --- A src/mainboard/hp/memphis-s/Kconfig A src/mainboard/hp/memphis-s/Kconfig.name A src/mainboard/hp/memphis-s/Makefile.inc A src/mainboard/hp/memphis-s/acpi/ec.asl A src/mainboard/hp/memphis-s/acpi/platform.asl A src/mainboard/hp/memphis-s/acpi/superio.asl A src/mainboard/hp/memphis-s/board_info.txt A src/mainboard/hp/memphis-s/bootblock.c A src/mainboard/hp/memphis-s/cmos.default A src/mainboard/hp/memphis-s/cmos.layout A src/mainboard/hp/memphis-s/data.vbt A src/mainboard/hp/memphis-s/devicetree.cb A src/mainboard/hp/memphis-s/dsdt.asl A src/mainboard/hp/memphis-s/gma-mainboard.ads A src/mainboard/hp/memphis-s/gpio.c A src/mainboard/hp/memphis-s/hda_verb.c A src/mainboard/hp/memphis-s/romstage.c 17 files changed, 655 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/69320/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/69320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If3162fa4c60374877d9e67e9e1f6121743f03b21 Gerrit-Change-Number: 69320 Gerrit-PatchSet: 3 Gerrit-Owner: Ravi Mistry Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ravi Mistry Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/craask: Add wifi sar table
by Reka Norman (Code Review) 07 Nov '22

07 Nov '22

Attention is currently required from: Tarun Tuli, Kangheui Won, Tim Wawrzynczak, Tyler Wang, Nick Vaccaro. Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68660 ) Change subject: mb/google/nissa/var/craask: Add wifi sar table ...................................................................... Patch Set 9: Code-Review+2 (1 comment) File src/mainboard/google/brya/variants/craask/variants.c: https://review.coreboot.org/c/coreboot/+/68660/comment/15ae7777_66713507 PS7, Line 19: WIFI_SAR_CBFS_DEFAULT_FILENAME > Update patch set 8, please help to review. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68660 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c92f0ab53ece12a97068f09241e5298909116aa Gerrit-Change-Number: 68660 Gerrit-PatchSet: 9 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Cathy Chen <cathy_chen(a)quanta.corp-partner.google.com> Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 07 Nov 2022 22:13:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Reka Norman <rekanorman(a)chromium.org> Comment-In-Reply-To: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: arch/x86/smbios.c: Allow creating entries for empty DIMM slots
by Jonathan Zhang (Code Review) 07 Nov '22

07 Nov '22

Attention is currently required from: Arthur Heymans, Marc Jones, Nico Huber, Angel Pons, lichenchen.carl, Shuming Chu (Shuming), Nill Ge. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64035 ) Change subject: arch/x86/smbios.c: Allow creating entries for empty DIMM slots ...................................................................... Patch Set 3: (1 comment) File src/arch/x86/smbios.c: https://review.coreboot.org/c/coreboot/+/64035/comment/d8ab58df_3d246257 PS3, Line 298: t->part_number = smbios_add_string(t->eos, ""); I did a test on target. A sample "dmidecode -t 17" entry for a slot with DIMM is: Handle 0x000B, DMI type 17, 40 bytes Memory Device Array Handle: 0x000A Error Information Handle: Not Provided Total Width: 80 bits Data Width: 64 bits Size: 16 GB Form Factor: RIMM Set: None Locator: DIMM_A0 Bank Locator: _Node0_Channel0_Dimm0 Type: <OUT OF SPEC> Type Detail: Synchronous Registered (Buffered) Speed: 4800 MT/s Manufacturer: Hynix Serial Number: 13a442a5 Asset Tag: DIMM_A0_AssetTag Part Number: HMCG78MEBRA107N Rank: 1 Configured Memory Speed: 4400 MT/s Minimum Voltage: 1.1 V Maximum Voltage: 1.1 V Configured Voltage: 1.1 V A sample entry for a empty slot (with this change) is: Handle 0x000C, DMI type 17, 40 bytes Memory Device Array Handle: 0x000A Error Information Handle: Not Provided Total Width: Unknown Data Width: Unknown Size: No Module Installed Form Factor: Unknown Set: None Locator: DIMM_C0 Bank Locator: _Node0_Channel2_Dimm0 Type: Unknown Type Detail: Other We can see that manufacturer, serial number, asset tag, part number fields are not even displayed for empty slot. So we could remove those 4 statements. -- To view, visit https://review.coreboot.org/c/coreboot/+/64035 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17ae83edf94483bd2eeef5524ff82721c196b8ba Gerrit-Change-Number: 64035 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nill Ge <geshijian(a)bytedance.com> Gerrit-Reviewer: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: lichenchen.carl <lichenchen.carl(a)bytedance.com> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: lichenchen.carl <lichenchen.carl(a)bytedance.com> Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Attention: Nill Ge <geshijian(a)bytedance.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 07 Nov 2022 22:10:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb: Add HP Memphis-S (IPM87-MP)
by build bot (Jenkins) (Code Review) 07 Nov '22

07 Nov '22

Attention is currently required from: Ravi Mistry. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69320 ) Change subject: mb: Add HP Memphis-S (IPM87-MP) ...................................................................... Patch Set 2: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162835): https://review.coreboot.org/c/coreboot/+/69320/comment/3f14f0fa_7e907589 PS2, Line 11: Specs: Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/69320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If3162fa4c60374877d9e67e9e1f6121743f03b21 Gerrit-Change-Number: 69320 Gerrit-PatchSet: 2 Gerrit-Owner: Ravi Mistry Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ravi Mistry Gerrit-Comment-Date: Mon, 07 Nov 2022 22:07:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb: Add HP Memphis-S (IPM87-MP)
by Ravi Mistry (Code Review) 07 Nov '22

07 Nov '22

Attention is currently required from: Ravi Mistry. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69320 to look at the new patch set (#2). Change subject: mb: Add HP Memphis-S (IPM87-MP) ...................................................................... mb: Add HP Memphis-S (IPM87-MP) This is a µATX mainboard with an LGA1150 socket and two DDR3 DIMM slots. Specs: - HP Memphis-S (IPM87-MP) - Intel H87 - Macronix MX25L6473E (8MB) - Fintek F71808A - Realtek RTL8111 compatible Gigabit Tested with EDK2 payload to boot Fedora Linux 36. Working: - PCIE slots (including MINI_CARD1) - USB 2.0, 3.0 - Both DIMM slots - SATA (except mSATA) - Ethernet - VGA, DVI (libgfxinit and VBT) - S0/S3/S5 - Audio - Hardware monitor Untested: - mSATA - HOOD_SENSE - MINI_LED header - EHCI debug port, LPC debug - CMOS Change-Id: If3162fa4c60374877d9e67e9e1f6121743f03b21 Signed-off-by: Ravi Mistry <rvstry(a)protonmail.com> --- A src/mainboard/hp/memphis-s/Kconfig A src/mainboard/hp/memphis-s/Kconfig.name A src/mainboard/hp/memphis-s/Makefile.inc A src/mainboard/hp/memphis-s/acpi/ec.asl A src/mainboard/hp/memphis-s/acpi/platform.asl A src/mainboard/hp/memphis-s/acpi/superio.asl A src/mainboard/hp/memphis-s/board_info.txt A src/mainboard/hp/memphis-s/bootblock.c A src/mainboard/hp/memphis-s/cmos.default A src/mainboard/hp/memphis-s/cmos.layout A src/mainboard/hp/memphis-s/data.vbt A src/mainboard/hp/memphis-s/devicetree.cb A src/mainboard/hp/memphis-s/dsdt.asl A src/mainboard/hp/memphis-s/gma-mainboard.ads A src/mainboard/hp/memphis-s/gpio.c A src/mainboard/hp/memphis-s/hda_verb.c A src/mainboard/hp/memphis-s/romstage.c 17 files changed, 658 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/69320/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If3162fa4c60374877d9e67e9e1f6121743f03b21 Gerrit-Change-Number: 69320 Gerrit-PatchSet: 2 Gerrit-Owner: Ravi Mistry Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ravi Mistry Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: arch/x86/smbios.c: Allow creating entries for empty DIMM slots
by Jonathan Zhang (Code Review) 07 Nov '22

07 Nov '22

Attention is currently required from: Arthur Heymans, Marc Jones, Nico Huber, Angel Pons, lichenchen.carl, Shuming Chu (Shuming), Nill Ge. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64035 ) Change subject: arch/x86/smbios.c: Allow creating entries for empty DIMM slots ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/arch/x86/smbios.c: https://review.coreboot.org/c/coreboot/+/64035/comment/521857fd_6de66194 PS1, Line 295: t->manufacturer = smbios_add_string(t->eos, "NO DIMM"); : t->serial_number = smbios_add_string(t->eos, "NO DIMM"); : t->asset_tag = smbios_add_string(t->eos, "NO DIMM"); : t->part_number = smbios_add_string(t->eos, "NO DIMM"); > We may want to fill in those fields with empty strings. Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/64035 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17ae83edf94483bd2eeef5524ff82721c196b8ba Gerrit-Change-Number: 64035 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nill Ge <geshijian(a)bytedance.com> Gerrit-Reviewer: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: lichenchen.carl <lichenchen.carl(a)bytedance.com> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: lichenchen.carl <lichenchen.carl(a)bytedance.com> Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Attention: Nill Ge <geshijian(a)bytedance.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 07 Nov 2022 21:57:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Jonathan Zhang <jonzhang(a)fb.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022