Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Matt DeVillier, Paul Menzel, Mike Banon, Fred Reitberger, Felix Held.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64892 )
Change subject: cpu/amd/family15: Use parallel_mp init
......................................................................
Patch Set 30:
(1 comment)
File src/cpu/amd/agesa/family15tn/model_15_init.c:
https://review.coreboot.org/c/coreboot/+/64892/comment/1b484e99_9325ee90
PS30, Line 77: /* DisableCf8ExtCfg */
: msr = rdmsr(NB_CFG_MSR);
: msr.hi &= ~(1 << (46 - 32));
: wrmsr(NB_CFG_MSR, msr);
Also not needed anymore
--
To view, visit https://review.coreboot.org/c/coreboot/+/64892
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33a5f93e3c2777fffb47400dfab9eedd774d3b2b
Gerrit-Change-Number: 64892
Gerrit-PatchSet: 30
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-CC: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 08 Nov 2022 12:50:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Ravi Mistry.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69320 )
Change subject: mb/hp/memphis-s: Add HP Memphis-S (IPM87-MP)
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/hp/memphis-s/romstage.c:
https://review.coreboot.org/c/coreboot/+/69320/comment/f0e69259_f4e470e4
PS6, Line 3: #include <stdint.h>
: #include <northbridge/intel/haswell/haswell.h>
: #include <northbridge/intel/haswell/raminit.h>
: #include <southbridge/intel/lynxpoint/pch.h>
Please include only what you use
--
To view, visit https://review.coreboot.org/c/coreboot/+/69320
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3162fa4c60374877d9e67e9e1f6121743f03b21
Gerrit-Change-Number: 69320
Gerrit-PatchSet: 6
Gerrit-Owner: Ravi Mistry
Gerrit-Reviewer: Ravi Mistry
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Ravi Mistry
Gerrit-Comment-Date: Tue, 08 Nov 2022 12:41:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Sean Rhodes, Paul Menzel, Tim Wawrzynczak, Angel Pons, Ben McMillen.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65785 )
Change subject: mb/starlabs/starbook: Add Alder Lake StarBook Mk VI variant
......................................................................
Patch Set 26:
(1 comment)
File src/mainboard/starlabs/starbook/variants/adl/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/65785/comment/1f6c2bfa_59478329
PS26, Line 71: u32
<stdint.h> ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/65785
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc0c265a88b19cf9e89cc8ab3e8db9abd8cf8409
Gerrit-Change-Number: 65785
Gerrit-PatchSet: 26
Gerrit-Owner: Ben McMillen <ben(a)starlabs.systems>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-CC: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Ben McMillen <ben(a)starlabs.systems>
Gerrit-Comment-Date: Tue, 08 Nov 2022 12:31:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Kangheui Won, Reka Norman, Nick Vaccaro.
Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69138 )
Change subject: mb/google/nissa/craask: Disable stylus GPIO pins based on fw_config
......................................................................
Patch Set 3:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69138
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e3a2583187c8a8e2616a5272b5a7a61debe982b
Gerrit-Change-Number: 69138
Gerrit-PatchSet: 3
Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Cathy Chen <cathy_chen(a)quanta.corp-partner.google.com>
Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-CC: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Tue, 08 Nov 2022 12:26:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Bao Zheng, Jason Glenesk, Marshall Dawson, Matt DeVillier, Zheng Bao, Martin Roth, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69150 )
Change subject: soc/amd/morgana: Add 32M support
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/amd/birman/board.fmd:
https://review.coreboot.org/c/coreboot/+/69150/comment/67741ff2_a86e4d7d
PS1, Line 1: FLASH@0xFE000000 32M {
: BIOS {
: EC 4K
: AMDFW @128K 13M
: FMAP @16M 4K
These changes should also be made on chromeos.fmd
--
To view, visit https://review.coreboot.org/c/coreboot/+/69150
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia0b5a75f828033b29c378bed9a939b23d7f19140
Gerrit-Change-Number: 69150
Gerrit-PatchSet: 1
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 08 Nov 2022 12:14:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment