Attention is currently required from: Johnny Lin, Ed Sharma, Martin Roth.
Hello build bot (Jenkins), Jonathan Zhang, Johnny Lin, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68637
to look at the new patch set (#3).
Change subject: commonlib/fsp_relocate: Fix Coverity Issues
......................................................................
commonlib/fsp_relocate: Fix Coverity Issues
Recently committed change 1df1cf9 resulted in some Coverity
reported issues. This change attempts to fix the static
analysis issues reported. The issues were reported as
comments in [CB:66819].
I have looked at all Coverity fixes before my change using
git log --oneline | grep -i coverity and then detailed
git diffs for all coverity changes. However none of them
had the same coverity errors reported as were reported
for my changes. I do not have the manner to run coverity
on my own to test my changes against coverity tests.
TESTED=
This code is tested with Intel CooperLake-SP FSP version
2.2.0.33A for DeltaLake boot
Signed-off-by: Eddie Sharma <aeddiesharma(a)fb.com>
Change-Id: I635c62929e8be9a474a91a62c29c3b5ee9b0ee64
---
M src/commonlib/fsp_relocate.c
1 file changed, 36 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/68637/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/68637
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I635c62929e8be9a474a91a62c29c3b5ee9b0ee64
Gerrit-Change-Number: 68637
Gerrit-PatchSet: 3
Gerrit-Owner: Ed Sharma <aeddiesharma(a)fb.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Ed Sharma <aeddiesharma(a)fb.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Iman Bingi.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69328
to look at the new patch set (#8).
Change subject: payloads/cbflashrom: Add new payload CBFlashrom
......................................................................
payloads/cbflashrom: Add new payload CBFlashrom
Flashrom with Graphical User Interface.
Depends on libpayload and nuklear.
Features:
* Graphical menus with scrolling.
* Text rendering engine (atm only bitmap font)
* Support for keyboard and mouse
* Support for USB and PS/2 devices
* Support for FAT32 file system (USB drives)
* Works as ELF payload
* Works as Seabios secondary payload
* Runs in qemu and on real hardware
Shortcomings:
* Doesn't work in VGA text mode
* Untested
TODO:
* Test on as many hardware/platforms as possible
Change-Id: Ib523ae9eb002f14749942137e53add4986098314
Signed-off-by: Ben Adu-Boahen <imanbingy(a)gmail.com>
---
A payloads/cbflashrom/.gitignore
A payloads/cbflashrom/Kconfig
A payloads/cbflashrom/Makefile
A payloads/cbflashrom/NuklearUI/NuklearCBFlashrom.c
A payloads/cbflashrom/NuklearUI/NuklearCBFlashrom.h
A payloads/cbflashrom/NuklearUI/NuklearCheckbox.c
A payloads/cbflashrom/NuklearUI/NuklearCheckbox.h
A payloads/cbflashrom/NuklearUI/NuklearCommon.h
A payloads/cbflashrom/NuklearUI/NuklearDataGrid.c
A payloads/cbflashrom/NuklearUI/NuklearDataGrid.h
A payloads/cbflashrom/NuklearUI/NuklearFieldFile.c
A payloads/cbflashrom/NuklearUI/NuklearFieldFile.h
A payloads/cbflashrom/NuklearUI/NuklearFieldHex.c
A payloads/cbflashrom/NuklearUI/NuklearFieldHex.h
A payloads/cbflashrom/NuklearUI/NuklearFileChooser.c
A payloads/cbflashrom/NuklearUI/NuklearFileChooser.h
A payloads/cbflashrom/NuklearUI/NuklearHex.c
A payloads/cbflashrom/NuklearUI/NuklearHex.h
A payloads/cbflashrom/NuklearUI/NuklearInput.c
A payloads/cbflashrom/NuklearUI/NuklearInput.h
A payloads/cbflashrom/NuklearUI/NuklearObject.c
A payloads/cbflashrom/NuklearUI/NuklearObject.h
A payloads/cbflashrom/NuklearUI/NuklearStyle.c
A payloads/cbflashrom/NuklearUI/NuklearStyle.h
A payloads/cbflashrom/NuklearUI/NuklearUI.h
A payloads/cbflashrom/arch/x86/cpuid.c
A payloads/cbflashrom/arch/x86/cpuid.h
A payloads/cbflashrom/arch/x86/memcpy.c
A payloads/cbflashrom/arch/x86/memcpy.h
A payloads/cbflashrom/cbflashrom.c
A payloads/cbflashrom/cbflashrom.h
A payloads/cbflashrom/flashrom/82802ab.c
A payloads/cbflashrom/flashrom/COPYING
A payloads/cbflashrom/flashrom/Doxyfile
A payloads/cbflashrom/flashrom/MAINTAINERS
A payloads/cbflashrom/flashrom/Makefile
A payloads/cbflashrom/flashrom/Makefile.include
A payloads/cbflashrom/flashrom/README
A payloads/cbflashrom/flashrom/amd_imc.c
A payloads/cbflashrom/flashrom/at45db.c
A payloads/cbflashrom/flashrom/atahpt.c
A payloads/cbflashrom/flashrom/atavia.c
A payloads/cbflashrom/flashrom/bitbang_spi.c
A payloads/cbflashrom/flashrom/board_enable.c
A payloads/cbflashrom/flashrom/buspirate_spi.c
A payloads/cbflashrom/flashrom/cbtable.c
A payloads/cbflashrom/flashrom/ch341a_spi.c
A payloads/cbflashrom/flashrom/chipset_enable.c
A payloads/cbflashrom/flashrom/cli_common.c
A payloads/cbflashrom/flashrom/cli_output.c
A payloads/cbflashrom/flashrom/custom_baud.c
A payloads/cbflashrom/flashrom/dediprog.c
A payloads/cbflashrom/flashrom/developerbox_spi.c
A payloads/cbflashrom/flashrom/digilent_spi.c
A payloads/cbflashrom/flashrom/dirtyjtag_spi.c
A payloads/cbflashrom/flashrom/dmi.c
A payloads/cbflashrom/flashrom/drkaiser.c
A payloads/cbflashrom/flashrom/edi.c
A payloads/cbflashrom/flashrom/en29lv640b.c
A payloads/cbflashrom/flashrom/flashchips.c
A payloads/cbflashrom/flashrom/flashrom.8.tmpl
A payloads/cbflashrom/flashrom/flashrom.c
A payloads/cbflashrom/flashrom/fmap.c
A payloads/cbflashrom/flashrom/ft2232_spi.c
A payloads/cbflashrom/flashrom/gfxnvidia.c
A payloads/cbflashrom/flashrom/helpers.c
A payloads/cbflashrom/flashrom/helpers_fileio.c
A payloads/cbflashrom/flashrom/hwaccess_physmap.c
A payloads/cbflashrom/flashrom/hwaccess_x86_io.c
A payloads/cbflashrom/flashrom/hwaccess_x86_msr.c
A payloads/cbflashrom/flashrom/ich_descriptors.c
A payloads/cbflashrom/flashrom/ichspi.c
A payloads/cbflashrom/flashrom/include/chipdrivers.h
A payloads/cbflashrom/flashrom/include/coreboot_tables.h
A payloads/cbflashrom/flashrom/include/custom_baud.h
A payloads/cbflashrom/flashrom/include/edi.h
A payloads/cbflashrom/flashrom/include/ene.h
A payloads/cbflashrom/flashrom/include/flash.h
A payloads/cbflashrom/flashrom/include/flashchips.h
A payloads/cbflashrom/flashrom/include/fmap.h
A payloads/cbflashrom/flashrom/include/hwaccess_physmap.h
A payloads/cbflashrom/flashrom/include/hwaccess_x86_io.h
A payloads/cbflashrom/flashrom/include/hwaccess_x86_msr.h
A payloads/cbflashrom/flashrom/include/i2c_helper.h
A payloads/cbflashrom/flashrom/include/ich_descriptors.h
A payloads/cbflashrom/flashrom/include/layout.h
A payloads/cbflashrom/flashrom/include/libflashrom.h
A payloads/cbflashrom/flashrom/include/platform.h
A payloads/cbflashrom/flashrom/include/platform/pci.h
A payloads/cbflashrom/flashrom/include/platform/swap.h
A payloads/cbflashrom/flashrom/include/programmer.h
A payloads/cbflashrom/flashrom/include/spi.h
A payloads/cbflashrom/flashrom/include/usb_device.h
A payloads/cbflashrom/flashrom/include/writeprotect.h
A payloads/cbflashrom/flashrom/internal.c
A payloads/cbflashrom/flashrom/internal.h
A payloads/cbflashrom/flashrom/it8212.c
A payloads/cbflashrom/flashrom/it87spi.c
A payloads/cbflashrom/flashrom/jedec.c
A payloads/cbflashrom/flashrom/jlink_spi.c
A payloads/cbflashrom/flashrom/known_boards.c
A payloads/cbflashrom/flashrom/layout.c
A payloads/cbflashrom/flashrom/libflashrom.c
A payloads/cbflashrom/flashrom/libflashrom.map
A payloads/cbflashrom/flashrom/mcp6x_spi.c
A payloads/cbflashrom/flashrom/meson.build
A payloads/cbflashrom/flashrom/meson_options.txt
A payloads/cbflashrom/flashrom/mstarddc_spi.c
A payloads/cbflashrom/flashrom/nic3com.c
A payloads/cbflashrom/flashrom/nicintel.c
A payloads/cbflashrom/flashrom/nicintel_eeprom.c
A payloads/cbflashrom/flashrom/nicintel_spi.c
A payloads/cbflashrom/flashrom/nicnatsemi.c
A payloads/cbflashrom/flashrom/nicrealtek.c
A payloads/cbflashrom/flashrom/ogp_spi.c
A payloads/cbflashrom/flashrom/opaque.c
A payloads/cbflashrom/flashrom/parade_lspcon.c
A payloads/cbflashrom/flashrom/parallel.c
A payloads/cbflashrom/flashrom/pcidev.c
A payloads/cbflashrom/flashrom/pickit2_spi.c
A payloads/cbflashrom/flashrom/platform/endian_big.c
A payloads/cbflashrom/flashrom/platform/endian_little.c
A payloads/cbflashrom/flashrom/platform/memaccess.c
A payloads/cbflashrom/flashrom/platform/meson.build
A payloads/cbflashrom/flashrom/pony_spi.c
A payloads/cbflashrom/flashrom/processor_enable.c
A payloads/cbflashrom/flashrom/programmer.c
A payloads/cbflashrom/flashrom/programmer_table.c
A payloads/cbflashrom/flashrom/raiden_debug_spi.c
A payloads/cbflashrom/flashrom/rayer_spi.c
A payloads/cbflashrom/flashrom/realtek_mst_i2c_spi.c
A payloads/cbflashrom/flashrom/s25f.c
A payloads/cbflashrom/flashrom/satamv.c
A payloads/cbflashrom/flashrom/satasii.c
A payloads/cbflashrom/flashrom/sb600spi.c
A payloads/cbflashrom/flashrom/serprog.c
A payloads/cbflashrom/flashrom/sfdp.c
A payloads/cbflashrom/flashrom/spi.c
A payloads/cbflashrom/flashrom/spi25.c
A payloads/cbflashrom/flashrom/spi25_statusreg.c
A payloads/cbflashrom/flashrom/spi95.c
A payloads/cbflashrom/flashrom/sst28sf040.c
A payloads/cbflashrom/flashrom/sst49lfxxxc.c
A payloads/cbflashrom/flashrom/sst_fwhub.c
A payloads/cbflashrom/flashrom/stlinkv3_spi.c
A payloads/cbflashrom/flashrom/stm50.c
A payloads/cbflashrom/flashrom/test_build.sh
A payloads/cbflashrom/flashrom/udelay.c
A payloads/cbflashrom/flashrom/usb_device.c
A payloads/cbflashrom/flashrom/usbblaster_spi.c
A payloads/cbflashrom/flashrom/usbdev.c
A payloads/cbflashrom/flashrom/w29ee011.c
A payloads/cbflashrom/flashrom/w39.c
A payloads/cbflashrom/flashrom/wbsio_spi.c
A payloads/cbflashrom/flashrom/writeprotect.c
A payloads/cbflashrom/flashrom/writeprotect_ranges.c
A payloads/cbflashrom/fsys/usbstorage.c
A payloads/cbflashrom/fsys/usbstorage.h
A payloads/cbflashrom/gfx/gfx.c
A payloads/cbflashrom/gfx/gfx.h
A payloads/cbflashrom/gfx/splash.c
A payloads/cbflashrom/gfx/splash.h
A payloads/cbflashrom/lang/en.c
A payloads/cbflashrom/lang/lang.c
A payloads/cbflashrom/lang/lang.h
A payloads/cbflashrom/libftdi/LICENSE
A payloads/cbflashrom/libftdi/src/ftdi.c
A payloads/cbflashrom/libftdi/src/ftdi.h
A payloads/cbflashrom/libftdi/src/ftdi_i.h
A payloads/cbflashrom/libftdi/src/ftdi_stream.c
A payloads/cbflashrom/libjaylink/buffer.c
A payloads/cbflashrom/libjaylink/core.c
A payloads/cbflashrom/libjaylink/device.c
A payloads/cbflashrom/libjaylink/discovery.c
A payloads/cbflashrom/libjaylink/discovery_usb.c
A payloads/cbflashrom/libjaylink/emucom.c
A payloads/cbflashrom/libjaylink/error.c
A payloads/cbflashrom/libjaylink/fileio.c
A payloads/cbflashrom/libjaylink/jtag.c
A payloads/cbflashrom/libjaylink/libjaylink-internal.h
A payloads/cbflashrom/libjaylink/libjaylink.h
A payloads/cbflashrom/libjaylink/list.c
A payloads/cbflashrom/libjaylink/log.c
A payloads/cbflashrom/libjaylink/strutil.c
A payloads/cbflashrom/libjaylink/swd.c
A payloads/cbflashrom/libjaylink/swo.c
A payloads/cbflashrom/libjaylink/target.c
A payloads/cbflashrom/libjaylink/transport.c
A payloads/cbflashrom/libjaylink/transport_usb.c
A payloads/cbflashrom/libjaylink/util.c
A payloads/cbflashrom/libusb/libusb.c
A payloads/cbflashrom/libusb/libusb.h
A payloads/cbflashrom/logo/cbui.png
A payloads/cbflashrom/lp.config
A payloads/cbflashrom/util/buffers.c
A payloads/cbflashrom/util/buffers.h
A payloads/cbflashrom/util/vector.c
A payloads/cbflashrom/util/vector.h
198 files changed, 92,841 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/69328/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/69328
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib523ae9eb002f14749942137e53add4986098314
Gerrit-Change-Number: 69328
Gerrit-PatchSet: 8
Gerrit-Owner: Iman Bingi <imanbingy(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Iman Bingi <imanbingy(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69361 )
Change subject: cpu/*: Drop PARALLEL_MP leftovers
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Patchset:
PS5:
Manual rebased, intel_sibling.c was modified on master
--
To view, visit https://review.coreboot.org/c/coreboot/+/69361
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c46c36390f116f8f8920c06e539075e60c7118c
Gerrit-Change-Number: 69361
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Wed, 09 Nov 2022 04:00:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Kyösti Mälkki, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69339 )
Change subject: Revert "mb/aopen/dxplplusu: Remove board"
......................................................................
Patch Set 5:
(9 comments)
File src/northbridge/intel/e7505/northbridge.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163052):
https://review.coreboot.org/c/coreboot/+/69339/comment/94cec7b9_66eb4776
PS5, Line 72: if (dev->path.type == DEVICE_PATH_DOMAIN) {
braces {} are not necessary for any arm of this statement
File src/northbridge/intel/e7505/raminit.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163052):
https://review.coreboot.org/c/coreboot/+/69339/comment/daf7722a_aacefa33
PS5, Line 175: while (i--) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163052):
https://review.coreboot.org/c/coreboot/+/69339/comment/bab68a96_aba16c62
PS5, Line 696: BUG();
Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163052):
https://review.coreboot.org/c/coreboot/+/69339/comment/4b97290a_047d46c7
PS5, Line 1187: if (!(dimm_mask & (1 << i))) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163052):
https://review.coreboot.org/c/coreboot/+/69339/comment/a78d8255_a4110df1
PS5, Line 1204: if (value != ERROR_SCHEME_ECC) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163052):
https://review.coreboot.org/c/coreboot/+/69339/comment/902c05a4_083057f8
PS5, Line 1274: if (sdram_width.side1 == 4) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163052):
https://review.coreboot.org/c/coreboot/+/69339/comment/a77ceee4_bc894fff
PS5, Line 1278: if (sdram_width.side2 == 4) {
braces {} are not necessary for single statement blocks
File src/southbridge/intel/i82801dx/i82801dx.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163052):
https://review.coreboot.org/c/coreboot/+/69339/comment/aba55708_2af3b029
PS5, Line 55: if (!dev->enabled) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163052):
https://review.coreboot.org/c/coreboot/+/69339/comment/b0d8b2ae_0de53bdf
PS5, Line 58: if (new_disable_mask != cur_disable_mask) {
braces {} are not necessary for single statement blocks
--
To view, visit https://review.coreboot.org/c/coreboot/+/69339
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1cd02278240d1b5d006fb2a7730d3d86390f85b
Gerrit-Change-Number: 69339
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 09 Nov 2022 03:58:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Kyösti Mälkki, Felix Held.
Hello build bot (Jenkins), Angel Pons, Arthur Heymans, Elyes Haouas, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69339
to look at the new patch set (#5).
Change subject: Revert "mb/aopen/dxplplusu: Remove board"
......................................................................
Revert "mb/aopen/dxplplusu: Remove board"
This reverts commit eb76a455cd39ec59b7f2ba28baeec9538befd59e
and applies minor fixes to make it build again.
PARALLEL_MP was working prior to board removal and no
relevant SMI handlers were implemented. So NO_SMM choice
is now selected.
Change-Id: Ia1cd02278240d1b5d006fb2a7730d3d86390f85b
Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
---
M src/arch/x86/smbios.c
M src/cpu/intel/Kconfig
M src/cpu/intel/Makefile.inc
A src/cpu/intel/model_f2x/Kconfig
A src/cpu/intel/model_f2x/Makefile.inc
A src/cpu/intel/model_f2x/model_f2x_init.c
A src/cpu/intel/socket_mPGA604/Kconfig
A src/cpu/intel/socket_mPGA604/Makefile.inc
M src/cpu/x86/Kconfig
A src/mainboard/aopen/Kconfig
A src/mainboard/aopen/Kconfig.name
A src/mainboard/aopen/dxplplusu/Kconfig
A src/mainboard/aopen/dxplplusu/Kconfig.name
A src/mainboard/aopen/dxplplusu/Makefile.inc
A src/mainboard/aopen/dxplplusu/acpi/e7505_pri.asl
A src/mainboard/aopen/dxplplusu/acpi/e7505_sec.asl
A src/mainboard/aopen/dxplplusu/acpi/i82801db.asl
A src/mainboard/aopen/dxplplusu/acpi/p64h2.asl
A src/mainboard/aopen/dxplplusu/acpi/power.asl
A src/mainboard/aopen/dxplplusu/acpi/scsi.asl
A src/mainboard/aopen/dxplplusu/acpi/superio.asl
A src/mainboard/aopen/dxplplusu/acpi_tables.c
A src/mainboard/aopen/dxplplusu/board_info.txt
A src/mainboard/aopen/dxplplusu/bootblock.c
A src/mainboard/aopen/dxplplusu/devicetree.cb
A src/mainboard/aopen/dxplplusu/dsdt.asl
A src/northbridge/intel/e7505/Kconfig
A src/northbridge/intel/e7505/Makefile.inc
A src/northbridge/intel/e7505/e7505.h
A src/northbridge/intel/e7505/memmap.c
A src/northbridge/intel/e7505/northbridge.c
A src/northbridge/intel/e7505/raminit.c
A src/northbridge/intel/e7505/raminit.h
A src/northbridge/intel/e7505/romstage.c
M src/southbridge/intel/common/smbus.c
A src/southbridge/intel/i82801dx/Kconfig
A src/southbridge/intel/i82801dx/Makefile.inc
A src/southbridge/intel/i82801dx/ac97.c
A src/southbridge/intel/i82801dx/bootblock.c
A src/southbridge/intel/i82801dx/chip.h
A src/southbridge/intel/i82801dx/early_smbus.c
A src/southbridge/intel/i82801dx/fadt.c
A src/southbridge/intel/i82801dx/i82801dx.c
A src/southbridge/intel/i82801dx/i82801dx.h
A src/southbridge/intel/i82801dx/ide.c
A src/southbridge/intel/i82801dx/lpc.c
A src/southbridge/intel/i82801dx/usb.c
A src/southbridge/intel/i82801dx/usb2.c
A src/southbridge/intel/i82870/82870.h
A src/southbridge/intel/i82870/Kconfig
A src/southbridge/intel/i82870/Makefile.inc
A src/southbridge/intel/i82870/ioapic.c
A src/southbridge/intel/i82870/pcibridge.c
M src/superio/smsc/Makefile.inc
A src/superio/smsc/lpc47m10x/Kconfig
A src/superio/smsc/lpc47m10x/Makefile.inc
A src/superio/smsc/lpc47m10x/early_serial.c
A src/superio/smsc/lpc47m10x/lpc47m10x.h
A src/superio/smsc/lpc47m10x/superio.c
59 files changed, 4,481 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/69339/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/69339
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1cd02278240d1b5d006fb2a7730d3d86390f85b
Gerrit-Change-Number: 69339
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans.
Kyösti Mälkki has uploaded a new patch set (#5) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/69361 )
Change subject: cpu/*: Drop PARALLEL_MP leftovers
......................................................................
cpu/*: Drop PARALLEL_MP leftovers
These symbols and codepaths are unused now so drop them.
Change-Id: I7c46c36390f116f8f8920c06e539075e60c7118c
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
D src/cpu/intel/hyperthreading/Makefile.inc
D src/cpu/intel/hyperthreading/intel_sibling.c
M src/cpu/intel/model_f3x/Makefile.inc
M src/cpu/intel/model_f3x/model_f3x_init.c
M src/cpu/x86/Kconfig.debug_cpu
D src/include/cpu/intel/hyperthreading.h
M src/mainboard/emulation/qemu-i440fx/northbridge.c
7 files changed, 13 insertions(+), 127 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/69361/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/69361
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c46c36390f116f8f8920c06e539075e60c7118c
Gerrit-Change-Number: 69361
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Iman Bingi.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69328
to look at the new patch set (#7).
Change subject: payloads/cbflashrom: Add new payload CBFlashrom
......................................................................
payloads/cbflashrom: Add new payload CBFlashrom
Flashrom with Graphical User Interface.
Depends on libpayload and nuklear.
Features:
* Graphical menus with scrolling.
* Text rendering engine (atm only bitmap font)
* Support for keyboard and mouse
* Support for USB and PS/2 devices
* Support for FAT32 file system (USB drives)
* Works as ELF payload
* Works as Seabios secondary payload
* Runs in qemu and on real hardware
Shortcomings:
* Doesn't work in VGA text mode
* Untested
TODO:
* Test on as many hardware/platforms as possible
Change-Id: Ib523ae9eb002f14749942137e53add4986098314
Signed-off-by: Ben Adu-Boahen <imanbingy(a)gmail.com>
---
M payloads/Kconfig
M payloads/Makefile.inc
A payloads/cbflashrom/.gitignore
A payloads/cbflashrom/Kconfig
A payloads/cbflashrom/Makefile
A payloads/cbflashrom/NuklearUI/NuklearCBFlashrom.c
A payloads/cbflashrom/NuklearUI/NuklearCBFlashrom.h
A payloads/cbflashrom/NuklearUI/NuklearCheckbox.c
A payloads/cbflashrom/NuklearUI/NuklearCheckbox.h
A payloads/cbflashrom/NuklearUI/NuklearCommon.h
A payloads/cbflashrom/NuklearUI/NuklearDataGrid.c
A payloads/cbflashrom/NuklearUI/NuklearDataGrid.h
A payloads/cbflashrom/NuklearUI/NuklearFieldFile.c
A payloads/cbflashrom/NuklearUI/NuklearFieldFile.h
A payloads/cbflashrom/NuklearUI/NuklearFieldHex.c
A payloads/cbflashrom/NuklearUI/NuklearFieldHex.h
A payloads/cbflashrom/NuklearUI/NuklearFileChooser.c
A payloads/cbflashrom/NuklearUI/NuklearFileChooser.h
A payloads/cbflashrom/NuklearUI/NuklearHex.c
A payloads/cbflashrom/NuklearUI/NuklearHex.h
A payloads/cbflashrom/NuklearUI/NuklearInput.c
A payloads/cbflashrom/NuklearUI/NuklearInput.h
A payloads/cbflashrom/NuklearUI/NuklearObject.c
A payloads/cbflashrom/NuklearUI/NuklearObject.h
A payloads/cbflashrom/NuklearUI/NuklearStyle.c
A payloads/cbflashrom/NuklearUI/NuklearStyle.h
A payloads/cbflashrom/NuklearUI/NuklearUI.h
A payloads/cbflashrom/arch/x86/cpuid.c
A payloads/cbflashrom/arch/x86/cpuid.h
A payloads/cbflashrom/arch/x86/memcpy.c
A payloads/cbflashrom/arch/x86/memcpy.h
A payloads/cbflashrom/cbflashrom.c
A payloads/cbflashrom/cbflashrom.h
A payloads/cbflashrom/flashrom/82802ab.c
A payloads/cbflashrom/flashrom/COPYING
A payloads/cbflashrom/flashrom/Doxyfile
A payloads/cbflashrom/flashrom/MAINTAINERS
A payloads/cbflashrom/flashrom/Makefile
A payloads/cbflashrom/flashrom/Makefile.include
A payloads/cbflashrom/flashrom/README
A payloads/cbflashrom/flashrom/amd_imc.c
A payloads/cbflashrom/flashrom/at45db.c
A payloads/cbflashrom/flashrom/atahpt.c
A payloads/cbflashrom/flashrom/atavia.c
A payloads/cbflashrom/flashrom/bitbang_spi.c
A payloads/cbflashrom/flashrom/board_enable.c
A payloads/cbflashrom/flashrom/buspirate_spi.c
A payloads/cbflashrom/flashrom/cbtable.c
A payloads/cbflashrom/flashrom/ch341a_spi.c
A payloads/cbflashrom/flashrom/chipset_enable.c
A payloads/cbflashrom/flashrom/cli_common.c
A payloads/cbflashrom/flashrom/cli_output.c
A payloads/cbflashrom/flashrom/custom_baud.c
A payloads/cbflashrom/flashrom/dediprog.c
A payloads/cbflashrom/flashrom/developerbox_spi.c
A payloads/cbflashrom/flashrom/digilent_spi.c
A payloads/cbflashrom/flashrom/dirtyjtag_spi.c
A payloads/cbflashrom/flashrom/dmi.c
A payloads/cbflashrom/flashrom/drkaiser.c
A payloads/cbflashrom/flashrom/edi.c
A payloads/cbflashrom/flashrom/en29lv640b.c
A payloads/cbflashrom/flashrom/flashchips.c
A payloads/cbflashrom/flashrom/flashrom.8.tmpl
A payloads/cbflashrom/flashrom/flashrom.c
A payloads/cbflashrom/flashrom/fmap.c
A payloads/cbflashrom/flashrom/ft2232_spi.c
A payloads/cbflashrom/flashrom/gfxnvidia.c
A payloads/cbflashrom/flashrom/helpers.c
A payloads/cbflashrom/flashrom/helpers_fileio.c
A payloads/cbflashrom/flashrom/hwaccess_physmap.c
A payloads/cbflashrom/flashrom/hwaccess_x86_io.c
A payloads/cbflashrom/flashrom/hwaccess_x86_msr.c
A payloads/cbflashrom/flashrom/ich_descriptors.c
A payloads/cbflashrom/flashrom/ichspi.c
A payloads/cbflashrom/flashrom/include/chipdrivers.h
A payloads/cbflashrom/flashrom/include/coreboot_tables.h
A payloads/cbflashrom/flashrom/include/custom_baud.h
A payloads/cbflashrom/flashrom/include/edi.h
A payloads/cbflashrom/flashrom/include/ene.h
A payloads/cbflashrom/flashrom/include/flash.h
A payloads/cbflashrom/flashrom/include/flashchips.h
A payloads/cbflashrom/flashrom/include/fmap.h
A payloads/cbflashrom/flashrom/include/hwaccess_physmap.h
A payloads/cbflashrom/flashrom/include/hwaccess_x86_io.h
A payloads/cbflashrom/flashrom/include/hwaccess_x86_msr.h
A payloads/cbflashrom/flashrom/include/i2c_helper.h
A payloads/cbflashrom/flashrom/include/ich_descriptors.h
A payloads/cbflashrom/flashrom/include/layout.h
A payloads/cbflashrom/flashrom/include/libflashrom.h
A payloads/cbflashrom/flashrom/include/platform.h
A payloads/cbflashrom/flashrom/include/platform/pci.h
A payloads/cbflashrom/flashrom/include/platform/swap.h
A payloads/cbflashrom/flashrom/include/programmer.h
A payloads/cbflashrom/flashrom/include/spi.h
A payloads/cbflashrom/flashrom/include/usb_device.h
A payloads/cbflashrom/flashrom/include/writeprotect.h
A payloads/cbflashrom/flashrom/internal.c
A payloads/cbflashrom/flashrom/internal.h
A payloads/cbflashrom/flashrom/it8212.c
A payloads/cbflashrom/flashrom/it87spi.c
A payloads/cbflashrom/flashrom/jedec.c
A payloads/cbflashrom/flashrom/jlink_spi.c
A payloads/cbflashrom/flashrom/known_boards.c
A payloads/cbflashrom/flashrom/layout.c
A payloads/cbflashrom/flashrom/libflashrom.c
A payloads/cbflashrom/flashrom/libflashrom.map
A payloads/cbflashrom/flashrom/mcp6x_spi.c
A payloads/cbflashrom/flashrom/meson.build
A payloads/cbflashrom/flashrom/meson_options.txt
A payloads/cbflashrom/flashrom/mstarddc_spi.c
A payloads/cbflashrom/flashrom/nic3com.c
A payloads/cbflashrom/flashrom/nicintel.c
A payloads/cbflashrom/flashrom/nicintel_eeprom.c
A payloads/cbflashrom/flashrom/nicintel_spi.c
A payloads/cbflashrom/flashrom/nicnatsemi.c
A payloads/cbflashrom/flashrom/nicrealtek.c
A payloads/cbflashrom/flashrom/ogp_spi.c
A payloads/cbflashrom/flashrom/opaque.c
A payloads/cbflashrom/flashrom/parade_lspcon.c
A payloads/cbflashrom/flashrom/parallel.c
A payloads/cbflashrom/flashrom/pcidev.c
A payloads/cbflashrom/flashrom/pickit2_spi.c
A payloads/cbflashrom/flashrom/platform/endian_big.c
A payloads/cbflashrom/flashrom/platform/endian_little.c
A payloads/cbflashrom/flashrom/platform/memaccess.c
A payloads/cbflashrom/flashrom/platform/meson.build
A payloads/cbflashrom/flashrom/pony_spi.c
A payloads/cbflashrom/flashrom/processor_enable.c
A payloads/cbflashrom/flashrom/programmer.c
A payloads/cbflashrom/flashrom/programmer_table.c
A payloads/cbflashrom/flashrom/raiden_debug_spi.c
A payloads/cbflashrom/flashrom/rayer_spi.c
A payloads/cbflashrom/flashrom/realtek_mst_i2c_spi.c
A payloads/cbflashrom/flashrom/s25f.c
A payloads/cbflashrom/flashrom/satamv.c
A payloads/cbflashrom/flashrom/satasii.c
A payloads/cbflashrom/flashrom/sb600spi.c
A payloads/cbflashrom/flashrom/serprog.c
A payloads/cbflashrom/flashrom/sfdp.c
A payloads/cbflashrom/flashrom/spi.c
A payloads/cbflashrom/flashrom/spi25.c
A payloads/cbflashrom/flashrom/spi25_statusreg.c
A payloads/cbflashrom/flashrom/spi95.c
A payloads/cbflashrom/flashrom/sst28sf040.c
A payloads/cbflashrom/flashrom/sst49lfxxxc.c
A payloads/cbflashrom/flashrom/sst_fwhub.c
A payloads/cbflashrom/flashrom/stlinkv3_spi.c
A payloads/cbflashrom/flashrom/stm50.c
A payloads/cbflashrom/flashrom/test_build.sh
A payloads/cbflashrom/flashrom/udelay.c
A payloads/cbflashrom/flashrom/usb_device.c
A payloads/cbflashrom/flashrom/usbblaster_spi.c
A payloads/cbflashrom/flashrom/usbdev.c
A payloads/cbflashrom/flashrom/w29ee011.c
A payloads/cbflashrom/flashrom/w39.c
A payloads/cbflashrom/flashrom/wbsio_spi.c
A payloads/cbflashrom/flashrom/writeprotect.c
A payloads/cbflashrom/flashrom/writeprotect_ranges.c
A payloads/cbflashrom/fsys/usbstorage.c
A payloads/cbflashrom/fsys/usbstorage.h
A payloads/cbflashrom/gfx/gfx.c
A payloads/cbflashrom/gfx/gfx.h
A payloads/cbflashrom/gfx/splash.c
A payloads/cbflashrom/gfx/splash.h
A payloads/cbflashrom/lang/en.c
A payloads/cbflashrom/lang/lang.c
A payloads/cbflashrom/lang/lang.h
A payloads/cbflashrom/libftdi/LICENSE
A payloads/cbflashrom/libftdi/src/ftdi.c
A payloads/cbflashrom/libftdi/src/ftdi.h
A payloads/cbflashrom/libftdi/src/ftdi_i.h
A payloads/cbflashrom/libftdi/src/ftdi_stream.c
A payloads/cbflashrom/libjaylink/buffer.c
A payloads/cbflashrom/libjaylink/core.c
A payloads/cbflashrom/libjaylink/device.c
A payloads/cbflashrom/libjaylink/discovery.c
A payloads/cbflashrom/libjaylink/discovery_usb.c
A payloads/cbflashrom/libjaylink/emucom.c
A payloads/cbflashrom/libjaylink/error.c
A payloads/cbflashrom/libjaylink/fileio.c
A payloads/cbflashrom/libjaylink/jtag.c
A payloads/cbflashrom/libjaylink/libjaylink-internal.h
A payloads/cbflashrom/libjaylink/libjaylink.h
A payloads/cbflashrom/libjaylink/list.c
A payloads/cbflashrom/libjaylink/log.c
A payloads/cbflashrom/libjaylink/strutil.c
A payloads/cbflashrom/libjaylink/swd.c
A payloads/cbflashrom/libjaylink/swo.c
A payloads/cbflashrom/libjaylink/target.c
A payloads/cbflashrom/libjaylink/transport.c
A payloads/cbflashrom/libjaylink/transport_usb.c
A payloads/cbflashrom/libjaylink/util.c
A payloads/cbflashrom/libusb/libusb.c
A payloads/cbflashrom/libusb/libusb.h
A payloads/cbflashrom/logo/cbui.png
A payloads/cbflashrom/lp.config
A payloads/cbflashrom/util/buffers.c
A payloads/cbflashrom/util/buffers.h
A payloads/cbflashrom/util/vector.c
A payloads/cbflashrom/util/vector.h
200 files changed, 92,858 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/69328/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/69328
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib523ae9eb002f14749942137e53add4986098314
Gerrit-Change-Number: 69328
Gerrit-PatchSet: 7
Gerrit-Owner: Iman Bingi <imanbingy(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Iman Bingi <imanbingy(a)gmail.com>
Gerrit-MessageType: newpatchset