coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: soc/intel/xeon_sp: Move SMBIOS type 4 override functions from mainboa...
by Shuming Chu (Shuming) (Code Review) 09 Nov '22

09 Nov '22

Attention is currently required from: Jonathan Zhang, Johnny Lin, Christian Walter, Shuming Chu (Shuming), Arthur Heymans. Hello build bot (Jenkins), Jonathan Zhang, Johnny Lin, Christian Walter, Jingle Hsu, Arthur Heymans, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69363 to look at the new patch set (#2). Change subject: soc/intel/xeon_sp: Move SMBIOS type 4 override functions from mainboard to soc ...................................................................... soc/intel/xeon_sp: Move SMBIOS type 4 override functions from mainboard to soc Move SMBIOS type 4 override functions from mainboard to soc so that all xeon family cpus share same functions without implementing again. Tested=On OCP Deltalake, dmidecode -t 4 shows expected info. Signed-off-by: JingleHsuWiwynn <jingle_hsu(a)wiwynn.com> Change-Id: I17df8de67bc2f5e89ea04da36efb2480a7e73174 --- M src/mainboard/ocp/deltalake/ramstage.c M src/soc/intel/xeon_sp/ramstage.c 2 files changed, 27 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/69363/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69363 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17df8de67bc2f5e89ea04da36efb2480a7e73174 Gerrit-Change-Number: 69363 Gerrit-PatchSet: 2 Gerrit-Owner: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: src/include/smbios: Add definition for smbios type 4 and type 9
by Shuming Chu (Shuming) (Code Review) 09 Nov '22

09 Nov '22

Attention is currently required from: Paul Menzel, Angel Pons, Shuming Chu (Shuming), Tim Chu. Hello build bot (Jenkins), Jonathan Zhang, Paul Menzel, Angel Pons, Angel Pons, Tim Chu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68902 to look at the new patch set (#5). Change subject: src/include/smbios: Add definition for smbios type 4 and type 9 ...................................................................... src/include/smbios: Add definition for smbios type 4 and type 9 Add definition for smbios type 4 and type 9 Signed-off-by: Tim Chu <Tim.Chu(a)quantatw.com> Change-Id: I559995b0204f8e5bdeef2c0f8b394f9011d72240 --- M src/include/smbios.h 1 file changed, 23 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/68902/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/68902 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I559995b0204f8e5bdeef2c0f8b394f9011d72240 Gerrit-Change-Number: 68902 Gerrit-PatchSet: 5 Gerrit-Owner: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/var/marasov: Generate SPD ID for supported memory parts
by Frank Chu (Code Review) 09 Nov '22

09 Nov '22

Attention is currently required from: Tarun Tuli, Kyle Lin, Frank Chu. Hello build bot (Jenkins), Tarun Tuli, Subrata Banik, Kyle Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69311 to look at the new patch set (#3). Change subject: mb/google/var/marasov: Generate SPD ID for supported memory parts ...................................................................... mb/google/var/marasov: Generate SPD ID for supported memory parts Add supported memory parts in mem_parts_used list, and generate SPD ID for these parts. DRAM Part Name ID to assign MT62F512M32D2DR-031 WT:B 0 (0000) H9JCNNNBK3MLYR-N6E 1 (0001) MT62F1G32D4DR-031 WT:B 4 (0100) H9JCNNNCP3MLYR-N6E 5 (0101) BUG=b:254365935 BRANCH=None TEST=run part_id_gen to generate SPD id Signed-off-by: Frank Chu <Frank_Chu(a)pegatron.corp-partner.google.com> Change-Id: Ifa0637b47d0017cdb9e26ed32328f4405c0df3f7 --- M src/mainboard/google/brya/variants/marasov/memory/Makefile.inc M src/mainboard/google/brya/variants/marasov/memory/dram_id.generated.txt M src/mainboard/google/brya/variants/marasov/memory/mem_parts_used.txt 3 files changed, 43 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/69311/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/69311 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifa0637b47d0017cdb9e26ed32328f4405c0df3f7 Gerrit-Change-Number: 69311 Gerrit-PatchSet: 3 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kyle Lin <kylelinck(a)google.com> Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mem_chip_info: Update to new format
by Yu-Ping Wu (Code Review) 09 Nov '22

09 Nov '22

Attention is currently required from: Hung-Te Lin, Julius Werner, Xixi Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68871 ) Change subject: mem_chip_info: Update to new format ...................................................................... Patch Set 7: (1 comment) Patchset: PS5: > @yupingso can you check if this work on corsola, and merge it before we lock down the RO? I checked and it worked as expected. I also uploaded the generated dts files to b/177917361#comment148. Julius & Xixi, you may want to double check the content. -- To view, visit https://review.coreboot.org/c/coreboot/+/68871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If34e6857439b6f6ab225344e5b4dd0ff11d8d42a Gerrit-Change-Number: 68871 Gerrit-PatchSet: 7 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-CC: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Wed, 09 Nov 2022 02:19:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: vboot: Add VBOOT_CBFS_INTEGRATION support
by 9elements QA (Code Review) 09 Nov '22

09 Nov '22

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66909 ) Change subject: vboot: Add VBOOT_CBFS_INTEGRATION support ...................................................................... Patch Set 27: Automatic boot test returned (PASS/FAIL/TOTAL): 14 / 1 / 15 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/134956 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/134955 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/134954 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/134953 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/134952 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/134951 FAIL: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/134950 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/134949 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload TianoCore : https://lava.9esec.io/r/134948 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35_SMM_TSEG and payload SeaBIOS : https://lava.9esec.io/r/134947 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload TianoCore : https://lava.9esec.io/r/134946 PASS: x86_32 "QEMU x86 q35/ich9" , build config EMULATION_QEMU_X86_Q35 and payload SeaBIOS : https://lava.9esec.io/r/134945 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/134944 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/134943 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/134941 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/66909 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40ae01c477c4e4f7a1c90e4026a8a868ae64b5ca Gerrit-Change-Number: 66909 Gerrit-PatchSet: 27 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Wed, 09 Nov 2022 01:53:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: security/tpm: make use of PCRs configurable via Kconfig
by Julius Werner (Code Review) 09 Nov '22

09 Nov '22

Attention is currently required from: Michał Żygowski, Maciej Pijanowski, Christian Walter, Krystian Hebel, Yu-Ping Wu, Sergii Dmytruk. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68750 ) Change subject: security/tpm: make use of PCRs configurable via Kconfig ...................................................................... Patch Set 4: (2 comments) File src/security/tpm/Kconfig: https://review.coreboot.org/c/coreboot/+/68750/comment/5e8cab53_e7b7eb3d PS4, Line 171: NEED_VBOOT_COMPATIBILITY As mentioned in the earlier patch I don't think we need the NEED_VBOOT_COMPATIBILITY option (and I think it's generally just a bad, unspecific name for an option). I'd recommend just using CHROMEOS here. https://review.coreboot.org/c/coreboot/+/68750/comment/83e50aa9_06d66d88 PS4, Line 172: default 1 So then boot mode and HWID are overlapping? That's probably not a good idea either... Why not just move both of these far out of the way (aren't there PCRs that are explicitly reserved for non-standard use, like 11 or 12 or something like that?), I think it would be better if we just find one new spot for both of them now where they can stay long term rather than risk having to move them again later (isn't PCR1 also standardized for something?). -- To view, visit https://review.coreboot.org/c/coreboot/+/68750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3a192d902072f6f8d415c2952a36522b5bf09f9 Gerrit-Change-Number: 68750 Gerrit-PatchSet: 4 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 09 Nov 2022 01:52:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: security/tpm: add TPM log format as per 1.2 spec
by Julius Werner (Code Review) 09 Nov '22

09 Nov '22

Attention is currently required from: Michał Żygowski, Maciej Pijanowski, Christian Walter, Krystian Hebel, Sergii Dmytruk. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68747 ) Change subject: security/tpm: add TPM log format as per 1.2 spec ...................................................................... Patch Set 4: (3 comments) File src/security/tpm/Kconfig: https://review.coreboot.org/c/coreboot/+/68747/comment/50d93059_8848b6b0 PS4, Line 105: config USE_TPM_LOG_TPM12 I don't get the point of these USE_xxx options, and it doesn't seem like you're adding any code that actually uses them? I think this could just be left as a simple menuconfig choice for now. (In general I think it's a bad idea if mainboards just randomly change the defaults for other Kconfigs, we may occasionally do that to ensure backwards compatibility but we should try not to propagate it going forward.) File src/security/tpm/tspi.h: https://review.coreboot.org/c/coreboot/+/68747/comment/31181cea_7d237fbe PS4, Line 13: #include "tpm12_log_serialized.h" I think conditional inclusion of different headers is generally a bad pattern that we should try to avoid where possible. It makes it very confusing to understand where which definition actually comes from (especially if you then start defining the same named constant with different values in different places). I know we did it with the TSS stuff as well but it was probably already a bad idea there. I think it would be better if you just include all the headers and namespaced the definitions properly so there are no collisions. (Or in the few rare cases where you actually want the same constant to be defined to different values based on Kconfig, it should be a very explicit #if block only around that one definition like for TPM_MEASURE_ALGO, not buried deep in conditionally included headers that have a few definitions which are intentionally overlapping like that and a ton that are not.) File src/security/tpm/tspi/log-tpm12.c: https://review.coreboot.org/c/coreboot/+/68747/comment/16aec382_3c7d6930 PS4, Line 59: struct tcpa_table *tcpa_log_init(void) We should avoid duplicating so much code between log implementations. I think you should put this function and the common parts of recover_tcpa_log() and tcpa_cbmem_init() into a shared file, and then have them call out to functions that are implemented by each individual log format and only concerned with the formats themselves (so that when things like how the log is migrated from SRAM to CBMEM change, we don't have to modify 3 different copies of that code). -- To view, visit https://review.coreboot.org/c/coreboot/+/68747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I89720615a75573d44dd0a39ad3d7faa78f125843 Gerrit-Change-Number: 68747 Gerrit-PatchSet: 4 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 09 Nov 2022 01:46:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: security/tpm: make log format configurable via Kconfig
by Julius Werner (Code Review) 09 Nov '22

09 Nov '22

Attention is currently required from: Tarun Tuli, Michał Żygowski, Maciej Pijanowski, Jason Nien, Subrata Banik, Christian Walter, Kapil Porwal, Tim Wawrzynczak, Nick Vaccaro, Krystian Hebel, Martin Roth, Sergii Dmytruk. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68746 ) Change subject: security/tpm: make log format configurable via Kconfig ...................................................................... Patch Set 5: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/68746/comment/dc691897_61a3bb6a PS5, Line 15: format as they are likely to depend on it. No, Google boards actually don't use measured boot and TCPA log at all (we just care about the values written directly to PCR 0 and 1 by the vboot code). The original TCPA log code was written by the 9elements guys (Philipp), I don't know who else has also been using it since (I think Werner from Siemens was also interested at some point?). If we can determine that nobody actually cares about retaining the old log format anymore (Google doesn't, at least), I'm also fine with removing support for it completely. File src/mainboard/google/asurada/Kconfig: https://review.coreboot.org/c/coreboot/+/68746/comment/82caa3cb_dfe603d2 PS5, Line 29: select NEED_VBOOT_COMPATIBILITY So since we don't use it you don't need to add this to every Google board. In general, only hardware properties should be `select`ed directly from the mainboard Kconfig, and user decisions (like which log format to use) should be left up to menuconfig anyway. File src/security/tpm/Kconfig: https://review.coreboot.org/c/coreboot/+/68746/comment/50111184_4afb895b PS3, Line 102: config USE_TPM_LOG_CB > Yes, it's required. Options defined in `choice` can't be selected directly. But I think you still shouldn't need an extra option, you could have written it like this: ``` choice prompt "TPM event log format" default TPM_LOG_CB if NEED_VBOOT_COMPATIBILITY default <something else otherwise> ``` (But we don't need it at all since as I mentioned Google boards and vboot don't care about this.) -- To view, visit https://review.coreboot.org/c/coreboot/+/68746 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3903aff54e01093bc9ea75862bbf5989cc6e6c55 Gerrit-Change-Number: 68746 Gerrit-PatchSet: 5 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 09 Nov 2022 01:45:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Krystian Hebel <krystian.hebel(a)3mdeb.com> Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: security/tpm: improve tlcl_extend() signature
by Julius Werner (Code Review) 09 Nov '22

09 Nov '22

Attention is currently required from: Erik van den Bogaert, Michał Żygowski, Maciej Pijanowski, Frans Hendriks, Christian Walter, Krystian Hebel, Sergii Dmytruk. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68745 ) Change subject: security/tpm: improve tlcl_extend() signature ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: Is this actually necessary? In CB:68748 TPM_MEASURE_ALGO is still a single constant, why not just use that? (I don't mind the removal of out_digest though.) -- To view, visit https://review.coreboot.org/c/coreboot/+/68745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I944302b502e3424c5041b17c713a867b0fc535c4 Gerrit-Change-Number: 68745 Gerrit-PatchSet: 4 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 09 Nov 2022 01:45:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya: add missing devices to DSDT
by Eran Mitrani (Code Review) 09 Nov '22

09 Nov '22

Attention is currently required from: Tarun Tuli. Hello Tarun Tuli, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69392 to look at the new patch set (#4). Change subject: mb/google/brya: add missing devices to DSDT ...................................................................... mb/google/brya: add missing devices to DSDT A previous CL ("Add missing ACPI device path names", SHA d22500f0c61f8c8e10d8f4a24e3e2bf031163c07) caused some warnings from the Kernel on Brya devices (see Tim's comment on patchset 8). This CL adds the missing devices to the DSDT to prevent those errors TEST=Built and tested on brya by verifying errors are gone. BUG=b:231582182 Change-Id: I82d53913c8da07b093e479ed8e12fda8c9990e3d Signed-off-by: Eran Mitrani <mitrani(a)google.com> --- M src/mainboard/google/brya/dsdt.asl 1 file changed, 22 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/69392/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/69392 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82d53913c8da07b093e479ed8e12fda8c9990e3d Gerrit-Change-Number: 69392 Gerrit-PatchSet: 4 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022