Attention is currently required from: Michał Żygowski, Christian Walter, Julius Werner, Sergii Dmytruk.
Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69159 )
Change subject: security/tpm: make tis_probe() return tpm_family
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/i2c/tpm/tpm.c:
https://review.coreboot.org/c/coreboot/+/69159/comment/c4b64421_dd2a5640
PS1, Line 461: *tpm_family = 1;
> Are you sure this is guaranteed? I thought I recall that 9645 can be 2. […]
TPM 2.0 for I2C does exist and it should be detected in the same way as for SPI/LPC. That being said, those tests aren't complete because they only test TIS version. Full check, regardless of bus, should be something like:
```
if (TPM_INTF_CAPABILITY.InterfaceVersion == 0)
tpm_family = 1 // (TIS <= 1.21, not used by TPM 2.0 devices)
else // (TIS 1.3, used both by TPM 1.2 and 2.0)
if (TPM_STS.tpmFamily == 0)
tpm_family = 1
else
tpm_family = 2
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/69159
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5006e0cdfef76ff79ce9e1cf280fcd5515ae01b0
Gerrit-Change-Number: 69159
Gerrit-PatchSet: 1
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Comment-Date: Thu, 10 Nov 2022 08:42:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Angel Pons, Kyösti Mälkki.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64342 )
Change subject: cpu/x86/mp_init.c: Keep track of initial lapic ID inside device_path
......................................................................
Patch Set 12:
(1 comment)
Patchset:
PS12:
Hmm with CPUINFO_V2 we might be able to be bit smarter about things. I don't think FSP is trashing %gs so we can still use the thread local storage. Currently the cpu_info() is pushed on the stack but we might as well put it in an array.
--
To view, visit https://review.coreboot.org/c/coreboot/+/64342
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d9f8d23c0b0e5c142f6907593428d8509e4e7bb
Gerrit-Change-Number: 64342
Gerrit-PatchSet: 12
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Comment-Date: Thu, 10 Nov 2022 08:41:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Raul Rangel, Tristan Corrick, Tim Wawrzynczak, Angel Pons, Alexander Couzens, Patrick Rudolph.
Arthur Heymans has uploaded a new patch set (#12) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/59314 )
Change subject: cpu/intel/haswell: Move chip_ops to cpu cluster
......................................................................
cpu/intel/haswell: Move chip_ops to cpu cluster
The cpu cluster is always present and it's the proper device to contain
the settings that need to be applied to all cpus. This makes it possible
to remove the fake lapic from devicetrees.
Change-Id: Ic449b2df8036e8c02b5559cca6b2e7479a70a786
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/cpu/intel/haswell/acpi.c
M src/cpu/intel/haswell/chip.h
M src/cpu/intel/haswell/haswell_init.c
M src/mainboard/asrock/b85m_pro4/devicetree.cb
M src/mainboard/asrock/h81m-hds/devicetree.cb
M src/mainboard/google/auron/devicetree.cb
M src/mainboard/google/auron/variants/buddy/overridetree.cb
M src/mainboard/google/auron/variants/samus/overridetree.cb
M src/mainboard/google/beltino/devicetree.cb
M src/mainboard/google/jecht/devicetree.cb
M src/mainboard/google/slippy/devicetree.cb
M src/mainboard/hp/folio_9480m/devicetree.cb
M src/mainboard/intel/baskingridge/devicetree.cb
M src/mainboard/intel/wtm2/devicetree.cb
M src/mainboard/lenovo/haswell/variants/t440p/devicetree.cb
M src/mainboard/lenovo/haswell/variants/w541/devicetree.cb
M src/mainboard/msi/h81m-p33/devicetree.cb
M src/mainboard/purism/librem_bdw/devicetree.cb
M src/mainboard/supermicro/x10slm-f/devicetree.cb
M src/northbridge/intel/haswell/northbridge.c
M src/soc/intel/broadwell/northbridge.c
21 files changed, 72 insertions(+), 138 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/59314/12
--
To view, visit https://review.coreboot.org/c/coreboot/+/59314
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic449b2df8036e8c02b5559cca6b2e7479a70a786
Gerrit-Change-Number: 59314
Gerrit-PatchSet: 12
Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Tristan Corrick <tristan(a)corrick.kiwi>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69389 )
Change subject: sb/intel/common/spi: Fix building for 64bit
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/southbridge/intel/common/spi.c:
https://review.coreboot.org/c/coreboot/+/69389/comment/601dcd15_3d5a148e
PS3, Line 161:
I'd remove this white space.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69389
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7bcb6dbf286438115c854d618eaa2da21c81400d
Gerrit-Change-Number: 69389
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Thu, 10 Nov 2022 08:34:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Held.
Hello build bot (Jenkins), Raul Rangel, Jonathon Hall,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69301
to look at the new patch set (#4).
Change subject: soc/intel/broadwell: Hook up PCI domain and CPU cluster ops to devicetree
......................................................................
soc/intel/broadwell: Hook up PCI domain and CPU cluster ops to devicetree
Change-Id: I77a333827552741453d8b575f2a8009b3e1bf8f1
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/mainboard/google/auron/devicetree.cb
M src/mainboard/google/jecht/devicetree.cb
M src/mainboard/intel/wtm2/devicetree.cb
M src/mainboard/purism/librem_bdw/devicetree.cb
M src/soc/intel/broadwell/northbridge.c
5 files changed, 20 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/69301/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/69301
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I77a333827552741453d8b575f2a8009b3e1bf8f1
Gerrit-Change-Number: 69301
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Held.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69301 )
Change subject: soc/intel/broadwell: Hook up PCI domain and CPU cluster ops to devicetree
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/auron/variants/buddy/overridetree.cb:
PS3:
> hmm, why are the cpu ops needed here, but not the domain ops? same question for the next variant
It's an override tree. Ops should not be needed.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69301
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I77a333827552741453d8b575f2a8009b3e1bf8f1
Gerrit-Change-Number: 69301
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 10 Nov 2022 08:31:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment