coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: mb/google/geralt: Fix incorrect timestamps in the eventlog
by Liju-Clr Chen (Code Review) 10 Nov '22

10 Nov '22

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yidi Lin, Yu-Ping Wu. Liju-Clr Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69432 ) Change subject: mb/google/geralt: Fix incorrect timestamps in the eventlog ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/69432/comment/85a359d8_abc7ed59 PS1, Line 7: mainboard/google/geralt > mb/google/geralt Done https://review.coreboot.org/c/coreboot/+/69432/comment/ffd5ba8a_1e333c44 PS1, Line 11: > can you attach the eventlog? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/69432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iddad102dc8d60de01a691d330deb8247e99c616a Gerrit-Change-Number: 69432 Gerrit-PatchSet: 2 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 10 Nov 2022 11:51:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/geralt: Fix incorrect timestamps in the eventlog
by Liju-Clr Chen (Code Review) 10 Nov '22

10 Nov '22

Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Yidi Lin, Yu-Ping Wu. Hello Hung-Te Lin, Rex-BC Chen, Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69432 to look at the new patch set (#2). Change subject: mb/google/geralt: Fix incorrect timestamps in the eventlog ...................................................................... mb/google/geralt: Fix incorrect timestamps in the eventlog Timestamp '2000-00-00 00:00:00' is considered as the invalid format. Enable RTC to fix incorrect timestamp format in the eventlog. BUG=b:233720142 TEST=check the timestamp field in /var/log/eventlog.txt localhost ~ # head /var/log/eventlog.txt 0 | 2022-10-15 22:59:38 | Log area cleared | 4088 1 | 2022-10-15 22:59:38 | Memory Cache Update | Normal | Success 2 | 2022-10-15 22:59:45 | System boot | 0 3 | 2022-10-15 22:59:46 | Firmware vboot info | boot_mode=Developer | fw_tried=A | fw_try_count=0 | fw_prev_tried=A | fw_prev_result=Unknown localhost ~ # localhost ~ # date Sun Oct 16 01:42:59 PDT 2022 localhost ~ # Change-Id: Iddad102dc8d60de01a691d330deb8247e99c616a Signed-off-by: Liju-Clr Chen <liju-clr.chen(a)mediatek.com> --- M src/mainboard/google/geralt/Kconfig M src/soc/mediatek/mt8188/Makefile.inc 2 files changed, 29 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/69432/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iddad102dc8d60de01a691d330deb8247e99c616a Gerrit-Change-Number: 69432 Gerrit-PatchSet: 2 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mainboard/google/geralt: Fix incorrect timestamps in the eventlog
by Rex-BC Chen (Code Review) 10 Nov '22

10 Nov '22

Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Yidi Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69432 ) Change subject: mainboard/google/geralt: Fix incorrect timestamps in the eventlog ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: please also rebase your local branch to latest coreboot tot -- To view, visit https://review.coreboot.org/c/coreboot/+/69432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iddad102dc8d60de01a691d330deb8247e99c616a Gerrit-Change-Number: 69432 Gerrit-PatchSet: 1 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 10 Nov 2022 11:12:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/amd/mendocino: Enhance DPTC_INPUT to support 13 DPTC thermal para...
by EricKY Cheng (Code Review) 10 Nov '22

10 Nov '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Jason Nien, Matt DeVillier, Tim Van Patten, Fred Reitberger, Felix Held. EricKY Cheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68649 ) Change subject: soc/amd/mendocino: Enhance DPTC_INPUT to support 13 DPTC thermal parameters ...................................................................... Patch Set 22: (1 comment) File src/soc/amd/mendocino/root_complex.c: https://review.coreboot.org/c/coreboot/+/68649/comment/9303d429_cd0c4172 PS16, Line 393: #else > > I assume below behavior is your suggestion? […] Update the code change after consulting AMD 1. Use #if (CONFIG(FEATURE_DYNAMIC_DPTC)) to include tables B through F. 2. Default Table A and no battery table use the Enhance DPTC_INPUT. 3. Support Enhance DPTC_INPUT structure directly, don't support old DPTC_INPUTS structure. 4. The update code change and design need to be verified by AMD and Google. Hi AMD, Since many default and low/now battery entries duplicated, do we need to expand the parameters for low/now battery in chip.h? -- To view, visit https://review.coreboot.org/c/coreboot/+/68649 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d6a00f0eca0b0941860b9bc75da41d7a10d60e8 Gerrit-Change-Number: 68649 Gerrit-PatchSet: 22 Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 10 Nov 2022 10:57:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mainboard/google/geralt: Fix incorrect timestamps in the eventlog
by Rex-BC Chen (Code Review) 10 Nov '22

10 Nov '22

Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Yidi Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69432 ) Change subject: mainboard/google/geralt: Fix incorrect timestamps in the eventlog ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/69432/comment/813a767f_5028165a PS1, Line 11: can you attach the eventlog? -- To view, visit https://review.coreboot.org/c/coreboot/+/69432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iddad102dc8d60de01a691d330deb8247e99c616a Gerrit-Change-Number: 69432 Gerrit-PatchSet: 1 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 10 Nov 2022 10:53:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mainboard/google/geralt: Fix incorrect timestamps in the eventlog
by Rex-BC Chen (Code Review) 10 Nov '22

10 Nov '22

Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Yidi Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69432 ) Change subject: mainboard/google/geralt: Fix incorrect timestamps in the eventlog ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/69432/comment/cfe17964_5f4b13f6 PS1, Line 7: mainboard/google/geralt mb/google/geralt -- To view, visit https://review.coreboot.org/c/coreboot/+/69432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iddad102dc8d60de01a691d330deb8247e99c616a Gerrit-Change-Number: 69432 Gerrit-PatchSet: 1 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 10 Nov 2022 10:52:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/nissa/pujjo: Modify touch screen hid to ELAN901C
by Leo Chou (Code Review) 10 Nov '22

10 Nov '22

Attention is currently required from: Tarun Tuli, Reka Norman, Shou-Chieh Hsu. Hello Tarun Tuli, Reka Norman, Shou-Chieh Hsu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69430 to look at the new patch set (#2). Change subject: mb/google/nissa/pujjo: Modify touch screen hid to ELAN901C ...................................................................... mb/google/nissa/pujjo: Modify touch screen hid to ELAN901C Modify touch screen hid for Pujjo board. BUG=b:258586760 TEST=Use the value to boot on Pujjo successfully. Signed-off-by: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Change-Id: Ia3b374de8cba2125c478814a1890a4b6831715b9 --- M src/mainboard/google/brya/variants/pujjo/overridetree.cb 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/69430/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69430 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia3b374de8cba2125c478814a1890a4b6831715b9 Gerrit-Change-Number: 69430 Gerrit-PatchSet: 2 Gerrit-Owner: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-CC: Jynn Chen <jynn.chen(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin3 Yang <Kevin3.Yang(a)lcfuturecenter.com> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: drivers/phy/m88e1512: Provide functionality to customize LED status
by build bot (Jenkins) (Code Review) 10 Nov '22

10 Nov '22

Attention is currently required from: Werner Zeh. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69386 ) Change subject: drivers/phy/m88e1512: Provide functionality to customize LED status ...................................................................... Patch Set 8: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163187): https://review.coreboot.org/c/coreboot/+/69386/comment/85ac454b_de07398c PS8, Line 14: https://web.archive.org/web/20221109080111/https://www.marvell.com/content/… Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/69386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia71c43f4286f9201f03cb759252ebb405ab81904 Gerrit-Change-Number: 69386 Gerrit-PatchSet: 8 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Thu, 10 Nov 2022 09:28:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/siemens/mc_ehl2: Enable Marvell PHY interrupt
by Mario Scheithauer (Code Review) 10 Nov '22

10 Nov '22

Attention is currently required from: Werner Zeh. Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69434 ) Change subject: mb/siemens/mc_ehl2: Enable Marvell PHY interrupt ...................................................................... mb/siemens/mc_ehl2: Enable Marvell PHY interrupt On this mainboard Marvell PHY INTn is routed to LED[2] pin. Change-Id: I28a78afdcf0599bb998f906ce8056a0586e24f33 Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> --- M src/mainboard/siemens/mc_ehl/variants/mc_ehl2/devicetree.cb 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/69434/1 diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/devicetree.cb b/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/devicetree.cb index b61ea52..46eedbf 100644 --- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/devicetree.cb +++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl2/devicetree.cb @@ -194,6 +194,8 @@ register "led_0_ctrl" = "7" # LED[1]: On - Link, Blink - Activity, Off - No Link register "led_1_ctrl" = "1" + # INTn is routed to LED[2] pin + register "enable_int" = "true" device pnp 0.0 on end # PHY address end end @@ -205,6 +207,8 @@ register "led_0_ctrl" = "7" # LED[1]: On - Link, Blink - Activity, Off - No Link register "led_1_ctrl" = "1" + # INTn is routed to LED[2] pin + register "enable_int" = "true" device pnp 0.1 on end # PHY address end end @@ -219,6 +223,8 @@ register "led_0_ctrl" = "7" # LED[1]: On - Link, Blink - Activity, Off - No Link register "led_1_ctrl" = "1" + # INTn is routed to LED[2] pin + register "enable_int" = "true" device pnp 1.1 on end # PHY address end end -- To view, visit https://review.coreboot.org/c/coreboot/+/69434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I28a78afdcf0599bb998f906ce8056a0586e24f33 Gerrit-Change-Number: 69434 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: drivers/phy/m88e1512: Add interrupt enable
by Mario Scheithauer (Code Review) 10 Nov '22

10 Nov '22

Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69433 ) Change subject: drivers/phy/m88e1512: Add interrupt enable ...................................................................... drivers/phy/m88e1512: Add interrupt enable INTn on Marvell PHY can be routed to LED[2] pin. This setting must be made via LED Timer Control Register on page 3. Change-Id: Ida1efbb604c382676b9d13ac8bf14de768f93637 Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> --- M src/drivers/phy/m88e1512/chip.h M src/drivers/phy/m88e1512/m88e1512.c M src/drivers/phy/m88e1512/m88e1512.h 3 files changed, 42 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/69433/1 diff --git a/src/drivers/phy/m88e1512/chip.h b/src/drivers/phy/m88e1512/chip.h index d30923a..cd66217 100644 --- a/src/drivers/phy/m88e1512/chip.h +++ b/src/drivers/phy/m88e1512/chip.h @@ -7,4 +7,5 @@ unsigned char led_0_ctrl; /* LED[0] Control */ unsigned char led_1_ctrl; /* LED[1] Control */ unsigned char led_2_ctrl; /* LED[2] Control */ + bool enable_int; /* INTn can be routed to LED[2] pin */ }; diff --git a/src/drivers/phy/m88e1512/m88e1512.c b/src/drivers/phy/m88e1512/m88e1512.c index aadd593..ba927f4 100644 --- a/src/drivers/phy/m88e1512/m88e1512.c +++ b/src/drivers/phy/m88e1512/m88e1512.c @@ -8,6 +8,12 @@ #include "chip.h" #include "m88e1512.h" +static void switch_page(struct device *dev, const struct mdio_operations *mdio_ops, + uint8_t phy_adr, uint8_t page) +{ + mdio_ops->write(dev, phy_adr, PAGE_REG, page); +} + static void m88e1512_init(struct device *dev) { const struct mdio_operations *mdio_ops; @@ -25,7 +31,7 @@ dev_path(parent), dev->chip_ops->name); /* Select page 3 to access LED function control register. */ - mdio_ops->write(parent, dev->path.pnp.device, PAGE_REG, 3); + switch_page(parent, mdio_ops, dev->path.pnp.device, 3); /* Modify PHY LED mode. */ page_reg = mdio_ops->read(parent, dev->path.pnp.device, LED_FUNC_CTRL_REG); @@ -34,7 +40,25 @@ mdio_ops->write(parent, dev->path.pnp.device, LED_FUNC_CTRL_REG, page_reg); /* Switch back to page 0. */ - mdio_ops->write(parent, dev->path.pnp.device, PAGE_REG, 0); + switch_page(parent, mdio_ops, dev->path.pnp.device, 0); + } + + /* INTn can be routed to LED[2] pin. */ + if (config->enable_int) { + printk(BIOS_DEBUG, "%s: INTn is routed to LED[2] pin %s.\n", + dev_path(parent), dev->chip_ops->name); + + /* Select page 3 to access LED function control register. */ + switch_page(parent, mdio_ops, dev->path.pnp.device, 3); + + page_reg = mdio_ops->read(parent, dev->path.pnp.device, + LED_TIMER_CTRL_REG); + setbits16(&page_reg, LED_IRQ_ENABLE); + mdio_ops->write(parent, dev->path.pnp.device, LED_TIMER_CTRL_REG, + page_reg); + + /* Switch back to page 0. */ + switch_page(parent, mdio_ops, dev->path.pnp.device, 0); } } diff --git a/src/drivers/phy/m88e1512/m88e1512.h b/src/drivers/phy/m88e1512/m88e1512.h index 36e3279..ca0f756 100644 --- a/src/drivers/phy/m88e1512/m88e1512.h +++ b/src/drivers/phy/m88e1512/m88e1512.h @@ -7,5 +7,7 @@ #define PAGE_REG 0x16 #define LED_FUNC_CTRL_REG 0x10 #define LED_FUNC_CTRL_MASK 0x0FFF +#define LED_TIMER_CTRL_REG 0x12 +#define LED_IRQ_ENABLE (1 << 7) #endif /* _PHY_M88E1512_H_ */ -- To view, visit https://review.coreboot.org/c/coreboot/+/69433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida1efbb604c382676b9d13ac8bf14de768f93637 Gerrit-Change-Number: 69433 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022