coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: ec/google/chromeec: Simplify KEYBOARD_BACKLIGHT error handling
by Martin L Roth (Code Review) 10 Nov '22

10 Nov '22

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69369 ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: ec/google/chromeec: Simplify KEYBOARD_BACKLIGHT error handling ...................................................................... ec/google/chromeec: Simplify KEYBOARD_BACKLIGHT error handling Simplify the implementation of setting the keyboard backlight PWM value. Host command stubs typcially don't need to examine the host command's return value as stored in cmd_code because that level of detail is not very interesting. Higher value error codes are returned in actual result structures. This host command can return EC_RES_ERROR for out of range PWM values which is already a generic error and unlikely to happen since we already limit the range to 0..100 here. Finally, none of the callers in coreboot check the return value. BUG=b:258126464 BRANCH=none TEST=none Change-Id: If17bc4e31baba02ba2f7ae8e7a5cbec7f97688c5 Signed-off-by: Caveh Jalali <caveh(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69369 Reviewed-by: Daisuke Nojiri <dnojiri(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/ec/google/chromeec/ec.c 1 file changed, 32 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Daisuke Nojiri: Looks good to me, approved diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index b609559..3afe840 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -87,10 +87,10 @@ .cmd_dev_index = 0, }; - google_chromeec_command(&cmd); - printk(BIOS_DEBUG, "Google Chrome set keyboard backlight: status (%x)\n", - cmd.cmd_code); - return cmd.cmd_code; + if (google_chromeec_command(&cmd) != 0) + return -1; + + return 0; } void google_chromeec_post(uint8_t postcode) -- To view, visit https://review.coreboot.org/c/coreboot/+/69369 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If17bc4e31baba02ba2f7ae8e7a5cbec7f97688c5 Gerrit-Change-Number: 69369 Gerrit-PatchSet: 4 Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: ec/google/chromeec: Fix keyboard_backlight call
by Martin L Roth (Code Review) 10 Nov '22

10 Nov '22

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69368 ) Change subject: ec/google/chromeec: Fix keyboard_backlight call ...................................................................... ec/google/chromeec: Fix keyboard_backlight call The EC_CMD_PWM_SET_KEYBOARD_BACKLIGHT command does not return data, so don't specify a result buffer. BUG=b:258126464 BRANCH=none TEST=none Change-Id: I5b9a0d228e187a9337498246a3b9ed8db07b95c7 Signed-off-by: Caveh Jalali <caveh(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69368 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Daisuke Nojiri <dnojiri(a)chromium.org> --- M src/ec/google/chromeec/ec.c 1 file changed, 24 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Daisuke Nojiri: Looks good to me, approved diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index 1fa59069..b609559 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -77,20 +77,19 @@ struct ec_params_pwm_set_keyboard_backlight params = { .percent = percent % 101, }; - struct ec_response_pwm_get_keyboard_backlight resp = {}; struct chromeec_command cmd = { .cmd_code = EC_CMD_PWM_SET_KEYBOARD_BACKLIGHT, .cmd_version = 0, .cmd_data_in = &params, - .cmd_data_out = &resp, + .cmd_data_out = NULL, .cmd_size_in = sizeof(params), - .cmd_size_out = sizeof(resp), + .cmd_size_out = 0, .cmd_dev_index = 0, }; google_chromeec_command(&cmd); - printk(BIOS_DEBUG, "Google Chrome set keyboard backlight: %x status (%x)\n", - resp.percent, cmd.cmd_code); + printk(BIOS_DEBUG, "Google Chrome set keyboard backlight: status (%x)\n", + cmd.cmd_code); return cmd.cmd_code; } -- To view, visit https://review.coreboot.org/c/coreboot/+/69368 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b9a0d228e187a9337498246a3b9ed8db07b95c7 Gerrit-Change-Number: 69368 Gerrit-PatchSet: 4 Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: google/chromeec: Add ACPI method for EC Panic
by Martin L Roth (Code Review) 10 Nov '22

10 Nov '22

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69391 ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: google/chromeec: Add ACPI method for EC Panic ...................................................................... google/chromeec: Add ACPI method for EC Panic Add an ACPI method to handle EC_HOST_EVENT_PANIC (bit 24) events. EC panic is not covered by the standard (0-F) ACPI notify values. Arbitrarily choosing B0 notify, which is in the 84-BF device specific ACPI notify range. This will be a no-op until the kernel driver is also updated to handle this event. BUG=b:258195448 BRANCH=None TEST=Observe event with modified cros_ec_lpc driver Signed-off-by: Rob Barnes <robbarnes(a)google.com> Change-Id: Iafa642c1c50f9a0083a8e618e1eabec9a7ce39b4 Reviewed-on: https://review.coreboot.org/c/coreboot/+/69391 Reviewed-by: Raul Rangel <rrangel(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/ec/google/chromeec/acpi/ec.asl 1 file changed, 35 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl index 3200902..e4637b3 100644 --- a/src/ec/google/chromeec/acpi/ec.asl +++ b/src/ec/google/chromeec/acpi/ec.asl @@ -12,6 +12,8 @@ #define EC_OEM_VARIABLE_DATA_MASK 0x7 #define INT3400_ODVP_CHANGED 0x88 +#define ACPI_NOTIFY_CROS_EC_PANIC 0xB0 + // Mainboard specific throttle handler #ifdef DPTF_ENABLE_CHARGER External (\_SB.DPTF.TCHG, DeviceObj) @@ -409,6 +411,13 @@ \PNOT () } + // EC Panic + Method (_Q18, 0, NotSerialized) + { + Printf ("EC: PANIC") + Notify (CREC, ACPI_NOTIFY_CROS_EC_PANIC) + } + // MKBP interrupt. Method (_Q1B, 0, NotSerialized) { -- To view, visit https://review.coreboot.org/c/coreboot/+/69391 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iafa642c1c50f9a0083a8e618e1eabec9a7ce39b4 Gerrit-Change-Number: 69391 Gerrit-PatchSet: 5 Gerrit-Owner: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Fix set but unused variable
by Paul Menzel (Code Review) 10 Nov '22

10 Nov '22

Attention is currently required from: Tarun Tuli, Martin L Roth, Subrata Banik, Kapil Porwal, Angel Pons, Arthur Heymans, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66264 ) Change subject: soc/intel/meteorlake: Fix set but unused variable ...................................................................... Patch Set 6: Code-Review+1 (1 comment) File src/soc/intel/meteorlake/systemagent.c: https://review.coreboot.org/c/coreboot/+/66264/comment/a0a0edaa_c69a50aa PS6, Line 86: line commented -- To view, visit https://review.coreboot.org/c/coreboot/+/66264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe1de3057c17b4aa8ecbd87fac598e43294584e3 Gerrit-Change-Number: 66264 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 10 Nov 2022 14:44:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: drivers/ipmi/ocp: Fix building with clang
by Paul Menzel (Code Review) 10 Nov '22

10 Nov '22

Attention is currently required from: Arthur Heymans. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69437 ) Change subject: drivers/ipmi/ocp: Fix building with clang ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/69437/comment/908d4416_38d82f20 PS1, Line 7: Fix building with clang Maybe more specific? Something like: > Use explicit comparison in if condition -- To view, visit https://review.coreboot.org/c/coreboot/+/69437 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9a2f03a0e05088a780ce1e829859421b461032ca Gerrit-Change-Number: 69437 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 10 Nov 2022 14:43:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/geralt: Fix incorrect timestamps in the eventlog
by Yidi Lin (Code Review) 10 Nov '22

10 Nov '22

Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Rex-BC Chen, Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69432 ) Change subject: mb/google/geralt: Fix incorrect timestamps in the eventlog ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/69432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iddad102dc8d60de01a691d330deb8247e99c616a Gerrit-Change-Number: 69432 Gerrit-PatchSet: 3 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 10 Nov 2022 14:34:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: [TESTONLY] Disable IPU
by Krishna P Bhat D (Code Review) 10 Nov '22

10 Nov '22

Krishna P Bhat D has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69438 ) Change subject: [TESTONLY] Disable IPU ...................................................................... [TESTONLY] Disable IPU Change-Id: Iba1d0e53acb0a1b10923b06bc5967ce8a159961d Signed-off-by: Krishna Prasad Bhat <krishna.p.bhat.d(a)intel.com> --- M src/mainboard/google/brya/variants/craask/overridetree.cb 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/69438/1 diff --git a/src/mainboard/google/brya/variants/craask/overridetree.cb b/src/mainboard/google/brya/variants/craask/overridetree.cb index 57f4306e..92d81fe 100644 --- a/src/mainboard/google/brya/variants/craask/overridetree.cb +++ b/src/mainboard/google/brya/variants/craask/overridetree.cb @@ -175,7 +175,7 @@ device generic 0 on end end end - device ref ipu on + device ref ipu off chip drivers/intel/mipi_camera register "acpi_uid" = "0x50000" register "acpi_name" = ""IPU0"" -- To view, visit https://review.coreboot.org/c/coreboot/+/69438 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iba1d0e53acb0a1b10923b06bc5967ce8a159961d Gerrit-Change-Number: 69438 Gerrit-PatchSet: 1 Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: drivers/ipmi/ocp: Fix building with clang
by Arthur Heymans (Code Review) 10 Nov '22

10 Nov '22

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69437 ) Change subject: drivers/ipmi/ocp: Fix building with clang ...................................................................... drivers/ipmi/ocp: Fix building with clang Fix the following warning: error: use of logical '&&' with constant operand [-Werror,-Wconstant-logical-operand] Change-Id: I9a2f03a0e05088a780ce1e829859421b461032ca Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/drivers/ipmi/ocp/ipmi_sel.c 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/69437/1 diff --git a/src/drivers/ipmi/ocp/ipmi_sel.c b/src/drivers/ipmi/ocp/ipmi_sel.c index b10755f..f7605ec 100644 --- a/src/drivers/ipmi/ocp/ipmi_sel.c +++ b/src/drivers/ipmi/ocp/ipmi_sel.c @@ -105,7 +105,7 @@ { struct ipmi_config_rsp rsp = {.slot_id = UINT8_MAX}; - if (CONFIG(IPMI_KCS) && CONFIG_BMC_KCS_BASE) { + if (CONFIG(IPMI_KCS) && CONFIG_BMC_KCS_BASE != 0) { if (ipmi_get_board_config(CONFIG_BMC_KCS_BASE, &rsp) != CB_SUCCESS) return UINT8_MAX; } -- To view, visit https://review.coreboot.org/c/coreboot/+/69437 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9a2f03a0e05088a780ce1e829859421b461032ca Gerrit-Change-Number: 69437 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: amdfwtool: Add definition of instance for PSP entry
by build bot (Jenkins) (Code Review) 10 Nov '22

10 Nov '22

Attention is currently required from: Jason Glenesk, Marshall Dawson, Matt DeVillier, Zheng Bao, Martin Roth, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69044 ) Change subject: amdfwtool: Add definition of instance for PSP entry ...................................................................... Patch Set 5: (1 comment) File util/amdfwtool/amdfwtool.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163210): https://review.coreboot.org/c/coreboot/+/69044/comment/d85a4dab_d1b2937a PS5, Line 166: } __attribute__((packed)); Prefer __packed over __attribute__((packed)) -- To view, visit https://review.coreboot.org/c/coreboot/+/69044 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9f6250fd0e26cfae2cc2128ca9413a5621d2df0c Gerrit-Change-Number: 69044 Gerrit-PatchSet: 5 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 10 Nov 2022 13:46:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: amdfwtool: Set the base address of AMDFW as relative
by build bot (Jenkins) (Code Review) 10 Nov '22

10 Nov '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Zheng Bao, Fred Reitberger, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69429 ) Change subject: amdfwtool: Set the base address of AMDFW as relative ...................................................................... Patch Set 2: (7 comments) File util/amdfwtool/amdfwtool.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163208): https://review.coreboot.org/c/coreboot/+/69429/comment/42c80e63_6f9f95f8 PS2, Line 2294: case 0: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163208): https://review.coreboot.org/c/coreboot/+/69429/comment/c30a768b_879844e8 PS2, Line 2295: case 0xFA0000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163208): https://review.coreboot.org/c/coreboot/+/69429/comment/4fe2a625_ac09b6ad PS2, Line 2296: case 0xF20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163208): https://review.coreboot.org/c/coreboot/+/69429/comment/5db7f1a0_248495c1 PS2, Line 2297: case 0xE20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163208): https://review.coreboot.org/c/coreboot/+/69429/comment/0bd288f2_01bbc677 PS2, Line 2298: case 0xC20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163208): https://review.coreboot.org/c/coreboot/+/69429/comment/d8915a49_1bf88d98 PS2, Line 2299: case 0x820000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163208): https://review.coreboot.org/c/coreboot/+/69429/comment/5af91aa1_9d97eec1 PS2, Line 2300: case 0x020000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment -- To view, visit https://review.coreboot.org/c/coreboot/+/69429 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If6fd5b21be90ac37618c484506db9b8a1e350ea2 Gerrit-Change-Number: 69429 Gerrit-PatchSet: 2 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 10 Nov 2022 13:46:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022