coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: drivers/fsp2: Don't die if the FSP signature doesn't match
by Martin Roth (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Jason Glenesk, Martin L Roth, Subrata Banik, Eric Lai, Andrey Petrov, Fred Reitberger, Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69412 ) Change subject: drivers/fsp2: Don't die if the FSP signature doesn't match ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: > > coreboot should not (and honestly cannot) be responsible for issues inside the FSP. […] Whether or not the FSP actually does the check is kind of beside the point to me. If it's the completely wrong FSP, presumably it's going to come across an error somewhere and die on it's own, or return to coreboot with an error. OR, if somehow it makes it through with no errors, but didn't configure things properly, coreboot will likely die somewhere else.. So either it's compatible enough to run, or something else will cause the boot to die without us needing to die here. File src/drivers/intel/fsp2_0/util.c: https://review.coreboot.org/c/coreboot/+/69412/comment/6c7a3958_05495aed PS3, Line 177: If it doesn't match, the : FSP binaries in CBFS are for a different platform than the platform code trying to use it > > Sorry, I think I'm missing your point here. How is this coreboot's responsibility? […] No, AMD isn't going to use a generic UPD ID. We have an issue where we're changing the UPD id right now which is what prompted me to look at this, but honestly I just don't think it's a good use of die(). I think die() should be used when the platform can't continue. Not when it thinks "there might be an error if I continue running, so let's halt now." The exception is if there's a security risk if we continue, and even then, i think there should be a way to continue booting so that firmware can be updated for example. Trying to run from memory and there's no memory? Yep, perfect place to die. The system literally cannot continue running. But this die call is just not needed. Sure, we can print a warning, but coreboot should try to continue booting. -- To view, visit https://review.coreboot.org/c/coreboot/+/69412 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I12aca7cad3298ac36b1fed09efaa190c958cf126 Gerrit-Change-Number: 69412 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 15 Nov 2022 16:09:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: WIP:soc/amd/morgana: Move PSP FWs to 0x20000
by Bao Zheng (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Jason Glenesk, Matt DeVillier, Zheng Bao, Martin Roth, Fred Reitberger, Felix Held. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69470 ) Change subject: WIP:soc/amd/morgana: Move PSP FWs to 0x20000 ...................................................................... Patch Set 2: (1 comment) File src/mainboard/amd/birman/Kconfig: https://review.coreboot.org/c/coreboot/+/69470/comment/ac5a8437_1e183478 PS2, Line 31: default 5 > for chromeos we didn't use the first possible efs location (which is the soc default) so that it res […] Ack. Now the Morgana requires the EFS is located at 0x20000 without other options. -- To view, visit https://review.coreboot.org/c/coreboot/+/69470 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b1c7f9a7488a4d5ef94f21099692a23c3f8d27c Gerrit-Change-Number: 69470 Gerrit-PatchSet: 2 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Zheng Bao Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 15 Nov 2022 15:54:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: nb/amd/pi/Kconfig: Drop unused Kconfig symbol
by Michael Niewöhner (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Elyes Haouas. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69333 ) Change subject: nb/amd/pi/Kconfig: Drop unused Kconfig symbol ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69333 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I713b3fed3fc6d55139badec93a67943dd93ced2a Gerrit-Change-Number: 69333 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 15 Nov 2022 15:53:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common/block/smbus/Kconfig: Drop unused Kconfig symbol
by Michael Niewöhner (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Elyes Haouas. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69331 ) Change subject: soc/intel/common/block/smbus/Kconfig: Drop unused Kconfig symbol ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: it's unused bc CB:44507 is still in review -- To view, visit https://review.coreboot.org/c/coreboot/+/69331 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic46e1663609068439069f666beca17ed76c679f0 Gerrit-Change-Number: 69331 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 15 Nov 2022 15:53:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common/block/sgx/Kconfig: Add missing default symbol
by Michael Niewöhner (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Nico Huber, Elyes Haouas. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69332 ) Change subject: soc/intel/common/block/sgx/Kconfig: Add missing default symbol ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Patchset: PS3: > Looking at the commit message of the last change there, I think […] I dropped SOC_INTEL_COMMON_BLOCK_SGX_PRMRR_SIZE_32MB by accident in CB:45413 -- To view, visit https://review.coreboot.org/c/coreboot/+/69332 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3af0a1c509ab2e2eccf3e36ff604a1040995af4 Gerrit-Change-Number: 69332 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 15 Nov 2022 15:50:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: DO NOT MERGE: Disable clang builds
by Martin L Roth (Code Review) 15 Nov '22

15 Nov '22

Martin L Roth has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/69626 ) Change subject: DO NOT MERGE: Disable clang builds ...................................................................... DO NOT MERGE: Disable clang builds Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Ie92c0144481562b7579bced6ac23813b914b10c5 --- M util/abuild/abuild 1 file changed, 27 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/69626/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69626 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie92c0144481562b7579bced6ac23813b914b10c5 Gerrit-Change-Number: 69626 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: [Code Migration] Boot time cache information prints
by Dinesh Gehlot (Code Review) 15 Nov '22

15 Nov '22

Dinesh Gehlot has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69615 ) Change subject: [Code Migration] Boot time cache information prints ...................................................................... [Code Migration] Boot time cache information prints Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> Change-Id: Ic7039a44f5f6ca0f9771bcc701f6cd21ca70ee9f --- M src/soc/intel/meteorlake/bootblock/report_platform.c 1 file changed, 28 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/69615/1 diff --git a/src/soc/intel/meteorlake/bootblock/report_platform.c b/src/soc/intel/meteorlake/bootblock/report_platform.c index 63f1771..510e3b7 100644 --- a/src/soc/intel/meteorlake/bootblock/report_platform.c +++ b/src/soc/intel/meteorlake/bootblock/report_platform.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include <commonlib/helpers.h> #include <console/console.h> #include <cpu/cpu.h> #include <cpu/intel/cpu_ids.h> @@ -64,6 +65,21 @@ return pci_read_config16(dev, PCI_DEVICE_ID); } +static void report_cache_info(void) +{ + int cache_level = CACHE_L3; + struct cpu_cache_info info; + + if (!fill_cpu_cache_info(cache_level, &info)) + return; + + printk(BIOS_INFO, "Cache: Level %d: ", cache_level); + printk(BIOS_INFO, "Associativity = %zd Partitions = %zd Line Size = %zd Sets = %zd\n", + info.num_ways, info.physical_partitions, info.line_size, info.num_sets); + + printk(BIOS_INFO, "Cache size = %zu MiB\n", get_cache_size(&info)/MiB); +} + static void report_cpu_info(void) { u32 i, cpu_id, cpu_feature_flag; @@ -94,6 +110,8 @@ printk(BIOS_DEBUG, "CPU: AES %ssupported, TXT %ssupported, VT %ssupported\n", mode[aes], mode[txt], mode[vt]); + + report_cache_info(); } static void report_mch_info(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/69615 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7039a44f5f6ca0f9771bcc701f6cd21ca70ee9f Gerrit-Change-Number: 69615 Gerrit-PatchSet: 1 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: DO NOT MERGE: Disable clang cros build
by Martin L Roth (Code Review) 15 Nov '22

15 Nov '22

Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69626 ) Change subject: DO NOT MERGE: Disable clang cros build ...................................................................... DO NOT MERGE: Disable clang cros build Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Ie92c0144481562b7579bced6ac23813b914b10c5 --- M util/abuild/abuild 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/69626/1 diff --git a/util/abuild/abuild b/util/abuild/abuild index 43dd833..75dda18 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -750,6 +750,9 @@ clang=true customizing="${customizing}, clang" configoptions="${configoptions}CONFIG_COMPILER_LLVM_CLANG=y\n# CONFIG_COMPILER_GCC is not set\n" + if [ "${chromeos}" = "true" ]; then + exit 0 + fi ;; -z|--clean) shift customizing="${customizing}, clean" @@ -767,6 +770,9 @@ testclass=chromeos customizing="${customizing}, chromeos" configoptions="${configoptions}CONFIG_CHROMEOS=y\nCONFIG_VBOOT_MEASURED_BOOT=y\n" + if [ "${clang}" = "true" ]; then + exit 0 + fi ;; -X|--xmlfile) shift; XMLFILE=$1; REAL_XMLFILE=$1; shift;; -I|--recursive) shift; recursive=true;; -- To view, visit https://review.coreboot.org/c/coreboot/+/69626 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie92c0144481562b7579bced6ac23813b914b10c5 Gerrit-Change-Number: 69626 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: Documentation: Add some more acronyms to the list
by Nicholas Chin (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Martin L Roth, Martin Roth. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67330 ) Change subject: Documentation: Add some more acronyms to the list ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I417bb151afcb3e996d9a12b2274ef02f2126bc7d Gerrit-Change-Number: 67330 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Tue, 15 Nov 2022 14:37:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya: Enable the Package C-state demotion
by Shaik Sameeruddin (Code Review) 15 Nov '22

15 Nov '22

Attention is currently required from: Tarun Tuli. Hello Tarun Tuli, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69614 to look at the new patch set (#2). Change subject: mb/google/brya: Enable the Package C-state demotion ...................................................................... mb/google/brya: Enable the Package C-state demotion Enabling the Packge C-state demotion for checking Power and Performance impact Signed-off-by: sameeruddin shaik <shaik.sameeruddin(a)intel.com> Change-Id: Iad2f4601f0a5760c6099d7d2a757c7c460aaf53d --- M src/mainboard/google/brya/variants/baseboard/skolas/devicetree.cb 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/69614/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69614 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad2f4601f0a5760c6099d7d2a757c7c460aaf53d Gerrit-Change-Number: 69614 Gerrit-PatchSet: 2 Gerrit-Owner: Shaik Sameeruddin <shaik.sameeruddin(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022