coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[M] Change in coreboot[master]: Documentation/measured_boot.md: document new TPM options
by Sergii Dmytruk (Code Review) 16 Nov '22

16 Nov '22

Attention is currently required from: Daniel P. Smith, Michał Żygowski, Maciej Pijanowski, Krystian Hebel. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68752 ) Change subject: Documentation/measured_boot.md: document new TPM options ...................................................................... Patch Set 8: (2 comments) File Documentation/security/vboot/measured_boot.md: https://review.coreboot.org/c/coreboot/+/68752/comment/270e7461_fd73b13d PS4, Line 135: In endianness of the firmware. Not meant to be stable. > Can do this after latest changes. […] Done https://review.coreboot.org/c/coreboot/+/68752/comment/d44c5b90_ffa5023e PS4, Line 158: In endianness of the firmware. Not meant to be stable. > Same as above. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6dae8e95c59b440c75e13473eefc4c2cf4fd369b Gerrit-Change-Number: 68752 Gerrit-PatchSet: 8 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel P. Smith Gerrit-Attention: Daniel P. Smith Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Wed, 16 Nov 2022 22:36:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Krystian Hebel <krystian.hebel(a)3mdeb.com> Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: security/tpm: add TPM log format as per 2.0 spec
by Sergii Dmytruk (Code Review) 16 Nov '22

16 Nov '22

Attention is currently required from: Michał Żygowski, Maciej Pijanowski, Christian Walter, Julius Werner, Krystian Hebel. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68748 ) Change subject: security/tpm: add TPM log format as per 2.0 spec ...................................................................... Patch Set 6: (4 comments) File src/security/tpm/tpm2_log_serialized.h: https://review.coreboot.org/c/coreboot/+/68748/comment/dad327b5_e9a3f911 PS5, Line 38: struct tpm_2_log_entry { > Why aren't these structures in commonlib when the spec_id ones are? Wouldn't e.g. […] At the moment `cbmem` parses log in its generic form (arbitrary number of hashes and variable-length fields) and doesn't need to know these implementation-specific declarations. File src/security/tpm/tspi/log-tpm2.c: https://review.coreboot.org/c/coreboot/+/68748/comment/9e116798_ef56368a PS5, Line 77: MAX_TPM_LOG_ENTRIES > Is it intentional that these two fields don't get forced to little-endian while the others do? Is gu […] Done https://review.coreboot.org/c/coreboot/+/68748/comment/363f793b_2dba9a71 PS5, Line 158: strncpy((char *)tce->data, name, sizeof(tce->data) - 1); > Same termination issue here. Done https://review.coreboot.org/c/coreboot/+/68748/comment/ce12ee52_0d5757e7 PS5, Line 176: tce->pcr > le32toh? Yes, thanks. Same in TPM1 log format. -- To view, visit https://review.coreboot.org/c/coreboot/+/68748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0fac386bebab1b7104378ae3424957c6497e84e1 Gerrit-Change-Number: 68748 Gerrit-PatchSet: 6 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Wed, 16 Nov 2022 22:36:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: security/tpm: add TPM log format as per 1.2 spec
by Sergii Dmytruk (Code Review) 16 Nov '22

16 Nov '22

Attention is currently required from: Michał Żygowski, Maciej Pijanowski, Christian Walter, Julius Werner, Krystian Hebel. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68747 ) Change subject: security/tpm: add TPM log format as per 1.2 spec ...................................................................... Patch Set 6: (7 comments) File src/commonlib/include/commonlib/tpm_log_defs.h: https://review.coreboot.org/c/coreboot/+/68747/comment/7580f484_f7ccef71 PS5, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */ > Note that licensing this as GPLv2 would make it hard to share with libpayload in the future. […] It's partially based on a commit by Michał Żygowski, so asked him. I suspect the license can be changed. File src/security/tpm/Kconfig: https://review.coreboot.org/c/coreboot/+/68747/comment/8e216d5e_a8b06d70 PS5, Line 107: TPM_LOG_TPM12 > We generally use "TPM1", not "TPM12" in the code, so I would suggest calling this TPM_LOG_TPM1 as we […] Done https://review.coreboot.org/c/coreboot/+/68747/comment/705687b8_e2eed3b6 PS5, Line 108: bool "TPM 1.2 format" > Can this log format be used with 2.0 TPMs? Otherwise, this should probably have a `depends on TPM1`. I don't think such usage is forbidden. File src/security/tpm/tspi.h: https://review.coreboot.org/c/coreboot/+/68747/comment/13e92a6e_dd5cee0d PS5, Line 11: #include "tpm12_log_serialized.h" > Please use angled brackets notation (i.e. <security/tpm/tpm1_log_serialized. […] Done File src/security/tpm/tspi/log-tpm12.c: https://review.coreboot.org/c/coreboot/+/68747/comment/1a19a732_e41ed206 PS5, Line 115: strncpy((char *)tce->data, name, sizeof(tce->data) - 1); > This needs to guarantee that tce->data gets null-terminated (your other functions rely on that), so […] I interpreted it as a reliance on memory being zeroed in the original code, then I wasn't sure it's the case and zeroed header explicitly, but forgot about this. Thanks. Added CB:69708 for old format. https://review.coreboot.org/c/coreboot/+/68747/comment/d01b8704_8289550f PS5, Line 123: tclt->spec_id.num_entries = 0; > So this means that the pre-RAM version of the log table will never be fully initialized (e.g. […] Added a comment for TPM1 and TPM2. https://review.coreboot.org/c/coreboot/+/68747/comment/13113eda_36577803 PS5, Line 161: struct tpm_12_log_entry *tce = &to_log->entries[to_log->spec_id.num_entries++]; > Why not just memcpy() the whole entry? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I89720615a75573d44dd0a39ad3d7faa78f125843 Gerrit-Change-Number: 68747 Gerrit-PatchSet: 6 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Wed, 16 Nov 2022 22:35:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: security/tpm: make tspi/crtm.c agnostic to log format
by Sergii Dmytruk (Code Review) 16 Nov '22

16 Nov '22

Attention is currently required from: Christian Walter, Julius Werner. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69445 ) Change subject: security/tpm: make tspi/crtm.c agnostic to log format ...................................................................... Patch Set 2: (1 comment) File src/security/tpm/tspi/log.c: https://review.coreboot.org/c/coreboot/+/69445/comment/16a3aff5_2a1fc19f PS1, Line 126: break; > What if the algorithm is not found? Out parameter will be set to `VB2_HASH_INVALID` and `tspi_measure_cache_to_pcr()` will fail because `tlcl_extend()` will fail for such value. I don't return an error for such case to not stop traversal as it can go on. -- To view, visit https://review.coreboot.org/c/coreboot/+/69445 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3013bd5f29f1412fbe646dc74d8946704b750a66 Gerrit-Change-Number: 69445 Gerrit-PatchSet: 2 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 16 Nov 2022 22:35:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: security/tpm: make log format configurable via Kconfig
by Sergii Dmytruk (Code Review) 16 Nov '22

16 Nov '22

Attention is currently required from: Tarun Tuli, Michał Żygowski, Maciej Pijanowski, Jason Nien, Subrata Banik, Christian Walter, Kapil Porwal, Tim Wawrzynczak, Nick Vaccaro, Julius Werner, Krystian Hebel, Martin Roth. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68746 ) Change subject: security/tpm: make log format configurable via Kconfig ...................................................................... Patch Set 7: (2 comments) File src/security/tpm/tspi.h: https://review.coreboot.org/c/coreboot/+/68746/comment/e19efc0a_8d2de5c1 PS6, Line 10: #include <commonlib/tcpa_log_serialized.h> > Why is this moving around? Done File src/security/tpm/tspi/crtm.h: https://review.coreboot.org/c/coreboot/+/68746/comment/adf060e4_86a4c3e6 PS6, Line 26: # if CONFIG(NO_TPM) || !CONFIG(TPM_MEASURED_BOOT) > NO_TPM should imply !TPM_MEASURED_BOOT, right? Right, thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/68746 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3903aff54e01093bc9ea75862bbf5989cc6e6c55 Gerrit-Change-Number: 68746 Gerrit-PatchSet: 7 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Wed, 16 Nov 2022 22:35:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Documentation/measured_boot.md: fix SRTM/DRTM explanations
by build bot (Jenkins) (Code Review) 16 Nov '22

16 Nov '22

Attention is currently required from: Daniel P. Smith, Michał Żygowski, Maciej Pijanowski, Krystian Hebel. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68751 ) Change subject: Documentation/measured_boot.md: fix SRTM/DRTM explanations ...................................................................... Patch Set 6: Verified+1 (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163840): https://review.coreboot.org/c/coreboot/+/68751/comment/bb26d464_22b7d3fd PS6, Line 11: Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Unrecognized email address: 'Daniel P. Smith' -- To view, visit https://review.coreboot.org/c/coreboot/+/68751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If224dc0cf3c0515dbd18daca544c22275e96b459 Gerrit-Change-Number: 68751 Gerrit-PatchSet: 6 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel P. Smith Gerrit-Attention: Daniel P. Smith Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Wed, 16 Nov 2022 22:33:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: treewide: stop calling custom TPM log "TCPA"
by build bot (Jenkins) (Code Review) 16 Nov '22

16 Nov '22

Attention is currently required from: Xi Chen, Hung-Te Lin, Christian Walter, Sergii Dmytruk. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69444 ) Change subject: treewide: stop calling custom TPM log "TCPA" ...................................................................... Patch Set 2: (2 comments) File src/include/memlayout.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163834): https://review.coreboot.org/c/coreboot/+/69444/comment/69c587c8_95616d47 PS2, Line 171: #define TPM_LOG(addr, size) \ Macros with multiple statements should be enclosed in a do - while loop Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163834): https://review.coreboot.org/c/coreboot/+/69444/comment/abba6f83_55e91aeb PS2, Line 171: #define TPM_LOG(addr, size) \ macros should not use a trailing semicolon -- To view, visit https://review.coreboot.org/c/coreboot/+/69444 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I896bd94f18b34d6c4b280f58b011d704df3d4022 Gerrit-Change-Number: 69444 Gerrit-PatchSet: 2 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 16 Nov 2022 22:30:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: security/tpm/tspi/log.c: fix strncpy() usage
by Sergii Dmytruk (Code Review) 16 Nov '22

16 Nov '22

Attention is currently required from: Christian Walter. Sergii Dmytruk has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69708 ) Change subject: security/tpm/tspi/log.c: fix strncpy() usage ...................................................................... security/tpm/tspi/log.c: fix strncpy() usage Change-Id: Ib24129829bef3764a8ba1e2c0d92bc42c5cfbc8d Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> --- M src/security/tpm/tspi/log.c 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/69708/1 diff --git a/src/security/tpm/tspi/log.c b/src/security/tpm/tspi/log.c index 96c3087..e33cacb 100644 --- a/src/security/tpm/tspi/log.c +++ b/src/security/tpm/tspi/log.c @@ -77,6 +77,8 @@ struct tpm_cb_log_entry *tce = &tclt->entries[tclt->num_entries++]; strncpy(tce->name, name, TPM_CB_LOG_PCR_HASH_NAME - 1); + tce->name[TPM_CB_LOG_PCR_HASH_NAME - 1] = '\0'; + tce->pcr = pcr; if (digest_len > TPM_CB_LOG_DIGEST_MAX_LENGTH) { @@ -143,7 +145,10 @@ for (i = 0; i < from_log->num_entries; i++) { struct tpm_cb_log_entry *tce = &to_log->entries[to_log->num_entries++]; + strncpy(tce->name, from_log->entries[i].name, TPM_CB_LOG_PCR_HASH_NAME - 1); + tce->name[TPM_CB_LOG_PCR_HASH_NAME - 1] = '\0'; + tce->pcr = from_log->entries[i].pcr; if (from_log->entries[i].digest_length > TPM_CB_LOG_DIGEST_MAX_LENGTH) { @@ -153,6 +158,8 @@ strncpy(tce->digest_type, from_log->entries[i].digest_type, TPM_CB_LOG_PCR_HASH_LEN - 1); + tce->digest_type[TPM_CB_LOG_PCR_HASH_LEN - 1] = '\0'; + tce->digest_length = MIN(from_log->entries[i].digest_length, TPM_CB_LOG_DIGEST_MAX_LENGTH); memcpy(tce->digest, from_log->entries[i].digest, tce->digest_length); -- To view, visit https://review.coreboot.org/c/coreboot/+/69708 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib24129829bef3764a8ba1e2c0d92bc42c5cfbc8d Gerrit-Change-Number: 69708 Gerrit-PatchSet: 1 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: Documentation/measured_boot.md: document new TPM options
by Sergii Dmytruk (Code Review) 16 Nov '22

16 Nov '22

Attention is currently required from: Daniel P. Smith, Michał Żygowski, Maciej Pijanowski, Krystian Hebel. Hello build bot (Jenkins), Michał Żygowski, Maciej Pijanowski, Krystian Hebel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68752 to look at the new patch set (#8). Change subject: Documentation/measured_boot.md: document new TPM options ...................................................................... Documentation/measured_boot.md: document new TPM options Change-Id: I6dae8e95c59b440c75e13473eefc4c2cf4fd369b Ticket: https://ticket.coreboot.org/issues/426 Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> --- M Documentation/security/vboot/measured_boot.md 1 file changed, 122 insertions(+), 32 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/68752/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/68752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6dae8e95c59b440c75e13473eefc4c2cf4fd369b Gerrit-Change-Number: 68752 Gerrit-PatchSet: 8 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel P. Smith Gerrit-Attention: Daniel P. Smith Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: util/cbmem: add parsing of TPM logs per standard
by Sergii Dmytruk (Code Review) 16 Nov '22

16 Nov '22

Attention is currently required from: Michał Żygowski, Maciej Pijanowski, Christian Walter, Krystian Hebel. Hello build bot (Jenkins), Michał Żygowski, Maciej Pijanowski, Christian Walter, Krystian Hebel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68749 to look at the new patch set (#7). Change subject: util/cbmem: add parsing of TPM logs per standard ...................................................................... util/cbmem: add parsing of TPM logs per standard coreboot is made to export the range allocated for the log. The range is helpful as there is no easy way to determine the size of the log from its header without parsing vendor info. Change-Id: Ib76dc7dec56dd1789a219539a1ac05a958f47a5c Ticket: https://ticket.coreboot.org/issues/425 Signed-off-by: Krystian Hebel <krystian.hebel(a)3mdeb.com> Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> --- M src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h M src/commonlib/include/commonlib/coreboot_tables.h M src/commonlib/include/commonlib/tpm_log_defs.h M src/lib/coreboot_table.c M src/security/tpm/tspi.h M src/security/tpm/tspi/log-tpm1.c M src/security/tpm/tspi/log-tpm2.c M util/cbmem/cbmem.c 8 files changed, 361 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/68749/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/68749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib76dc7dec56dd1789a219539a1ac05a958f47a5c Gerrit-Change-Number: 68749 Gerrit-PatchSet: 7 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022