coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: sb/intel/i82801dx/bootblock.c: Include "i82801dx.h"
by Elyes Haouas (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Arthur Heymans, Felix Held. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69717 ) Change subject: sb/intel/i82801dx/bootblock.c: Include "i82801dx.h" ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: would you submit as Jankins failed to build (tree)mainboard/aopen/dxplplusu ? -- To view, visit https://review.coreboot.org/c/coreboot/+/69717 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I58ff31ab98c4310478cf3bbe8aecce4000ac8205 Gerrit-Change-Number: 69717 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 17 Nov 2022 13:33:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: nb/intel/ironlake,sandybridge/gma: Fix out() parameter order
by Felix Held (Code Review) 17 Nov '22

17 Nov '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69670 ) Change subject: nb/intel/ironlake,sandybridge/gma: Fix out() parameter order ...................................................................... nb/intel/ironlake,sandybridge/gma: Fix out() parameter order Change-Id: I4baa2e06d336736caf5505a05ed4353bcbfdb517 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69670 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/northbridge/intel/ironlake/gma.c M src/northbridge/intel/sandybridge/gma.c 2 files changed, 22 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Elyes Haouas: Looks good to me, approved Arthur Heymans: Looks good to me, but someone else must approve Angel Pons: Looks good to me, but someone else must approve diff --git a/src/northbridge/intel/ironlake/gma.c b/src/northbridge/intel/ironlake/gma.c index 8084560..fb21d35 100644 --- a/src/northbridge/intel/ironlake/gma.c +++ b/src/northbridge/intel/ironlake/gma.c @@ -122,15 +122,15 @@ /* clear DMISCI status */ reg16 = inw(DEFAULT_PMBASE + TCO1_STS); reg16 &= DMISCI_STS; - outw(DEFAULT_PMBASE + TCO1_STS, reg16); + outw(reg16, DEFAULT_PMBASE + TCO1_STS); /* clear acpi tco status */ - outl(DEFAULT_PMBASE + GPE0_STS, TCOSCI_STS); + outl(TCOSCI_STS, DEFAULT_PMBASE + GPE0_STS); /* enable acpi tco scis */ reg16 = inw(DEFAULT_PMBASE + GPE0_EN); reg16 |= TCOSCI_EN; - outw(DEFAULT_PMBASE + GPE0_EN, reg16); + outw(reg16, DEFAULT_PMBASE + GPE0_EN); } static void gma_func0_init(struct device *dev) diff --git a/src/northbridge/intel/sandybridge/gma.c b/src/northbridge/intel/sandybridge/gma.c index d1b9263..3eed5cc 100644 --- a/src/northbridge/intel/sandybridge/gma.c +++ b/src/northbridge/intel/sandybridge/gma.c @@ -570,15 +570,15 @@ /* Clear DMISCI status */ reg16 = inw(DEFAULT_PMBASE + TCO1_STS); reg16 &= DMISCI_STS; - outw(DEFAULT_PMBASE + TCO1_STS, reg16); + outw(reg16, DEFAULT_PMBASE + TCO1_STS); /* Clear ACPI TCO status */ - outl(DEFAULT_PMBASE + GPE0_STS, TCOSCI_STS); + outl(TCOSCI_STS, DEFAULT_PMBASE + GPE0_STS); /* Enable ACPI TCO SCIs */ reg16 = inw(DEFAULT_PMBASE + GPE0_EN); reg16 |= TCOSCI_EN; - outw(DEFAULT_PMBASE + GPE0_EN, reg16); + outw(reg16, DEFAULT_PMBASE + GPE0_EN); } static void gma_func0_init(struct device *dev) -- To view, visit https://review.coreboot.org/c/coreboot/+/69670 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4baa2e06d336736caf5505a05ed4353bcbfdb517 Gerrit-Change-Number: 69670 Gerrit-PatchSet: 3 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: mb/google/rex: Add `disable_gpio_export_in_crs` for rex
by Felix Held (Code Review) 17 Nov '22

17 Nov '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69612 ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/rex: Add `disable_gpio_export_in_crs` for rex ...................................................................... mb/google/rex: Add `disable_gpio_export_in_crs` for rex None of the touchscreens (over I2C) used in the rex program requires exporting GPIOs in the ACPI _CRS method. This can cause i2c devices to malfunction or cause timing sequence violations if ACPI exports a PowerResource for the device that uses GPIOs that are also exported in _CRS. BUG=none TEST=Able to build and boot Google, Rex platform. Without this patch: [ERROR] I2C: 00:10: Exposing GPIOs in Power Resource and _CRS With this patch: None Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I578a60eff27f94d6dc94b900604bc7560337d60b Reviewed-on: https://review.coreboot.org/c/coreboot/+/69612 Reviewed-by: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Reviewed-by: Kapil Porwal <kapilporwal(a)google.com> Reviewed-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/rex/variants/rex0/overridetree.cb 1 file changed, 34 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Sridhar Siricilla: Looks good to me, but someone else must approve Ivy Jian: Looks good to me, approved Kapil Porwal: Looks good to me, approved diff --git a/src/mainboard/google/rex/variants/rex0/overridetree.cb b/src/mainboard/google/rex/variants/rex0/overridetree.cb index a7f5a95..f3b0fab 100644 --- a/src/mainboard/google/rex/variants/rex0/overridetree.cb +++ b/src/mainboard/google/rex/variants/rex0/overridetree.cb @@ -357,6 +357,7 @@ register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C06)" register "generic.stop_off_delay_ms" = "2" register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" register "hid_desc_reg_offset" = "0x01" device i2c 10 on end end -- To view, visit https://review.coreboot.org/c/coreboot/+/69612 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I578a60eff27f94d6dc94b900604bc7560337d60b Gerrit-Change-Number: 69612 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/pujjo: Tune timing on SD device RTD3
by Felix Held (Code Review) 17 Nov '22

17 Nov '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69679 ) Change subject: mb/google/nissa/var/pujjo: Tune timing on SD device RTD3 ...................................................................... mb/google/nissa/var/pujjo: Tune timing on SD device RTD3 Tune timing between power on and reset on SD device RTD3. BUG=b:250746988 TEST=Use the value to boot on Pujjo successfully. Signed-off-by: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Change-Id: I1ea77ec8381000249229653f1c0b9044bdf7866d Reviewed-on: https://review.coreboot.org/c/coreboot/+/69679 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Reka Norman <rekanorman(a)chromium.org> --- M src/mainboard/google/brya/variants/pujjo/overridetree.cb 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Reka Norman: Looks good to me, approved diff --git a/src/mainboard/google/brya/variants/pujjo/overridetree.cb b/src/mainboard/google/brya/variants/pujjo/overridetree.cb index 0a5624c..4bc96f9 100644 --- a/src/mainboard/google/brya/variants/pujjo/overridetree.cb +++ b/src/mainboard/google/brya/variants/pujjo/overridetree.cb @@ -543,6 +543,7 @@ register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H13)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H12)" register "srcclk_pin" = "3" + register "enable_delay_ms" = "50" device generic 0 on end end probe SD_CARD SD_PRESENT -- To view, visit https://review.coreboot.org/c/coreboot/+/69679 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ea77ec8381000249229653f1c0b9044bdf7866d Gerrit-Change-Number: 69679 Gerrit-PatchSet: 2 Gerrit-Owner: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-CC: Jynn Chen <jynn.chen(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin3 Yang <Kevin3.Yang(a)lcfuturecenter.com> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: lib/malloc.c: Fix log messages
by Elyes Haouas (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Felix Held. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69624 ) Change subject: lib/malloc.c: Fix log messages ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/69624/comment/cef6aea7_fb18c9b9 PS1, Line 9: Wrning > Warning Done Patchset: PS2: Thank you -- To view, visit https://review.coreboot.org/c/coreboot/+/69624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e4341555a3b03a531bd94ba5e36cbcadda9c663 Gerrit-Change-Number: 69624 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 17 Nov 2022 13:29:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: arch/{arm64,riscv}: Remove "CRIT: " from log messages
by Felix Held (Code Review) 17 Nov '22

17 Nov '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69497 ) Change subject: arch/{arm64,riscv}: Remove "CRIT: " from log messages ...................................................................... arch/{arm64,riscv}: Remove "CRIT: " from log messages It is no longer necessary to explicitly add "CRIT: " in front of BIOS_CRIT message. Change-Id: I506c1d278960c91d1283e9b1936c9c1678a10e17 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69497 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> --- M src/arch/arm64/fit_payload.c M src/arch/riscv/fit_payload.c 2 files changed, 18 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved diff --git a/src/arch/arm64/fit_payload.c b/src/arch/arm64/fit_payload.c index 7f1c8f8..f8ae16a 100644 --- a/src/arch/arm64/fit_payload.c +++ b/src/arch/arm64/fit_payload.c @@ -169,7 +169,7 @@ void *arg = NULL; if (!decompress_kernel_header(config->kernel)) { - printk(BIOS_CRIT, "CRIT: Payload doesn't look like an ARM64" + printk(BIOS_CRIT, "Payload doesn't look like an ARM64" " kernel Image.\n"); return false; } diff --git a/src/arch/riscv/fit_payload.c b/src/arch/riscv/fit_payload.c index f7f4106..bfa0c98 100644 --- a/src/arch/riscv/fit_payload.c +++ b/src/arch/riscv/fit_payload.c @@ -67,7 +67,7 @@ void *arg = NULL; if (!config->fdt || !fdt) { - printk(BIOS_CRIT, "CRIT: Providing a valid FDT is mandatory to " + printk(BIOS_CRIT, "Providing a valid FDT is mandatory to " "boot a RISC-V kernel!\n"); return false; /* TODO: Fall back to the ROM FDT? */ -- To view, visit https://review.coreboot.org/c/coreboot/+/69497 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I506c1d278960c91d1283e9b1936c9c1678a10e17 Gerrit-Change-Number: 69497 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: lib/malloc.c: Fix log messages
by Elyes Haouas (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Elyes Haouas. Hello build bot (Jenkins), Eric Lai, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69624 to look at the new patch set (#2). Change subject: lib/malloc.c: Fix log messages ...................................................................... lib/malloc.c: Fix log messages It is no longer necessary to explicitly add "Warning" in front of BIOS_WARNING message. Change-Id: I6e4341555a3b03a531bd94ba5e36cbcadda9c663 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/lib/malloc.c 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/69624/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e4341555a3b03a531bd94ba5e36cbcadda9c663 Gerrit-Change-Number: 69624 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: commonlib/storage/sdhci.c: Remove "ERROR: " from log message
by Felix Held (Code Review) 17 Nov '22

17 Nov '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69622 ) Change subject: commonlib/storage/sdhci.c: Remove "ERROR: " from log message ...................................................................... commonlib/storage/sdhci.c: Remove "ERROR: " from log message It is no longer necessary to explicitly add "ERROR: " in front of BIOS_ERR message. Change-Id: I36e2785ae567d82339212140c1bde0876dfd450d Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69622 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> --- M src/commonlib/storage/sdhci.c 1 file changed, 17 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved diff --git a/src/commonlib/storage/sdhci.c b/src/commonlib/storage/sdhci.c index 16420d9..3a01f62 100644 --- a/src/commonlib/storage/sdhci.c +++ b/src/commonlib/storage/sdhci.c @@ -320,8 +320,7 @@ if (!dma_coherent(buf)) { bbstate = &bbstate_val; if (bounce_buffer_start(bbstate, buf, len, bbflags)) { - sdhc_error( - "ERROR: Failed to get bounce buffer.\n"); + sdhc_error("Failed to get bounce buffer.\n"); return -1; } } -- To view, visit https://review.coreboot.org/c/coreboot/+/69622 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36e2785ae567d82339212140c1bde0876dfd450d Gerrit-Change-Number: 69622 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: lib/malloc.c: Fix log messages
by Felix Held (Code Review) 17 Nov '22

17 Nov '22

Attention is currently required from: Elyes Haouas. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69624 ) Change subject: lib/malloc.c: Fix log messages ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/69624/comment/c16702ab_27b61c9e PS1, Line 9: Wrning Warning -- To view, visit https://review.coreboot.org/c/coreboot/+/69624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e4341555a3b03a531bd94ba5e36cbcadda9c663 Gerrit-Change-Number: 69624 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 17 Nov 2022 13:28:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: drivers/uart/Kconfig: Drop unused Kconfig symbol
by Felix Held (Code Review) 17 Nov '22

17 Nov '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69334 ) Change subject: drivers/uart/Kconfig: Drop unused Kconfig symbol ...................................................................... drivers/uart/Kconfig: Drop unused Kconfig symbol Change-Id: I43e6b57477cb4fd2c8ab399e9cc74591b0a44684 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69334 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> --- M src/drivers/uart/Kconfig 1 file changed, 13 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved diff --git a/src/drivers/uart/Kconfig b/src/drivers/uart/Kconfig index a2a7f9f..097c144 100644 --- a/src/drivers/uart/Kconfig +++ b/src/drivers/uart/Kconfig @@ -69,9 +69,3 @@ bool select HAVE_UART_SPECIAL select UART_OVERRIDE_INPUT_CLOCK_DIVIDER - -config UART_USE_REFCLK_AS_INPUT_CLOCK - bool - default n - help - Use uart_platform_refclk to specify the input clock value. -- To view, visit https://review.coreboot.org/c/coreboot/+/69334 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I43e6b57477cb4fd2c8ab399e9cc74591b0a44684 Gerrit-Change-Number: 69334 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022