coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[M] Change in coreboot[master]: [MTL]src/vc: Add new FirmwareVersionInfo.h
by Saurabh Mishra (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Balaji Manigandan, Ronak Kanabar. Saurabh Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69882 ) Change subject: [MTL]src/vc: Add new FirmwareVersionInfo.h ...................................................................... Patch Set 5: (3 comments) This change is ready for review. Commit Message: https://review.coreboot.org/c/coreboot/+/69882/comment/162bde5d_b15af57e PS2, Line 10: Changes include: : - Add FirmwareVersionInfo.h : - Remove obselete FirmwareVersionInfoHob.h : - Select new version info via Kconfig. : > I would suggest split this into different patch. […] Done File src/soc/intel/meteorlake/Kconfig: https://review.coreboot.org/c/coreboot/+/69882/comment/4e40b6ed_30a14e3d PS2, Line 19: select DISPLAY_FSP_VERSION_INFO > remove this Kconfig Done https://review.coreboot.org/c/coreboot/+/69882/comment/b1329fe5_47ed6558 PS2, Line 19: select DISPLAY_FSP_VERSION_INFO > > this has dependency on FirmwareVersionInfoHob.h […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/69882 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib5c843bb0dccd5db92f74148df3a17037988392c Gerrit-Change-Number: 69882 Gerrit-PatchSet: 5 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 08:35:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Balaji Manigandan <balaji.manigandan(a)intel.com> Comment-In-Reply-To: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: [MTL]src/vc: Remove deprecated header FirmwareVersionInfoHob.h
by Saurabh Mishra (Code Review) 22 Nov '22

22 Nov '22

Saurabh Mishra has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/69884 ) Change subject: [MTL]src/vc: Remove deprecated header FirmwareVersionInfoHob.h ...................................................................... [MTL]src/vc: Remove deprecated header FirmwareVersionInfoHob.h FirmwareVersionInfoHob.h is removed to use new VersionInfo. BUG=TBD BRANCH=None TEST=Verify MTL Rex0 build with all the patch in relation chain and verify the version output prints no junk data observed. Signed-off-by: Saurabh Mishra <mishra.saurabh(a)intel.com> Change-Id: I06fd89f201e9e4100524e58033086327ad4ffc7b --- D src/vendorcode/intel/fsp/fsp2_0/meteorlake/FirmwareVersionInfoHob.h 1 file changed, 17 insertions(+), 68 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/69884/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I06fd89f201e9e4100524e58033086327ad4ffc7b Gerrit-Change-Number: 69884 Gerrit-PatchSet: 2 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: vendorcode/intel/fsp: Remove deprecated header
by Saurabh Mishra (Code Review) 22 Nov '22

22 Nov '22

Saurabh Mishra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69884 ) Change subject: vendorcode/intel/fsp: Remove deprecated header ...................................................................... vendorcode/intel/fsp: Remove deprecated header FirmwareVersionInfoHob.h is removed to use new VersionInfo. BUG=TBD BRANCH=None TEST=Verify MTL Rex0 build with all the patch in relation chain and verify the version output prints no junk data observed. Signed-off-by: Saurabh Mishra <mishra.saurabh(a)intel.com> Change-Id: I06fd89f201e9e4100524e58033086327ad4ffc7b --- D src/vendorcode/intel/fsp/fsp2_0/meteorlake/FirmwareVersionInfoHob.h 1 file changed, 17 insertions(+), 68 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/69884/1 diff --git a/src/vendorcode/intel/fsp/fsp2_0/meteorlake/FirmwareVersionInfoHob.h b/src/vendorcode/intel/fsp/fsp2_0/meteorlake/FirmwareVersionInfoHob.h deleted file mode 100644 index 14efd90..0000000 --- a/src/vendorcode/intel/fsp/fsp2_0/meteorlake/FirmwareVersionInfoHob.h +++ /dev/null @@ -1,68 +0,0 @@ -/** @file - Header file for Firmware Version Information - - @copyright - Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.<BR> - - This program and the accompanying materials are licensed and made available under - the terms and conditions of the BSD License which accompanies this distribution. - The full text of the license may be found at - http://opensource.org/licenses/bsd-license.php - - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. - -**/ - -#ifndef _FIRMWARE_VERSION_INFO_HOB_H_ -#define _FIRMWARE_VERSION_INFO_HOB_H_ - -#include <Uefi/UefiMultiPhase.h> -#include <Pi/PiBootMode.h> -#include <Pi/PiHob.h> - -#pragma pack(1) -/// -/// Firmware Version Structure -/// -typedef struct { - UINT8 MajorVersion; - UINT8 MinorVersion; - UINT8 Revision; - UINT16 BuildNumber; -} FIRMWARE_VERSION; - -/// -/// Firmware Version Information Structure -/// -typedef struct { - UINT8 ComponentNameIndex; ///< Offset 0 Index of Component Name - UINT8 VersionStringIndex; ///< Offset 1 Index of Version String - FIRMWARE_VERSION Version; ///< Offset 2-6 Firmware version -} FIRMWARE_VERSION_INFO; - -#ifndef __SMBIOS_STANDARD_H__ -/// -/// The Smbios structure header. -/// -typedef struct { - UINT8 Type; - UINT8 Length; - UINT16 Handle; -} SMBIOS_STRUCTURE; -#endif - -/// -/// Firmware Version Information HOB Structure -/// -typedef struct { - EFI_HOB_GUID_TYPE Header; ///< Offset 0-23 The header of FVI HOB - SMBIOS_STRUCTURE SmbiosData; ///< Offset 24-27 The SMBIOS header of FVI HOB - UINT8 Count; ///< Offset 28 Number of FVI elements included. -/// -/// FIRMWARE_VERSION_INFO structures followed by the null terminated string buffer -/// -} FIRMWARE_VERSION_INFO_HOB; -#pragma pack() - -#endif // _FIRMWARE_VERSION_INFO_HOB_H_ \ No newline at end of file -- To view, visit https://review.coreboot.org/c/coreboot/+/69884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I06fd89f201e9e4100524e58033086327ad4ffc7b Gerrit-Change-Number: 69884 Gerrit-PatchSet: 1 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2
by Ronak Kanabar (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Saurabh Mishra, Tarun Tuli, Kapil Porwal, Balaji Manigandan. Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69883 ) Change subject: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2 ...................................................................... Patch Set 2: (1 comment) File src/soc/intel/meteorlake/Kconfig: https://review.coreboot.org/c/coreboot/+/69883/comment/c71e71d8_31b3e7f3 PS2, Line 93: remove extra space and line -- To view, visit https://review.coreboot.org/c/coreboot/+/69883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I789db9d280c45639eca6ceafea65b96a93a395cf Gerrit-Change-Number: 69883 Gerrit-PatchSet: 2 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 08:24:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2
by Subrata Banik (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Saurabh Mishra, Tarun Tuli, Kapil Porwal, Balaji Manigandan, Ronak Kanabar. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69883 ) Change subject: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2 ...................................................................... Patch Set 2: (1 comment) File src/soc/intel/meteorlake/Kconfig: https://review.coreboot.org/c/coreboot/+/69883/comment/9ab36aa5_e1d68cb3 PS2, Line 93: why? -- To view, visit https://review.coreboot.org/c/coreboot/+/69883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I789db9d280c45639eca6ceafea65b96a93a395cf Gerrit-Change-Number: 69883 Gerrit-PatchSet: 2 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 08:24:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2
by Saurabh Mishra (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Hello Tarun Tuli, Subrata Banik, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69883 to look at the new patch set (#2). Change subject: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2 ...................................................................... soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2 Select DISPLAY_FSP_VERSION_INFO_2 for Meteor Lake soc. BUG=TBD BRANCH=None TEST=Verify MTL Rex0 build with all the patch in relation chain and verify the version output prints no junk data observed. Signed-off-by: Saurabh Mishra <mishra.saurabh(a)intel.com> Change-Id: I789db9d280c45639eca6ceafea65b96a93a395cf --- M src/soc/intel/meteorlake/Kconfig 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/69883/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I789db9d280c45639eca6ceafea65b96a93a395cf Gerrit-Change-Number: 69883 Gerrit-PatchSet: 2 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2
by build bot (Jenkins) (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69883 ) Change subject: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2 ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/meteorlake/Kconfig: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164227): https://review.coreboot.org/c/coreboot/+/69883/comment/36cd73c6_dab238d5 PS1, Line 93: trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/69883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I789db9d280c45639eca6ceafea65b96a93a395cf Gerrit-Change-Number: 69883 Gerrit-PatchSet: 1 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 08:19:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2
by Saurabh Mishra (Code Review) 22 Nov '22

22 Nov '22

Saurabh Mishra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69883 ) Change subject: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2 ...................................................................... soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2 Select DISPLAY_FSP_VERSION_INFO_2 for Meteor Lake soc. BUG=TBD BRANCH=None TEST=Verify MTLRVP build with all the patch in relation chain and verify the version output prints no junk data observed. Signed-off-by: Saurabh Mishra <mishra.saurabh(a)intel.com> Change-Id: I789db9d280c45639eca6ceafea65b96a93a395cf --- M src/soc/intel/meteorlake/Kconfig 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/69883/1 diff --git a/src/soc/intel/meteorlake/Kconfig b/src/soc/intel/meteorlake/Kconfig index b8e4052..5ec2135 100644 --- a/src/soc/intel/meteorlake/Kconfig +++ b/src/soc/intel/meteorlake/Kconfig @@ -16,7 +16,7 @@ select CPU_SUPPORTS_INTEL_TME select CPU_SUPPORTS_PM_TIMER_EMULATION select DEFAULT_X2APIC_LATE_WORKAROUND - select DISPLAY_FSP_VERSION_INFO + select DISPLAY_FSP_VERSION_INFO_2 select DRIVERS_USB_ACPI select EDK2_CPU_TIMER_LIB if PAYLOAD_EDK2 select FSP_COMPRESS_FSP_S_LZ4 @@ -90,6 +90,7 @@ select TSC_MONOTONIC_TIMER select UDELAY_TSC select UDK_202111_BINDING + config MAX_CPUS int -- To view, visit https://review.coreboot.org/c/coreboot/+/69883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I789db9d280c45639eca6ceafea65b96a93a395cf Gerrit-Change-Number: 69883 Gerrit-PatchSet: 1 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: src/soc/qualcomm: Remove unnecessary space after casts
by Elyes Haouas (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Hung-Te Lin, Martin L Roth, Yu-Ping Wu. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69807 ) Change subject: src/soc/qualcomm: Remove unnecessary space after casts ...................................................................... Patch Set 3: (1 comment) File src/soc/qualcomm/common/qspi.c: https://review.coreboot.org/c/coreboot/+/69807/comment/a65199ce_52624338 PS2, Line 115: > Nit: Another here Thank you -- To view, visit https://review.coreboot.org/c/coreboot/+/69807 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic6c711fe3fad19c24ca4c01f8d0a4bc002f14bd6 Gerrit-Change-Number: 69807 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 08:15:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/mediatek: Add error handling for dptx_get_edid()
by Yidi Lin (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69858 ) Change subject: soc/mediatek: Add error handling for dptx_get_edid() ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/69858 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0fd672b175feb9b813c1d9ec4140e4273079ff07 Gerrit-Change-Number: 69858 Gerrit-PatchSet: 4 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 08:01:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022