coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: soc/mediatek: Add error handling for dptx_get_edid()
by Liju-Clr Chen (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Hung-Te Lin, Liju-Clr Chen. Hello Hung-Te Lin, Rex-BC Chen, Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69858 to look at the new patch set (#3). Change subject: soc/mediatek: Add error handling for dptx_get_edid() ...................................................................... soc/mediatek: Add error handling for dptx_get_edid() Skip eDP initialization when we failed to get EDID. This prevents the PLL assertion in dp_intf_config() if the display could not be initialized properly. BUG=b:233720142 TEST=boot to depthcharge on MT8188 EVB. Change-Id: I0fd672b175feb9b813c1d9ec4140e4273079ff07 Signed-off-by: Liju-Clr Chen <liju-clr.chen(a)mediatek.com> --- M src/soc/mediatek/common/dp/dptx.c 1 file changed, 21 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/69858/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/69858 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0fd672b175feb9b813c1d9ec4140e4273079ff07 Gerrit-Change-Number: 69858 Gerrit-PatchSet: 3 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/brya/var/craask: Modify GPIOs for craaskneto/craaskino
by Eric Lai (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Tarun Tuli, David Wu, Ren Kuo, Reka Norman, Tyler Wang, Nick Vaccaro. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69693 ) Change subject: mb/google/brya/var/craask: Modify GPIOs for craaskneto/craaskino ...................................................................... Patch Set 6: (2 comments) File src/mainboard/google/brya/variants/craask/gpio.c: https://review.coreboot.org/c/coreboot/+/69693/comment/b87e8ec2_683ababc PS6, Line 160: if (id >= 0x20) { if(board_id() >= 20), if the value just use once, we can save the variable. File src/mainboard/google/brya/variants/craask/overridetree.cb: https://review.coreboot.org/c/coreboot/+/69693/comment/4726158a_1af75130 PS6, Line 448: device ref pcie_rp9 on Do you want to probe FW config here? -- To view, visit https://review.coreboot.org/c/coreboot/+/69693 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b9c90abe562768ea2afff5608a8cfac764569d5 Gerrit-Change-Number: 69693 Gerrit-PatchSet: 6 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 07:47:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in blobs[master]: soc/mediatek/mt8186: Update SSPM firmware from v1.0.0 to v2.0.0
by Yu-Ping Wu (Code Review) 22 Nov '22

22 Nov '22

Yu-Ping Wu has submitted this change. ( https://review.coreboot.org/c/blobs/+/69780 ) Change subject: soc/mediatek/mt8186: Update SSPM firmware from v1.0.0 to v2.0.0 ...................................................................... soc/mediatek/mt8186: Update SSPM firmware from v1.0.0 to v2.0.0 Add PMIC MT6315 support for SSPM. BUG=b:249436110 TEST=test of suspend and resume pass. Signed-off-by: Allen-KH Cheng <allen-kh.cheng(a)mediatek.com> Change-Id: I5cf5c0a46ce0af056dca6af7442a9ddb5be4b490 --- M soc/mediatek/mt8186/sspm.bin M soc/mediatek/mt8186/sspm.bin.md5 M soc/mediatek/mt8186/sspm_release_notes.txt 3 files changed, 19 insertions(+), 1 deletion(-) Approvals: Yu-Ping Wu: Verified; Looks good to me, approved Yidi Lin: Looks good to me, but someone else must approve diff --git a/soc/mediatek/mt8186/sspm.bin b/soc/mediatek/mt8186/sspm.bin index cb71d57..5a02ff9 100644 --- a/soc/mediatek/mt8186/sspm.bin +++ b/soc/mediatek/mt8186/sspm.bin Binary files differ diff --git a/soc/mediatek/mt8186/sspm.bin.md5 b/soc/mediatek/mt8186/sspm.bin.md5 index 974a48b..db23fda 100644 --- a/soc/mediatek/mt8186/sspm.bin.md5 +++ b/soc/mediatek/mt8186/sspm.bin.md5 @@ -1 +1 @@ -1092f052c52ad94135fa1cdc3abbffe4 *sspm.bin +3f46481d101daa07420edbc39f55537f *sspm.bin diff --git a/soc/mediatek/mt8186/sspm_release_notes.txt b/soc/mediatek/mt8186/sspm_release_notes.txt index d5e5158..37a7704 100644 --- a/soc/mediatek/mt8186/sspm_release_notes.txt +++ b/soc/mediatek/mt8186/sspm_release_notes.txt @@ -1,4 +1,7 @@ ** Build from MediaTek Internal ** +# v2.0.0 +1. Add PMIC MT6315 support for SSPM. + # v1.0.0 1. Add sspm.bin v1.0.0. -- To view, visit https://review.coreboot.org/c/blobs/+/69780 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: I5cf5c0a46ce0af056dca6af7442a9ddb5be4b490 Gerrit-Change-Number: 69780 Gerrit-PatchSet: 1 Gerrit-Owner: KuanHsun Cheng <Allen-KH.Cheng(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: merged

1 0

[S] Change in blobs[master]: soc/mediatek/mt8186: Update SSPM firmware from v1.0.0 to v2.0.0
by Yu-Ping Wu (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Hung-Te Lin, KuanHsun Cheng. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/69780 ) Change subject: soc/mediatek/mt8186: Update SSPM firmware from v1.0.0 to v2.0.0 ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://review.coreboot.org/c/blobs/+/69780 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: I5cf5c0a46ce0af056dca6af7442a9ddb5be4b490 Gerrit-Change-Number: 69780 Gerrit-PatchSet: 1 Gerrit-Owner: KuanHsun Cheng <Allen-KH.Cheng(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: KuanHsun Cheng <Allen-KH.Cheng(a)mediatek.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 07:38:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/mediatek: Add error handling for dptx_get_edid()
by Yu-Ping Wu (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Hung-Te Lin, Liju-Clr Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69858 ) Change subject: soc/mediatek: Add error handling for dptx_get_edid() ...................................................................... Patch Set 2: (1 comment) File src/soc/mediatek/common/dp/dptx.c: https://review.coreboot.org/c/coreboot/+/69858/comment/b2f8f065_ce3b0241 PS2, Line 1114: dptx_get_edid > dptx_get_edid() return 0 as success, return -1 as failure. […] Shouldn't this be `if (dptx_get_edid(&mtk_edp, edid))`? -- To view, visit https://review.coreboot.org/c/coreboot/+/69858 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0fd672b175feb9b813c1d9ec4140e4273079ff07 Gerrit-Change-Number: 69858 Gerrit-PatchSet: 2 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 07:38:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/mediatek: Add error handling for dptx_get_edid()
by Liju-Clr Chen (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Liju-Clr Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69858 ) Change subject: soc/mediatek: Add error handling for dptx_get_edid() ...................................................................... Patch Set 2: (1 comment) File src/soc/mediatek/common/dp/dptx.c: https://review.coreboot.org/c/coreboot/+/69858/comment/78ceedef_5a2e9360 PS2, Line 1114: dptx_get_edid > Doesn't this return -1 on error? dptx_get_edid() return 0 as success, return -1 as failure. I'm not sure what do you mean? -- To view, visit https://review.coreboot.org/c/coreboot/+/69858 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0fd672b175feb9b813c1d9ec4140e4273079ff07 Gerrit-Change-Number: 69858 Gerrit-PatchSet: 2 Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 07:18:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in blobs[master]: soc/mediatek/mt8186: Update SSPM firmware from v1.0.0 to v2.0.0
by Yidi Lin (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Hung-Te Lin, KuanHsun Cheng. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/69780 ) Change subject: soc/mediatek/mt8186: Update SSPM firmware from v1.0.0 to v2.0.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/blobs/+/69780 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: I5cf5c0a46ce0af056dca6af7442a9ddb5be4b490 Gerrit-Change-Number: 69780 Gerrit-PatchSet: 1 Gerrit-Owner: KuanHsun Cheng <Allen-KH.Cheng(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: KuanHsun Cheng <Allen-KH.Cheng(a)mediatek.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 06:59:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Select X86_INIT_NEED_1_SIPI Kconfig
by Kapil Porwal (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Paul Menzel, Arthur Heymans. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69851 ) Change subject: soc/intel/meteorlake: Select X86_INIT_NEED_1_SIPI Kconfig ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69851 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iec21470b9b34514169789c39bdc3be4e4ff6c7b5 Gerrit-Change-Number: 69851 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 22 Nov 2022 06:59:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Select X86_INIT_NEED_1_SIPI Kconfig
by Subrata Banik (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Paul Menzel, Kapil Porwal, Arthur Heymans. Hello build bot (Jenkins), Tarun Tuli, Kapil Porwal, Eric Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69851 to look at the new patch set (#5). Change subject: soc/intel/meteorlake: Select X86_INIT_NEED_1_SIPI Kconfig ...................................................................... soc/intel/meteorlake: Select X86_INIT_NEED_1_SIPI Kconfig This patch helps to save 10.200ms of booting time without any issue seen during MP Init. All cores are out from reset and alive. Port the Alder Lake 'commit 6526e7896727 ("soc/intel/alderlake: Select X86_INIT_NEED_1_SIPI Kconfig for RPL")' also to Meteor Lake. Additionally, no performance degradation is observed while running benchmarks. BUG=b:211770003 TEST=Able to boot Google, Rex to ChromeOS with all cores enabled. Without this patch: 30:device enumeration 1,480,217 (28,232) With this patch: 30:device enumeration 1,472,466 (18,334) Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Iec21470b9b34514169789c39bdc3be4e4ff6c7b5 --- M src/soc/intel/meteorlake/Kconfig 1 file changed, 28 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/69851/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/69851 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iec21470b9b34514169789c39bdc3be4e4ff6c7b5 Gerrit-Change-Number: 69851 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[XL] Change in coreboot[master]: mb/intel/mtlrvp: Configure devicetree and GPIOs for Meteor Lake-P
by Eric Lai (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Ashish Kumar Mishra, Harsha B R, Haribalaraman Ramasubramanian, Rizwan Qureshi, Sridhar Siricilla, Balaji Manigandan, Krishna P Bhat D, Usha P. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69396 ) Change subject: mb/intel/mtlrvp: Configure devicetree and GPIOs for Meteor Lake-P ...................................................................... Patch Set 13: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/69396 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3173c3f32b36d24467431df3652badd70efeab93 Gerrit-Change-Number: 69396 Gerrit-PatchSet: 13 Gerrit-Owner: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Reviewer: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Attention: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Attention: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 06:38:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022