coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: amdfwtool: Allow the location to be a relative address
by build bot (Jenkins) (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Zheng Bao. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69856 ) Change subject: amdfwtool: Allow the location to be a relative address ...................................................................... Patch Set 1: (6 comments) File util/amdfwtool/amdfwtool.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164215): https://review.coreboot.org/c/coreboot/+/69856/comment/55308f6f_8b9968b5 PS1, Line 2365: case 0xFA0000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164215): https://review.coreboot.org/c/coreboot/+/69856/comment/16dcf20f_8a396c0c PS1, Line 2366: case 0xF20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164215): https://review.coreboot.org/c/coreboot/+/69856/comment/f0e751fc_12332c30 PS1, Line 2367: case 0xE20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164215): https://review.coreboot.org/c/coreboot/+/69856/comment/be29d6a9_8d6bdfb2 PS1, Line 2368: case 0xC20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164215): https://review.coreboot.org/c/coreboot/+/69856/comment/d940274b_636b51e7 PS1, Line 2369: case 0x820000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164215): https://review.coreboot.org/c/coreboot/+/69856/comment/90368186_764c7e6b PS1, Line 2370: case 0x020000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment -- To view, visit https://review.coreboot.org/c/coreboot/+/69856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4308ec9ea05a87329aba0b409508c79ebf42325c Gerrit-Change-Number: 69856 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Zheng Bao Gerrit-Comment-Date: Tue, 22 Nov 2022 03:16:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: amdfwtool: Allow the amdfw.rom to be split into two parts
by Bao Zheng (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Zheng Bao. Hello Zheng Bao, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/69857 to review the following change. Change subject: amdfwtool: Allow the amdfw.rom to be split into two parts ...................................................................... amdfwtool: Allow the amdfw.rom to be split into two parts Split the big PSP FW data into two parts, head and body. The head needs to be located at specific location. The body address is more flexible. So the EC FW can be put to the address like 0x80000. Change-Id: Ic058cfaeebd1a947227cfa9be2db4eb22702aa28 Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M util/amdfwtool/amdfwtool.c 1 file changed, 65 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/69857/1 diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index 1d98e68..272e55c 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -193,11 +193,13 @@ printf("--bios-bin-dest <HEX_VAL> Destination for uncompressed BIOS\n"); printf("--bios-uncomp-size <HEX> Uncompressed size of BIOS image\n"); printf("--output <filename> output filename\n"); + printf("--body-output <filename> output of FW body filename\n"); printf("--flashsize <HEX_VAL> ROM size in bytes\n"); printf(" size must be larger than %dKB\n", MIN_ROM_KB); printf(" and must a multiple of 1024\n"); printf("--location Location of Directory\n"); + printf("--body-location Location of body of firmwares\n"); printf("--anywhere Use any 64-byte aligned addr for Directory\n"); printf("--sharedmem Location of PSP/FW shared memory\n"); printf("--sharedmem-size Maximum size of the PSP/FW shared memory\n"); @@ -1724,8 +1726,10 @@ AMDFW_OPT_APOB_NVSIZE, AMDFW_OPT_OUTPUT, + AMDFW_OPT_BODY_OUTPUT, AMDFW_OPT_FLASHSIZE, AMDFW_OPT_LOCATION, + AMDFW_OPT_FW_BODY_LOCATION, AMDFW_OPT_ANYWHERE, AMDFW_OPT_SHAREDMEM, AMDFW_OPT_SHAREDMEM_SIZE, @@ -1785,8 +1789,10 @@ {"spi-micron-flag", required_argument, 0, LONGOPT_SPI_MICRON_FLAG }, /* other */ {"output", required_argument, 0, AMDFW_OPT_OUTPUT }, + {"body-output", required_argument, 0, AMDFW_OPT_BODY_OUTPUT }, {"flashsize", required_argument, 0, AMDFW_OPT_FLASHSIZE }, {"location", required_argument, 0, AMDFW_OPT_LOCATION }, + {"body-location", required_argument, 0, AMDFW_OPT_FW_BODY_LOCATION }, {"anywhere", no_argument, 0, AMDFW_OPT_ANYWHERE }, {"sharedmem", required_argument, 0, AMDFW_OPT_SHAREDMEM }, {"sharedmem-size", required_argument, 0, AMDFW_OPT_SHAREDMEM_SIZE }, @@ -2041,7 +2047,7 @@ bool comboable = false; int fuse_defined = 0; int targetfd; - char *output = NULL, *config = NULL; + char *output = NULL, *body_output = NULL, *config = NULL; FILE *config_handle; context ctx = { 0 }; /* Values cleared after each firmware or parameter, regardless if N/A */ @@ -2050,6 +2056,7 @@ bool any_location = 0; uint32_t romsig_offset; uint32_t rom_base_address; + uint32_t romsig_head_size, fw_body_offset = 0xFFFFFFFF; uint8_t soc_id = PLATFORM_UNKNOWN; uint8_t efs_spi_readmode = 0xff; uint8_t efs_spi_speed = 0xff; @@ -2225,6 +2232,9 @@ case AMDFW_OPT_OUTPUT: output = optarg; break; + case AMDFW_OPT_BODY_OUTPUT: + body_output = optarg; + break; case AMDFW_OPT_FLASHSIZE: ctx.rom_size = (uint32_t)strtoul(optarg, &tmp, 16); if (*tmp != '\0') { @@ -2241,6 +2251,14 @@ retval = 1; } break; + case AMDFW_OPT_FW_BODY_LOCATION: + fw_body_offset = (uint32_t)strtoul(optarg, &tmp, 16); + if (*tmp != '\0') { + fprintf(stderr, "Error: Directory Location specified" + " incorrectly (%s)\n\n", optarg); + retval = 1; + } + break; case AMDFW_OPT_ANYWHERE: any_location = 1; break; @@ -2418,6 +2436,16 @@ ctx.address_mode == AMD_ADDR_PHYSICAL ? "absolute" : "relative", RUN_CURRENT(ctx)); + romsig_head_size = 0x1000; /* Hardcode */ + if (fw_body_offset != 0xFFFFFFFF) { + ctx.current += romsig_head_size; + + if (ctx.current <= fw_body_offset) + ctx.current = fw_body_offset; + else + return 1; + } + integrate_firmwares(&ctx, amd_romsig, amd_fw_table); ctx.current = ALIGN_UP(ctx.current, 0x10000U); /* TODO: is it necessary? */ @@ -2535,9 +2563,12 @@ targetfd = open(output, O_RDWR | O_CREAT | O_TRUNC, 0666); if (targetfd >= 0) { - ssize_t bytes; - bytes = write(targetfd, amd_romsig, ctx.current - romsig_offset); - if (bytes != ctx.current - romsig_offset) { + ssize_t bytes, write_bytes; + write_bytes = fw_body_offset == 0xFFFFFFFF ? + ctx.current - romsig_offset : + romsig_head_size; + bytes = write(targetfd, amd_romsig, write_bytes); + if (bytes != write_bytes) { fprintf(stderr, "Error: Writing to file %s failed\n", output); retval = 1; } @@ -2546,6 +2577,22 @@ fprintf(stderr, "Error: could not open file: %s\n", output); retval = 1; } + if (fw_body_offset != 0xFFFFFFFF && body_output != NULL) { + targetfd = open(body_output, O_RDWR | O_CREAT | O_TRUNC, 0666); + if (targetfd >= 0) { + ssize_t bytes; + + bytes = write(targetfd, BUFF_OFFSET(ctx, fw_body_offset), ctx.current - fw_body_offset); + if (bytes != ctx.current - fw_body_offset) { + fprintf(stderr, "Error: Writing to file %s failed\n", output); + retval = 1; + } + close(targetfd); + } else { + fprintf(stderr, "Error: could not open file: %s\n", body_output); + retval = 1; + } + } free(rom); return retval; -- To view, visit https://review.coreboot.org/c/coreboot/+/69857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic058cfaeebd1a947227cfa9be2db4eb22702aa28 Gerrit-Change-Number: 69857 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Attention: Zheng Bao Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: amdfwtool: Allow the location to be a relative address
by Bao Zheng (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Zheng Bao. Hello Zheng Bao, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/69856 to review the following change. Change subject: amdfwtool: Allow the location to be a relative address ...................................................................... amdfwtool: Allow the location to be a relative address When the BIOS size is more than 32M, the physical address of EFS header will be complicated, like 0xfe020000 or 0xfc020000. So we make it simpler to allow to use relative address. Change-Id: I4308ec9ea05a87329aba0b409508c79ebf42325c Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M util/amdfwtool/amdfwtool.c 1 file changed, 27 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/69856/1 diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index 5a4c034..1d98e68 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -2344,10 +2344,6 @@ printf(" AMDFWTOOL Using ROM size of %dKB\n", ctx.rom_size / 1024); rom_base_address = 0xFFFFFFFF - ctx.rom_size + 1; - if (dir_location && (dir_location < rom_base_address)) { - fprintf(stderr, "Error: Directory location outside of ROM.\n\n"); - return 1; - } if (any_location) { if (dir_location & 0x3f) { @@ -2357,18 +2353,29 @@ } } else { switch (dir_location) { - case 0: /* Fall through */ case 0xFFFA0000: /* Fall through */ case 0xFFF20000: /* Fall through */ case 0xFFE20000: /* Fall through */ case 0xFFC20000: /* Fall through */ case 0xFF820000: /* Fall through */ case 0xFF020000: /* Fall through */ + /* Physical address. */ + dir_location = dir_location - rom_base_address; + break; + case 0xFA0000: /* Fall through */ + case 0xF20000: /* Fall through */ + case 0xE20000: /* Fall through */ + case 0xC20000: /* Fall through */ + case 0x820000: /* Fall through */ + case 0x020000: /* Fall through */ + /* Relative address. */ break; default: fprintf(stderr, "Error: Invalid Directory location.\n"); fprintf(stderr, " Valid locations are 0xFFFA0000, 0xFFF20000,\n"); fprintf(stderr, " 0xFFE20000, 0xFFC20000, 0xFF820000, 0xFF020000\n"); + fprintf(stderr, " 0xFA0000, 0xF20000, 0xE20000, 0xC20000,\n"); + fprintf(stderr, " 0x820000, 0x020000\n"); return 1; } } @@ -2380,7 +2387,7 @@ memset(ctx.rom, 0xFF, ctx.rom_size); if (dir_location) - romsig_offset = ctx.current = dir_location - rom_base_address; + romsig_offset = ctx.current = dir_location; else romsig_offset = ctx.current = AMD_ROMSIG_OFFSET; -- To view, visit https://review.coreboot.org/c/coreboot/+/69856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4308ec9ea05a87329aba0b409508c79ebf42325c Gerrit-Change-Number: 69856 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Attention: Zheng Bao Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: amdfwtool: Add instance 1 for bios image
by Bao Zheng (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Zheng Bao. Hello build bot (Jenkins), Zheng Bao, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69151 to look at the new patch set (#8). Change subject: amdfwtool: Add instance 1 for bios image ...................................................................... amdfwtool: Add instance 1 for bios image Change-Id: Iaa40872b270cf9ff289794c8c51c4d8b448d862d Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M util/amdfwtool/amdfwtool.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/69151/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/69151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa40872b270cf9ff289794c8c51c4d8b448d862d Gerrit-Change-Number: 69151 Gerrit-PatchSet: 8 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Zheng Bao Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: amdfwtool: Add the new entry type for new family morgana
by Bao Zheng (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Bao Zheng, Jason Glenesk, Marshall Dawson, Matt DeVillier, Zheng Bao, Martin Roth. Hello build bot (Jenkins), Jason Glenesk, Martin L Roth, Marshall Dawson, Matt DeVillier, Zheng Bao, Martin Roth, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69045 to look at the new patch set (#9). Change subject: amdfwtool: Add the new entry type for new family morgana ...................................................................... amdfwtool: Add the new entry type for new family morgana Change-Id: I7565c5eda75b332a48613440d7e4cfb388d5012f Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h M util/amdfwtool/data_parse.c 3 files changed, 110 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/69045/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/69045 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7565c5eda75b332a48613440d7e4cfb388d5012f Gerrit-Change-Number: 69045 Gerrit-PatchSet: 9 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: drivers/vpd, cpu/x86/smm: Add VPD support for SMM
by Ed Sharma (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Arthur Heymans, Marc Jones, Subrata Banik, Johnny Lin, Christian Walter, Shuming Chu (Shuming), Michael Niewöhner, Kyösti Mälkki. Ed Sharma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67092 ) Change subject: drivers/vpd, cpu/x86/smm: Add VPD support for SMM ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/67092 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I418568ef53b6de46db9b02846543e592930effd3 Gerrit-Change-Number: 67092 Gerrit-PatchSet: 4 Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Ed Sharma <aeddiesharma(a)fb.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 02:52:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: [RFC] Pull libgfxinit in early romstage
by build bot (Jenkins) (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Nico Huber, Tarun Tuli, Martin L Roth, Jérémy Compostella, Angel Pons, Arthur Heymans, Kyösti Mälkki, Andrey Petrov. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69757 ) Change subject: [RFC] Pull libgfxinit in early romstage ...................................................................... Patch Set 4: (3 comments) File src/soc/intel/common/block/graphics/romstage.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164211): https://review.coreboot.org/c/coreboot/+/69757/comment/782f3a18_2e7a195a PS4, Line 27: if (CONFIG(ROMSTAGE_MAINBOARD_USE_LIBGFXINIT)) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164211): https://review.coreboot.org/c/coreboot/+/69757/comment/7aa1b4d1_c3e1e283 PS4, Line 27: if (CONFIG(ROMSTAGE_MAINBOARD_USE_LIBGFXINIT)) { please, no space before tabs Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164211): https://review.coreboot.org/c/coreboot/+/69757/comment/8d6d8595_6a891663 PS4, Line 27: if (CONFIG(ROMSTAGE_MAINBOARD_USE_LIBGFXINIT)) { please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/69757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If3357e746a7d94afe9d285c36ed6172c7bfd9718 Gerrit-Change-Number: 69757 Gerrit-PatchSet: 4 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jeremy Compostella <jeremy.compostella(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 02:50:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: [RFC] Pull libgfxinit in early romstage
by Jeremy Compostella (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Nico Huber, Tarun Tuli, Martin L Roth, Jérémy Compostella, Angel Pons, Arthur Heymans, Kyösti Mälkki, Andrey Petrov. Jeremy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69757 ) Change subject: [RFC] Pull libgfxinit in early romstage ...................................................................... Patch Set 3: (2 comments) File src/arch/x86/car.ld: https://review.coreboot.org/c/coreboot/+/69757/comment/eebf9bab_192b646e PS3, Line 72: * un-initialized variables which are initialized at runtime. Therefor, > 'Therefor' may be misspelled - perhaps 'Therefore'? Please fix. https://review.coreboot.org/c/coreboot/+/69757/comment/628eaed5_e0a11e21 PS3, Line 73: * they can be be placed in the .bss section.*/ > Possible repeated word: 'be' Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/69757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If3357e746a7d94afe9d285c36ed6172c7bfd9718 Gerrit-Change-Number: 69757 Gerrit-PatchSet: 3 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jeremy Compostella <jeremy.compostella(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 02:49:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: [RFC] Pull libgfxinit in early romstage
by Jérémy Compostella (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Nico Huber, Tarun Tuli, Martin L Roth, Jérémy Compostella, Angel Pons, Arthur Heymans, Kyösti Mälkki, Andrey Petrov. Hello build bot (Jenkins), Tarun Tuli, Martin L Roth, Subrata Banik, Angel Pons, Arthur Heymans, Kyösti Mälkki, Andrey Petrov, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69757 to look at the new patch set (#4). Change subject: [RFC] Pull libgfxinit in early romstage ...................................................................... [RFC] Pull libgfxinit in early romstage The goal is to display a text message while memory training is in progress. Change-Id: If3357e746a7d94afe9d285c36ed6172c7bfd9718 Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> --- M Makefile M src/arch/x86/car.ld M src/console/Makefile.inc M src/device/Kconfig M src/drivers/intel/fsp2_0/Kconfig M src/drivers/intel/fsp2_0/memory_init.c M src/drivers/intel/gma/Kconfig M src/drivers/intel/gma/Makefile.inc M src/drivers/pc80/vga/Kconfig M src/drivers/pc80/vga/Makefile.inc M src/include/adainit.h M src/lib/Kconfig M src/lib/Makefile.inc M src/lib/gnat/Makefile.inc M src/mainboard/google/brya/Makefile.inc A src/mainboard/google/brya/gma-mainboard.ads M src/soc/intel/alderlake/Kconfig M src/soc/intel/alderlake/romstage/Makefile.inc A src/soc/intel/alderlake/romstage/graphics.c M src/soc/intel/common/block/graphics/Makefile.inc A src/soc/intel/common/block/graphics/romstage.c 21 files changed, 318 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/69757/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/69757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If3357e746a7d94afe9d285c36ed6172c7bfd9718 Gerrit-Change-Number: 69757 Gerrit-PatchSet: 4 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jeremy Compostella <jeremy.compostella(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: [RFC] Pull libgfxinit in early romstage
by Jeremy Compostella (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Nico Huber, Tarun Tuli, Martin L Roth, Jérémy Compostella, Angel Pons, Arthur Heymans, Kyösti Mälkki, Andrey Petrov. Jeremy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69757 ) Change subject: [RFC] Pull libgfxinit in early romstage ...................................................................... Patch Set 3: (3 comments) File src/soc/intel/common/block/graphics/romstage.c: https://review.coreboot.org/c/coreboot/+/69757/comment/eb675290_71d7cfde PS3, Line 27: if (CONFIG(ROMSTAGE_MAINBOARD_USE_LIBGFXINIT)) { > please, no space before tabs Please fix. https://review.coreboot.org/c/coreboot/+/69757/comment/ad43634b_0691415d PS3, Line 27: if (CONFIG(ROMSTAGE_MAINBOARD_USE_LIBGFXINIT)) { > please, no spaces at the start of a line Please fix. https://review.coreboot.org/c/coreboot/+/69757/comment/15a8e76e_f5aec749 PS3, Line 27: if (CONFIG(ROMSTAGE_MAINBOARD_USE_LIBGFXINIT)) { > code indent should use tabs where possible Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/69757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If3357e746a7d94afe9d285c36ed6172c7bfd9718 Gerrit-Change-Number: 69757 Gerrit-PatchSet: 3 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jeremy Compostella <jeremy.compostella(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 02:47:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022