coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2
by build bot (Jenkins) (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Saurabh Mishra, Tarun Tuli, Kapil Porwal, Balaji Manigandan. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69883 ) Change subject: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2 ...................................................................... Patch Set 4: (1 comment) File src/soc/intel/meteorlake/Kconfig: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164233): https://review.coreboot.org/c/coreboot/+/69883/comment/943a1a9a_edb78466 PS4, Line 93: trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/69883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I789db9d280c45639eca6ceafea65b96a93a395cf Gerrit-Change-Number: 69883 Gerrit-PatchSet: 4 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 09:19:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2
by Saurabh Mishra (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Saurabh Mishra, Tarun Tuli, Kapil Porwal, Balaji Manigandan. Hello Tarun Tuli, Subrata Banik, Kapil Porwal, Balaji Manigandan, Ronak Kanabar, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69883 to look at the new patch set (#4). Change subject: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2 ...................................................................... soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2 Changes include: - Select DISPLAY_FSP_VERSION_INFO_2 for Meteor Lake soc. BUG=TBD BRANCH=None TEST=Verify MTL Rex0 build with all the patch in relation chain and verify the version output prints no junk data observed. Signed-off-by: Saurabh Mishra <mishra.saurabh(a)intel.com> Change-Id: I789db9d280c45639eca6ceafea65b96a93a395cf --- M src/soc/intel/meteorlake/Kconfig 1 file changed, 20 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/69883/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/69883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I789db9d280c45639eca6ceafea65b96a93a395cf Gerrit-Change-Number: 69883 Gerrit-PatchSet: 4 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: vc/intel/fsp/mtl: Remove deprecated header FirmwareVersionInfoHob.h
by Saurabh Mishra (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Hello Tarun Tuli, Subrata Banik, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69884 to look at the new patch set (#5). Change subject: vc/intel/fsp/mtl: Remove deprecated header FirmwareVersionInfoHob.h ...................................................................... vc/intel/fsp/mtl: Remove deprecated header FirmwareVersionInfoHob.h Changes include: - FirmwareVersionInfoHob.h is removed to use new FirmwareVersionInfo.h BUG=TBD BRANCH=None TEST=Verify MTL Rex0 build with all the patch in relation chain and verify the version output prints no junk data observed. Signed-off-by: Saurabh Mishra <mishra.saurabh(a)intel.com> Change-Id: I06fd89f201e9e4100524e58033086327ad4ffc7b --- D src/vendorcode/intel/fsp/fsp2_0/meteorlake/FirmwareVersionInfoHob.h 1 file changed, 18 insertions(+), 68 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/69884/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/69884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I06fd89f201e9e4100524e58033086327ad4ffc7b Gerrit-Change-Number: 69884 Gerrit-PatchSet: 5 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XL] Change in coreboot[master]: mb/intel/mtlrvp: Configure devicetree and GPIOs for Meteor Lake-P
by Harsha B R (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Haribalaraman Ramasubramanian, Krishna P Bhat D, Eric Lai. Harsha B R has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69396 ) Change subject: mb/intel/mtlrvp: Configure devicetree and GPIOs for Meteor Lake-P ...................................................................... Patch Set 14: Code-Review+1 (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/69396/comment/fd077c84_dafe43a5 PS13, Line 9: Add devicetree and GPIO configuration for Metero Lake-P. > nit: Meteor Lake-P. Ack File src/mainboard/intel/mtlrvp/Kconfig: https://review.coreboot.org/c/coreboot/+/69396/comment/ea85e737_2a11feb7 PS13, Line 16: select HAVE_ACPI_RESUME > nit: Alphabetically order the Kconfigs. Ack File src/mainboard/intel/mtlrvp/variants/mtlrvp_p/overridetree.cb: https://review.coreboot.org/c/coreboot/+/69396/comment/743adfdd_194fb6d3 PS13, Line 1: chip soc/intel/alderlake > meteorlake Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/69396 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3173c3f32b36d24467431df3652badd70efeab93 Gerrit-Change-Number: 69396 Gerrit-PatchSet: 14 Gerrit-Owner: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Reviewer: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 09:15:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: mb/intel/mtlrvp: Configure devicetree and GPIOs for Meteor Lake-P
by Harsha B R (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Harsha B R, Haribalaraman Ramasubramanian, Eric Lai. Hello Ashish Kumar Mishra, build bot (Jenkins), Haribalaraman Ramasubramanian, Rizwan Qureshi, Sridhar Siricilla, Balaji Manigandan, Krishna P Bhat D, Eric Lai, Usha P, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69396 to look at the new patch set (#14). Change subject: mb/intel/mtlrvp: Configure devicetree and GPIOs for Meteor Lake-P ...................................................................... mb/intel/mtlrvp: Configure devicetree and GPIOs for Meteor Lake-P Add devicetree and GPIO configuration for Meteor Lake-P. Changes include, 1. Modify existing devicetree.cb to support MTL-RVP board and variant 2. Add separate file for MTL-P GPIOs 3. Add overridetree MTL-P variant BRANCH=none BUG=b:224325352 TEST=emerge-rex coreboot chromeos-bootimage Signed-off-by: Harsha B R <harsha.b.r(a)intel.com> Change-Id: I3173c3f32b36d24467431df3652badd70efeab93 --- M src/mainboard/intel/mtlrvp/Kconfig M src/mainboard/intel/mtlrvp/Makefile.inc M src/mainboard/intel/mtlrvp/devicetree.cb A src/mainboard/intel/mtlrvp/gpio.c A src/mainboard/intel/mtlrvp/include/baseboard/board_id.h A src/mainboard/intel/mtlrvp/include/baseboard/variants.h A src/mainboard/intel/mtlrvp/variants/mtlrvp_p/overridetree.cb 7 files changed, 1,113 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/69396/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/69396 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3173c3f32b36d24467431df3652badd70efeab93 Gerrit-Change-Number: 69396 Gerrit-PatchSet: 14 Gerrit-Owner: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Reviewer: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Attention: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2
by Subrata Banik (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Saurabh Mishra, Tarun Tuli, Kapil Porwal, Balaji Manigandan. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69883 ) Change subject: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2 ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: this order is broken now.You can't delete the existing header when u have Kconfig selected -- To view, visit https://review.coreboot.org/c/coreboot/+/69883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I789db9d280c45639eca6ceafea65b96a93a395cf Gerrit-Change-Number: 69883 Gerrit-PatchSet: 3 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 09:03:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/amd/mendocino: Enhance DPTC_INPUT to support 13 DPTC thermal para...
by Chris Wang (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Jason Nien, EricKY Cheng, Matt DeVillier, Martin Roth, Tim Van Patten, Fred Reitberger, Felix Held. Chris Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68649 ) Change subject: soc/amd/mendocino: Enhance DPTC_INPUT to support 13 DPTC thermal parameters ...................................................................... Patch Set 31: (1 comment) File src/soc/amd/mendocino/root_complex.c: https://review.coreboot.org/c/coreboot/+/68649/comment/a8e850d7_9382d3cb PS16, Line 393: #else > My concern is that the new fields added to `DPTC_INPUTS()` need to be added to `google/skyrim/varian […] for below settings vrm_current_limit_throttle_mA, vrm_maximum_current_limit_throttle_mA, vrm_soc_current_limit_throttle_mA, since the below settings will apply to dptc parameters, it's better to follow AMD IRM, or you have your own setting that needs to apply to. There's no other STT setting that will be changed via DPTC, so those values will keep the value you set to default in devtree. -- To view, visit https://review.coreboot.org/c/coreboot/+/68649 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d6a00f0eca0b0941860b9bc75da41d7a10d60e8 Gerrit-Change-Number: 68649 Gerrit-PatchSet: 31 Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nelson Ye <nelson_ye(a)compal.corp-partner.google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 22 Nov 2022 09:02:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: security/tpm: resolve conflicts in TSS implementations
by Yu-Ping Wu (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Michał Żygowski, Frans Hendriks, Matt DeVillier, Christian Walter, Julius Werner, Krystian Hebel, Fred Reitberger, Sergii Dmytruk, Felix Held. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69160 ) Change subject: security/tpm: resolve conflicts in TSS implementations ...................................................................... Patch Set 8: (6 comments) File src/security/tpm/Makefile.inc: https://review.coreboot.org/c/coreboot/+/69160/comment/6b11723c_df60b8d6 PS8, Line 13: ramstage-y += tss/tss.c : romstage-y += tss/tss.c : bootblock-y += tss/tss.c : verstage-y += tss/tss.c : postcar-y += tss/tss.c Can use `all-y` for all classes (bootblock verstage romstage postcar ramstage). File src/security/tpm/tss.h: https://review.coreboot.org/c/coreboot/+/69160/comment/3e8c476c_4ffd9ff9 PS8, Line 19: #include <security/tpm/tis.h> Sort the headers. File src/security/tpm/tss/tss.c: https://review.coreboot.org/c/coreboot/+/69160/comment/378eba8e_53fecf91 PS8, Line 17: chose choose https://review.coreboot.org/c/coreboot/+/69160/comment/7712adac_bbb78d57 PS8, Line 20: Extra blank line. https://review.coreboot.org/c/coreboot/+/69160/comment/1b9f60ae_ddee9817 PS8, Line 22: VB2_SUCCESS Not related to your change, but why does this function return VB2_*? Can't we just return something like 0/1/-1 here? https://review.coreboot.org/c/coreboot/+/69160/comment/4d2fe69b_39407363 PS8, Line 37: if (CONFIG(TPM1) && family == TPM_1) : return tlcl1_startup(); : if (CONFIG(TPM2) && family == TPM_2) : return tlcl2_startup(); : return TPM_E_INTERNAL_INCONSISTENCY; I wonder if we can define a macro to simplify the functions below: ``` #define TLCL_CALL(name, ...) do { if (CONFIG(TPM1) && family == TPM_1) return tlcl1_##name(__VA_ARGS__); ... } while (0) ``` Then we could use it like ``` TLCL_CALL(extend, pcr_num, in_digest, out_digest); ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/69160 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia0ea5a917c46ada9fc3274f17240e12bca98db6a Gerrit-Change-Number: 69160 Gerrit-PatchSet: 8 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 22 Nov 2022 09:01:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: vc/intel/fsp/mtl: Add new FirmwareVersionInfo.h
by Saurabh Mishra (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Balaji Manigandan, Ronak Kanabar. Hello Tarun Tuli, Subrata Banik, Kapil Porwal, Balaji Manigandan, Ronak Kanabar, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69882 to look at the new patch set (#7). Change subject: vc/intel/fsp/mtl: Add new FirmwareVersionInfo.h ...................................................................... vc/intel/fsp/mtl: Add new FirmwareVersionInfo.h Changes include: - Add FirmwareVersionInfo.h BUG=TBD BRANCH=None TEST=Verify MTL Rex0 build with all the patch in relation chain and verify the version output prints no junk data observed. Signed-off-by: Saurabh Mishra <mishra.saurabh(a)intel.com> Change-Id: Ib5c843bb0dccd5db92f74148df3a17037988392c --- A src/vendorcode/intel/fsp/fsp2_0/meteorlake/FirmwareVersionInfo.h 1 file changed, 72 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/69882/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/69882 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib5c843bb0dccd5db92f74148df3a17037988392c Gerrit-Change-Number: 69882 Gerrit-PatchSet: 7 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2
by Ronak Kanabar (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Saurabh Mishra, Tarun Tuli, Subrata Banik, Kapil Porwal, Balaji Manigandan. Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69883 ) Change subject: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2 ...................................................................... Patch Set 3: (1 comment) File src/soc/intel/meteorlake/Kconfig: https://review.coreboot.org/c/coreboot/+/69883/comment/b11f253b_8dd7de2d PS3, Line 93: > trailing whitespace Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/69883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I789db9d280c45639eca6ceafea65b96a93a395cf Gerrit-Change-Number: 69883 Gerrit-PatchSet: 3 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 08:45:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022