coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2
by Saurabh Mishra (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Balaji Manigandan, Ronak Kanabar. Saurabh Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69883 ) Change subject: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2 ...................................................................... Patch Set 5: (1 comment) File src/soc/intel/meteorlake/Kconfig: https://review.coreboot.org/c/coreboot/+/69883/comment/053875d4_d29a1c52 PS4, Line 93: > > trailing whitespace […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/69883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I789db9d280c45639eca6ceafea65b96a93a395cf Gerrit-Change-Number: 69883 Gerrit-PatchSet: 5 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 09:27:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2
by Saurabh Mishra (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Saurabh Mishra, Tarun Tuli, Subrata Banik, Kapil Porwal, Balaji Manigandan. Hello Tarun Tuli, Subrata Banik, Kapil Porwal, Balaji Manigandan, Ronak Kanabar, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69883 to look at the new patch set (#5). Change subject: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2 ...................................................................... soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2 Changes include: - Select DISPLAY_FSP_VERSION_INFO_2 for Meteor Lake soc. BUG=TBD BRANCH=None TEST=Verify MTL Rex0 build with all the patch in relation chain and verify the version output prints no junk data observed. Signed-off-by: Saurabh Mishra <mishra.saurabh(a)intel.com> Change-Id: I789db9d280c45639eca6ceafea65b96a93a395cf --- M src/soc/intel/meteorlake/Kconfig 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/69883/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/69883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I789db9d280c45639eca6ceafea65b96a93a395cf Gerrit-Change-Number: 69883 Gerrit-PatchSet: 5 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2
by Ronak Kanabar (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Saurabh Mishra, Tarun Tuli, Subrata Banik, Kapil Porwal, Balaji Manigandan. Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69883 ) Change subject: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2 ...................................................................... Patch Set 4: (1 comment) File src/soc/intel/meteorlake/Kconfig: https://review.coreboot.org/c/coreboot/+/69883/comment/326a87fe_9ca13ba0 PS4, Line 93: > trailing whitespace Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/69883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I789db9d280c45639eca6ceafea65b96a93a395cf Gerrit-Change-Number: 69883 Gerrit-PatchSet: 4 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 09:26:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2
by Saurabh Mishra (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Balaji Manigandan, Ronak Kanabar. Saurabh Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69883 ) Change subject: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2 ...................................................................... Patch Set 4: (1 comment) File src/soc/intel/meteorlake/Kconfig: https://review.coreboot.org/c/coreboot/+/69883/comment/7616465c_ee2ced59 PS3, Line 93: > > trailing whitespace […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/69883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I789db9d280c45639eca6ceafea65b96a93a395cf Gerrit-Change-Number: 69883 Gerrit-PatchSet: 4 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 09:24:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/brya/var/craask: Modify GPIOs for craaskneto/craaskino
by Ren Kuo (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Tarun Tuli, David Wu, Reka Norman, Tyler Wang, Nick Vaccaro, Eric Lai. Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69693 ) Change subject: mb/google/brya/var/craask: Modify GPIOs for craaskneto/craaskino ...................................................................... Patch Set 6: (2 comments) File src/mainboard/google/brya/variants/craask/gpio.c: https://review.coreboot.org/c/coreboot/+/69693/comment/2bef3f0a_b392aba6 PS6, Line 160: if (id >= 0x20) { > if(board_id() >= 20), if the value just use once, we can save the variable. This is for crasskneto/craskino projects GPIO pads to divide from crask project. The craask project's board id is 0x0 ~ 0x1f. The craaskneto/craaskion project's board is is 0x20 ~ File src/mainboard/google/brya/variants/craask/overridetree.cb: https://review.coreboot.org/c/coreboot/+/69693/comment/8baaff8c_a0d0ce19 PS6, Line 448: device ref pcie_rp9 on > Do you want to probe FW config here? I plan to update another CL to proble eMMC and nVME storage. The CL is for easy test on photo DUTs. -- To view, visit https://review.coreboot.org/c/coreboot/+/69693 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b9c90abe562768ea2afff5608a8cfac764569d5 Gerrit-Change-Number: 69693 Gerrit-PatchSet: 6 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 09:24:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: sb/intel/common: Improve TCO code
by Elyes Haouas (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Patrick Rudolph. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27678 ) Change subject: sb/intel/common: Improve TCO code ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Oops! sorry for the rebase. -- To view, visit https://review.coreboot.org/c/coreboot/+/27678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f0b439325227f3fb9f409a56f66256b5a9587d0 Gerrit-Change-Number: 27678 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 22 Nov 2022 09:23:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: sb/intel/common: Improve TCO code
by Elyes Haouas (Code Review) 22 Nov '22

22 Nov '22

Elyes Haouas has uploaded a new patch set (#2) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/27678 ) Change subject: sb/intel/common: Improve TCO code ...................................................................... sb/intel/common: Improve TCO code * Use register access like on soc/intel * Fix comment spelling * Report unhandled TCO bits in SMM (was dead code) Change-Id: I5f0b439325227f3fb9f409a56f66256b5a9587d0 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/southbridge/intel/common/pmutil.c M src/southbridge/intel/common/pmutil.h M src/southbridge/intel/common/smihandler.c 3 files changed, 27 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/27678/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/27678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5f0b439325227f3fb9f409a56f66256b5a9587d0 Gerrit-Change-Number: 27678 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: drivers/net/phy/m88e1512: Provide functionality to customize LED status
by Mario Scheithauer (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Arthur Heymans, Werner Zeh. Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69386 ) Change subject: drivers/net/phy/m88e1512: Provide functionality to customize LED status ...................................................................... Patch Set 16: (1 comment) File src/drivers/phy/m88e1512/m88e1512.c: https://review.coreboot.org/c/coreboot/+/69386/comment/510457f6_836298e8 PS10, Line 18: : const struct mdio_operations *mdio_ops; : struct device *parent = dev->bus->dev; > Ack Hi Arthur, could you please look over the MDIO interface again, if it fits so far now? Thanks in advance. -- To view, visit https://review.coreboot.org/c/coreboot/+/69386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia71c43f4286f9201f03cb759252ebb405ab81904 Gerrit-Change-Number: 69386 Gerrit-PatchSet: 16 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 09:20:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2
by Saurabh Mishra (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Balaji Manigandan. Saurabh Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69883 ) Change subject: soc/intel/meteorlake: Select DISPLAY_FSP_VERSION_INFO_2 ...................................................................... Patch Set 4: (1 comment) Patchset: PS3: > this order is broken now. […] Fixed. -- To view, visit https://review.coreboot.org/c/coreboot/+/69883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I789db9d280c45639eca6ceafea65b96a93a395cf Gerrit-Change-Number: 69883 Gerrit-PatchSet: 4 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 09:20:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: vc/intel/fsp/mtl: Add new header FirmwareVersionInfo.h
by Saurabh Mishra (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Balaji Manigandan, Ronak Kanabar. Hello Tarun Tuli, Subrata Banik, Kapil Porwal, Balaji Manigandan, Ronak Kanabar, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69882 to look at the new patch set (#8). Change subject: vc/intel/fsp/mtl: Add new header FirmwareVersionInfo.h ...................................................................... vc/intel/fsp/mtl: Add new header FirmwareVersionInfo.h Changes include: - Add FirmwareVersionInfo.h BUG=TBD BRANCH=None TEST=Verify MTL Rex0 build with all the patch in relation chain and verify the version output prints no junk data observed. Signed-off-by: Saurabh Mishra <mishra.saurabh(a)intel.com> Change-Id: Ib5c843bb0dccd5db92f74148df3a17037988392c --- A src/vendorcode/intel/fsp/fsp2_0/meteorlake/FirmwareVersionInfo.h 1 file changed, 72 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/69882/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/69882 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib5c843bb0dccd5db92f74148df3a17037988392c Gerrit-Change-Number: 69882 Gerrit-PatchSet: 8 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022