coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: ec/google/chromeec: Fix clang warnings
by Arthur Heymans (Code Review) 23 Nov '22

23 Nov '22

Attention is currently required from: Caveh Jalali, Julius Werner, Arthur Heymans, Boris Mittelberg. Hello build bot (Jenkins), Caveh Jalali, Julius Werner, Boris Mittelberg, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69742 to look at the new patch set (#4). Change subject: ec/google/chromeec: Fix clang warnings ...................................................................... ec/google/chromeec: Fix clang warnings Clang warns about structs inside a union also needing the packed attribute. Change-Id: I8b5233618081db86caedcb2d14870974e109ed9b Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/ec/google/chromeec/ec_commands.h 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/69742/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/69742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b5233618081db86caedcb2d14870974e109ed9b Gerrit-Change-Number: 69742 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: arch/arm: Use unified assembly syntax
by Arthur Heymans (Code Review) 23 Nov '22

23 Nov '22

Attention is currently required from: Arthur Heymans, Julius Werner. Arthur Heymans has uploaded a new patch set (#29) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/63058 ) Change subject: arch/arm: Use unified assembly syntax ...................................................................... arch/arm: Use unified assembly syntax Taken from Linux which also updated these files. Clang only works with this syntax, so this fixes builds for arm. TESTED on qemu vexpress-a9 and verstage on google/vilboz with BUILD_TIMELESS=1, binaries remain the same. Change-Id: Ia320dc2c460c99d934b8f17dee7748a9def4e750 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/arch/arm/libgcc/lib1funcs.S M src/arch/arm/memcpy.S M src/arch/arm/memmove.S M src/arch/arm/memset.S 4 files changed, 59 insertions(+), 34 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/63058/29 -- To view, visit https://review.coreboot.org/c/coreboot/+/63058 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia320dc2c460c99d934b8f17dee7748a9def4e750 Gerrit-Change-Number: 63058 Gerrit-PatchSet: 29 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: arch/x86: Buildtest clang targets with VBOOT_STARTS_BEFORE_BOOTBLOCK
by Martin L Roth (Code Review) 23 Nov '22

23 Nov '22

Attention is currently required from: Arthur Heymans, Martin Roth. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69746 ) Change subject: arch/x86: Buildtest clang targets with VBOOT_STARTS_BEFORE_BOOTBLOCK ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Patchset: PS5: Awesome! Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/69746 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie115c27b4cb0b8f83d7647bdd27ffcbac9376399 Gerrit-Change-Number: 69746 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 22:14:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: arch/arm/armv7: Disable generating neon FPU code
by Martin L Roth (Code Review) 23 Nov '22

23 Nov '22

Attention is currently required from: Julius Werner, Arthur Heymans. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69745 ) Change subject: arch/arm/armv7: Disable generating neon FPU code ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I48fc505107d131466be39f466151df62b2d2bd0b Gerrit-Change-Number: 69745 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 22 Nov 2022 22:14:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: arm/armv7/Makefile.inc: Fix processing ld files with clang
by Martin L Roth (Code Review) 23 Nov '22

23 Nov '22

Attention is currently required from: Julius Werner, Arthur Heymans. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69744 ) Change subject: arm/armv7/Makefile.inc: Fix processing ld files with clang ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69744 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I040aa14a06c728269ca1026e0002392e5ac8fef8 Gerrit-Change-Number: 69744 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 22 Nov 2022 22:13:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: arch/arm: Use unified assembly syntax
by Arthur Heymans (Code Review) 23 Nov '22

23 Nov '22

Attention is currently required from: Arthur Heymans, Julius Werner. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63058 ) Change subject: arch/arm: Use unified assembly syntax ...................................................................... Patch Set 28: (1 comment) Patchset: PS28: > Does this fix the clang issues with ARM? The commit message could maybe have some information about WHY we're making this change. > > Other than that, I think the patch looks good. I'm not the ARM asm expert, but it looks like most of the changes are just ordering. Clang indeed only works with this syntax. I'll add it to the commit message. -- To view, visit https://review.coreboot.org/c/coreboot/+/63058 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia320dc2c460c99d934b8f17dee7748a9def4e750 Gerrit-Change-Number: 63058 Gerrit-PatchSet: 28 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Tue, 22 Nov 2022 22:11:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: arch/arm/eabi_compat.c: Add eabi_clrX and eabi_memcyX
by Martin L Roth (Code Review) 23 Nov '22

23 Nov '22

Attention is currently required from: Julius Werner, Arthur Heymans. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69743 ) Change subject: arch/arm/eabi_compat.c: Add eabi_clrX and eabi_memcyX ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/69743/comment/2c01dd91_52bb684f PS5, Line 7: arch/arm/eabi_compat.c: Add eabi_clrX and eabi_memcyX Where did these macros originate? Is the license compatible with the GPL-2.0-or-later license in the file? -- To view, visit https://review.coreboot.org/c/coreboot/+/69743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I460a0096918141c1cf8826bdf1853a3aa3aecff8 Gerrit-Change-Number: 69743 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 22 Nov 2022 22:09:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: ec/google/chromeec: Fix clang warnings
by Martin L Roth (Code Review) 23 Nov '22

23 Nov '22

Attention is currently required from: Caveh Jalali, Julius Werner, Arthur Heymans, Boris Mittelberg. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69742 ) Change subject: ec/google/chromeec: Fix clang warnings ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: > the primary instance of this file is in the chromium EC tree. […] Caveh, coreboot engineers are not responsible for making changes in the chromeEC codebase. That's up to Google. When this file was copied into the coreboot codebase, it became part of coreboot. So long as it doesn't affect the output, think that the code changes are free to go either way, if Google wants to take them. Arthur, do these changes make any difference to the GCC output, or is it still identical? Maybe mark these changes with a /* coreboot change */ so that they don't get removed the next time the file is updated? PS3: U -- To view, visit https://review.coreboot.org/c/coreboot/+/69742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b5233618081db86caedcb2d14870974e109ed9b Gerrit-Change-Number: 69742 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 22:07:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Caveh Jalali <caveh(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: arch/arm: Use unified assembly syntax
by Martin L Roth (Code Review) 23 Nov '22

23 Nov '22

Attention is currently required from: Arthur Heymans, Julius Werner. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63058 ) Change subject: arch/arm: Use unified assembly syntax ...................................................................... Patch Set 28: Code-Review+2 (1 comment) Patchset: PS28: Does this fix the clang issues with ARM? The commit message could maybe have some information about WHY we're making this change. Other than that, I think the patch looks good. I'm not the ARM asm expert, but it looks like most of the changes are just ordering. -- To view, visit https://review.coreboot.org/c/coreboot/+/63058 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia320dc2c460c99d934b8f17dee7748a9def4e750 Gerrit-Change-Number: 63058 Gerrit-PatchSet: 28 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 22 Nov 2022 22:01:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/brya/var/craask: Modify GPIOs for craaskneto/craaskino
by Nick Vaccaro (Code Review) 22 Nov '22

22 Nov '22

Attention is currently required from: Tarun Tuli, David Wu, Ren Kuo, Reka Norman, Tyler Wang, Eric Lai. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69693 ) Change subject: mb/google/brya/var/craask: Modify GPIOs for craaskneto/craaskino ...................................................................... Patch Set 6: (4 comments) File src/mainboard/google/brya/variants/craask/fw_config.c: https://review.coreboot.org/c/coreboot/+/69693/comment/faf2b28e_4cb5d645 PS6, Line 67: /* craask: board id = 0x00 ~ 0x1f */ > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/69693/comment/9aa1f5b8_c181e25d PS6, Line 95: /* craaskneto/craaskino: board id >= 0x20 */ > code indent should use tabs where possible Please fix. https://review.coreboot.org/c/coreboot/+/69693/comment/8ba505a7_e514551c PS6, Line 103: gpio_padbased_override(padbased_table, wfc_disable_pads, Since you're disabling MIPI WFC in both cases ((id >= 0x20) || (id < 0x20)), why not just set the pads as disabled in the main gpio tables in variant/craask/gpio.c? File src/mainboard/google/brya/variants/craask/gpio.c: https://review.coreboot.org/c/coreboot/+/69693/comment/8b855118_53d30a62 PS6, Line 160: 0x20 This magic number 0x20 is used a fair amount in different source files, would be nice to assign a variable name to it, perhaps something like "KNETO_KINO_BOARD_ID_MIN" ? -- To view, visit https://review.coreboot.org/c/coreboot/+/69693 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b9c90abe562768ea2afff5608a8cfac764569d5 Gerrit-Change-Number: 69693 Gerrit-PatchSet: 6 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 21:53:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022