coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: arch/arm/eabi_compat.c: Add eabi_clrX and eabi_memcyX
by Arthur Heymans (Code Review) 23 Nov '22

23 Nov '22

Attention is currently required from: Martin L Roth, Julius Werner. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69743 ) Change subject: arch/arm/eabi_compat.c: Add eabi_clrX and eabi_memcyX ...................................................................... Patch Set 8: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/69743/comment/36e51a10_c15d1af2 PS5, Line 7: arch/arm/eabi_compat.c: Add eabi_clrX and eabi_memcyX > Where did these macros originate? Is the license compatible with the GPL-2.0-or-later license in the file? I already can't remember. I think it's the results of googling things... I wrote the memcpyx ones myself. File src/arch/arm/eabi_compat.c: https://review.coreboot.org/c/coreboot/+/69743/comment/122248db_a03cbcc6 PS6, Line 26: __aeabi_memclr Just wrong... -- To view, visit https://review.coreboot.org/c/coreboot/+/69743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I460a0096918141c1cf8826bdf1853a3aa3aecff8 Gerrit-Change-Number: 69743 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Tue, 22 Nov 2022 22:29:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: sb/intel/i82801gx: Move SPIBASE and SPIBARxx to i82801gx.h
by Martin L Roth (Code Review) 23 Nov '22

23 Nov '22

Attention is currently required from: Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69899 ) Change subject: sb/intel/i82801gx: Move SPIBASE and SPIBARxx to i82801gx.h ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69899 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb8487c7757b89a09c1cee4a83f94b9077dac87e Gerrit-Change-Number: 69899 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 22 Nov 2022 22:29:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Revert "mb/google/brya/var/kano: select SOC_INTEL_RAPTORLAKE"
by Nick Vaccaro (Code Review) 23 Nov '22

23 Nov '22

Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69919 ) Change subject: Revert "mb/google/brya/var/kano: select SOC_INTEL_RAPTORLAKE" ...................................................................... Revert "mb/google/brya/var/kano: select SOC_INTEL_RAPTORLAKE" This reverts commit 7203aa5c2dcb90e50356305cabbe062bd4f4dc76. Change-Id: Ieaa44a33a7c65d384581b5145821b449783ca3fa Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/mainboard/google/brya/Kconfig.name 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/69919/1 diff --git a/src/mainboard/google/brya/Kconfig.name b/src/mainboard/google/brya/Kconfig.name index bdd278e..71ea005 100644 --- a/src/mainboard/google/brya/Kconfig.name +++ b/src/mainboard/google/brya/Kconfig.name @@ -78,7 +78,6 @@ select SOC_INTEL_COMMON_BLOCK_IPU select CHROMEOS_WIFI_SAR if CHROMEOS select EC_GOOGLE_CHROMEEC_INCLUDE_SSFC_IN_FW_CONFIG - select SOC_INTEL_RAPTORLAKE config BOARD_GOOGLE_NIVVIKS bool "-> Nivviks" -- To view, visit https://review.coreboot.org/c/coreboot/+/69919 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieaa44a33a7c65d384581b5145821b449783ca3fa Gerrit-Change-Number: 69919 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: sb/intel/i82801gx: Use "sb/intel/common/tco.h" macros
by Martin L Roth (Code Review) 23 Nov '22

23 Nov '22

Attention is currently required from: Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69878 ) Change subject: sb/intel/i82801gx: Use "sb/intel/common/tco.h" macros ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: Maybe make a comment in the commit message about changing the inw/outw to read_pmbase16/write_pmbase16 in lpc.c? -- To view, visit https://review.coreboot.org/c/coreboot/+/69878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id281a3478051c4876ccbe26452d8744769c86654 Gerrit-Change-Number: 69878 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 22 Nov 2022 22:25:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: ec/google/chromeec: Fix clang warnings
by Arthur Heymans (Code Review) 23 Nov '22

23 Nov '22

Attention is currently required from: Martin L Roth, Caveh Jalali, Julius Werner, Boris Mittelberg. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69742 ) Change subject: ec/google/chromeec: Fix clang warnings ...................................................................... Patch Set 4: (1 comment) Patchset: PS3: > Caveh, coreboot engineers are not responsible for making changes in the chromeEC codebase. That's up to Google. When this file was copied into the coreboot codebase, it became part of coreboot. So long as it doesn't affect the output, think that the code changes are free to go either way, if Google wants to take them. > > Arthur, do these changes make any difference to the GCC output, or is it still identical? Maybe mark these changes with a /* coreboot change */ so that they don't get removed the next time the file is updated? I just checked. Identical output with gcc. I also added the comment. -- To view, visit https://review.coreboot.org/c/coreboot/+/69742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b5233618081db86caedcb2d14870974e109ed9b Gerrit-Change-Number: 69742 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Tue, 22 Nov 2022 22:22:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Comment-In-Reply-To: Caveh Jalali <caveh(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: ec/google/chromeec: Fix clang warnings
by Arthur Heymans (Code Review) 23 Nov '22

23 Nov '22

Attention is currently required from: Caveh Jalali, Julius Werner, Arthur Heymans, Boris Mittelberg. Hello build bot (Jenkins), Caveh Jalali, Julius Werner, Boris Mittelberg, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69742 to look at the new patch set (#6). Change subject: ec/google/chromeec: Fix clang warnings ...................................................................... ec/google/chromeec: Fix clang warnings Clang warns about structs inside a union also needing the packed attribute. This files is copied from the chromeec project, so it adds comment next to the coreboot specific changes as a reference. TEST: google/vilboz remains the same with BUILD_TIMELESSS=1 and gcc. Change-Id: I8b5233618081db86caedcb2d14870974e109ed9b Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/ec/google/chromeec/ec_commands.h 1 file changed, 20 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/69742/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/69742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b5233618081db86caedcb2d14870974e109ed9b Gerrit-Change-Number: 69742 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: arch/arm: Buildtest all arm targets with clang
by Arthur Heymans (Code Review) 23 Nov '22

23 Nov '22

Attention is currently required from: Julius Werner, Arthur Heymans. Hello build bot (Jenkins), Martin L Roth, Julius Werner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69747 to look at the new patch set (#7). Change subject: arch/arm: Buildtest all arm targets with clang ...................................................................... arch/arm: Buildtest all arm targets with clang Change-Id: I88cf8ce16fb6c61c19d615e396f5871179b06fc8 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/arch/arm/Kconfig 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/69747/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/69747 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88cf8ce16fb6c61c19d615e396f5871179b06fc8 Gerrit-Change-Number: 69747 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: arch/x86: Buildtest clang targets with VBOOT_STARTS_BEFORE_BOOTBLOCK
by Arthur Heymans (Code Review) 23 Nov '22

23 Nov '22

Attention is currently required from: Arthur Heymans, Martin Roth. Hello build bot (Jenkins), Martin L Roth, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69746 to look at the new patch set (#7). Change subject: arch/x86: Buildtest clang targets with VBOOT_STARTS_BEFORE_BOOTBLOCK ...................................................................... arch/x86: Buildtest clang targets with VBOOT_STARTS_BEFORE_BOOTBLOCK TESTED: google/vilboz boots with clang build. Change-Id: Ie115c27b4cb0b8f83d7647bdd27ffcbac9376399 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/arch/x86/Kconfig 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/69746/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/69746 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie115c27b4cb0b8f83d7647bdd27ffcbac9376399 Gerrit-Change-Number: 69746 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: arch/arm/armv7: Disable generating neon FPU code
by Arthur Heymans (Code Review) 23 Nov '22

23 Nov '22

Attention is currently required from: Julius Werner, Arthur Heymans. Hello build bot (Jenkins), Martin L Roth, Julius Werner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69745 to look at the new patch set (#7). Change subject: arch/arm/armv7: Disable generating neon FPU code ...................................................................... arch/arm/armv7: Disable generating neon FPU code By default clang generates code with neon instructions. These are not supported on all arm targets so default to fpu=none. Change-Id: I48fc505107d131466be39f466151df62b2d2bd0b Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/arch/arm/armv7/Makefile.inc 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/69745/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/69745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I48fc505107d131466be39f466151df62b2d2bd0b Gerrit-Change-Number: 69745 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: arm/armv7/Makefile.inc: Fix processing ld files with clang
by Arthur Heymans (Code Review) 23 Nov '22

23 Nov '22

Attention is currently required from: Julius Werner, Arthur Heymans. Hello build bot (Jenkins), Martin L Roth, Julius Werner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69744 to look at the new patch set (#7). Change subject: arm/armv7/Makefile.inc: Fix processing ld files with clang ...................................................................... arm/armv7/Makefile.inc: Fix processing ld files with clang When processing linker scripts clang needs to be set for the proper target or it gets confused by other options. Change-Id: I040aa14a06c728269ca1026e0002392e5ac8fef8 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/arch/arm/armv7/Makefile.inc 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/69744/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/69744 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I040aa14a06c728269ca1026e0002392e5ac8fef8 Gerrit-Change-Number: 69744 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022