coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: 3rdparty/arm-trusted-firmware: Update to v2.7
by Felix Singer (Code Review) 23 Nov '22

23 Nov '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69943 ) Change subject: 3rdparty/arm-trusted-firmware: Update to v2.7 ...................................................................... 3rdparty/arm-trusted-firmware: Update to v2.7 Move submodule pointer to commit 35f4c7295baf, which is equal to v2.7. Change-Id: If091b460aa8197ae1ba9928140645f941a74f30c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M 3rdparty/arm-trusted-firmware 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/69943/1 diff --git a/3rdparty/arm-trusted-firmware b/3rdparty/arm-trusted-firmware index 61fe782..35f4c72 160000 --- a/3rdparty/arm-trusted-firmware +++ b/3rdparty/arm-trusted-firmware @@ -1 +1 @@ -Subproject commit 61fe7826d8ae41c906b2189136a1ae482f91f84a +Subproject commit 35f4c7295bafeb32c8bcbdfb6a3f2e74a57e732b -- To view, visit https://review.coreboot.org/c/coreboot/+/69943 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If091b460aa8197ae1ba9928140645f941a74f30c Gerrit-Change-Number: 69943 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: crossgcc: Upgrade IASL from 20220331 to 20221020
by Elyes Haouas (Code Review) 23 Nov '22

23 Nov '22

Attention is currently required from: Martin L Roth, Paul Menzel, Arthur Heymans, Felix Held. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68929 ) Change subject: crossgcc: Upgrade IASL from 20220331 to 20221020 ...................................................................... Patch Set 11: (1 comment) Patchset: PS11: Please don't keep coreboot tree using acpica-20220331. -- To view, visit https://review.coreboot.org/c/coreboot/+/68929 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I386a6757a318336bc616091afe0c4ed88cd89583 Gerrit-Change-Number: 68929 Gerrit-PatchSet: 11 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 23 Nov 2022 12:03:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/crossgcc: Update GCC from 11.2 to 12.2
by Elyes Haouas (Code Review) 23 Nov '22

23 Nov '22

Attention is currently required from: Felix Singer, Martin L Roth. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66922 ) Change subject: util/crossgcc: Update GCC from 11.2 to 12.2 ...................................................................... Patch Set 10: Code-Review+2 (1 comment) Patchset: PS10: 1- binutils and probably src/lib/gnat needs an update. 2- maybe arm-trusted-firmware, libgfxinit and libhwbase needs some fix/update to support GCC/GNAT-12 & binutils-2.39 -- To view, visit https://review.coreboot.org/c/coreboot/+/66922 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia15e48847c6aea4f3188588b5092250568f16a09 Gerrit-Change-Number: 66922 Gerrit-PatchSet: 10 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Wed, 23 Nov 2022 11:59:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: crossgcc: Upgrade CMake from 3.24.2 to 3.25.0
by Elyes Haouas (Code Review) 23 Nov '22

23 Nov '22

Attention is currently required from: Felix Singer. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69715 ) Change subject: crossgcc: Upgrade CMake from 3.24.2 to 3.25.0 ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > Please use `coreboot-toolchain` as topic. I'm using topic:toolchain since 2017 😊 https://review.coreboot.org/q/topic:toolchain,50 -- To view, visit https://review.coreboot.org/c/coreboot/+/69715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iebccaf984c2c8b449c8f152484a4df1e75e74fd8 Gerrit-Change-Number: 69715 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Wed, 23 Nov 2022 11:52:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Decouple HECI disabling interface from its Kconfig
by Eric Lai (Code Review) 23 Nov '22

23 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69930 ) Change subject: soc/intel/meteorlake: Decouple HECI disabling interface from its Kconfig ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69930 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c9c5a73028cde90af3553093a13d0c05b831bae Gerrit-Change-Number: 69930 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Wed, 23 Nov 2022 11:41:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/wwan/fm: Use correct GUID for DmaProperty in ACPI _DSD
by build bot (Jenkins) (Code Review) 23 Nov '22

23 Nov '22

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69932 ) Change subject: drivers/wwan/fm: Use correct GUID for DmaProperty in ACPI _DSD ...................................................................... Patch Set 1: (2 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164374): https://review.coreboot.org/c/coreboot/+/69932/comment/7dafbc64_3b9e5bd1 PS1, Line 12: https://learn.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie… Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164374): https://review.coreboot.org/c/coreboot/+/69932/comment/05a5e064_ea1162bd PS1, Line 17: ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */, Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/69932 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I05b8c3bf23cc43863527bc514d9a96096d45003c Gerrit-Change-Number: 69932 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 23 Nov 2022 11:22:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: drivers/wwan/fm: Use correct GUID for DmaProperty in ACPI _DSD
by Kapil Porwal (Code Review) 23 Nov '22

23 Nov '22

Kapil Porwal has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69932 ) Change subject: drivers/wwan/fm: Use correct GUID for DmaProperty in ACPI _DSD ...................................................................... drivers/wwan/fm: Use correct GUID for DmaProperty in ACPI _DSD Use correct GUID for DmaProperty in ACPI _DSD. Reference: https://learn.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie… Before: Name (_DSD, Package (0x02) // _DSD: Device-Specific Data { ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */, Package (0x01) { Package (0x02) { "DmaProperty", One } } }) After: Name (_DSD, Package (0x02) // _DSD: Device-Specific Data { ToUUID ("70d24161-6dd5-4c9e-8070-705531292865"), Package (0x01) { Package (0x02) { "DmaProperty", One } } }) BUG=b:259716145 TEST=Verified the new GUID is reflected in ACPI SSDT at runtime. Signed-off-by: Kapil Porwal <kapilporwal(a)google.com> Change-Id: I05b8c3bf23cc43863527bc514d9a96096d45003c --- M src/drivers/wwan/fm/acpi_fm350gl.c 1 file changed, 53 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/69932/1 diff --git a/src/drivers/wwan/fm/acpi_fm350gl.c b/src/drivers/wwan/fm/acpi_fm350gl.c index dbc4f24..7ff8b2b 100644 --- a/src/drivers/wwan/fm/acpi_fm350gl.c +++ b/src/drivers/wwan/fm/acpi_fm350gl.c @@ -5,6 +5,9 @@ #include "chip.h" #include "soc/intel/common/block/pcie/rtd3/chip.h" +/* ID for the DmaProperty in _DSD */ +#define ACPI_DSD_DMA_PROPERTY_UUID "70D24161-6DD5-4C9E-8070-705531292865" + /* FCPO# to RESET# delay time during WWAN ON */ #define FM350GL_TN2B 20 /* RESET# to PERST# delay time during WWAN ON */ @@ -243,9 +246,11 @@ wwan_fm350gl_acpi_method_dpts(parent, config); if (config->add_acpi_dma_property) { - struct acpi_dp *dsd; + struct acpi_dp *dsd, *pkg; dsd = acpi_dp_new_table("_DSD"); - acpi_dp_add_integer(dsd, "DmaProperty", 1); + pkg = acpi_dp_new_table(ACPI_DSD_DMA_PROPERTY_UUID); + acpi_dp_add_integer(pkg, "DmaProperty", 1); + acpi_dp_add_package(dsd, pkg); acpi_dp_write(dsd); } -- To view, visit https://review.coreboot.org/c/coreboot/+/69932 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I05b8c3bf23cc43863527bc514d9a96096d45003c Gerrit-Change-Number: 69932 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: crossgcc: Upgrade LLVM from 15.0.0 to 15.0.5
by Paul Menzel (Code Review) 23 Nov '22

23 Nov '22

Attention is currently required from: Martin L Roth, Arthur Heymans, Elyes Haouas. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69700 ) Change subject: crossgcc: Upgrade LLVM from 15.0.0 to 15.0.5 ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/69700 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e6c23c6552eded92e706bc21bb162a66767572e Gerrit-Change-Number: 69700 Gerrit-PatchSet: 9 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 23 Nov 2022 11:21:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: ec/google/chromeec: Fix clang warnings
by Paul Menzel (Code Review) 23 Nov '22

23 Nov '22

Attention is currently required from: Martin L Roth, Caveh Jalali, Julius Werner, Arthur Heymans, Boris Mittelberg. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69742 ) Change subject: ec/google/chromeec: Fix clang warnings ...................................................................... Patch Set 6: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/69742/comment/fda847b4_fd3be86c PS6, Line 7: Fix clang warnings Maybe: > Add packed attribute to structs in union https://review.coreboot.org/c/coreboot/+/69742/comment/d5fb3613_1c4cd9e2 PS6, Line 15: BUILD_TIMELESSS TIMELESS -- To view, visit https://review.coreboot.org/c/coreboot/+/69742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b5233618081db86caedcb2d14870974e109ed9b Gerrit-Change-Number: 69742 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Wed, 23 Nov 2022 11:21:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/octopus/variants/phaser: Implement variant_memory_sku()
by Stanley Wu (Code Review) 23 Nov '22

23 Nov '22

Attention is currently required from: Jamie Chen, Derek Huang, Marco Chen, Eric Lai. Stanley Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69925 ) Change subject: mb/google/octopus/variants/phaser: Implement variant_memory_sku() ...................................................................... Patch Set 3: (17 comments) File src/mainboard/google/octopus/variants/phaser/memory.c: https://review.coreboot.org/c/coreboot/+/69925/comment/ce0080b9_39a2dd3b PS1, Line 24: size_t rt; > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/69925/comment/0f7ba7b1_cf7c5968 PS1, Line 24: size_t rt; > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/69925/comment/774522ad_c1761ac5 PS1, Line 25: gpio_t pads[] = { > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/69925/comment/1ccaf5f2_66de7928 PS1, Line 25: gpio_t pads[] = { > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/69925/comment/ff85e8d2_05c9962b PS1, Line 26: [3] = MEM_CONFIG3, [2] = MEM_CONFIG2, > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/69925/comment/480c1d63_9369d1b4 PS1, Line 26: [3] = MEM_CONFIG3, [2] = MEM_CONFIG2, > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/69925/comment/88e999e3_aeaafd70 PS1, Line 27: [1] = MEM_CONFIG1, [0] = MEM_CONFIG0, > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/69925/comment/5a04a30a_1f8717d4 PS1, Line 27: [1] = MEM_CONFIG1, [0] = MEM_CONFIG0, > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/69925/comment/703c7f4f_251f6073 PS1, Line 28: }; > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/69925/comment/0a8b6510_a5aac0b9 PS1, Line 28: }; > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/69925/comment/1c44a30a_0f2a0dcf PS1, Line 30: rt = gpio_base2_value(pads, ARRAY_SIZE(pads)); > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/69925/comment/d498c7ae_b7de7b84 PS1, Line 30: rt = gpio_base2_value(pads, ARRAY_SIZE(pads)); > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/69925/comment/3d92eee3_d2fff530 PS1, Line 31: return (rt == 3) ? 1 : rt; // If RAM ID = 3, return 1 > > code indent should use tabs where possible […] Done https://review.coreboot.org/c/coreboot/+/69925/comment/ba09624f_4ab74f14 PS1, Line 31: return (rt == 3) ? 1 : rt; // If RAM ID = 3, return 1 > > please, no spaces at the start of a line […] Done https://review.coreboot.org/c/coreboot/+/69925/comment/6e6eeb94_5603b778 PS1, Line 32: } > > adding a line without newline at end of file […] Done File src/mainboard/google/octopus/variants/phaser/memory.c: https://review.coreboot.org/c/coreboot/+/69925/comment/b3a4de66_1007570d PS2, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright 2017 Intel Corp. : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ > /* SPDX-License-Identifier: GPL-2. […] Done File src/mainboard/google/octopus/variants/phaser/memory.c: https://review.coreboot.org/c/coreboot/+/69925/comment/ac66325d_4f728b4a PS3, Line 18: return (rt == 3) ? 1 : rt; // If RAM ID = 3, return 1 > agree to add board id check to override memory ID for specific board id Thanks for the suggestion. But there don`t have specific board_id define for ram_id=3 case. All board id is the same with MP shipping unit. -- To view, visit https://review.coreboot.org/c/coreboot/+/69925 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36ec6bad7096e5de666ac6500c8419fc6e383ae1 Gerrit-Change-Number: 69925 Gerrit-PatchSet: 3 Gerrit-Owner: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-CC: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Marco Chen <marcochen(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 23 Nov 2022 11:14:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Derek Huang <derekhuang(a)google.com> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022