coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: util/testing: Fully clean all but the standard GCC build
by Felix Singer (Code Review) 24 Nov '22

24 Nov '22

Attention is currently required from: Martin L Roth. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69954 ) Change subject: util/testing: Fully clean all but the standard GCC build ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69954 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I69fe803e4b4213a199d0b76089da443aa769aa92 Gerrit-Change-Number: 69954 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Thu, 24 Nov 2022 05:13:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: [WIP] mb/google/nissa/var/craask: Add support for NVMe GPIOs
by Reka Norman (Code Review) 24 Nov '22

24 Nov '22

Attention is currently required from: Tarun Tuli, Kangheui Won, Ren Kuo, Tyler Wang, Eric Lai. Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69958 ) Change subject: [WIP] mb/google/nissa/var/craask: Add support for NVMe GPIOs ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/brya/variants/craask/gpio.c: https://review.coreboot.org/c/coreboot/+/69958/comment/2525366c_a440d287 PS1, Line 15: GPP_D6 > GPP_D6 is WWAN_EN for craask,but it's SSD_CLKREQ_ODL for craaskneto/crasskino. […] It's overriden to SSD_CLKREQ_ODL in fw_config.c. CLKREQ pins don't need to be set in bootblock, only in ramstage. -- To view, visit https://review.coreboot.org/c/coreboot/+/69958 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I76a056cddff2246cfb5bb26ddbdfc333b49d9aaf Gerrit-Change-Number: 69958 Gerrit-PatchSet: 1 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 24 Nov 2022 05:11:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craask: Modify functions for craaskneto/craaskino
by Ren Kuo (Code Review) 24 Nov '22

24 Nov '22

Attention is currently required from: Tarun Tuli, David Wu, Kangheui Won, Reka Norman, Tyler Wang, Nick Vaccaro, Eric Lai. Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69693 ) Change subject: mb/google/nissa/var/craask: Modify functions for craaskneto/craaskino ...................................................................... Patch Set 9: Code-Review-1 -- To view, visit https://review.coreboot.org/c/coreboot/+/69693 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b9c90abe562768ea2afff5608a8cfac764569d5 Gerrit-Change-Number: 69693 Gerrit-PatchSet: 9 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 24 Nov 2022 05:08:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craask: Modify functions for craaskneto/craaskino
by Ren Kuo (Code Review) 24 Nov '22

24 Nov '22

Attention is currently required from: Tarun Tuli, David Wu, Kangheui Won, Reka Norman, Tyler Wang, Nick Vaccaro, Eric Lai. Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69693 ) Change subject: mb/google/nissa/var/craask: Modify functions for craaskneto/craaskino ...................................................................... Patch Set 9: (1 comment) Patchset: PS8: > After discussing with Kangheui, we think it would be better to use fw_config instead of board_id. […] thanks ~~ Reka -- To view, visit https://review.coreboot.org/c/coreboot/+/69693 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b9c90abe562768ea2afff5608a8cfac764569d5 Gerrit-Change-Number: 69693 Gerrit-PatchSet: 9 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 24 Nov 2022 05:08:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Reka Norman <rekanorman(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: [WIP] mb/google/nissa/var/craask: Add support for NVMe GPIOs
by Ren Kuo (Code Review) 24 Nov '22

24 Nov '22

Attention is currently required from: Tarun Tuli, Kangheui Won, Reka Norman, Tyler Wang, Eric Lai. Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69958 ) Change subject: [WIP] mb/google/nissa/var/craask: Add support for NVMe GPIOs ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/brya/variants/craask/gpio.c: https://review.coreboot.org/c/coreboot/+/69958/comment/c889ddb3_d430d46d PS1, Line 15: GPP_D6 GPP_D6 is WWAN_EN for craask,but it's SSD_CLKREQ_ODL for craaskneto/crasskino. The setting should be different in ramstarge and bootblock (early_gpio_table[]) -- To view, visit https://review.coreboot.org/c/coreboot/+/69958 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I76a056cddff2246cfb5bb26ddbdfc333b49d9aaf Gerrit-Change-Number: 69958 Gerrit-PatchSet: 1 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-CC: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 24 Nov 2022 05:07:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: 3rdparty/libgfxinit: Update submodule pointer to 066e52eeaa32
by Felix Singer (Code Review) 24 Nov '22

24 Nov '22

Attention is currently required from: Nico Huber. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69945 ) Change subject: 3rdparty/libgfxinit: Update submodule pointer to 066e52eeaa32 ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/69945 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b36a4b5f0a7a075ddef5d4bec984f3cd131626d Gerrit-Change-Number: 69945 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Thu, 24 Nov 2022 04:56:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: 3rdparty/libhwbase: Update submodule pointer to 8be5a82b85ce
by Felix Singer (Code Review) 24 Nov '22

24 Nov '22

Attention is currently required from: Nico Huber. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69944 ) Change subject: 3rdparty/libhwbase: Update submodule pointer to 8be5a82b85ce ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/69944 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ad61c39125b19922ae2fdda9767544d857139d0 Gerrit-Change-Number: 69944 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Thu, 24 Nov 2022 04:56:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: 3rdparty/arm-trusted-firmware: Update to v2.8
by Felix Singer (Code Review) 24 Nov '22

24 Nov '22

Attention is currently required from: Martin L Roth, Julius Werner, Elyes Haouas. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69943 ) Change subject: 3rdparty/arm-trusted-firmware: Update to v2.8 ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/69943 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If091b460aa8197ae1ba9928140645f941a74f30c Gerrit-Change-Number: 69943 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 24 Nov 2022 04:56:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craask: Modify functions for craaskneto/craaskino
by build bot (Jenkins) (Code Review) 24 Nov '22

24 Nov '22

Attention is currently required from: Tarun Tuli, David Wu, Kangheui Won, Ren Kuo, Tyler Wang, Nick Vaccaro, Eric Lai. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69693 ) Change subject: mb/google/nissa/var/craask: Modify functions for craaskneto/craaskino ...................................................................... Patch Set 9: (6 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164429): https://review.coreboot.org/c/coreboot/+/69693/comment/ff702d14_24067ee1 PS9, Line 11: 2. Modfiy fw_config gpio table to skip the LTE and WFC setting from craask. Possible unwrapped commit description (prefer a maximum 72 chars per line) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164429): https://review.coreboot.org/c/coreboot/+/69693/comment/2f8d392b_5ad4355f PS9, Line 11: 2. Modfiy fw_config gpio table to skip the LTE and WFC setting from craask. 'Modfiy' may be misspelled - perhaps 'Modify'? Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164429): https://review.coreboot.org/c/coreboot/+/69693/comment/ec36169a_98dba6e0 PS9, Line 13: 4. Add keybaord backligt definiation for EC 'definiation' may be misspelled - perhaps 'definition'? File src/mainboard/google/brya/variants/craask/gpio.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164429): https://review.coreboot.org/c/coreboot/+/69693/comment/9e45bc87_fb39b161 PS9, Line 181: }else { space required after that close brace '}' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164429): https://review.coreboot.org/c/coreboot/+/69693/comment/9ac54f07_d1f16abc PS9, Line 194: }else { space required after that close brace '}' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164429): https://review.coreboot.org/c/coreboot/+/69693/comment/cfefa167_4bc43e81 PS9, Line 207: }else { space required after that close brace '}' -- To view, visit https://review.coreboot.org/c/coreboot/+/69693 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b9c90abe562768ea2afff5608a8cfac764569d5 Gerrit-Change-Number: 69693 Gerrit-PatchSet: 9 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 24 Nov 2022 04:54:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craask: Modify functions for craaskneto/craaskino
by Reka Norman (Code Review) 24 Nov '22

24 Nov '22

Attention is currently required from: Tarun Tuli, David Wu, Kangheui Won, Ren Kuo, Tyler Wang, Nick Vaccaro, Eric Lai. Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69693 ) Change subject: mb/google/nissa/var/craask: Modify functions for craaskneto/craaskino ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: After discussing with Kangheui, we think it would be better to use fw_config instead of board_id. It's slightly complicated since GPP_D6 is used in two different ways, but it should still work. I've uploaded a CL here: CB:69958. Could you please test it? Both that NVMe works on craaskneto/craaskino and that LTE still works on craask. Note you'll have to set fw_config to include STORAGE_NVME for NVMe. -- To view, visit https://review.coreboot.org/c/coreboot/+/69693 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6b9c90abe562768ea2afff5608a8cfac764569d5 Gerrit-Change-Number: 69693 Gerrit-PatchSet: 8 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 24 Nov 2022 04:53:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022