coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: [NEEDS TEST] util/superiotool: Replace iopl with ioperm
by Nicholas Chin (Code Review) 24 Nov '22

24 Nov '22

Attention is currently required from: Felix Held. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69981 ) Change subject: [NEEDS TEST] util/superiotool: Replace iopl with ioperm ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Hmm, looks like superiotool.h has some `#define iopl` macros for NetBSD. Not sure if this patch breaks that ``` #if defined(__NetBSD__) && (defined(__i386__) || defined(__x86_64__)) #include <sys/types.h> #include <machine/sysarch.h> #if defined(__i386__) #define iopl i386_iopl #elif defined(__x86_64__) #define iopl x86_64_iopl #endif ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/69981 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6671023b09d22ff38e578d11d04674fb6ae763c9 Gerrit-Change-Number: 69981 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 24 Nov 2022 18:49:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/cmn/cse: Create API to perform essential post EOP operations
by Subrata Banik (Code Review) 24 Nov '22

24 Nov '22

Subrata Banik has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/69977 ) Change subject: soc/intel/cmn/cse: Create API to perform essential post EOP operations ...................................................................... soc/intel/cmn/cse: Create API to perform essential post EOP operations This patch creates an API that can perform essential CSE operation after sending the EOP command to the CSE and before booting to OS. Lists of operation are - Perform global reset lock - Put HECI1 to D0i3 and disable the HECI1 if the user selects - Set D0I3 for all HECI devices. Additionally, ensures that CSE .final operation is not sending EOP and other essential operations if the SoC user selects SOC_INTEL_CSE_SEND_EOP_LATE config. BUG=b:260041679 TEST=Able to boot Google/Rex after sending CSE EOP late. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I10131ea9b553a62f0d632783c4dbad96d35d6563 --- M src/soc/intel/common/block/cse/cse.c M src/soc/intel/common/block/include/intelblocks/cse.h 2 files changed, 54 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/69977/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/69977 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10131ea9b553a62f0d632783c4dbad96d35d6563 Gerrit-Change-Number: 69977 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Allow sending late EOP cmd to CSE
by Subrata Banik (Code Review) 24 Nov '22

24 Nov '22

Attention is currently required from: Tarun Tuli, Kapil Porwal. Hello Tarun Tuli, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69999 to look at the new patch set (#3). Change subject: soc/intel/meteorlake: Allow sending late EOP cmd to CSE ...................................................................... soc/intel/meteorlake: Allow sending late EOP cmd to CSE This patch selects SOC_INTEL_CSE_SEND_EOP_LATE config to let IA common code to skip sending CSE EOP cmd during finalize operation rather uses boot state machine (either payload load or payload boot) to delay in sending EOP cmd to CSE. BUG=b:260041679 TEST=Able to boot to Google/Rex with this patch and observed ~150ms savings in boot time Without this patch: 942:before sending EOP to ME 1,795,702 (354) 943:after sending EOP to ME 1,950,526 (154,824) With this patch: 942:before sending EOP to ME 2,051,406 (35,484) 943:after sending EOP to ME 2,057,583 (6,177) Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I7d44d5eff890ac78e3075d49cc249f740686dd0d --- M src/soc/intel/meteorlake/Kconfig 1 file changed, 30 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/69999/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/69999 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7d44d5eff890ac78e3075d49cc249f740686dd0d Gerrit-Change-Number: 69999 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/cmn/cse: Allow to perform essential post CSE operations
by Subrata Banik (Code Review) 24 Nov '22

24 Nov '22

Subrata Banik has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/69978 ) Change subject: soc/intel/cmn/cse: Allow to perform essential post CSE operations ...................................................................... soc/intel/cmn/cse: Allow to perform essential post CSE operations This patch allows to send late EOP cmd to CSE (after CSE .final) using boot state machine (either BS_PAYLOAD_BOOT or BS_PAYLOAD_LOAD) if the SoC user selects SOC_INTEL_CSE_SEND_EOP_LATE config. BUG=b:260041679 TEST=Able to boot Google/Rex after sending CSE EOP late. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: If4c4564befcd38732368b21f1ca3e24b68c30e0c --- M src/soc/intel/common/block/cse/cse_eop.c 1 file changed, 20 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/69978/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/69978 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4c4564befcd38732368b21f1ca3e24b68c30e0c Gerrit-Change-Number: 69978 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/intel/cmn/cse: Create another config for sending CSE EOP cmd late
by Subrata Banik (Code Review) 24 Nov '22

24 Nov '22

Subrata Banik has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/69976 ) Change subject: soc/intel/cmn/cse: Create another config for sending CSE EOP cmd late ...................................................................... soc/intel/cmn/cse: Create another config for sending CSE EOP cmd late Presently, coreboot supports two instances of sending EOP cmd to the Intel CSE. 1. Sending EOP cmd to CSE during `.final` operation from cse pci driver. 2. Starting with Alder Lake, the recommendation was to send EOP to CSE earlier than CSE `.final` operation. Since then it's referred to as `Sending EOP Early`. This method helped to save the CSE EOP response time significantly. During Meteor Lake platform, CSE EOP response time has become non-deterministic and we have figured that sending EOP command later than CSE .final operation is actually helping to optimize the boot time significantly (around ~150ms savings compared to sending from `.final` ops and ~5sec compared to sending CSE early). Hence, this patch intended to create yet another kconfig for sending CSE late (specifically after `.final` operation). The idea for this newer config is to use the boot state machine for sending CSE EOP cmd. The patch train in this series would add the specific changes to allow sending EOP late and perform other essential operations required prior booting to OS as coreboot decided to skip calling into FSP Notify phase. The current plan is that Intel Meteor Lake platform will select this newer config from SoC code. BUG=b:260041679 TEST=Able to send EOP command successfully for Google/Taeko. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Iea512cd5b79d61dd5d5a962079baf525027c831f --- M src/soc/intel/common/block/cse/Kconfig 1 file changed, 50 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/69976/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/69976 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea512cd5b79d61dd5d5a962079baf525027c831f Gerrit-Change-Number: 69976 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: [NEEDS TEST] util/superiotool: Replace iopl with ioperm
by Nicholas Chin (Code Review) 24 Nov '22

24 Nov '22

Attention is currently required from: Felix Held. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69981 ) Change subject: [NEEDS TEST] util/superiotool: Replace iopl with ioperm ...................................................................... Patch Set 3: (1 comment) File util/superiotool/superiotool.c: https://review.coreboot.org/c/coreboot/+/69981/comment/97798111_b2a1184a PS1, Line 328: iopl > s/comment/parameter of the perror call/ Done -- To view, visit https://review.coreboot.org/c/coreboot/+/69981 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6671023b09d22ff38e578d11d04674fb6ae763c9 Gerrit-Change-Number: 69981 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 24 Nov 2022 18:41:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: [NEEDS TEST] util/superiotool: Replace iopl with ioperm
by build bot (Jenkins) (Code Review) 24 Nov '22

24 Nov '22

Attention is currently required from: Nicholas Chin. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69981 ) Change subject: [NEEDS TEST] util/superiotool: Replace iopl with ioperm ...................................................................... Patch Set 3: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164493): https://review.coreboot.org/c/coreboot/+/69981/comment/104cc120_8e584524 PS3, Line 13: 'sucessfully' may be misspelled - perhaps 'successfully'? -- To view, visit https://review.coreboot.org/c/coreboot/+/69981 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6671023b09d22ff38e578d11d04674fb6ae763c9 Gerrit-Change-Number: 69981 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Thu, 24 Nov 2022 18:41:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: [NEEDS TEST] util/superiotool: Replace iopl with ioperm
by Nicholas Chin (Code Review) 24 Nov '22

24 Nov '22

Attention is currently required from: Nicholas Chin. Hello Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69981 to look at the new patch set (#3). Change subject: [NEEDS TEST] util/superiotool: Replace iopl with ioperm ...................................................................... [NEEDS TEST] util/superiotool: Replace iopl with ioperm The iopl system call is marked as deprecated, and on some distributions the call no longer seems to be implemented. Replace it with ioperm. Resolves: https://ticket.coreboot.org/issues/440 TEST: Run superiotool sucessfully on Ubuntu 22.10, which does not seem to have iopl implemented Change-Id: I6671023b09d22ff38e578d11d04674fb6ae763c9 Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M util/superiotool/superiotool.c 1 file changed, 20 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/69981/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/69981 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6671023b09d22ff38e578d11d04674fb6ae763c9 Gerrit-Change-Number: 69981 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Allow sending late EOP cmd to CSE
by Subrata Banik (Code Review) 24 Nov '22

24 Nov '22

Attention is currently required from: Tarun Tuli, Kapil Porwal. Hello Tarun Tuli, Kapil Porwal, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69999 to look at the new patch set (#2). Change subject: soc/intel/meteorlake: Allow sending late EOP cmd to CSE ...................................................................... soc/intel/meteorlake: Allow sending late EOP cmd to CSE This patch selects SOC_INTEL_CSE_SEND_EOP_LATE config to let IA common code to skip sending CSE EOP cmd during finalize operation rather uses boot state machine (either payload load or payload boot) to delay in sending EOP cmd to CSE. BUG=b:260041679 TEST=Able to boot to Google/Rex with this patch and observed ~150ms savings in boot time Without this patch: 942:before sending EOP to ME 1,795,702 (354) 943:after sending EOP to ME 1,950,526 (154,824) With this patch: 942:before sending EOP to ME 2,051,406 (35,484) 943:after sending EOP to ME 2,057,583 (6,177) Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I7d44d5eff890ac78e3075d49cc249f740686dd0d --- M src/soc/intel/meteorlake/Kconfig 1 file changed, 30 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/69999/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69999 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7d44d5eff890ac78e3075d49cc249f740686dd0d Gerrit-Change-Number: 69999 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/cmn/cse: Allow to perform essential post CSE operations
by Subrata Banik (Code Review) 24 Nov '22

24 Nov '22

Subrata Banik has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/69978 ) Change subject: soc/intel/cmn/cse: Allow to perform essential post CSE operations ...................................................................... soc/intel/cmn/cse: Allow to perform essential post CSE operations This patch allows to send late EOP cmd to CSE (after CSE .final) using boot state machine (either BS_PAYLOAD_BOOT or BS_PAYLOAD_LOAD) if the SoC user selects SOC_INTEL_CSE_SEND_EOP_LATE config. BUG=b:260041679 TEST=Able to boot Google/Rex after sending CSE EOP late. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: If4c4564befcd38732368b21f1ca3e24b68c30e0c --- M src/soc/intel/common/block/cse/cse_eop.c 1 file changed, 20 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/69978/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69978 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4c4564befcd38732368b21f1ca3e24b68c30e0c Gerrit-Change-Number: 69978 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022