coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[M] Change in coreboot[master]: cpu/x86/smm: Add PCI BAR store functionality
by Robert Zieba (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Arthur Heymans, Raul Rangel, Nico Huber, Angel Pons, Martin Roth, Karthik Ramasubramanian, Felix Held. Robert Zieba has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67931 ) Change subject: cpu/x86/smm: Add PCI BAR store functionality ...................................................................... Patch Set 10: (4 comments) File src/cpu/x86/smm/pci_bar_store.c: https://review.coreboot.org/c/coreboot/+/67931/comment/39bbaa4f_6416d2c7 PS7, Line 20: if (num_devices > num_slots) { : printk(BIOS_ERR, "Failed to store PCI BARs, number of devices exceeds slots\n"); : return false; : } > nit: Would it make sense to do this check inside the for loop so that it can store what bars it can, […] Moved this into the loop to allow storing at least some BARs if there aren't enough for everything. https://review.coreboot.org/c/coreboot/+/67931/comment/fb1059b1_99c3f23e PS7, Line 26: devices > You need to make sure the device is a PCI device Done File src/cpu/x86/smm/smm_module_loader.c: https://review.coreboot.org/c/coreboot/+/67931/comment/a5e7d79e_064614d3 PS7, Line 342: smm_pci_bar_store_init > if CONFIG(SMM_PCI_BAR_STORE) […] Done File src/include/cpu/x86/smm.h: https://review.coreboot.org/c/coreboot/+/67931/comment/b6b463e0_eb088c35 PS7, Line 217: #if CONFIG(SMM_PCI_BAR_STORE) > We shouldn't need to do this. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/67931 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I23fb1e935dd1b89f1cc5c834cc2025f0fe5fda37 Gerrit-Change-Number: 67931 Gerrit-PatchSet: 10 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 16:44:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in libgfxinit[master]: dp info: Provide Link_Status'Object_Size and padding
by Paul Menzel (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Nico Huber. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/68105 ) Change subject: dp info: Provide Link_Status'Object_Size and padding ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/libgfxinit/+/68105/comment/b71624d8_15d68cb9 PS1, Line 7: Link_Status'Object_Size > It's Ada and denotes an attribute. […] Thank you for the clarification. https://review.coreboot.org/c/libgfxinit/+/68105/comment/70a775fa_b65463b4 PS1, Line 8: > Added a paragraph, hope that helps. Done -- To view, visit https://review.coreboot.org/c/libgfxinit/+/68105 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Id7f6b9f50105d9357adcb60fd551b719d9eccd30 Gerrit-Change-Number: 68105 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 16:43:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in libgfxinit[master]: gma: Work around GNATprove issue with nested loops
by Nico Huber (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/68112 ) Change subject: gma: Work around GNATprove issue with nested loops ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/libgfxinit/+/68112/comment/be0b7901_7c72fc5d PS1, Line 10: weird check messages. > Do these messages have something in common? Is it worth providing an example? Problems were varying from toolchain version to version, I'll check with something newish. -- To view, visit https://review.coreboot.org/c/libgfxinit/+/68112 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I5430081767c760b85401300e0db4d26fd78270d7 Gerrit-Change-Number: 68112 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 28 Nov 2022 16:41:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/system76/adl-p: Add Galago Pro 6 as a variant
by Tim Crawford (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Jeremy Soller. Hello Jeremy Soller, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69211 to look at the new patch set (#3). Change subject: mb/system76/adl-p: Add Galago Pro 6 as a variant ...................................................................... mb/system76/adl-p: Add Galago Pro 6 as a variant The Galago Pro 6 (galp6) is an Alder Lake-P board. Tested with a custom edk2 UefiPayloadPkg. Working: - PS/2 keyboard, touchpad - Both DIMM slots (with NMSO480E82-3200EA00) - M.2 NVMe SSD (with MZVL2500HCJQ) - All USB ports - All USB ports - SD card reader - Webcam - Ethernet - WiFi/Bluetooth - Integrated graphics using Intel GOP driver - Backlight controls on Windows 10 and Linux 6.1 - HDMI output - DisplayPort output over USB-C - Internal microphone - Internal speakers - Combined headphone + mic 3.5mm audio - S0ix suspend/resume - Booting Pop!_OS Linux 22.04 with kernel 6.0.6 - Internal flashing with flashrom v1.2-1087-gde016a17 Not working: - Detection of devices in TBT slot on boot Change-Id: I8940fb3777d7f18393ef50baec32f9445b375648 Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- M Documentation/mainboard/index.md A Documentation/mainboard/system76/galp6.md M src/mainboard/system76/adl-p/Kconfig M src/mainboard/system76/adl-p/Kconfig.name A src/mainboard/system76/adl-p/variants/galp6/board_info.txt A src/mainboard/system76/adl-p/variants/galp6/data.vbt A src/mainboard/system76/adl-p/variants/galp6/gpio.c A src/mainboard/system76/adl-p/variants/galp6/gpio_early.c A src/mainboard/system76/adl-p/variants/galp6/hda_verb.c A src/mainboard/system76/adl-p/variants/galp6/overridetree.cb A src/mainboard/system76/adl-p/variants/galp6/romstage.c 11 files changed, 586 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/69211/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/69211 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8940fb3777d7f18393ef50baec32f9445b375648 Gerrit-Change-Number: 69211 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: [WIP] soc/amd/cezanne: Add support for 64bit builds
by Raul Rangel (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Jason Glenesk, Matt DeVillier, Fred Reitberger, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69898 ) Change subject: [WIP] soc/amd/cezanne: Add support for 64bit builds ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69898 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I77d468983f0e3feaa6cd589ef9a54af8892b48ce Gerrit-Change-Number: 69898 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 16:34:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: [WIP] vc/amd/fsp/cezanne/FspmUpd: don't use pointers for usb_phy conf...
by Raul Rangel (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Jason Glenesk, Matt DeVillier, Fred Reitberger, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69897 ) Change subject: [WIP] vc/amd/fsp/cezanne/FspmUpd: don't use pointers for usb_phy configuration ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69897 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I81f3a38344f91cecb4fe5431ed211834e5ed599c Gerrit-Change-Number: 69897 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 16:34:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/system76/adl-p: Add Galago Pro 6 as a variant
by Tim Crawford (Code Review) 28 Nov '22

28 Nov '22

Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69211 ) Change subject: mb/system76/adl-p: Add Galago Pro 6 as a variant ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/69211 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8940fb3777d7f18393ef50baec32f9445b375648 Gerrit-Change-Number: 69211 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 28 Nov 2022 16:27:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libgfxinit[master]: dp info: Provide Link_Status'Object_Size and padding
by Nico Huber (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Paul Menzel. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/68105 ) Change subject: dp info: Provide Link_Status'Object_Size and padding ...................................................................... Patch Set 2: Verified+1 (2 comments) Commit Message: https://review.coreboot.org/c/libgfxinit/+/68105/comment/fd363340_2adb8c29 PS1, Line 7: Link_Status'Object_Size > I do not know the notation with the '. It's Ada and denotes an attribute. What should be changed? https://review.coreboot.org/c/libgfxinit/+/68105/comment/02810c8f_f5ff6d8c PS1, Line 8: > Maybe add a sentence, what `Object_Size` and `padding` are going to be used for? Added a paragraph, hope that helps. -- To view, visit https://review.coreboot.org/c/libgfxinit/+/68105 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Id7f6b9f50105d9357adcb60fd551b719d9eccd30 Gerrit-Change-Number: 68105 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 28 Nov 2022 16:23:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in libgfxinit[master]: dp info: Provide Link_Status'Object_Size and padding
by Nico Huber (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Nico Huber. Hello Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/libgfxinit/+/68105 to look at the new patch set (#2). Change subject: dp info: Provide Link_Status'Object_Size and padding ...................................................................... dp info: Provide Link_Status'Object_Size and padding We convert a plane byte buffer to a `Link_Status` object via an `Unchecked_Conversion`. While the situation is actually clear to the compiler because of the record representation clause for `Link_Status`, SPARK rules demand an explicit `'Object_Size`. The `'Object_Size` attribute specifies the exact size the compiler should allocate for objects of the given type. The `Padding` field is added to fill the gap left by reserved bits. Change-Id: Id7f6b9f50105d9357adcb60fd551b719d9eccd30 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/hw-gfx-dp_info.adb M common/hw-gfx-dp_info.ads 2 files changed, 28 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/05/68105/2 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/68105 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Id7f6b9f50105d9357adcb60fd551b719d9eccd30 Gerrit-Change-Number: 68105 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: sb,soc/intel: Drop spurious SMI entry message
by Elyes Haouas (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Jeff Daly, Vanessa Eusebio, Kyösti Mälkki. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70047 ) Change subject: sb,soc/intel: Drop spurious SMI entry message ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/70047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad7a60098c0391cc23384035af49e373dad90233 Gerrit-Change-Number: 70047 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Mon, 28 Nov 2022 06:59:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022