coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[M] Change in coreboot[master]: amdfwtool: Add the new entry type for new family morgana
by Matt DeVillier (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Bao Zheng, Jason Glenesk, Marshall Dawson, Zheng Bao, Martin Roth. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69045 ) Change subject: amdfwtool: Add the new entry type for new family morgana ...................................................................... Patch Set 9: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/69045/comment/6262693f_bb442807 PS9, Line 7: Add the new entry type for new family morgana perhaps: "Add new entry types required to support morgana SoC" -- To view, visit https://review.coreboot.org/c/coreboot/+/69045 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7565c5eda75b332a48613440d7e4cfb388d5012f Gerrit-Change-Number: 69045 Gerrit-PatchSet: 9 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Mon, 28 Nov 2022 18:13:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/amd/birman/gpio: Configure birman GPIOs
by Fred Reitberger (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Jason Glenesk, Felix Held. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69411 ) Change subject: mb/amd/birman/gpio: Configure birman GPIOs ...................................................................... Patch Set 3: (6 comments) File src/mainboard/amd/birman/gpio.c: https://review.coreboot.org/c/coreboot/+/69411/comment/2ac5f3a3_90a742e3 PS2, Line 19: PAD_GPI(GPIO_3, PULL_UP), > this should probably be PAD_SCI instead of PAD_GPI Done https://review.coreboot.org/c/coreboot/+/69411/comment/48ac6f86_dbc61120 PS2, Line 31: PAD_SCI(GPIO_9, PULL_UP, EDGE_LOW), > i'm not 100% sure what this does and if it needs the SCI, but since it's a GEVENT capable pin, i'd g […] I'm not 100% sure here either. The reference implementation isn't much help either - it looks like it might only be an input. https://review.coreboot.org/c/coreboot/+/69411/comment/0572fb90_14656035 PS2, Line 33: PAD_GPO(GPIO_10, HIGH), > have you checked this with the reference implementation? not sure what's the correct default here Verified against the reference implementation. https://review.coreboot.org/c/coreboot/+/69411/comment/402c35e3_e532175b PS2, Line 37: PAD_GPO(GPIO_12, HIGH), > not sure what this one does and if this is the correct output level. […] Verified against the reference implementation. https://review.coreboot.org/c/coreboot/+/69411/comment/645cb41d_5b1ed4ee PS2, Line 80: PAD_GPO(GPIO_42, HIGH), > have you checked this with the reference implementation? not sure what's the correct default here Verified against the reference implementation. https://review.coreboot.org/c/coreboot/+/69411/comment/91a86032_2589faaf PS2, Line 91: /* SPI1_CS1_L */ : PAD_NF(GPIO_74, SPI1_CS1_L, PULL_NONE), > this is used as GPO and not as SPI1 #CS1 Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/69411 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5459efb38431e568e25405c440b5b9cf1354f02f Gerrit-Change-Number: 69411 Gerrit-PatchSet: 3 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 17:50:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/amd/birman/gpio: Configure birman GPIOs
by Fred Reitberger (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Jason Glenesk, Fred Reitberger. Hello build bot (Jenkins), Jason Glenesk, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69411 to look at the new patch set (#3). Change subject: mb/amd/birman/gpio: Configure birman GPIOs ...................................................................... mb/amd/birman/gpio: Configure birman GPIOs Configure birman GPIOs per schematic 105-D67000-00B v0.7 Signed-off-by: Fred Reitberger <reitbergerfred(a)gmail.com> Change-Id: I5459efb38431e568e25405c440b5b9cf1354f02f --- M src/mainboard/amd/birman/early_gpio.c M src/mainboard/amd/birman/gpio.c 2 files changed, 246 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/69411/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/69411 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5459efb38431e568e25405c440b5b9cf1354f02f Gerrit-Change-Number: 69411 Gerrit-PatchSet: 3 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in libgfxinit[master]: gma: add a Turn_Off procedure to clear the graphic configuration
by Nico Huber (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Jérémy Compostella. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/69938 ) Change subject: gma: add a Turn_Off procedure to clear the graphic configuration ...................................................................... Patch Set 1: (2 comments) File common/hw-gfx-gma.adb: https://review.coreboot.org/c/libgfxinit/+/69938/comment/8d0a47aa_b39ed356 PS1, Line 629: Power_And_Clocks.Pre_All_Off; This procedure doesn't clean up anything libgfxinit set up but rather disables things that libgfxinit doesn't know how to use. https://review.coreboot.org/c/libgfxinit/+/69938/comment/a368d37e_c4720508 PS1, Line 630: Connectors.Pre_All_Off; : Display_Controller.All_Off; : Connectors.Post_All_Off; : PLLs.All_Off; : Power_And_Clocks.Post_All_Off; This part should be covered by calling Update_Outputs with all ports set to `Disabled`. Do you happen to know if the Clear_Fences below is necessary to make the GOP work? If not, we might already have everything we need in the API. -- To view, visit https://review.coreboot.org/c/libgfxinit/+/69938 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Ida65bf3303d4dbf956d6fc9340f935e6c4e6b447 Gerrit-Change-Number: 69938 Gerrit-PatchSet: 1 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Mon, 28 Nov 2022 17:36:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: driver/intel/fsp2_0/hand_off_block: rework fsp_display_fvi_version_hob
by Raul Rangel (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Subrata Banik, Alex Levin, Arthur Heymans, Andrey Petrov, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69499 ) Change subject: driver/intel/fsp2_0/hand_off_block: rework fsp_display_fvi_version_hob ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Alex, who is covering for Tim W? -- To view, visit https://review.coreboot.org/c/coreboot/+/69499 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3398043dbdb3fc618277cefdd349b2c935bbfa52 Gerrit-Change-Number: 69499 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Alex Levin <levinale(a)chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Alex Levin <levinale(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 17:17:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim/var/frostflow: Update RAM ID table
by Jon Murphy (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Frank Wu, John Su, Jason Nien, Kangheui Won, Martin Roth. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68664 ) Change subject: mb/google/skyrim/var/frostflow: Update RAM ID table ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68664 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ff879ff7185f5a0ca1b9632820aba3b0f5d02c6 Gerrit-Change-Number: 68664 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Mon, 28 Nov 2022 17:07:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim/var/frostflow: Update RAM ID table
by Karthik Ramasubramanian (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Frank Wu, John Su, Jason Nien, Kangheui Won, Jon Murphy, Martin Roth. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68664 ) Change subject: mb/google/skyrim/var/frostflow: Update RAM ID table ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68664 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8ff879ff7185f5a0ca1b9632820aba3b0f5d02c6 Gerrit-Change-Number: 68664 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Mon, 28 Nov 2022 17:05:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya: Enable crashlog
by Sven van Ashbrook (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Nick Vaccaro. Sven van Ashbrook has uploaded a new patch set (#3) to the change originally created by Gaggery Tsai. ( https://review.coreboot.org/c/coreboot/+/68526 ) Change subject: mb/google/brya: Enable crashlog ...................................................................... mb/google/brya: Enable crashlog This patch enables crashlog for all brya projects. BUG=b:190756531, b:259978562 BRANCH=None TEST=emerge-brya coreboot chromeos-bootimage & ensure the crashlog PCIe device 0xa.0 is enabled and intel-pmt kernel driver is loaded. Signed-off-by: Gaggery Tsai <gaggery.tsai(a)intel.com> Change-Id: Ib632c8ac9ea7a4f0e0b08b96eb149f8ef1386be0 --- M src/mainboard/google/brya/Kconfig 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/68526/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/68526 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib632c8ac9ea7a4f0e0b08b96eb149f8ef1386be0 Gerrit-Change-Number: 68526 Gerrit-PatchSet: 3 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sven van Ashbrook <svenva(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in libgfxinit[master]: gma: Work around GNATprove issue with nested loops
by Nico Huber (Code Review) 28 Nov '22

28 Nov '22

Attention is currently required from: Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/68112 ) Change subject: gma: Work around GNATprove issue with nested loops ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/68112 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I5430081767c760b85401300e0db4d26fd78270d7 Gerrit-Change-Number: 68112 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 28 Nov 2022 17:04:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libgfxinit[master]: gma: Correct Global annotation for Initialize()
by Nico Huber (Code Review) 28 Nov '22

28 Nov '22

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/68111 ) Change subject: gma: Correct Global annotation for Initialize() ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/68111 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I7086b024d96f0a17f19f46f60ceac6757eb91867 Gerrit-Change-Number: 68111 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 17:04:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022