coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[S] Change in coreboot[master]: configs/config.msi_ms7d25: Enable CBFS serial and UUID as default
by Angel Pons (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Michał Żygowski, Michał Kopeć. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64640 ) Change subject: configs/config.msi_ms7d25: Enable CBFS serial and UUID as default ...................................................................... Patch Set 8: Code-Review+2 (1 comment) File src/mainboard/msi/ms7d25/Kconfig: https://review.coreboot.org/c/coreboot/+/64640/comment/0a310427_1241d187 PS6, Line 75: bool > Actually it seems I cannot define them like that here, because it makes a dependency on MSI board to […] Sounds good, and makes more sense. One can also enable these options via site-local/Kconfig which is very convenient. -- To view, visit https://review.coreboot.org/c/coreboot/+/64640 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8af889f12617d4ab6a27c6f336276c04f26244c Gerrit-Change-Number: 64640 Gerrit-PatchSet: 8 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 09:06:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: payloads/edk2: Separate the build target and repository
by Lean Sheng Tan (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Sean Rhodes, Martin L Roth, Matt DeVillier, Stefan Reinauer. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66080 ) Change subject: payloads/edk2: Separate the build target and repository ...................................................................... Patch Set 27: (1 comment) Patchset: PS27: Hi Matt, I had a quick chat with Sean on the motivation behind this patch, so you could also clone a separate edk2 branch for UPL. Would you consider to clone edk2-platform repo while keeping edk2 repo sync to master? because edk2-platforms allows overwrite files in the main edk2 repo and this would also means easier maintenance onwards. -- To view, visit https://review.coreboot.org/c/coreboot/+/66080 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If7f12423058ef69838741f384495ca766ccea083 Gerrit-Change-Number: 66080 Gerrit-PatchSet: 27 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Oct 2022 09:05:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: sb/intel/i82801gx/early_init.c: Include common/rcba.h
by Elyes Haouas (Code Review) 03 Oct '22

03 Oct '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68079 ) Change subject: sb/intel/i82801gx/early_init.c: Include common/rcba.h ...................................................................... sb/intel/i82801gx/early_init.c: Include common/rcba.h Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Change-Id: I5d9bc4ae942ba171a5d3ef4f77da69398fbac692 --- M src/southbridge/intel/i82801gx/early_init.c 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/68079/1 diff --git a/src/southbridge/intel/i82801gx/early_init.c b/src/southbridge/intel/i82801gx/early_init.c index 3a0e0b1..deb3deb 100644 --- a/src/southbridge/intel/i82801gx/early_init.c +++ b/src/southbridge/intel/i82801gx/early_init.c @@ -5,8 +5,10 @@ #include <device/smbus_host.h> #include <southbridge/intel/common/gpio.h> #include <southbridge/intel/common/pmbase.h> -#include "i82801gx.h" +#include <southbridge/intel/common/rcba.h> + #include "chip.h" +#include "i82801gx.h" void i82801gx_lpc_setup(void) { -- To view, visit https://review.coreboot.org/c/coreboot/+/68079 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d9bc4ae942ba171a5d3ef4f77da69398fbac692 Gerrit-Change-Number: 68079 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/msi/ms7d25: Populate SMBIOS product name based on CNVi presence
by Michał Żygowski (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Michał Żygowski, Michał Kopeć. Hello build bot (Jenkins), Michał Kopeć, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68078 to look at the new patch set (#2). Change subject: mb/msi/ms7d25: Populate SMBIOS product name based on CNVi presence ...................................................................... mb/msi/ms7d25: Populate SMBIOS product name based on CNVi presence MSI PRO Z690-A WIFI DDR4 and MSI PRO Z690-A DDR4 are basically the same boards, except the latter has no WiFi populated. Check the CNVi WiFi presence and return correct SMBIOS product name string. TEST=Check SMBIOS product name on both WiFi and non-WiFi variants in Linux. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I5fedbce413dfb6a589a406d1e34e3e114ca6a40f --- M src/mainboard/msi/ms7d25/mainboard.c 1 file changed, 31 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/68078/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68078 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5fedbce413dfb6a589a406d1e34e3e114ca6a40f Gerrit-Change-Number: 68078 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: configs/config.msi_ms7d25: Enable CBFS serial and UUID as default
by Michał Żygowski (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Michał Kopeć, Angel Pons. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64640 ) Change subject: configs/config.msi_ms7d25: Enable CBFS serial and UUID as default ...................................................................... Patch Set 8: (1 comment) File src/mainboard/msi/ms7d25/Kconfig: https://review.coreboot.org/c/coreboot/+/64640/comment/00e26123_52f9d7ef PS6, Line 75: bool > Done Actually it seems I cannot define them like that here, because it makes a dependency on MSI board to select these drivers in menuconfig... So I moved the selection to the config file. -- To view, visit https://review.coreboot.org/c/coreboot/+/64640 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8af889f12617d4ab6a27c6f336276c04f26244c Gerrit-Change-Number: 64640 Gerrit-PatchSet: 8 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 08:58:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/msi/ms7d25: Populate SMBIOS product name based on CNVi presence
by build bot (Jenkins) (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Michał Kopeć. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68078 ) Change subject: mb/msi/ms7d25: Populate SMBIOS product name based on CNVi presence ...................................................................... Patch Set 1: (1 comment) File src/mainboard/msi/ms7d25/mainboard.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159582): https://review.coreboot.org/c/coreboot/+/68078/comment/8ba2cbbb_d75edc35 PS1, Line 42: else trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/68078 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5fedbce413dfb6a589a406d1e34e3e114ca6a40f Gerrit-Change-Number: 68078 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 08:57:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/msi/ms7d25: Populate SMBIOS product name based on CNVi presence
by Michał Żygowski (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Michał Kopeć. Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68078 ) Change subject: mb/msi/ms7d25: Populate SMBIOS product name based on CNVi presence ...................................................................... mb/msi/ms7d25: Populate SMBIOS product name based on CNVi presence MSI PRO Z690-A WIFI DDR4 and MSI PRO Z690-A DDR4 are basically the same boards, except the latter has no WiFi populated. Check the CNVi WiFi presence and return correct SMBIOS product name string. TEST=Check SMBIOS product name on both WiFi and non-WiFi variants in Linux. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I5fedbce413dfb6a589a406d1e34e3e114ca6a40f --- M src/mainboard/msi/ms7d25/mainboard.c 1 file changed, 31 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/68078/1 diff --git a/src/mainboard/msi/ms7d25/mainboard.c b/src/mainboard/msi/ms7d25/mainboard.c index 2d46887..e1f60f6 100644 --- a/src/mainboard/msi/ms7d25/mainboard.c +++ b/src/mainboard/msi/ms7d25/mainboard.c @@ -2,6 +2,7 @@ #include <acpi/acpi.h> #include <device/device.h> +#include <soc/pci_devs.h> #include <soc/ramstage.h> #include <smbios.h> #include <string.h> @@ -32,6 +33,19 @@ return "MS-7D25"; } +const char *smbios_mainboard_product_name(void) +{ + /* Currently we support DDR4 variants, but e.g. DDR5 can be added later */ + if (CONFIG(BOARD_MSI_Z690_A_PRO_WIFI_DDR4)) { + if (is_devfn_enabled(PCH_DEVFN_CNVI_WIFI)) + return "PRO Z690-A WIFI DDR4(MS-7D25)"; + else + return "PRO Z690-A DDR4(MS-7D25)"; + } + + return CONFIG_MAINBOARD_PART_NUMBER; +} + /* Only baseboard serial number is populated */ const char *smbios_system_serial_number(void) { -- To view, visit https://review.coreboot.org/c/coreboot/+/68078 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5fedbce413dfb6a589a406d1e34e3e114ca6a40f Gerrit-Change-Number: 68078 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: configs/config.msi_ms7d25: Enable CBFS serial and UUID as default
by Michał Żygowski (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Michał Żygowski, Michał Kopeć. Hello build bot (Jenkins), Michał Kopeć, Paul Menzel, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64640 to look at the new patch set (#8). Change subject: configs/config.msi_ms7d25: Enable CBFS serial and UUID as default ...................................................................... configs/config.msi_ms7d25: Enable CBFS serial and UUID as default There is no option to calculate or generate the serial number and UUID on this platform. Enable CBFS UUID and serial by default so anybody can easily populate the missing fields. TEST=Add UUID and serial CBFS files, boot the platform and see both UUID and serial number are populated correctly. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: Ic8af889f12617d4ab6a27c6f336276c04f26244c --- M configs/config.msi_ms7d25 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/64640/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/64640 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8af889f12617d4ab6a27c6f336276c04f26244c Gerrit-Change-Number: 64640 Gerrit-PatchSet: 8 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: smbios: Add API to generate SMBIOS type 28 Temperature Probe
by Erik van den Bogaert (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Angel Pons. Erik van den Bogaert has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67926 ) Change subject: smbios: Add API to generate SMBIOS type 28 Temperature Probe ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Ack. […] Yes, that is the one. -- To view, visit https://review.coreboot.org/c/coreboot/+/67926 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I710124ca88dac9edb68aab98cf5950aa16c695d3 Gerrit-Change-Number: 67926 Gerrit-PatchSet: 2 Gerrit-Owner: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 08:52:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Erik van den Bogaert <ebogaert(a)eltan.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: smbios: Add API to generate SMBIOS type 28 Temperature Probe
by Angel Pons (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Erik van den Bogaert, Angel Pons. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67926 ) Change subject: smbios: Add API to generate SMBIOS type 28 Temperature Probe ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS1: > There is no other patch ready yet which will make use of this patch. […] Ack. Is it the AS_TGL1 board referenced in the PCIEXBAR change? -- To view, visit https://review.coreboot.org/c/coreboot/+/67926 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I710124ca88dac9edb68aab98cf5950aa16c695d3 Gerrit-Change-Number: 67926 Gerrit-PatchSet: 2 Gerrit-Owner: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 08:48:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Erik van den Bogaert <ebogaert(a)eltan.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022