coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[S] Change in libgfxinit[master]: dp training: Fix `EQ_Delay` function
by Angel Pons (Code Review) 03 Oct '22

03 Oct '22

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/67447 ) Change subject: dp training: Fix `EQ_Delay` function ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/libgfxinit/+/67447/comment/6c86401c_2226f201 PS1, Line 7: hw-gfx-dp_training.adb > Just noticed, we usually don't do file names, something like `dp training:` […] Done -- To view, visit https://review.coreboot.org/c/libgfxinit/+/67447 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I18d118ff1bf013175290a1c9fba4d449c7b00cb4 Gerrit-Change-Number: 67447 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 08:47:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[S] Change in libgfxinit[master]: dp training: Fix `EQ_Delay` function
by Angel Pons (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Angel Pons. Hello Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/libgfxinit/+/67447 to look at the new patch set (#2). Change subject: dp training: Fix `EQ_Delay` function ...................................................................... dp training: Fix `EQ_Delay` function The DisplayPort v2.0 specification does not mention anything about the delay being dependent on the link bandwidth. Change-Id: I18d118ff1bf013175290a1c9fba4d449c7b00cb4 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M common/hw-gfx-dp_training.adb 1 file changed, 14 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/47/67447/2 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/67447 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I18d118ff1bf013175290a1c9fba4d449c7b00cb4 Gerrit-Change-Number: 67447 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mainboard/msi/ms7d25: Enable CBFS serial number and UUID as default
by Angel Pons (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Michał Żygowski, Michał Kopeć. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64640 ) Change subject: mainboard/msi/ms7d25: Enable CBFS serial number and UUID as default ...................................................................... Patch Set 7: Code-Review+1 (2 comments) File src/mainboard/msi/ms7d25/Kconfig: https://review.coreboot.org/c/coreboot/+/64640/comment/c0b2612c_a1fec371 PS6, Line 75: bool > You shouldn't need to specify the types Done https://review.coreboot.org/c/coreboot/+/64640/comment/e1352395_15ae69e1 PS6, Line 79: bool > Ditto Done -- To view, visit https://review.coreboot.org/c/coreboot/+/64640 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8af889f12617d4ab6a27c6f336276c04f26244c Gerrit-Change-Number: 64640 Gerrit-PatchSet: 7 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 08:45:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: smbios: Add API to generate SMBIOS type 28 Temperature Probe
by Erik van den Bogaert (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Angel Pons. Erik van den Bogaert has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67926 ) Change subject: smbios: Add API to generate SMBIOS type 28 Temperature Probe ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/67926/comment/42b0378f_416e330e PS1, Line 7: SMIOS > typo: SM*B*IOS Done Patchset: PS1: > Right now this doesn't do anything new. […] There is no other patch ready yet which will make use of this patch. We are working on a platform which will make use of this patch except it still needs some debugging. These patches will be uploaded later. -- To view, visit https://review.coreboot.org/c/coreboot/+/67926 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I710124ca88dac9edb68aab98cf5950aa16c695d3 Gerrit-Change-Number: 67926 Gerrit-PatchSet: 2 Gerrit-Owner: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 08:44:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/mithrax: adjust I2C5 times for TP
by Paul Menzel (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Frank Wu, John Su, Tarun Tuli, YH Lin, Subrata Banik, Tim Wawrzynczak, Nick Vaccaro. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67920 ) Change subject: mb/google/brya/var/mithrax: adjust I2C5 times for TP ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/67920/comment/0679547b_e8d2d7d9 PS3, Line 10: specification Is it the specification or some datasheet? https://review.coreboot.org/c/coreboot/+/67920/comment/6606044d_b4de9201 PS3, Line 11: Please add the measured values before and after your change. -- To view, visit https://review.coreboot.org/c/coreboot/+/67920 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5977f0dbba8924cc8a1c72c36358d6ba6f2de940 Gerrit-Change-Number: 67920 Gerrit-PatchSet: 3 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Mon, 03 Oct 2022 08:36:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Makefile.inc: Decrease minimal pagesize from 4 kB to 1 kB
by Angel Pons (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Nico Huber, Martin L Roth, Paul Menzel, Julius Werner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62830 ) Change subject: Makefile.inc: Decrease minimal pagesize from 4 kB to 1 kB ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62830 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e36633f42cb4dc5af53212c10c919a86e451ee0 Gerrit-Change-Number: 62830 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Mon, 03 Oct 2022 08:36:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim/var/winterhold: Expend EC share memory register defi...
by EricKY Cheng (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Raul Rangel, Jason Nien, Isaac Lee, Jon Murphy, Tim Wawrzynczak, Martin Roth, Eric Peers, Moises Garcia, Tim Van Patten, Karthikeyan Ramasubramanian. EricKY Cheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68077 ) Change subject: mb/google/skyrim/var/winterhold: Expend EC share memory register define for Dynamic Thermal Table Switching Proposal ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/68077/comment/9e242fb5_be3cf0a8 PS1, Line 6: > Subject line should not end with a period. Please fix. https://review.coreboot.org/c/coreboot/+/68077/comment/28026a5c_5973183a PS1, Line 6: > Possible long commit subject (prefer a maximum 65 characters) Please fix. https://review.coreboot.org/c/coreboot/+/68077/comment/974dc6bc_d5d8c0d3 PS1, Line 10: Define offset 0x09 bit 5 for temperature status of thermal table switch > Possible unwrapped commit description (prefer a maximum 72 chars per line) Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/68077 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I37b3a0d8f6546361c8d5501e98e3e1b0d814fce3 Gerrit-Change-Number: 68077 Gerrit-PatchSet: 2 Gerrit-Owner: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-Reviewer: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Moises Garcia <moisesgarcia(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Isaac Lee <isaaclee(a)google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-Attention: Moises Garcia <moisesgarcia(a)google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthikeyan Ramasubramanian <kramasub(a)chromium.org> Gerrit-Comment-Date: Mon, 03 Oct 2022 08:35:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: smbios: Add API to generate SMBIOS type 28 Temperature Probe
by Erik van den Bogaert (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Erik van den Bogaert, Angel Pons. Hello build bot (Jenkins), Frans Hendriks, Angel Pons, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67926 to look at the new patch set (#2). Change subject: smbios: Add API to generate SMBIOS type 28 Temperature Probe ...................................................................... smbios: Add API to generate SMBIOS type 28 Temperature Probe Based on DMTF SMBIOS Specification 3.5.0 Signed-off-by: Erik van den Bogaert <ebogaert(a)eltan.com> Change-Id: I710124ca88dac9edb68aab98cf5950aa16c695d3 --- M src/arch/x86/smbios.c M src/include/smbios.h 2 files changed, 93 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/67926/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67926 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I710124ca88dac9edb68aab98cf5950aa16c695d3 Gerrit-Change-Number: 67926 Gerrit-PatchSet: 2 Gerrit-Owner: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/starlabs/lite/glkr: Enable configuring Fast Charging on the Lite M...
by Angel Pons (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Sean Rhodes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66319 ) Change subject: mb/starlabs/lite/glkr: Enable configuring Fast Charging on the Lite Mk IV ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/66319 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I714867d455c4e0d01d6cb1cb9dc64669fb41100c Gerrit-Change-Number: 66319 Gerrit-PatchSet: 8 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Mon, 03 Oct 2022 08:35:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: ec/starlabs/merlin: Add support for enabling fast charge
by Angel Pons (Code Review) 03 Oct '22

03 Oct '22

Attention is currently required from: Sean Rhodes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66298 ) Change subject: ec/starlabs/merlin: Add support for enabling fast charge ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/66298 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie01eb59d3f41b242190973fd9c58b1494320c12a Gerrit-Change-Number: 66298 Gerrit-PatchSet: 8 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Mon, 03 Oct 2022 08:33:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022